From nobody Thu Apr 9 19:19:38 2026 Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4AB8311C36 for ; Tue, 3 Mar 2026 21:27:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772573273; cv=none; b=T9cleI3uEW57wZ25Xy6KXsWuErWSN6tKyBVkVGDRQxyFglBQd9n7F2T80aIgtDtT1UrpmLS95dxlzQUglr6XUT1JEd3MNyCcKrQeeYMwIF6+jEwPam3qt58uCk8lzlHrwbqdmox60cGYyYkGgxhZXBAiNSxCOxLeL7MWEVYA/n0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772573273; c=relaxed/simple; bh=GtU9Dfh4VIRfVSHyhKz1FIFkVCMh0Bo6tOPnZFmo4ZI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=e33X2SO3zqnE5zCFqZebW/Be2Qn1PMBmL+I/IAA1xpUQEkSpXK7OcoVhljiXLP163h5XVR6Rmz1Ln0h7Lg1pC9jdRiMqVrDP00KzCuekwXsx+IAQg0aIzouPxyi7w8hHnjVLloDkZYSC/TFOnjY0elzVpvVvbcg/uCMdYp75kOk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=MFGadkgl; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="MFGadkgl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; s=k1; bh=SgSYSnoh1roEFX kDlKBYZ59+a9y24wPKXaec0bimGfI=; b=MFGadkglpzkC3Ajo16GDSzygJ2/hTo CTPUM5BLGWsIE7gAhW/E76c/wm9/3mvqdJr3CKjO/z5nQJ4sfvqA2U95Mt+AW5EH iurSizNH7fGd4/5KWAeBDZ4CUJWwYNFjaFic15U/04H9UFRiAK3UJpEn5IHEc5v7 QFru7h7R2yYpo7rkY8/UgKjn3VWG/FSPVzhQ4WIxaUjrxe7uFEZof91IhLcbkixt ASBYf3IcAYO7eVDeMJRUkP3bE1xXPxRHbDOGYudtg5FKRrLTKwnE6olr2KvPaGdF HaIfWBb4U7N+AxBnJHmgjDacCkJN7JdqF8DPF6vODZ347omoyQhZKxEA== Received: (qmail 461369 invoked from network); 3 Mar 2026 22:27:49 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 3 Mar 2026 22:27:49 +0100 X-UD-Smtp-Session: l3s3148p1@G4gGYCVM+Koujnu+ From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Wolfram Sang , Jassi Brar Subject: [PATCH v3] mailbox: test: really ignore optional memory resources Date: Tue, 3 Mar 2026 22:27:39 +0100 Message-ID: <20260303212738.12769-2-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Memory resources are optional but if the resource is empty devm_platform_get_and_ioremap_resource() prints an error nonetheless. Refactor the code to check the resources locally first and process them only if they are present. The -EBUSY error message of ioremap_resource() is still kept because it is correct. The comment which explains that a plain ioremap() is tried as a workaround is turned into a info message. So, a user will be informed about it, too. Signed-off-by: Wolfram Sang --- drivers/mailbox/mailbox-test.c | 37 +++++++++++++++++++--------------- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c index cfd5429df17e..df53d918d9fa 100644 --- a/drivers/mailbox/mailbox-test.c +++ b/drivers/mailbox/mailbox-test.c @@ -356,11 +356,27 @@ mbox_test_request_channel(struct platform_device *pde= v, const char *name) return channel; } =20 +static void *mbox_test_ioremap(struct platform_device *pdev, unsigned int = res_num) +{ + struct resource *res; + void *mmio; + + res =3D platform_get_resource(pdev, IORESOURCE_MEM, res_num); + if (!res) + return NULL; + + mmio =3D devm_ioremap_resource(&pdev->dev, res); + if (PTR_ERR(mmio) =3D=3D -EBUSY) { + dev_info(&pdev->dev, "trying workaround with plain ioremap\n"); + return devm_ioremap(&pdev->dev, res->start, resource_size(res)); + } + + return IS_ERR(mmio) ? NULL : mmio; +} + static int mbox_test_probe(struct platform_device *pdev) { struct mbox_test_device *tdev; - struct resource *res; - resource_size_t size; int ret; =20 tdev =3D devm_kzalloc(&pdev->dev, sizeof(*tdev), GFP_KERNEL); @@ -368,23 +384,12 @@ static int mbox_test_probe(struct platform_device *pd= ev) return -ENOMEM; =20 /* It's okay for MMIO to be NULL */ - tdev->tx_mmio =3D devm_platform_get_and_ioremap_resource(pdev, 0, &res); - if (PTR_ERR(tdev->tx_mmio) =3D=3D -EBUSY) { - /* if reserved area in SRAM, try just ioremap */ - size =3D resource_size(res); - tdev->tx_mmio =3D devm_ioremap(&pdev->dev, res->start, size); - } else if (IS_ERR(tdev->tx_mmio)) { - tdev->tx_mmio =3D NULL; - } + tdev->tx_mmio =3D mbox_test_ioremap(pdev, 0); =20 /* If specified, second reg entry is Rx MMIO */ - tdev->rx_mmio =3D devm_platform_get_and_ioremap_resource(pdev, 1, &res); - if (PTR_ERR(tdev->rx_mmio) =3D=3D -EBUSY) { - size =3D resource_size(res); - tdev->rx_mmio =3D devm_ioremap(&pdev->dev, res->start, size); - } else if (IS_ERR(tdev->rx_mmio)) { + tdev->rx_mmio =3D mbox_test_ioremap(pdev, 1); + if (!tdev->rx_mmio) tdev->rx_mmio =3D tdev->tx_mmio; - } =20 tdev->tx_channel =3D mbox_test_request_channel(pdev, "tx"); tdev->rx_channel =3D mbox_test_request_channel(pdev, "rx"); --=20 2.51.0