From nobody Thu Apr 9 18:03:29 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70CB6285C8B for ; Tue, 3 Mar 2026 18:32:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772562772; cv=none; b=WRwOhYxELyMdCJ2zPdBPMottXR80kFxSthX/dfN0K6Iv+/GJM6DH3YrDvaI8QRfAsS5MZX4GPo5rSF1njDsbOEDfeYjgAipXAYBK0JLGTHdADiW8PV6rD/Qa1fmjlYdam5a1lXK6cLk3wOm0xxE54kgRWdoTtVUSo/ftpueqarY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772562772; c=relaxed/simple; bh=pDTS99H9G3FQ7s8OEniQv20CbRMBXGF/t/C0VfYZ8Tw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=N2RD1uDsUvjnPsoEDiMeWJ4FSe+veGLnrf8rIBu4wWuhCsE5TRfF4MZ/YZa2fLWlDNPvzBI3SQNltQekPS4QtQ+vVA3+kiQvgQ66+vTCOeivDRrFUNx5HIZvVa5bpXKDyHZFeY3kHS2aQCWtrwS9sJx9jLAEKfaFHZQwZQ38STY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a6H6AI9f; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a6H6AI9f" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-8249fc726e9so3314680b3a.2 for ; Tue, 03 Mar 2026 10:32:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772562771; x=1773167571; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+mhk0IQogWu+9kUAjPJ+I0zLCB4TO/jLH4z7cWFQ9qw=; b=a6H6AI9flBk901gJqi0m7NA8IeHlb16tE86Yz4BE5DYT5LXZ5HOy14VQZsRGpOH6XM bERvJy8MU/rgwUFMIC0q0FjMb8TnXw/K7Jvt3QrR+Svj6Ckter6Evzkwo97XBepg6Kpa DC3Lw5TCmkO4DmXZDPgzoe/+i8La1O06tIFXwvzWUCxpsm42EcN4nGPqrvreO68PkrOB sUxQ7kKAnhvXFcGEg7aQ6rGh3sbe6/DfFnbDDFfTz5jYJWn4B73ujEAzU6p/+b4D77fO xHZ7DopdAURHod9ksI7J9gU0+lTPhFrXmNiZR+2zT9EEixg3rv1MLLUlQ41q+y9ZtyUH CKMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772562771; x=1773167571; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+mhk0IQogWu+9kUAjPJ+I0zLCB4TO/jLH4z7cWFQ9qw=; b=FtsZ1vXuRR1y68VTm1561djT7tlMqLoB+alx5TtE0LuEjjW4ufI895C261livQhbw7 cYbJGWzPSe2Xq5bD616stDqirUSsjzhfojNdhML6N+M21pRJ3SJzQQIKNH8EqB72SNJG kBTH8/DEUptLpSiduYOUudBN4UJFZrMhmlL0evfn5T/je3O4ntrfs6x6ddRGtoUG5WpI elV1Ixm+P1Hema8P855VGAbOSzwbdyE3O6GZxquMcvojjlVYgm5pLWJKyKtzDKyRq1gf f4kjDhb1bV6aGh73H1GPHReMs/XEJM8fBVUCT1q3VEioV0e5+AIOBI5q/JGXURrbll57 fkfQ== X-Gm-Message-State: AOJu0YxWi/X8K6aYz3yRep5Q6GfIYcOPeLLr73SrSmlNmksbh49RcviC YhFkX32fjvEQ9i+6Byp/k/wt9qUCuZpKQUSCGsrdcdBO0mX6jCcN0/vt X-Gm-Gg: ATEYQzy2bjR3HPht8FHo0LJjCwPgpRapSB3R3ythKJ1JAo78uFGBOdfs4cMRnaSK+xp lQpR5pe9Bg2bClu2RE+hOuiKaRNyq67/2Nbn4v+IjvS8cjKMtq3oJ308vLfEANL3Hgrvd3gz3t8 HTqxVJT3LqfDp/Xn1gyZTc3TSfwpN2BbEzd0JnqoyODQmDA5T2B4F/SfuExpGljvEcL6uEttOul BITG2KKF2u9mOIO3+sdZw0DCkn4nFYZxcevqlH5qvzn74ru5xe5/YX/Ch2Y2+RihjzGeydIDmsi 5G+2NQodnh5uU1G0coHK0It/9I+5KEh1uksoQ+oiCsVl07ZlIzjTHOuN6HQHeBDYXAoJCa/lB9+ hlMRd/oW8Ov5dYvleF9Vt3ezHqYVUf7YNgzJ0IDR1TMH4iimJTMAijW3d76EHwJo0TgotQcQlrj vTRn/1+Ca2momZDdEX9mrdKSKZmf4= X-Received: by 2002:a05:6a21:600b:b0:393:e2e3:5de0 with SMTP id adf61e73a8af0-395c3a475acmr15418675637.27.1772562770744; Tue, 03 Mar 2026 10:32:50 -0800 (PST) Received: from rust-kernel.. ([27.6.89.157]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70fa638dbcsm15137647a12.14.2026.03.03.10.32.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 10:32:50 -0800 (PST) From: Subhash Rawat To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Subhash Rawat Subject: [PATCH] mfd: dln2: Switch to managed resources and fix bare unsigned types Date: Tue, 3 Mar 2026 18:32:36 +0000 Message-ID: <20260303183236.574940-1-rawatsubhash02@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert dln2_probe and dln2_setup_rx_urbs to use devm_kzalloc() and devm_kmalloc() respectively. This simplifies resource management by allowing the removal of manual kfree() calls in dln2_free() and dln2_free_rx_urbs(). Additionally, update bare 'unsigned' types to 'unsigned int' to satisfy checkpatch.pl warnings and comply with the Linux kernel coding style. Signed-off-by: Subhash Rawat --- drivers/mfd/dln2.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c index d12510e39..7f281b409 100644 --- a/drivers/mfd/dln2.c +++ b/drivers/mfd/dln2.c @@ -424,8 +424,8 @@ static void free_rx_slot(struct dln2_dev *dln2, u16 han= dle, int slot) } =20 static int _dln2_transfer(struct dln2_dev *dln2, u16 handle, u16 cmd, - const void *obuf, unsigned obuf_len, - void *ibuf, unsigned *ibuf_len) + const void *obuf, unsigned int obuf_len, + void *ibuf, unsigned int *ibuf_len) { int ret =3D 0; int rx_slot; @@ -511,8 +511,8 @@ static int _dln2_transfer(struct dln2_dev *dln2, u16 ha= ndle, u16 cmd, } =20 int dln2_transfer(struct platform_device *pdev, u16 cmd, - const void *obuf, unsigned obuf_len, - void *ibuf, unsigned *ibuf_len) + const void *obuf, unsigned int obuf_len, + void *ibuf, unsigned int *ibuf_len) { struct dln2_platform_data *dln2_pdata; struct dln2_dev *dln2; @@ -583,10 +583,8 @@ static void dln2_free_rx_urbs(struct dln2_dev *dln2) { int i; =20 - for (i =3D 0; i < DLN2_MAX_URBS; i++) { + for (i =3D 0; i < DLN2_MAX_URBS; i++) usb_free_urb(dln2->rx_urb[i]); - kfree(dln2->rx_buf[i]); - } } =20 static void dln2_stop_rx_urbs(struct dln2_dev *dln2) @@ -601,7 +599,6 @@ static void dln2_free(struct dln2_dev *dln2) { dln2_free_rx_urbs(dln2); usb_put_dev(dln2->usb_dev); - kfree(dln2); } =20 static int dln2_setup_rx_urbs(struct dln2_dev *dln2, @@ -609,9 +606,10 @@ static int dln2_setup_rx_urbs(struct dln2_dev *dln2, { int i; const int rx_max_size =3D DLN2_RX_BUF_SIZE; + struct device *dev =3D &dln2->interface->dev; =20 for (i =3D 0; i < DLN2_MAX_URBS; i++) { - dln2->rx_buf[i] =3D kmalloc(rx_max_size, GFP_KERNEL); + dln2->rx_buf[i] =3D devm_kmalloc(dev, rx_max_size, GFP_KERNEL); if (!dln2->rx_buf[i]) return -ENOMEM; =20 @@ -778,7 +776,7 @@ static int dln2_probe(struct usb_interface *interface, if (ret) return ret; =20 - dln2 =3D kzalloc_obj(*dln2); + dln2 =3D devm_kzalloc(dev, sizeof(*dln2), GFP_KERNEL); if (!dln2) return -ENOMEM; =20 --=20 2.43.0