From nobody Thu Apr 9 19:20:03 2026 Received: from mail-dl1-f41.google.com (mail-dl1-f41.google.com [74.125.82.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ADD84EA39E for ; Tue, 3 Mar 2026 18:02:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772560925; cv=none; b=na86YUSbJVvLm0RIBb6L1R/1kAfnYa5jVsx3SyI6tO2XNEIRnXYri3Z6cBNHBXQ0YwjJdZLJ021RJHvriKb9L2NCYiHSXY76se+/FTD9eutM38ZnEid/XXn2DVldYKt1JGzOT3quwCY9ljGmqabtIf+qrDYWV+KsN/UW2C51JpI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772560925; c=relaxed/simple; bh=/IXmo69Qqppsb0Rguh1puUkOgy5dR4pABTlr/a1NR3o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Z632F9IakCiGqHslKb35QdwLpT5o6t3hy9x4NTUFMRVQXT6u9LUThUKOE7+0V6KrxoZwi/YG8PO9l5wdTrOMQ3N9TW42a21ZdZWxwCQbyZD7FrouAhhRvZEK4Zkkmweh78Y8hvF4EYma/bwStKE19EpB7gL/q86ID+tk8SAyKcM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LFOFwRvB; arc=none smtp.client-ip=74.125.82.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LFOFwRvB" Received: by mail-dl1-f41.google.com with SMTP id a92af1059eb24-1270adc5121so7469792c88.0 for ; Tue, 03 Mar 2026 10:02:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772560923; x=1773165723; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nYGdbxnOx3otBr6PvYVC6d9nFh0rDHzCPxy+MS19bo0=; b=LFOFwRvBxGNJHCcQtPfFkMFQB3KqM9Ww+dsksJf5cpVYxcHoawXjL4XINR/5aGSl2I yfwUbnpg8WqVlF5y5SPIDThtzFeZI4kCKnvXkPBXs4LPtBSWdJKTUNoIEBmLR9fBPJhO i0jtvhtstywHJeqY9xraoV+YtOSe4KCS/gJLkMen0q/WgU09A9BoS/UjpkmYixoiOg2s QX7RJlpQgfTil6AavMDkALf9otTMne6LkQgdq1laPbMOhFFPKFrkgot40PtL+cjD7Yj3 85Fvze2u+Z/MRysy9g6nzNo1YBFIaswzH22DnPO4Z+WUKgPb9kdMv7VOn8dJR1nnd8EB uONw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772560923; x=1773165723; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nYGdbxnOx3otBr6PvYVC6d9nFh0rDHzCPxy+MS19bo0=; b=gkgO7Yahs2khfFL3+ZsrGurrmm2+1mv0ssQuhAL03V/d0H1OI+Md6i0Ic9Yc3eEj4X Hyg7ANYGXfsFLHA+wNR2BSmcP+svKsdr6hekO3PiQ36KRds3fapiP7M/GjsFEnWoTpVD 1IK+8o6T2A/2WhBQAgnkKJAQjLKUo4WkysFOd6gewy4b7bbUMmqPTw1Kgybhk1zhF2B7 +zsX/piyJvmcgyd1Q9082YGvMLgzuIoMSJWzV1dk1CAGYVL+rWirscsUcY5hukhsJEU+ gFTEdXntZe9Nh9C1xmyYMwGnGBtHqq9F6Lh4bbw86Q6e9lJHUJvDeGaNHm6RHU3dzB/l gsAw== X-Forwarded-Encrypted: i=1; AJvYcCXUNlnNNuwR0mvX2KgA87yJWgk6JlYsEbZT+yH4E48bC/xu2LmSbwjjQgmU+9XtdVf21r3xKMhDdgi4ecE=@vger.kernel.org X-Gm-Message-State: AOJu0YyxTlOabIySR+NYwv66ZS+/gNH53Fd6i1FNdsLxof+vxOdJRfTr uQ89HYZkplwRlkL58PDs726xppAmUm7o6Qp78+QEwGLM08c/X+Qve9+I X-Gm-Gg: ATEYQzx7eqyhvGAIWgqXgHE8TP98K209tote4P9zsEWHWUBZPU7w7S295l3f/tgernH b1iGgCSlAAyQ1ZH4g9ym7heb8PoPUxqkvq2/rky5+tSpIylH6KgnSWxmOX5EOWCAghRW4z/i3iH y1jcV7xaWNsovgUbKEROK9XC4axM0afYYcti6c5dQ8WtIxCQsZDz1btN2nJuSd9ir7oMzwcVkhw 5msN/kxNQ68MhBAb9WQCLpat3zCx2iUy9WcnlFXnODnp38LWJVtjeALPRDVVbQ4Hbsk7nm5EG02 QC/DaItV7HTRt0MF+uRIP0/cuCNiZDtmqLmWR8sPAb5jTLXCI+91TH+pSoWTHmHfV+IWlebKQwj m/yJbYuaBG4KLCvzagHUTjcC15+3AjBlK/YCQ9iRtE2mu+j0/E4vpWc1kqRdcU4np63FshEt2SQ U5h2DjDd1cP1p85OrDX9+tlYL1wfg/8fawiJMMpWyTa68mI+1eO9ncTPVIpnu6dRsHHinMZ1jLH 5z8pwdHotH9KQcn800/BJTUe2bwxWUoSHg78wlwMmMq4tKMry0BrdQ9OT7s5Wulqi7oZuNFQ+/0 X-Received: by 2002:a05:7300:6ca8:b0:2be:aa:9a4a with SMTP id 5a478bee46e88-2be00aa9ba5mr3428751eec.0.1772560923094; Tue, 03 Mar 2026 10:02:03 -0800 (PST) Received: from arch.guest.box.net ([8.39.49.136]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bdfba0df2fsm9506612eec.7.2026.03.03.10.02.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 10:02:02 -0800 (PST) From: Milos Nikic To: jack@suse.cz Cc: tytso@mit.edu, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Milos Nikic , Zhang Yi , Andreas Dilger Subject: [PATCH v4 1/2] jbd2: gracefully abort instead of panicking on unlocked buffer Date: Tue, 3 Mar 2026 10:01:56 -0800 Message-ID: <20260303180157.53061-2-nikic.milos@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260303180157.53061-1-nikic.milos@gmail.com> References: <20260303180157.53061-1-nikic.milos@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In jbd2_journal_get_create_access(), if the caller passes an unlocked buffer, the code currently triggers a fatal J_ASSERT. While an unlocked buffer here is a clear API violation and a bug in the caller, crashing the entire system is an overly severe response. It brings down the whole machine for a localized filesystem inconsistency. Replace the J_ASSERT with a WARN_ON_ONCE to capture the offending caller's stack trace, and return an error (-EINVAL). This allows the journal to gracefully abort the transaction, protecting data integrity without causing a kernel panic. Signed-off-by: Milos Nikic Reviewed-by: Zhang Yi Reviewed-by: Jan Kara Reviewed-by: Andreas Dilger --- fs/jbd2/transaction.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c index dca4b5d8aaaa..04d17a5f2a82 100644 --- a/fs/jbd2/transaction.c +++ b/fs/jbd2/transaction.c @@ -1302,7 +1302,12 @@ int jbd2_journal_get_create_access(handle_t *handle,= struct buffer_head *bh) goto out; } =20 - J_ASSERT_JH(jh, buffer_locked(jh2bh(jh))); + if (WARN_ON_ONCE(!buffer_locked(jh2bh(jh)))) { + err =3D -EINVAL; + spin_unlock(&jh->b_state_lock); + jbd2_journal_abort(journal, err); + goto out; + } =20 if (jh->b_transaction =3D=3D NULL) { /* --=20 2.53.0