From nobody Thu Apr 9 17:58:04 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67EFC36C0D0 for ; Tue, 3 Mar 2026 14:05:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772546732; cv=none; b=Ag2fn704E1z0djRerm5Tk0oFwrEfnjbDlfJDrjEyI0XO1K+84nEkjok2t9j3mO2TclkUxOTYHwzPQCy3iM+AZJtaZmA4H82e5lKohb5yFr5tMSraL/tI6+XW8t9WRc4013ZJrY5TQJHsT/tk1JuIIVx5rCXU3wCR1ee3S9Uuc10= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772546732; c=relaxed/simple; bh=78to4xX37jepPCsQPIj/aEiR/ioHwa8PPqM87jRSaJM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rB+E8v4dBIxSazSg503Ci9nZtfpVVBMW6nPXCSGvCX7td3idLftzqBivWXxCGOW1U0fERBeDz5u5RFv5q6p7A62yntwILd2DOL3Lqcu97x5OusvY9OujIMnEHw9z3TREvM7ZEk3VKTpBJMae0dPVxH6X9g0+aFnOlA9nJwCWFTg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JtH9+uXP; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JtH9+uXP" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-8274936d2c0so5595872b3a.3 for ; Tue, 03 Mar 2026 06:05:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772546731; x=1773151531; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NKnpBxEFiyO+cBtM3GQyxdFXgNM7HxbJ6tEuCELZ7Pg=; b=JtH9+uXPmL3Gs1ud6wWSsprbQpbq/hckWsxec28qnVScD3GL9wdTVuuz5t0kPD3fer YyHRlsg7c5EEcGS6Mh4vC7BmrRDQjublc5YvHEScZpCJdUwiuI6paOGyDlCe/45kZRN5 XBWmcyEckT1o+ueRMIXTYe+GJA/7fOxrD4u0TdY/Q6TlhV22LdsiU3JuaoXOlOLzaC9D DLh7EQKzd79K9Kz2XEyhTIxQApKxR0bWB7pfTgzPiy7Qa71wyFsz+P8tMkOJFKYrp5o4 sDiw9IS+53n05rXan9qglcHZRvpMVh/RTAmxVComakAHcD+uAYlTUnEvjNl4lJzwOEA0 14JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772546731; x=1773151531; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NKnpBxEFiyO+cBtM3GQyxdFXgNM7HxbJ6tEuCELZ7Pg=; b=QZCKxWeUWz4uD4Tif3HlkLQc9jJRJmN5jqUxxbfsOBZLoQtsTAjztKDavJLfH/Ck8A VOkGhpjVSFXw3yoInzWd0cs+l+Jf+KyX/TY9+8JCQLxCz1ySMk0bIHmBtrIguNkWE3yV 3nAcmyPrG9p1W3SGss+AzBXlXIX24I5uBeEH8vuc3izwCi03A48uI+OPK2RbzjLxDDro LPw2dgLzUkB4fJvrtyl/x8vgHfzXIdvW3nlYpXNbPvCQ03bILCD+2ZbIoRYQf+AFQBN1 tSpwAMqZMf6nJX3G1nSOZdcmiQDW+g/eEU/ed7BvwZUOICKw9fYgEmaz9F9Bd9KFjAXc yaMw== X-Forwarded-Encrypted: i=1; AJvYcCVVDc38D+DxoLvsPtRWFgpT9rc4C+zimTTREfOk8K5mL80XwoHkSRJz5JZy43LzQDaHWSBhZvMTWPd1FTo=@vger.kernel.org X-Gm-Message-State: AOJu0YyTDsLHXojsG/+zLEd2rPAGso7xdL8fxTWNJTXx78nU8b6XPNX/ iutqm5dvTS6H7jF5L2O90jrqCXNj4EljFldcjWpnFay7/JHaKExYhi8ZEuQ4Zteu9I0= X-Gm-Gg: ATEYQzxCh1bY9ItaOxvsiP38tXX1dGchxOKDEu1L56zGyhK11SkMKGwMP7k1Xq261i6 pvLoP9M3fT/esrn4xMNyF3hHcVEp5JFSdX1DEhBRqbcLZRPKN0aUE6PX+vGKiL7cv6//MD6+RIh 0sFbA1LWapkLT+hHT64ThgIsE+iErHhcfKsP6h/1Vohh9gU9zzCWSinoa6wLwzVbi0YDCOCX/K9 ggA3wq9ROtQ9YZnRy78ynbD6F3ZAqluPH/mAMZ3+flPxzFOvTTQeDD6Qna0sRTLIw8wYSuKXaoO vqR44o4nA7BfWjHpiky9OIP3pzm576B2mH+V6egRccYVc/1r4mCcSsk1qZzI90xGRYROSt/vwhb roSr+q8LG63MxJQEvzpD7iqNUcvcSYxofN4C6+LIRLGxZ2ON6GgJuN29pcfb9+QQXy/g6DQ5IE3 I281BhQjqFfryRtRHoIm92MtdlGRA/6T2yoQ== X-Received: by 2002:a05:6a00:9086:b0:81e:a228:f0cb with SMTP id d2e1a72fcca58-8274d9d9b38mr18083176b3a.36.1772546730640; Tue, 03 Mar 2026 06:05:30 -0800 (PST) Received: from yangwen.localdomain ([121.225.53.117]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82739dabd43sm19110835b3a.25.2026.03.03.06.05.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 06:05:14 -0800 (PST) From: Yang Wen To: linkinjeon@kernel.org, sj1557.seo@samsung.com Cc: yuezhang.mo@sony.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Wen Subject: [PATCH v2] exfat: initialize caching fields during inode allocation Date: Tue, 3 Mar 2026 22:05:09 +0800 Message-ID: <20260303140509.3928-1-anmuxixixi@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" exfat_alloc_inode() does not initialize the cache_lru list head of struct exfat_inode_info. If an inode is evicted before its cache structures are properly initialized (e.g., during a forced unmount), the cleanup path in __exfat_cache_inval_inode() may observe an uninitialized list head. The check: while (!list_empty(&ei->cache_lru)) may incorrectly succeed when stale pointers remain from a reused slab object. Subsequent list traversal can then operate on invalid entries, potentially leading to a NULL pointer dereference or memory corruption. Initialize cache_lru, cache_lru_lock, nr_caches, and cache_valid_id in exfat_alloc_inode() to ensure a well-defined state at allocation time. Signed-off-by: Yang Wen --- fs/exfat/super.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/exfat/super.c b/fs/exfat/super.c index 83396fd265cd..f793e66a4a38 100644 --- a/fs/exfat/super.c +++ b/fs/exfat/super.c @@ -195,6 +195,10 @@ static struct inode *exfat_alloc_inode(struct super_bl= ock *sb) if (!ei) return NULL; =20 + spin_lock_init(&ei->cache_lru_lock); + ei->nr_caches =3D 0; + ei->cache_valid_id =3D EXFAT_CACHE_VALID + 1; + INIT_LIST_HEAD(&ei->cache_lru); init_rwsem(&ei->truncate_lock); return &ei->vfs_inode; } @@ -879,10 +883,6 @@ static void exfat_inode_init_once(void *foo) { struct exfat_inode_info *ei =3D (struct exfat_inode_info *)foo; =20 - spin_lock_init(&ei->cache_lru_lock); - ei->nr_caches =3D 0; - ei->cache_valid_id =3D EXFAT_CACHE_VALID + 1; - INIT_LIST_HEAD(&ei->cache_lru); INIT_HLIST_NODE(&ei->i_hash_fat); inode_init_once(&ei->vfs_inode); } --=20 2.43.0