From nobody Thu Apr 16 03:43:57 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012020.outbound.protection.outlook.com [52.101.43.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4807385527; Tue, 3 Mar 2026 06:57:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.20 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772521035; cv=fail; b=lHyoA85qMojZ5xD8+B4QPNPPaQxvmdejYy6msXKdrB+Kym3W69HiQDdQ4DdqW8r3TZr87MhSLWEho4rRa+eY4zqp3iNtkJX8zZpfe8kAXd+3jCZZXlCp0MtF0HRijMrupQbQV+wp72/uoyTl4oOeN/7g6qiNnLj45HcHZNxy/sU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772521035; c=relaxed/simple; bh=BAsRI4RrCDD5G6d0YpP4P3cVrC7+ltI1d+SYx2dVa6c=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=L43JOccUJ9bjFSHRfA+0LRebt1Jia53Anpv94Ydm8e0kXCaPomwgZS5Xp2T7m2g05QzpYl3F6U3H2N7S81ebcKfiBu4f7Z+iZMbvPzChrKyfy5ao4BPiKdogbDEaM9hxbkRtA6WFkVNnAMQvy/qM2A+hPDPgfItqiKF/0Kt3BtY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=pQNci0W5; arc=fail smtp.client-ip=52.101.43.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="pQNci0W5" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rBBbPMRgnXUljtU2CA3T3kiZC16GcBvE8IpmfPSHAPqLdAxJBUDOLdPVnZ4mbe8k0FRZwz5o7yISHKqu2iNx4nwUKqkvguYRJNV1wEPktcjD3aNRsVvEPjnNV1JKWowoYmQGipniNOpqNg0cjDl7lstbCsk/sWHkBcwGrBH8bF6QlO5K4LxooE18LIkJXaJX3NO1+vNGXyzN4Y6VgQCR0Kh/sX44vdJzEIceoYrF7WSB3UsaORXe1l2lqeKt6nudIZSKfvAaJCuFuxvBggz2bs4YNCCfuA3sbaGwOuMZSAKw1JfB9gTP0GSuHnisOWsuSa5fPntszjvvcQNWP/fSrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7BbQg5yhyQlxzdr8GzWQ4xrjhqsMoQ6jQOI3CY92qE4=; b=XRSJ4Q3IFwPDCk9hBzDkM6191pvXSWjvo0Yust6goFlJG6IpgnjpLrf4CIIjByjw75pvWocswCd6p/peA8f4YM792xbgrc6iR2ejp5JbwsUfL1ZmdbYedyDx3gfHcFXTcE6dwFCcqjM86wg8UYEzHATHrr8LgMqtcQA3v1nPSOoHGucUP0OjUtvM217DqB8UYM04OzNiJS7AybuDLcl59UgLZJhnRYEACtVpfley04WqTMbg0zS7Aw5WxoA0u9VjToE+YOZ9LJsp8WTcYbwVNPHx4DyGvcMRo1traT+nM6L5YCJ2kug8tiL33PYt1UIKjgi3GdaSI3PkzOkw1banvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7BbQg5yhyQlxzdr8GzWQ4xrjhqsMoQ6jQOI3CY92qE4=; b=pQNci0W5U8RBCqYVxHxnU+M/Etg+kKuAJcjlNlggkVrTB0fvz+QSMNR4JKIvZrjGBWj547myvRodroD8lpLX0JHSDwPXGF0rcgDPGkfvJtzMNYyQfY/xQcAwzUS+xwho1CZK8r9Tk5TaHprQrQPhdYskzo998865P9vcNUC8h6cPQfH4b0HOyabrHNT0Bwe6qKYCwdPl0Xq301O3q/OpAIOif85iYOtmX3sBTTCj5gQfWKOu4SygTdkdZT2zkl/HQOP4C3dvS0JVoebInGzROhS3kc0WWOayOWCYt0HyKPgR5Hwhs47erK04wcx2Z3r4RxZB1o3V93HRbFnWWk1rRg== Received: from BLAPR03CA0054.namprd03.prod.outlook.com (2603:10b6:208:32d::29) by DS4PR12MB9769.namprd12.prod.outlook.com (2603:10b6:8:2a9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Tue, 3 Mar 2026 06:55:34 +0000 Received: from BL6PEPF0001AB59.namprd02.prod.outlook.com (2603:10b6:208:32d:cafe::5d) by BLAPR03CA0054.outlook.office365.com (2603:10b6:208:32d::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.21 via Frontend Transport; Tue, 3 Mar 2026 06:55:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL6PEPF0001AB59.mail.protection.outlook.com (10.167.241.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.16 via Frontend Transport; Tue, 3 Mar 2026 06:55:33 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:55:22 -0800 Received: from mmaddireddy-ubuntu.nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:55:15 -0800 From: Manikanta Maddireddy To: , , , , , , , , , , , , , , , , , , <18255117159@163.com> CC: , , , Manikanta Maddireddy Subject: [PATCH v7 01/13] PCI: tegra194: Fix polling delay for L2 state Date: Tue, 3 Mar 2026 12:24:36 +0530 Message-ID: <20260303065448.2361488-2-mmaddireddy@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260303065448.2361488-1-mmaddireddy@nvidia.com> References: <20260303065448.2361488-1-mmaddireddy@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB59:EE_|DS4PR12MB9769:EE_ X-MS-Office365-Filtering-Correlation-Id: ad092662-eca3-459f-ef26-08de78f1de19 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|7416014|1800799024|82310400026|921020; X-Microsoft-Antispam-Message-Info: 9GugbsglXSXmxs7sJ7/dprstZ2D5FKHtm4Ym6wdqp4ptNLLx4RFT/MBSEDzYAGgcN0ysxjoSUCW0xjVMepsEcgSwXMYrFo99WrhgiEMHbRfj8mmry55cPjwet6b4SxqJN0MH1hVhLbj1pEJS5E9wIaBK+2ej+SmW8b9J2fUt5tIEL8kG1gChuKRPC7OgjHdPRbd/6Zv0x/54UVKkhXmmCSBAu8PbNOqJulHOiUmWqdIT1E2XEM2CDM8kvK/cx4AoXaW57nUAWym+qX3Wgaz75CTwPFrLpx4xD2lzz1fFjxkQA9TKFiiuee3fbvQVT6gnd8VPldrL7BejTNSM2UpJDsAEH8L0cvQVYK1Lj59OaEijedAlCGoAEE3EWRXK1NEOpwXjU+eR0yGt+zBXcBh+CCHxIyDu5HUPXLgIz+oMrVGYOLz1V4znyAW/o+pbGKcFbLnGFYwTHOsm9mnbKSl2xKPepuwepweEi/qOdHqJ1BsZPlSW7uKXINEPGWK5hPB9E7kKe279TWbpXQnVB+r4aAyBQfj/Oh+2cJOimpk7iz1jjuZN8v7iZgJHak8IFSaXhifuhdE8YEVDlZ3Bsyk9eL9Mm/F1yWkxuW3cuyPEsmaGHcADRiGT4gusv4W1aGgXzEIPyEEm1cRYnNf/c/mIWpfYTEEtFqHDdUAGYYzcxc0DYsu1QaQpNT0F/WyehY0opSHNlCkzt5UpELFquSSDaEwSkig+ABr17d1+9XYQVsE8Bc258Hkxi1oVBzrRwKZMxnn1Nx9iXegZi2ldCQxj3MEieK8uVZXFbOD+rZIcxivsFocVKBjTjNXV5kSPmj5Gl3K/lrtXco1KsJ+VMjXN9GMKi7+lWCb1Y/XgfSGW1Fw= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(376014)(7416014)(1800799024)(82310400026)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: itcS7Gs+DcF5EKU8cJP1BrfPkTljBBA57LsGvNL+yMm1FsItyqOoDd2tAxYvDQrqY18sWrZcowNeWaGSXg+HGjXqNCxUOPizXau5ZIWKNaUWtaC5ZQ/hCztiQeKoSqed45UnnkN86Z+Ridlq63KcGDPzCGqD2fGOlwe8/0FdMnx4b+2iRrRAlvXY26i7kXiPF28xbeA5MEflF28poG+dszZfTytZWinMVghjr0JzrrF/sswoLoU6xiNI0ULIB+YEUa5zLAyKxNMLXmEwOOAksLqO+G3KDeXZuXLqih/kD0s2Q+1pFR8pp8/Aow1INiJiqqnIhqTQDnHj3XbD+G9+gHu4LUpBuZLFjk3BG4YtUUKC92LEkSMiZcELio7ImkiSmRN9+mVxqRgth3ngcsjbvbhffZDghaMERjTOZVJeUZZuXAR0o3I5O3eM/nAmmCwY X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2026 06:55:33.9918 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ad092662-eca3-459f-ef26-08de78f1de19 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB59.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PR12MB9769 Content-Type: text/plain; charset="utf-8" From: Vidya Sagar As per PCIe spec r7.0, sec 5.3.3.2.1, after sending PME_Turn_Off message, Root Port should wait for 1~10 msec for PME_TO_Ack message. Currently, driver is polling for 10 msec with 1 usec delay which is aggressive. Use existing macro PCIE_PME_TO_L2_TIMEOUT_US to poll for 10 msec with 1 msec delay. Since this function is used in non-atomic context only, use non-atomic poll function. Fixes: 56e15a238d92 ("PCI: tegra: Add Tegra194 PCIe support") Reviewed-by: Jon Hunter Tested-by: Jon Hunter Signed-off-by: Vidya Sagar Signed-off-by: Manikanta Maddireddy --- Changes V6 -> V7: Use PCIE_PME_TO_L2_TIMEOUT_US instead PME_ACK_TIMEOUT Changes V1 -> V6: None drivers/pci/controller/dwc/pcie-tegra194.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/contr= oller/dwc/pcie-tegra194.c index 0ddeef70726d..d6c6bd512b51 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -198,8 +198,6 @@ #define CAP_SPCIE_CAP_OFF_USP_TX_PRESET0_MASK GENMASK(11, 8) #define CAP_SPCIE_CAP_OFF_USP_TX_PRESET0_SHIFT 8 =20 -#define PME_ACK_TIMEOUT 10000 - #define LTSSM_TIMEOUT 50000 /* 50ms */ =20 #define GEN3_GEN4_EQ_PRESET_INIT 5 @@ -1553,9 +1551,10 @@ static int tegra_pcie_try_link_l2(struct tegra_pcie_= dw *pcie) val |=3D APPL_PM_XMT_TURNOFF_STATE; appl_writel(pcie, val, APPL_RADM_STATUS); =20 - return readl_poll_timeout_atomic(pcie->appl_base + APPL_DEBUG, val, - val & APPL_DEBUG_PM_LINKST_IN_L2_LAT, - 1, PME_ACK_TIMEOUT); + return readl_poll_timeout(pcie->appl_base + APPL_DEBUG, val, + val & APPL_DEBUG_PM_LINKST_IN_L2_LAT, + PCIE_PME_TO_L2_TIMEOUT_US/10, + PCIE_PME_TO_L2_TIMEOUT_US); } =20 static void tegra_pcie_dw_pme_turnoff(struct tegra_pcie_dw *pcie) --=20 2.34.1 From nobody Thu Apr 16 03:43:57 2026 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013066.outbound.protection.outlook.com [40.93.196.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6358347510; Tue, 3 Mar 2026 06:55:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.66 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772520947; cv=fail; b=pCAwfloWmmNg8NN9Wa3sVkObpgma9++r7vk6dU42B54Xk9qdwWG8WtdMxUJYj/JLP+B8hwT9AEVmBhrVvD2k5HzX7y/WNNtRDigWSO7vgnXBugeHIVLwv4rL2xQw0G/LXRdDhuHxUvNywpstex/CAkONHpUH9+mbBb3jGCU9DKw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772520947; c=relaxed/simple; bh=8h/LPu4k654wwwYgfy0gfessnWR9Xg/dodcD5CMKuzo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aFRQRjXeqORuc2M7aLSd8aK7ALUS8dIeJp2s+dH/qQATm4NLHJi7onho+ZS6jYpEpe/ZwVcvZkMYYU+N0FgT8ncON2rCXE/StMirkiz327pGSNdAPtNYCuZs81Kbi4hPcmVnPM5cVtJSA7r1cc7pIdNAAc8mBjVIVOx6TduWjek= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=ZpKWNjDr; arc=fail smtp.client-ip=40.93.196.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="ZpKWNjDr" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SbRtIX7A/kjTKUi0ZAkzUMjJlUCRBq49+ERvL8qFcrW4i4gAZ9kFuDz9iieZoiJks6CY8JsbHrJZhkkktgRIlaoJzM3L3oLCR/3v/8XzBI+MtQmLthXwUBmNbIEMpB2+Ejso/TzJ+u9U3Ka9Q22QuvdNDADWDPF+izQYtsGhWgsDCjp2eqHPhDuAU7ELUVmxN9ok1geuJJmrNnwlCENNbQ7+l1m8EQ4I5wL2Yza/AwKZstQYGBn/DRBbGPiltYj0EUdBmGKL2gVacnwA6x2rD7ZbWFPM4FPKv0kZDhow88M61Qfz9zn+HvlmPoT6jWKxF6rwjWT4kKGClQ/OkifKmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nqwBOth+TWBnAgBtZ1DuVXqnpT/+VKOJ8NB0zEv8pjM=; b=ij5k9P+SvrXhHwnlpJ22aWH+gy7VK/NJB373qEGG+dddwRnv8vE1AlKG5byuQ7nsOEtFu3+lJQQND9ernZsTRjQ8JD14kIOHb15odbvHhz8jj8JIhekYQfZhYVXbA3HwNGgygiogzof69OSdk0ccRPPm1UnZN/b/Z86GZPSeGVj1C6HHmd0GKpMD8STgZ97NSNCsE3WAlcBeF4+Whc+AwSqy92FLaG0zbPd3/jlEjoaqv43Xd/jiRrkJK4rwMzgutkHVeoS3002YYonBULi5lYxJ78ANGPjBqeKUtNYG76APFLYEgdJ5V/py+4Hw58CEN+pc2b4+0cZHA2pIHpzM+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nqwBOth+TWBnAgBtZ1DuVXqnpT/+VKOJ8NB0zEv8pjM=; b=ZpKWNjDrTL5pJKP3lL2hGjtNLEY/ZlKANiFa5tCfVRetUhD9Bj1ld4XTxKgB2Po22iZiKNpuvO1FT93r/Us1Z37Icp40R3Hi85MQ/XATcU/74ACTQ2bJeDI/ETyoCoGXF9MnMFoDIVUYIf71W0AdVIhIr9f14ZzID/OPj0st+bM8U6JGQg+rwP+KzxKYJQUo9VIm3K7Kri7+exaJjPOi6jIxsMrq2wfD9bJp+lfvnWTAuwtwf5/z6swvsAb2XjEWK0FVveYoQE4l3ALYilB6YWiNkavNnZlFKB9/URaTQwtTizpT4y9vSoBcIlrudosnfm7ZZkj597O2oa+5DGucSQ== Received: from BLAPR03CA0048.namprd03.prod.outlook.com (2603:10b6:208:32d::23) by DS0PR12MB6413.namprd12.prod.outlook.com (2603:10b6:8:ce::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.21; Tue, 3 Mar 2026 06:55:40 +0000 Received: from BL6PEPF0001AB59.namprd02.prod.outlook.com (2603:10b6:208:32d:cafe::2f) by BLAPR03CA0048.outlook.office365.com (2603:10b6:208:32d::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.21 via Frontend Transport; Tue, 3 Mar 2026 06:55:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL6PEPF0001AB59.mail.protection.outlook.com (10.167.241.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.16 via Frontend Transport; Tue, 3 Mar 2026 06:55:39 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:55:29 -0800 Received: from mmaddireddy-ubuntu.nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:55:22 -0800 From: Manikanta Maddireddy To: , , , , , , , , , , , , , , , , , , <18255117159@163.com> CC: , , , Manikanta Maddireddy Subject: [PATCH v7 02/13] PCI: tegra194: Refactor LTSSM state polling on surprise down Date: Tue, 3 Mar 2026 12:24:37 +0530 Message-ID: <20260303065448.2361488-3-mmaddireddy@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260303065448.2361488-1-mmaddireddy@nvidia.com> References: <20260303065448.2361488-1-mmaddireddy@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB59:EE_|DS0PR12MB6413:EE_ X-MS-Office365-Filtering-Correlation-Id: 939e9aaf-139e-4199-5025-08de78f1e18a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|7416014|376014|1800799024|921020; X-Microsoft-Antispam-Message-Info: 7hHJCtP8D5EGvbJT6eH1qYBCb5hnBFUiqQoMh7LCBymRc7gHHpGcAlq4hilsO0TGMTNELewGh3wuzkjQNpUg1u7wpTx1WCHfddeH9p4yRWvAq4OT6MXXOhLLvm2XyxISwf6lXlS0zQeLIqGvDTYINvqzZgM3rCUP8xENLTgvdsvAloYL7alEzCLWjIdRpCNL38r7U8cQRAqJ8J3TDJiRm+qNI69cD0xVcXOh2qByGK4CEnVzYTqBnbO0SirifklQ0dFp7PmZhtKEJzCyc9kjF06io6dtl6gIOxkgkr6J/LAGpUg3TEYErEP5t1AEEvXJB2+KZBx6xC39xPhGoFUVpaBpFilzZO4kwOIhTFrT6qk/ROVKapf0rcLF08gzuU/bMuKB7YO0WpK2/YloHfw8V/TO8aIlfVly12qt1LSG0jtBSdYjYDZ1T1+equMF8YGjPJx2BriYEF5QQlBThz4JUSPw+E9pgZCAvacZhH8l8GTLobwO/o0Kr9z82+236RjPp7u30IroGhB4ANoCIdVbT13WJ88sqDpZ9C2bIascLlJWr6ABpzveD+2mMOC6bQ3fM8QifHdMvTWEfKt+lA8d2n90GwNwmpex6jTNjLhVAPKuS3sl7naeE0UdVNlHcEytI1XCWAt1EN3uIhOCZ/qxEfN/M61RlIvtJcblr9zM8CtO9/DdjN4F/A89PLpRDgSo/PDFcEX+akTas4giitB329FlclEL0i2l8QFdNaU4o2c3x7796gHEI4OknQ1XRTNDf7FwcsSNwIB1wSBt2CoalXgB6aoBkqMP/Py231eW1ypUrlDICI5smeUAXdoZxLqJPB3DQ4rsUmIY4gatQx+tJb2rtMfLZ3I0mSbsa9aN674= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(7416014)(376014)(1800799024)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Pko7a+sdgyaVnSVcUHbdtT+086OMr+sha2UUhTcgwXJd+pK02LxhALFHPeKu3oDOUvqPfNuMgRxUZ6js1kjU8muNhxzvOWBzNMS/xvp9ABEr53/TMTkQllgAAvEK0To0FUQqkGk8Y4ZNwC95950zrWrQJJ2ZyHbRixc0wOA569ghXzx37uQpyEIlgVtVHP4Im/6AP7wnDnLb0YPskD021ZmO4WuHlxEv0uQyLRLxXSf9c9f05nqZTPjxYdmc2Q1acH3Zh4V7pxsgwobnSig1Xv42W9ZiQHJxxy3eEATQjTbd1VWdA6ooELfo9GFHFUER2/CAaDqz+5XcvFeMRN523T2Y8yWIdHMpDiZjJGfOJ10RCv2QH2JOb+E9Zxc9voiCEcOXI3vSi530QxK/1J6fY0NMzQclyw0fASZQmfPRu9ZpRhkX2MRZO7nlOTl7SkBg X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2026 06:55:39.7508 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 939e9aaf-139e-4199-5025-08de78f1e18a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB59.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6413 Content-Type: text/plain; charset="utf-8" From: Vidya Sagar On surprise down, LTSSM state transits from L0 -> Recovery.RcvrLock -> Recovery.RcvrSpeed -> Gen1 Recovery.RcvrLock -> Detect. Recovery.RcvrLock and Recovery.RcvrSpeed transit times are 24 msec and 48 msec respectively. So, the total time taken to transit from L0 to detect state is ~96 msec. Hence, increase the poll time to 120 msec. Disable the LTSSM state after it transits to detect to avoid LTSSM toggling between polling and detect states. tegra_pcie_dw_pme_turnoff() function is called in non-atomic context only, so use the non-atomic poll function. Fixes: 56e15a238d92 ("PCI: tegra: Add Tegra194 PCIe support") Reviewed-by: Jon Hunter Tested-by: Jon Hunter Signed-off-by: Vidya Sagar Signed-off-by: Manikanta Maddireddy --- Changes V6 -> V7: Append _US to LTSSM macros Changes V5 -> V6: Retain only one fixes tag Changes V1 -> V5: None drivers/pci/controller/dwc/pcie-tegra194.c | 55 +++++++++++++--------- 1 file changed, 32 insertions(+), 23 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/contr= oller/dwc/pcie-tegra194.c index d6c6bd512b51..afbc0bdd8a93 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -137,7 +137,11 @@ #define APPL_DEBUG_PM_LINKST_IN_L0 0x11 #define APPL_DEBUG_LTSSM_STATE_MASK GENMASK(8, 3) #define APPL_DEBUG_LTSSM_STATE_SHIFT 3 -#define LTSSM_STATE_PRE_DETECT 5 +#define LTSSM_STATE_DETECT_QUIET 0x00 +#define LTSSM_STATE_DETECT_ACT 0x08 +#define LTSSM_STATE_PRE_DETECT_QUIET 0x28 +#define LTSSM_STATE_DETECT_WAIT 0x30 +#define LTSSM_STATE_L2_IDLE 0xa8 =20 #define APPL_RADM_STATUS 0xE4 #define APPL_PM_XMT_TURNOFF_STATE BIT(0) @@ -198,7 +202,8 @@ #define CAP_SPCIE_CAP_OFF_USP_TX_PRESET0_MASK GENMASK(11, 8) #define CAP_SPCIE_CAP_OFF_USP_TX_PRESET0_SHIFT 8 =20 -#define LTSSM_TIMEOUT 50000 /* 50ms */ +#define LTSSM_DELAY_US 10000 /* 10 ms */ +#define LTSSM_TIMEOUT_US 120000 /* 120 ms */ =20 #define GEN3_GEN4_EQ_PRESET_INIT 5 =20 @@ -1589,23 +1594,22 @@ static void tegra_pcie_dw_pme_turnoff(struct tegra_= pcie_dw *pcie) data &=3D ~APPL_PINMUX_PEX_RST; appl_writel(pcie, data, APPL_PINMUX); =20 + err =3D readl_poll_timeout(pcie->appl_base + APPL_DEBUG, data, + ((data & APPL_DEBUG_LTSSM_STATE_MASK) =3D=3D LTSSM_STATE_DETECT_QUIET) = || + ((data & APPL_DEBUG_LTSSM_STATE_MASK) =3D=3D LTSSM_STATE_DETECT_ACT) || + ((data & APPL_DEBUG_LTSSM_STATE_MASK) =3D=3D LTSSM_STATE_PRE_DETECT_QUI= ET) || + ((data & APPL_DEBUG_LTSSM_STATE_MASK) =3D=3D LTSSM_STATE_DETECT_WAIT), + LTSSM_DELAY_US, LTSSM_TIMEOUT_US); + if (err) + dev_info(pcie->dev, "Link didn't go to detect state\n"); + /* - * Some cards do not go to detect state even after de-asserting - * PERST#. So, de-assert LTSSM to bring link to detect state. + * Deassert LTSSM state to stop the state toggling between + * polling and detect. */ data =3D readl(pcie->appl_base + APPL_CTRL); data &=3D ~APPL_CTRL_LTSSM_EN; writel(data, pcie->appl_base + APPL_CTRL); - - err =3D readl_poll_timeout_atomic(pcie->appl_base + APPL_DEBUG, - data, - ((data & - APPL_DEBUG_LTSSM_STATE_MASK) >> - APPL_DEBUG_LTSSM_STATE_SHIFT) =3D=3D - LTSSM_STATE_PRE_DETECT, - 1, LTSSM_TIMEOUT); - if (err) - dev_info(pcie->dev, "Link didn't go to detect state\n"); } /* * DBI registers may not be accessible after this as PLL-E would be @@ -1679,19 +1683,24 @@ static void pex_ep_event_pex_rst_assert(struct tegr= a_pcie_dw *pcie) if (pcie->ep_state =3D=3D EP_STATE_DISABLED) return; =20 - /* Disable LTSSM */ + ret =3D readl_poll_timeout(pcie->appl_base + APPL_DEBUG, val, + ((val & APPL_DEBUG_LTSSM_STATE_MASK) =3D=3D LTSSM_STATE_DETECT_QUIET) || + ((val & APPL_DEBUG_LTSSM_STATE_MASK) =3D=3D LTSSM_STATE_DETECT_ACT) || + ((val & APPL_DEBUG_LTSSM_STATE_MASK) =3D=3D LTSSM_STATE_PRE_DETECT_QUIET= ) || + ((val & APPL_DEBUG_LTSSM_STATE_MASK) =3D=3D LTSSM_STATE_DETECT_WAIT) || + ((val & APPL_DEBUG_LTSSM_STATE_MASK) =3D=3D LTSSM_STATE_L2_IDLE), + LTSSM_DELAY_US, LTSSM_TIMEOUT_US); + if (ret) + dev_err(pcie->dev, "LTSSM state: 0x%x timeout: %d\n", val, ret); + + /* + * Deassert LTSSM state to stop the state toggling between + * polling and detect. + */ val =3D appl_readl(pcie, APPL_CTRL); val &=3D ~APPL_CTRL_LTSSM_EN; appl_writel(pcie, val, APPL_CTRL); =20 - ret =3D readl_poll_timeout(pcie->appl_base + APPL_DEBUG, val, - ((val & APPL_DEBUG_LTSSM_STATE_MASK) >> - APPL_DEBUG_LTSSM_STATE_SHIFT) =3D=3D - LTSSM_STATE_PRE_DETECT, - 1, LTSSM_TIMEOUT); - if (ret) - dev_err(pcie->dev, "Failed to go Detect state: %d\n", ret); - reset_control_assert(pcie->core_rst); =20 tegra_pcie_disable_phy(pcie); --=20 2.34.1 From nobody Thu Apr 16 03:43:57 2026 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010026.outbound.protection.outlook.com [52.101.46.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4756533555B; Tue, 3 Mar 2026 06:55:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.26 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772520954; cv=fail; b=mK2CCvQQeSowMJcAbE8Dv4y4A1TOaV8qkZaMEiRhrgQjvoPCdNCBxIIsgbmXWsHD36IkXZi+klmljz0cV8VxN5PWFWQFYPbVrzYo3TqsWHEcyU4e6Uzm/62pituCpYsJacexBuN/qZLr75JdN5Cpstys5pDoDT0TCjO4waUV6e0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772520954; c=relaxed/simple; bh=qr9BGECjnddRxq6Y55Ear8v8TDZhFqM9U6XbxlPgmKw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=N4k7bHWYG2dC4uF1IKwcTbenmOHy2I6QjuQxdc0YCmlJmA8LU/Ns+XfxV0Kzb1kP5sWVKKAUEQpGy6OSX/UTC+iJwSvF2xQU16tFpf7foiRb3jV4jcZyTRRPyYsPdU6P1eH53lqRsfOTCZl6Z+Es3wiU83ThVjiztbGsv1GTH44= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=R9AsW9ml; arc=fail smtp.client-ip=52.101.46.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="R9AsW9ml" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FhhNafcjmX6HyUjubmomf/qozrGILACdm7rLQmjQ8R8BrVwVE0vnHrPUwUA+Dh9IFhkw/9CDtrWJxilHm/TxLiDPUbqTXCV0q1SjGSqdmo2tS7Jgd4XFCWHaKvRYQokTXUi+GROL05QQS0jn7Z9tnkpuUcAtOA0dzw8e+D5qyyXbGRHuDm61CtNuNABoRuv6DlRAz7pe6L2snjLj1wYBxh225t2BnCce7gOAt44nkevq36/OYzCWcdGWsRQopcq4WwTrM+W7OErQV18nf+/LSJJTgMSKrRiaklLkmJhmBWOuG5NUrb1woniU1qVCsM3CoZI2IPSvwEMBJreL3DKGhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EMywdM2zlWVRoxF6FaQVIcT9UlXKyIQp0fw2YuyUl9I=; b=JdlJ8iSHUgx9e2y0Ijio0QBb/e0hNcP2Y4+F05TjYGU6sm3b6lWwYWwe8RlDdINLDwu+5U6f/urYskREg0hZFiBuBi9r6LX1+hZjfYf2m3cF4PHG48EH8vC8z6E6wmih3Arp9Bmk9L0oY1eAh5wnO6oyXUanzTuTuB/Y0Z34O7TeRkaBfTRJiGlcpz029C41Qwr+u1SKCfBQYK30ZscDELmkw8MVkr6E+Z8UmUt2kyMPqrQ/rLebIss88SKRRd0pc0ypLNl9nrhD76sM7v+wmChQIFvGNjFTilvcp4bnwAefd5hvPrBdwWBfICLD8eiZ1HZvK+1gJjMVY+gQl9eLRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EMywdM2zlWVRoxF6FaQVIcT9UlXKyIQp0fw2YuyUl9I=; b=R9AsW9mlsLbBHMta1lNMrGFPT50/pvNKbKAFywcdYRz3Y4azVQ8FKeZ2f2ryVobT1RlCXP66ZY5RYMhF4YMI3vi0objW0rEyF4MYX4ksEvhd01pV8bup2BKmsPghRnY+dvcYxjcP9SlTvhkrIx1AlYjovceFKuTke+VPUZn5jBLnz9+ue/Qoxa9+L8pSKbPKQQ2RR68IgKMYGpvyWb7BoxcVShOYzn6XN95u7U2VvtuM7Y93+0i99lSY5mzvYbDxsfubOIvix131F9I5VcURfYVkQM8tALOfflMgZQpNVS0cgFCN97+sN/8pO23r80p2BYjRy+2RT8+vfAyA9zT0LA== Received: from BN0PR02CA0011.namprd02.prod.outlook.com (2603:10b6:408:e4::16) by LV3PR12MB9404.namprd12.prod.outlook.com (2603:10b6:408:219::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.21; Tue, 3 Mar 2026 06:55:48 +0000 Received: from BN2PEPF00004FBF.namprd04.prod.outlook.com (2603:10b6:408:e4:cafe::17) by BN0PR02CA0011.outlook.office365.com (2603:10b6:408:e4::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.21 via Frontend Transport; Tue, 3 Mar 2026 06:55:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN2PEPF00004FBF.mail.protection.outlook.com (10.167.243.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.16 via Frontend Transport; Tue, 3 Mar 2026 06:55:48 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:55:36 -0800 Received: from mmaddireddy-ubuntu.nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:55:29 -0800 From: Manikanta Maddireddy To: , , , , , , , , , , , , , , , , , , <18255117159@163.com> CC: , , , Manikanta Maddireddy Subject: [PATCH v7 03/13] PCI: tegra194: Don't force the device into the D0 state before L2 Date: Tue, 3 Mar 2026 12:24:38 +0530 Message-ID: <20260303065448.2361488-4-mmaddireddy@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260303065448.2361488-1-mmaddireddy@nvidia.com> References: <20260303065448.2361488-1-mmaddireddy@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF00004FBF:EE_|LV3PR12MB9404:EE_ X-MS-Office365-Filtering-Correlation-Id: c8b7bc05-5140-4faf-6cfa-08de78f1e6b8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|7416014|376014|36860700013|921020; X-Microsoft-Antispam-Message-Info: gjbTaCH4O4WxUQBAB4LgjFAmejhsyuk0bds42FoTbt6DUOnt6hySIFQ242QTfJ7WKNPuiIFWcywnbIabGlhKb4cTnC3ZczyEeuLVtLuRvEpH7jYMwVVfzdfk0S00GCwtB3lzAQtv/QJ9cJ6gtLXKOcnsfHIp2+YGDjHF2+u4liO52UThB33BTLDIBTPeDgmwDs1hovkiTMQN8bDSrfJIZj3BoSkz1FyGtbRUfsTiv11sSLqaUo8fSHr2iDHFgQXEezT9eMfjQTT/LJTKSvcNz304jsfecekb402XQpdxBLu5zegcNjI7WnkYg/RABr05e+0wDvIbA8gd+GgmAzGV3LbwUc9zcyJJQ0s7C74UdLxUOTOrjS7LyN+WKfv7wTzhZJ/ipuncvuNFcHgBcGU1Eg75HaquDRGBwT4wsBlF4F8Bmwwkd0Xd40DyQMzqxzQK25oqOX+UnSFhu67rxEDHnow1YXletcWSXLiqZpXg0+slBsGdm6gz9czWbS81vTS5mI8kKSZkmKYGx3reGITTUYqq1A1ufhRRI8nc7P9LganKNGLlLueZn+0GTGwMbkzIQcOkSc5b5JcHxrDblvR8D58oSgEFM2nqzuZ8G1BmBrhoy/9xR1Us/p6iE3s7yYm60Zz6S/GOQE/E96xiWZvB8b1YOVvL0VGA0inxVlfE3LnxIfLU6S9LVuuAxzjjYqTjs8osjZWygZal6lLA6H4xD5eI4PfEWIMYeYNE8pUu8W6zNNyT1HKZqGPHaUFAPHeBGtVEoEM/HzOvjBk1iMmHpT7cs8KoXszdJ0934AiI5Pxsc6hdpsaExZCSWF237xXOb9nnEWgHFdoU44lQptQG6w== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(7416014)(376014)(36860700013)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Lmbk2sbBJX0r5nT3fMs391mtUvQu2rxrSUUOjL4gmipYdwCEs+de77O0/9ws/ZF+TyXG9cv9uCh6JoZbiWnHsGQZiaFN6aeb8hcdLZLs619IFsumuc2KSrarG/HFgTlDyI71aWYGOo6j/+L0WktdMKVh7XXAJwawfTctl2xbEv5u2yL5tH/+L2qJCwQe5iD9zsZsczuHro+wjmNO3xzNtQaR8WoYsHMYp9lmc51kgCaRvD8fulzSWn2o9V1+KyiA0fueyNNzo747Zj+kjZc1HdK+S9ggux7Wt4yOJH2nR1Tu2BYDSRYpLT9wlIVAiRg/Zhok+8Y1TRbXGdapZhlAF161MLuHG8zoGrcUs5EiESwJ/gBu1ijSTnjbJF/YVJl3xC3wfEAgq74YIgiHNWUdrTcA/zydLohccmPSGYKukMF92mubG9HP3F27xt9IKydi X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2026 06:55:48.4644 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c8b7bc05-5140-4faf-6cfa-08de78f1e6b8 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF00004FBF.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9404 Content-Type: text/plain; charset="utf-8" From: Vidya Sagar As per PCIe CEM spec rev 4.0 ver 1.0 sec 2.3, the PCIe Endpoint device should be in D3 state to assert wake# pin. This takes precedence over PCI Express Base r4.0 v1.0 September 27-2017, 5.2 Link State Power Management which states that the device can be put into D0 state before taking the link to L2 state. To enable the wake functionality for Endpoint devices, do not force the devices to D0 state before taking the link to L2 state. There is no functional issue with the Endpoint devices where the link doesn't go into L2 state (the reason why the earlier change was made in the first place) as the Root Port proceeds with the usual flow post PME timeout. Fixes: 56e15a238d92 ("PCI: tegra: Add Tegra194 PCIe support") Reviewed-by: Jon Hunter Tested-by: Jon Hunter Signed-off-by: Vidya Sagar Signed-off-by: Manikanta Maddireddy --- Changes V6 -> V7: Fix commit message Changes V1 -> V6: None drivers/pci/controller/dwc/pcie-tegra194.c | 41 ---------------------- 1 file changed, 41 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/contr= oller/dwc/pcie-tegra194.c index afbc0bdd8a93..831986de584e 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -1258,44 +1258,6 @@ static int tegra_pcie_bpmp_set_pll_state(struct tegr= a_pcie_dw *pcie, return 0; } =20 -static void tegra_pcie_downstream_dev_to_D0(struct tegra_pcie_dw *pcie) -{ - struct dw_pcie_rp *pp =3D &pcie->pci.pp; - struct pci_bus *child, *root_port_bus =3D NULL; - struct pci_dev *pdev; - - /* - * link doesn't go into L2 state with some of the endpoints with Tegra - * if they are not in D0 state. So, need to make sure that immediate - * downstream devices are in D0 state before sending PME_TurnOff to put - * link into L2 state. - * This is as per PCI Express Base r4.0 v1.0 September 27-2017, - * 5.2 Link State Power Management (Page #428). - */ - - list_for_each_entry(child, &pp->bridge->bus->children, node) { - if (child->parent =3D=3D pp->bridge->bus) { - root_port_bus =3D child; - break; - } - } - - if (!root_port_bus) { - dev_err(pcie->dev, "Failed to find downstream bus of Root Port\n"); - return; - } - - /* Bring downstream devices to D0 if they are not already in */ - list_for_each_entry(pdev, &root_port_bus->devices, bus_list) { - if (PCI_SLOT(pdev->devfn) =3D=3D 0) { - if (pci_set_power_state(pdev, PCI_D0)) - dev_err(pcie->dev, - "Failed to transition %s to D0 state\n", - dev_name(&pdev->dev)); - } - } -} - static int tegra_pcie_get_slot_regulators(struct tegra_pcie_dw *pcie) { pcie->slot_ctl_3v3 =3D devm_regulator_get_optional(pcie->dev, "vpcie3v3"); @@ -1625,7 +1587,6 @@ static void tegra_pcie_dw_pme_turnoff(struct tegra_pc= ie_dw *pcie) =20 static void tegra_pcie_deinit_controller(struct tegra_pcie_dw *pcie) { - tegra_pcie_downstream_dev_to_D0(pcie); dw_pcie_host_deinit(&pcie->pci.pp); tegra_pcie_dw_pme_turnoff(pcie); tegra_pcie_unconfig_controller(pcie); @@ -2335,7 +2296,6 @@ static int tegra_pcie_dw_suspend_noirq(struct device = *dev) if (!pcie->link_state) return 0; =20 - tegra_pcie_downstream_dev_to_D0(pcie); tegra_pcie_dw_pme_turnoff(pcie); tegra_pcie_unconfig_controller(pcie); =20 @@ -2409,7 +2369,6 @@ static void tegra_pcie_dw_shutdown(struct platform_de= vice *pdev) return; =20 debugfs_remove_recursive(pcie->debugfs); - tegra_pcie_downstream_dev_to_D0(pcie); =20 disable_irq(pcie->pci.pp.irq); if (IS_ENABLED(CONFIG_PCI_MSI)) --=20 2.34.1 From nobody Thu Apr 16 03:43:57 2026 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010022.outbound.protection.outlook.com [52.101.85.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03A3B347510; Tue, 3 Mar 2026 06:55:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.22 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772520961; cv=fail; b=nVeQ95b3u7Y2vyFubcHd+ZIEQXjbRwKWSWwj4PGZnkC369s4fSwmH7Fx2BVZ99lhYE2oWfcl43+gMSDoJkPhnV89LEGjzcq6u5DqNp7QHMEhpbMV/u/pQA3IZka0s79P1iM/84JN+nakZJUVCT2TN/xeH8xlLZ1YnBvIwF7bJz4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772520961; c=relaxed/simple; bh=aIVT82cPwRkHeL4quTnqOnxUZlNxw4IXsS7N+4qb70g=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XcIz1b7azhoJmudzM76CI0pQ59/QLtmPURsZEnaHrVJWLGIZtYkBVSwVWYEHQ0xYfOKKgMq12FHipsxtDiSq4cQoLHe5FIxgg8skmJxQRMakmTL+twjP3qH6zG3m9vrYpyFRNYA5IPEE1nCzZRZrUS6m9akb2a4TXgcaXp0719M= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=AP4RtAy3; arc=fail smtp.client-ip=52.101.85.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="AP4RtAy3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tvJwH4gFFufOVfmqB2dVG5WlzCG9iXD0RT4Ryqh8rBCnKBH9O8wygKSawnrr+NBqvJjJ/vyntxcMtUsfJ70X2oCW04vgwlWtx53MjiIy/ucqzKsUMczMiCl6dBtfgeAVm3d9j3IEgAQY0eoGygA6ELej1Dsdcsuq28WIGKVT3KrC22E+SF7rQHi9GIlgm9UJA1tKraiEGvnk9SFu3sO+I87TBdtZSCQDrciBBN4UQC9jdfzJuOwkLic1yZgNTdbsQard8PqqNpA+iY+gSjuxXpkoWA1eIlrxdx42saBwW19xAPTMpwCQ4mtH0tRAhS++ltA1Zw8DLdcL8WdVRin7Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S0Ff/uWzrWFrS0xHsR+RHlWPrLhNf//SWWqb42WGI6Y=; b=xssJt5B2pWlVDaXxwSWfgw5N/12z3eOC30rrX66xBuqMsEdS7whRrGhsOL3IziUBh6zd/Q1NGA1EPTmeBZpax3dVzlxLUt0JFv7WqKXdOC+H6Pr/ZKRvkjL5JcBeGZ2M2IlLkfrIMmjD4mHaI+OFyuUSihVaypeFmL46RXHuDCgSxk4A0N5V0unpqRaLbpF2yRwl1fB404ab2rolRl8nIuQjTKuNGAOcCbOIoDZULibvwT6y47rPY+5HWWvPUOjxLv8ZncnQ/LnMeE8vp2o9QOJRoFu007ybbX+3/vsbR+x+Vfl5PbdCQVoSfiarn9vYlOtnTFDLqn2g6cdvP3KVug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S0Ff/uWzrWFrS0xHsR+RHlWPrLhNf//SWWqb42WGI6Y=; b=AP4RtAy3i/2xfnQ+FG2kxAM9n/tQVblypRCdEppTm0QU8Ci4n3AQqDulUIrHdD647ZaJGEiCtjfeKQeNVXJgnOEn0dT5wQSfZlZIOnKFdV+KZGn24+0ukYFccMR2QB+qOOadb/x160a7lJRvIO/Q3cNzQxZ45NzmqJpfop9xC0TKrrT8+AoplUJauontWTw5upYFDEsvdT5OorR2cC/tub0FhOR5eWC0fKgHynCaqFo5hWp3kDFG2B5jclTZ2HE9af5JqxjyA8kkZP8C0N5LvfF5/UHPufI576D5Q/+z08LCQGWcHKpff47NpWj3gWDo7bGO8xW9+XjWQaIZrkcbNg== Received: from BN9PR03CA0086.namprd03.prod.outlook.com (2603:10b6:408:fc::31) by CYXPR12MB9386.namprd12.prod.outlook.com (2603:10b6:930:de::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Tue, 3 Mar 2026 06:55:56 +0000 Received: from BN2PEPF00004FBB.namprd04.prod.outlook.com (2603:10b6:408:fc:cafe::54) by BN9PR03CA0086.outlook.office365.com (2603:10b6:408:fc::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.21 via Frontend Transport; Tue, 3 Mar 2026 06:55:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN2PEPF00004FBB.mail.protection.outlook.com (10.167.243.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.16 via Frontend Transport; Tue, 3 Mar 2026 06:55:55 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:55:43 -0800 Received: from mmaddireddy-ubuntu.nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:55:36 -0800 From: Manikanta Maddireddy To: , , , , , , , , , , , , , , , , , , <18255117159@163.com> CC: , , , Manikanta Maddireddy Subject: [PATCH v7 04/13] PCI: tegra194: Disable PERST IRQ only in Endpoint mode Date: Tue, 3 Mar 2026 12:24:39 +0530 Message-ID: <20260303065448.2361488-5-mmaddireddy@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260303065448.2361488-1-mmaddireddy@nvidia.com> References: <20260303065448.2361488-1-mmaddireddy@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF00004FBB:EE_|CYXPR12MB9386:EE_ X-MS-Office365-Filtering-Correlation-Id: 73d78240-38f5-4131-06c5-08de78f1eb3c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700013|1800799024|376014|7416014|921020; X-Microsoft-Antispam-Message-Info: jI/BPBIK+GgoZMQl8n0+6VMjuMq5HIGkOWz53r2rAnDLYcnJwhyz7tcMZdsesm5lGQ36elj+C69OsxN1br7O1ewnOjOOc4ItY3tUVqaHLw/kwwB4mP7KsBqcgOc7/WnpLR0FTgwWONqoTJghP39z1Yrpk+DWPow2buMV8X9yM0eIYucl5wG47SpuWHlZSJhSVvyN6ue8g06QLHP+zTaLRyqUPV+vQlypJotocFpYudCd8XZn2OVlxFalnhjE7caxbPuBJHLlU+17wnt3heHugk9GyPClp+16Ag7HQ8H2zXtzl3XYzcuJXHMSYTJKT+p3pNF0e1yAXj8U/3EvYbp4dYfNdsgJRqdiXPZD3L2rT0rkZRqHzAMkkv0pSEUIiOKybw6xNOLOgFsSGN1jMDhSJvANsdMb1yV36fXp3bD2xR/k/cn/kGWFEiGc46s5ZvIcrjSmPC47zLeWF16qdv8A31Tdlh5Q6n0Xg3KaqG8tVc4DE6R4fPZX4tRiQHqi+a25NaLQvL2QEsnLdCu6uBezHwHm4m3alNm3wXfvsf7D3IkX+isu2BAuWrpEuZVR3g02IMlSB2b5QoYz8YBemy2kIsp/5qoOZxz5Fe+qIuP9rMUt+0AE/a00textNZ28To8MI5ZO25IGmDehPwY3iZgjCMpXttzwkRjbWJAyJpqF1U60jgJzEkxN7WKfNNKDR0hGfebpFO0aY1dUkCNHxwidQkLynEeb+HpDAeRZOnU9TSU7slU/JSwOQOyzjD9hzYfsIMK8KGvjbJEGlSoXHHMgpayegX16jb94KJCUtZjrXTgBtNvWsjj6W7JvR3+aVeiqfH7XkjeCHP24AfHmbJ13xg== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(36860700013)(1800799024)(376014)(7416014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Sq3lXjCErnXJRuuAl3P4/p8v173SsY9S5ONYnXfb4FjcqeP3YcV2urJFu37NAU3ROn2GIhuQMhl9jfRjQn6N8d1ilrKOVeEaEDpW3sxGxLj4zaIrAMX0Cze04CVuW2XtKKXkpofLUvOG04sGWxG3jZpKQA9k8Z8Xl0tiHf942Te/EE84aJOTpRB3kUdih4hQw/l98dNmeOZKfa/kcD2C8jGGOkGMmCM9kSa7WUtFhiBUTzrT3s20ED+E8paOw0T/BmY/9ktOa/eO8UslNtXe36r3X+Xo4elE3Juz8guyCbsAwCFRe+qtF6JDks3HlKfpgh2Tk/hgb3VkMbw9N6GqEZwRxtl4LaS+C28Q/vOH0znhJFH3/Yszi2LL0Ew62tqR3xD6b946RNi8AApyLTNRHLAsUtkwUsILRYbSk1CtFvumdRDXJa5b6QPUB1LqB5FU X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2026 06:55:55.9365 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 73d78240-38f5-4131-06c5-08de78f1eb3c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF00004FBB.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9386 Content-Type: text/plain; charset="utf-8" The PERST (PERST#) GPIO interrupt is only registered when the controller is operating in Endpoint mode. In Root Port mode, the PERST GPIO is configured as an output to control downstream devices, and no interrupt is registered for it. Currently, tegra_pcie_dw_stop_link() unconditionally calls disable_irq() on pex_rst_irq, which causes issues in Root Port mode where this IRQ is not registered. Fix this by only disabling the PERST IRQ when operating in Endpoint mode, where the interrupt is actually registered and used to detect PERST assertion/deassertion from the host. Fixes: c57247f940e8 ("PCI: tegra: Add support for PCIe Endpoint mode in Teg= ra194") Reviewed-by: Jon Hunter Tested-by: Jon Hunter Reviewed-by: Vidya Sagar Signed-off-by: Manikanta Maddireddy --- Changes V1 -> V7: None drivers/pci/controller/dwc/pcie-tegra194.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/contr= oller/dwc/pcie-tegra194.c index 831986de584e..dd8b92fbd393 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -1025,7 +1025,8 @@ static void tegra_pcie_dw_stop_link(struct dw_pcie *p= ci) { struct tegra_pcie_dw *pcie =3D to_tegra_pcie(pci); =20 - disable_irq(pcie->pex_rst_irq); + if (pcie->of_data->mode =3D=3D DW_PCIE_EP_TYPE) + disable_irq(pcie->pex_rst_irq); } =20 static const struct dw_pcie_ops tegra_dw_pcie_ops =3D { --=20 2.34.1 From nobody Thu Apr 16 03:43:57 2026 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013065.outbound.protection.outlook.com [40.107.201.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C0C8383C90; Tue, 3 Mar 2026 06:56:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.65 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772520972; cv=fail; b=e8mVoaZOJISINZsoF4LEicXWZLBzjVYDWeEPMu7MHzwDHvrx2T2AB/dK7omL6mbM2US45bNYFUkLHimaunQyfpkx6zl/8zl0rnV4omV5ASLbtoscHZ+jE+Fnt60BWscz8DDyj5z46D2g+GfVVhbW6oA+zIP56a3RBDzu2Y1XJYw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772520972; c=relaxed/simple; bh=koFySUYWEqbBcWMrbkqQIfi9DDjuB/pPHApTo0tobEU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VeT0bMW+rj+f8dsqZWYZ1ftAli5tV760Gir7xIrbBsOQ3hh0JjPwnu9a6IBqf3zKvSzlhSNCvi8F7b/zKRvGuivB/dYj23vkdy5ofd2BQzB4ajLqlMRUnNuMThKhnRCL5NE/OABvSHpBbirm31Fj/SbUCdiokfy/7biZuYhNc5A= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=SYcB7Tt8; arc=fail smtp.client-ip=40.107.201.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="SYcB7Tt8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DLtg6Bgi3Hl0dCEP6CELJJPfdiO5F2YPwH48ytKcWxhEbkRuGHMg5fdvDKojfiNxk3AFsoSgMlfddD0RZxHnxefDEVfsLBNuiKwDGfsJpNUoNX7vYWXNvSbNzZQM8LINdWilhEaUAo+jbEjbOLHvu38g5re5jLfaEW2vGsVqVRb+8xO3x0AW2nb50wjE0ysVU0rxwArGbH0fkhv25o+Qnqv6dTt8ac5z9uO5Gwfx1jhygIgXq6OMxQYkkrI/6MKcSoN3riznUXBtF/fLaBW5bu7CRZ92rCbCxQvh0kkJgra+4g8ANIUMBjlvOUhr/jlIR0YRQjvMii/kZeQ3EsHswg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0U+iURCncUb3p3Qd8a10ypYwUGHM1knPktG6KwHdKkA=; b=UyqcK//xLKFZYL3Aa6v82tEaxYrKF9x87WMEw5Kwxlo/frEQivS5+dPDuYq8wmxP4nbwIiDOHRRo60QtUICIti8ztgx4ye8mZG/SNZbBKxp4qenYOuCjKGYhpVV80z+8EQ2LaDQVNvBIfmdiQ9fRlhBPK0FbVrXipI9Anvm0IKimzdH1Y+junEss0mbPpEMbtm4LL78HJl/PIncZEf9G6GbmDmhBrm8XjTIwy8xQLBpMjlcmCgMiWQ8reaaFzZPa0UwfRKwxTU0yMZnEB6BPRHW3pxt787bc1XTMz6Fj2/pO8JVpdN9khZ/TjEkBhHnamyrkAOh7pqS7SgEXv/AhDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0U+iURCncUb3p3Qd8a10ypYwUGHM1knPktG6KwHdKkA=; b=SYcB7Tt8/0n5XoekDKiK6PGLLeTcpgcAgx4oDntmzSmRmdzZWvPSUIJlBkXIzKeRk7YH9i/WTEMkRqienZ69+ObNcDBxWv3c2GMsSZy4rVTVcWq4JRC51ccGtgAvfQO9jHWKjbSpbR3SP85FemzV8chnIOc7lLV2gK0aIrpPhhS5J+/cOJ6bRAOqJdG5wQhRYwsklJR4sHac/gqysVmDTZFOWqE64uUGuE/DeC/Br1ainuANdRE38FFD8tJAQPVdi2v5VJJ+9q1kEnsHodAWi3XUb55Mo4cQdmQS8X08zh9K66RAVYIMUX8OKuyGm3OixM1owSXA4u9pEuLm9WyQJA== Received: from BN9PR03CA0398.namprd03.prod.outlook.com (2603:10b6:408:111::13) by CH3PR12MB8903.namprd12.prod.outlook.com (2603:10b6:610:17a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.21; Tue, 3 Mar 2026 06:56:05 +0000 Received: from BN2PEPF00004FBF.namprd04.prod.outlook.com (2603:10b6:408:111:cafe::5a) by BN9PR03CA0398.outlook.office365.com (2603:10b6:408:111::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.21 via Frontend Transport; Tue, 3 Mar 2026 06:56:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN2PEPF00004FBF.mail.protection.outlook.com (10.167.243.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.16 via Frontend Transport; Tue, 3 Mar 2026 06:56:03 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:55:50 -0800 Received: from mmaddireddy-ubuntu.nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:55:43 -0800 From: Manikanta Maddireddy To: , , , , , , , , , , , , , , , , , , <18255117159@163.com> CC: , , , Manikanta Maddireddy Subject: [PATCH v7 05/13] PCI: tegra194: Use devm_gpiod_get_optional() to parse "nvidia,refclk-select" Date: Tue, 3 Mar 2026 12:24:40 +0530 Message-ID: <20260303065448.2361488-6-mmaddireddy@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260303065448.2361488-1-mmaddireddy@nvidia.com> References: <20260303065448.2361488-1-mmaddireddy@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF00004FBF:EE_|CH3PR12MB8903:EE_ X-MS-Office365-Filtering-Correlation-Id: 368c01b5-f72a-4b9e-cf75-08de78f1efd2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|7416014|36860700013|1800799024|921020; X-Microsoft-Antispam-Message-Info: /f2b/oH+HblfwX0pMLUBjmAi/W1fVmrD2rT8bfGiHNIgQzLcUCOyjWSkCU0evzrjc3KpDAR/bR4lrCf4MSLu1Kc9SApNsilqzxsaiOBRCaaL5vtOI9tArESMboX6or4O0iKjAV55puiCBYKsoCD40GyDdzi2B/ngPptxlr1S89XG2WLm88UoZ9Tq46xxTK1hsX8j7YdOS+KgqcgsSX0m0hn02bxjRqdxJSkNG+saL5KUl7Xx7TWJMP8bnLWXsStN18gEeGyus7Pf2guDmvjSn4eMiyZ+HbwnY00Jg/P8peG9P8ZRR8bqnIvErRdOipabySSuSdv8aASeJ42f5OSZSHatXKs+sjfhr2z1kEYw/7l5JT4azqjRuRu6eKeEVmu2EXm/PXuV6SUvHXZbAbOdYutfaPHhOWwk1EFdMNn9cRcbl3lkqG+XWf6eWyep0B+vxYwlT9S0f/Fbpm34xj0f84FbfkjN8WVLZPyHnz7pblNqkYcSF+tuWV/KXFnD/Cj10/BMjDVniW0eU2uNEW7Hxd/qFuTZONDwmInYW/lRyTqkFEFxXExU8oKF0lziSo5nYVX5FuNsBXEI15H67TNXn6Fp28CyhUsxIpNo9awleEnJSffItBLMmxOVxWgUtkK1wU16k3ibvdmL6mLrUtPej674FdyLxhMk5Mz6Y4etcVRUwzmEgvwNoNQpusJnrjsPcTADzMRwbuSyaW9KO8bqitK7ckScpSUc1NdRq7+qywowztDcIdVDCJdUnWjR3Hp5LlmZyO6e2yAxyZIaMhrB6gQF/H83d6yKcP/ueDv1qGAAJCtsh22gj/EYbsFQk4XFv6w9oqZj4pP6SD9SNA+tsw== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(376014)(7416014)(36860700013)(1800799024)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: s0v4JH1xAvAhwnCv+sK3y03+qHYrNy9yu4x3MVpqnr0SL1jrmFMI+zAKxkMreSM7OChoSxRJLi/TO8NjM+nGK6y2sj1J3UUquyYaTigK6L3cNleC2IIV00i5jwgTrAdozFcABjzq7QWAOw8S6qVRwr3BG4rAGE3IPrMsMkI6IG9u+Wp7yvAoj6oFFrvVF/EBI0F4HVhka9DVRNC2fObf1zSXFyu5ByG13JByxjRMawR97Bu5kEDF81GboEiZ7cGdBaiHUMsphBPKFRALbQ1bOlNPv4njgmA8lCvk3hYOtyNasn0gzfw/s9UVH8aKT0Fko/wfLKsh2ssitD4+S7RwI9FGomPhDDkJoE66V6VOC+LHG5k+lT9jxYve9DjdBfQrT0CDf3M2dKdmUKnUWwNGhPFL09eDqxu8tDdMzsuuo+p91uaGYLsK+s4lMb1K6s3Q X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2026 06:56:03.7479 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 368c01b5-f72a-4b9e-cf75-08de78f1efd2 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF00004FBF.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8903 Content-Type: text/plain; charset="utf-8" From: Vidya Sagar The GPIO DT property "nvidia,refclk-select" to select the PCIe reference clock is optional. Use devm_gpiod_get_optional() to get it. Fixes: c57247f940e8 ("PCI: tegra: Add support for PCIe endpoint mode in Teg= ra194") Reviewed-by: Jon Hunter Tested-by: Jon Hunter Signed-off-by: Vidya Sagar Signed-off-by: Manikanta Maddireddy --- Changes V5 -> V7: None Changes V4 -> V5: Added Fixes tag Changes V1 -> V4: None drivers/pci/controller/dwc/pcie-tegra194.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/contr= oller/dwc/pcie-tegra194.c index dd8b92fbd393..7dcf3e3596dd 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -1167,9 +1167,9 @@ static int tegra_pcie_dw_parse_dt(struct tegra_pcie_d= w *pcie) return err; } =20 - pcie->pex_refclk_sel_gpiod =3D devm_gpiod_get(pcie->dev, - "nvidia,refclk-select", - GPIOD_OUT_HIGH); + pcie->pex_refclk_sel_gpiod =3D devm_gpiod_get_optional(pcie->dev, + "nvidia,refclk-select", + GPIOD_OUT_HIGH); if (IS_ERR(pcie->pex_refclk_sel_gpiod)) { int err =3D PTR_ERR(pcie->pex_refclk_sel_gpiod); const char *level =3D KERN_ERR; --=20 2.34.1 From nobody Thu Apr 16 03:43:57 2026 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012020.outbound.protection.outlook.com [40.93.195.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CACF385531; Tue, 3 Mar 2026 06:56:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.20 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772520981; cv=fail; b=FK3WMJ/FulCLIQyFt45bunqIIpjMQBwCgDf2yF74dCcJEEj7Qj0Yw9ikCRpGRP2WxG7sYmAIRnMbe79kGcO/vAnT9yS+Pi40vz2C0diDhLVxFS7CZmgsAygZ39DEgcagxQFuD+1O4W56RzYS1gq+G5mZW346AqPSn5ocjHgLob8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772520981; c=relaxed/simple; bh=gCFbPZUWKAP5ZEFDkDnVu2zg0zAYcuANhEdOk9JNSQ0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fP8BFOMPcsjIsgDcyfnyN7MlZeX4jtGmSHWRxkMtkwRNwBXllQicU6mG7l5UvYnj6FvSuUttikc3cxe1yrEdRT6pZTsTGxgy5CATC/9viMlkYS66o8WYSWk7NWN6nwRV00DUdBfOFs3JHxp9aEFCCsZyz77xFofHGoKqutTtA+g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=N1OWIZ/Y; arc=fail smtp.client-ip=40.93.195.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="N1OWIZ/Y" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OPKB/idNf5IQxwEWCsPtjqhwDOSbS/cBXTiD2a3GFUdIIvZt6GHXGWFsla6tY0/sGVSW6rSbL3oVIRJTNfiJpBn69zjsHT3yptPquRDVT2P5PsQcjxg2+ZOJOhQOs6Ij+at+pzlxbP1AAdl++TIwUYvN6qNWmiD/GohlZeQLEVMrtk0wp02+ijlPh4eBddE0RImhyP/FgAACr/7wVwcj2Ir0d/9ZhFXrkou/hZ6Ji8Cx9pWNVKsULBA1JUi9wDryTzBW9SoFoziefDfB/Ehj83zHtYDXAedgZ8KQSxnre4pKj7JD0VaSnY4YHxdnijgdb407EgXF1yhTsYJe37E9nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zz6GZ8fZvRJUcCUnE7ufNE6yDtqlU94PMRa4pkBsAr8=; b=duQdolvrTZ7b8hAGPLKM04YcQ5j7o6zzwnavsgVq3fFWZeHQ+61rWv4nVXqGHfDMHPMO6qzjxhWKqdO9sK+RRk7jqeRfCGHzyNiqDvcz5sdoYh5Hico/a5SSbqerwcmqXxwFeB+m023bMmJ9QOevIIQQVLDwfEt+wBocihCO8RxhS3UoPyzWgVnHBOzpgUeF1Azgf4zjyjumS3wwkpiiY7XSAPJL+aod7D6CXON+Tkma+PrOh7Ju/1Uo+6Jj7FTYoKhT36hNPZ9MFmalkX4+HREFT3CIpaWhsX5NZ1xsFjYO0dFk9xPlAcu4l0tgWxB/v5BzGdEBQGsRyo/jlnzxMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zz6GZ8fZvRJUcCUnE7ufNE6yDtqlU94PMRa4pkBsAr8=; b=N1OWIZ/YSy2jo7qwF19PrTnUZZTTDez8rXqlB7OcxCWsSuXvDWU3FZZHWPcPJDHQ7mNYtNcxM9MgJfJSV760VDl8AVf+a3elhuvbbPWzF86fcfPtXzfigN6ueetPjJBB8zCPs3gxP/ra5PfHiInzVBkwb82X+UfIMfZSLJzaxNPgN2amEOjOcMLmdiGY+MWN2srGolNkNov4gUw5yKK9fMEAbJ4R0Jv6jWh7rrN6tO9rEohHaFkY0HV+7/3pr6SLpLPgpKISkFfH27qsLDDQbzyZ8sKvqGRreL7tGsd+ZSa2mK5tv6JjthMaJ+kvayLosICgRlQddH6sFYLXy6MnnQ== Received: from BLAPR03CA0048.namprd03.prod.outlook.com (2603:10b6:208:32d::23) by DM4PR12MB8522.namprd12.prod.outlook.com (2603:10b6:8:18f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Tue, 3 Mar 2026 06:56:12 +0000 Received: from BL6PEPF0001AB59.namprd02.prod.outlook.com (2603:10b6:208:32d:cafe::d9) by BLAPR03CA0048.outlook.office365.com (2603:10b6:208:32d::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.21 via Frontend Transport; Tue, 3 Mar 2026 06:55:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL6PEPF0001AB59.mail.protection.outlook.com (10.167.241.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.16 via Frontend Transport; Tue, 3 Mar 2026 06:56:11 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:55:57 -0800 Received: from mmaddireddy-ubuntu.nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:55:50 -0800 From: Manikanta Maddireddy To: , , , , , , , , , , , , , , , , , , <18255117159@163.com> CC: , , , Manikanta Maddireddy Subject: [PATCH v7 06/13] PCI: tegra194: Disable direct speed change for EP Date: Tue, 3 Mar 2026 12:24:41 +0530 Message-ID: <20260303065448.2361488-7-mmaddireddy@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260303065448.2361488-1-mmaddireddy@nvidia.com> References: <20260303065448.2361488-1-mmaddireddy@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB59:EE_|DM4PR12MB8522:EE_ X-MS-Office365-Filtering-Correlation-Id: 1c7b1c6c-8d40-436f-726c-08de78f1f4bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700013|1800799024|7416014|376014|921020; X-Microsoft-Antispam-Message-Info: ufd9s/QQ0Kq/BnyM4c4i3VmLQlXEv7CU9zbRznguvTy2isX+/ydNRIfjP2kgT1ZnQlUffRipTi2ZbEMCEDtIVnE0jSxZTfZHxXKv0DSVSfTUIXZcy8m3Erp/vY7FCGDc5gp2x96ZvZSpHR5aFknRubV0Y8DMmkPy/Nbf0m7Ek55RYgVjT88ORh3OB+bWK33bBThKmPAMcVDPXipNVSOe9jlIwmJ0xfnOWYcyciXeRGBN013J294jf68FbivRCFYOQa9wRPfgxKfq2GVe1peJPQO1B6AQHlPOqmL/jKHLz9h71l+SMmp53WT69OaFeLoJUntyJcBzts3XgdEAkFQMVHBlj0z+8vVtD1pRW2XU8d7jWL7a20HIfSPlYZgHnTLYLA6+0+rqXK+7FhLpNycpcb1bLg+sEyJi7gRsIvI5mO7Ps2HdwEPS4jp1cJrZ9ox/4rBwpKnfV5yWcbOnfHNfZ9mz95ZRgnpZ4Exn1Yk6kc+ED7CsYtsfcHrdZ05hlMCAoNNedzu/pAAsI6C+GBQjpkNRWgWtciFcuK3XMb4KFfNhkzmrJRMpfsiFwZ6zY3ft8OZBCyzBuCwzfuqVb/rB8r6kP6MjcEoV6xdYTXZvQ5bhzuWf+7VI4Y3Xg4YgfpvtsOn1g74o5aVDLDh1+8WX2e144vQz9ADRjgC1BIyyoC2HAfUVxDIy2G2b6Zu+k9oe5WPwdizqRNDqiAE4OHBrTamyXy4Q1vkRil+lRxtjmuPKiQekgrngM78h115VRV7ACvVqYfcqtqUMDgc3GlM3QdpFlu7yQZQNDff+aOEYfEHy4Raw3mk8sM64PcQGk3CUX2vv3g/YYDw8EZsqiBSyC7TqT5mOKzqyvV9YrI4C5uI= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(36860700013)(1800799024)(7416014)(376014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: qTR/sUEsJiPd5FJbdipLCHvclE+FOXTXfzLuH72qacy7rpQxMQU8Rqn9rNOFEEW37wlcQiDlBoJtWQpdhUPcsOLJu4pqr54/nCkI5mSrGPL783ZAr/PKp0Ue7ChU65d3Gr5kzW/AvYm7c2bL7GcuV31rnfQ/aopF4O49TdMeIytv4/qQys3ykXvSTaAsqkaDCZMJFm7AEYyaLyNOi8L1HO5DQCPsKjmxfQugMqYX4YTsnikDFlKhE9BnSD3egLTfxxmZXFYI5K0Ah/9NBPM8jD8t72WqmFIKpxhaiVnQ6F+uh/LOCQDIRnm9/DKKJy69938y1KOo1LT4AaFZr0WtxkliJdcp9y0rZ1UXy9iGYEqtYOlDmE0a3WBGpLBOcU0fQ79A66H6j31UMV5mB0G9SJMRp2T8n5T9ctAlD9LioF8gnCI3kqWsJ9VBKeXBcHBH X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2026 06:56:11.9244 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1c7b1c6c-8d40-436f-726c-08de78f1f4bc X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB59.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8522 Content-Type: text/plain; charset="utf-8" From: Vidya Sagar Disable direct speed change for the Endpoint to prevent it from initiating the speed change post physical layer link up at gen1. This leaves the speed change ownership with the host. Fixes: c57247f940e8 ("PCI: tegra: Add support for PCIe endpoint mode in Teg= ra194") Reviewed-by: Jon Hunter Tested-by: Jon Hunter Signed-off-by: Vidya Sagar Signed-off-by: Manikanta Maddireddy --- Changes V1 -> V7: None drivers/pci/controller/dwc/pcie-tegra194.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/contr= oller/dwc/pcie-tegra194.c index 7dcf3e3596dd..2da3478f0b5f 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -1805,6 +1805,10 @@ static void pex_ep_event_pex_rst_deassert(struct teg= ra_pcie_dw *pcie) =20 reset_control_deassert(pcie->core_rst); =20 + val =3D dw_pcie_readl_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL); + val &=3D ~PORT_LOGIC_SPEED_CHANGE; + dw_pcie_writel_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL, val); + if (pcie->update_fc_fixup) { val =3D dw_pcie_readl_dbi(pci, CFG_TIMER_CTRL_MAX_FUNC_NUM_OFF); val |=3D 0x1 << CFG_TIMER_CTRL_ACK_NAK_SHIFT; --=20 2.34.1 From nobody Thu Apr 16 03:43:57 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012034.outbound.protection.outlook.com [52.101.43.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A746338643B; Tue, 3 Mar 2026 06:56:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.34 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772520984; cv=fail; b=MkmMDQy/D1rv2j40pKLn8y0lTuv5Pgg9iQ1m19to9xxJcxkuu0mOkrUy6qdnuq8jWS8Qf+i0TUjAEpt92B0C1Oe0meSYrLebqY6thhM/9SvVRAfNM0ezN+YG8J3RmzlYxERU2LXUAl7NOqdguh+oTxj1ZbJ8Upg6JHov/nbDlIE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772520984; c=relaxed/simple; bh=8G2p0+C7+apaBvNpJz/F0WYtVBujLOa5l8jbb0+M11w=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fbCovLRXLJbRhceNO5kvhZDIsfqO+Tb/JmVxsUOkFhUSVRlUwHPWBzzDUpzJ46tht6Sx/GIwYtKo0HsQZXjQ13ZVXl3LhJPiqIlFC7Fx5/pmUCmbJyK0OamAH9pO3dY7eU8uWvMTn5uTZgPlyoQdWEqrO4MWZ0YQabyM8Hz8qZg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=UX9XV1Sb; arc=fail smtp.client-ip=52.101.43.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="UX9XV1Sb" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WeKhySIbsVR0aH4sp1/XhdiyxYUDQtfIR/4d5cq/AIYs5RwJPWQTHK1+gykBhWymlwLQI4dERFeJuHwrnbcZg0Lif0200FKniVBk6yXl5m/Ur2xtXY9zhAqImO7K9gUVyi0OC+X766wFwaBm48xHa10d9AGVMYzWzCmah1jLHeL0vdm0jDuOyLtAbI8hChsI+y2dzKHzLpLdP0NMa813Rg4xc9Vol4AegaHK4bwk6AvSAFdvsPbota9inlUTaBFnnyt8tLoS3OMr/tw08hzBmJYFLp3X6POB5aUlqPBcOSuKdEJpuUW2bwjvZP7V2R9D92dQJeUzZFbhV7MXkZmjgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a4fsYgDNo0mJjce6YgegRNwVG/asQnkld8eMApLG7Ps=; b=Cje2F02trJjCgQ4p5O7RV+c/jEa63B1WJMISKcWGWriIiTzDfEqj5XUjgUN/4nDxWN+v7jAxY078MfZDhHzk1j65wM+Y+ASqf/ZP3NMnC9AKCVNpUZEfXsnMMiQ+cirEFnJdh87DrWZ6AMg6NHub78Qypo78UDXIr9k1B+OaHm6VMAA14FjISLJMh8BZZNvT3pdu5fAb7BecGNT+kaOflvo1El8SSaYpPo+Ril33dM0nAoQONSQO/ChHmlMM9XYTDmy1KE+0lf0dRPrYtI9hcNRlAU2E0hgAC5EAwsCpfigcmmSzhaugm0rSYi7bF4FK5UkxYOchlJIlJTI0wSle2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a4fsYgDNo0mJjce6YgegRNwVG/asQnkld8eMApLG7Ps=; b=UX9XV1SbO7tbQX6VXxxj/I639XEO9omRJkB5zf2XJWGBJX9pX2uWTs+MEa+0O5E/yzrKeLejF+Xv5kn0ixIN8EVymF/H6yM/7NppQ28/L+L98Rq7vT1P9A1cgUUrsnZ3bv0uJ5SNOJpfR33UU1M5gA76jGl7S9t9Z0Z1vz3f3Lunn7o+vXHsdjoIZlrCEIfcNT/HUsSlw38AffCsd4YWMa1aSFqX/d9d49Y7JwGPCSTn0Fkh7e3aLkcPp4wv33/KZsATWJqcF5zMtY75S5xy/BFqUdrdIhK1DSj07i3sSmOfi0y3sR0fWhfVecxD1d41UAbdeb0POQaxAAzlBeiH0A== Received: from MN2PR01CA0038.prod.exchangelabs.com (2603:10b6:208:23f::7) by PH0PR12MB8176.namprd12.prod.outlook.com (2603:10b6:510:290::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.17; Tue, 3 Mar 2026 06:56:19 +0000 Received: from BL6PEPF0001AB57.namprd02.prod.outlook.com (2603:10b6:208:23f:cafe::b0) by MN2PR01CA0038.outlook.office365.com (2603:10b6:208:23f::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.20 via Frontend Transport; Tue, 3 Mar 2026 06:56:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL6PEPF0001AB57.mail.protection.outlook.com (10.167.241.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.16 via Frontend Transport; Tue, 3 Mar 2026 06:56:19 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:56:04 -0800 Received: from mmaddireddy-ubuntu.nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:55:57 -0800 From: Manikanta Maddireddy To: , , , , , , , , , , , , , , , , , , <18255117159@163.com> CC: , , , Manikanta Maddireddy Subject: [PATCH v7 07/13] PCI: tegra194: Set LTR message request before PCIe link up Date: Tue, 3 Mar 2026 12:24:42 +0530 Message-ID: <20260303065448.2361488-8-mmaddireddy@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260303065448.2361488-1-mmaddireddy@nvidia.com> References: <20260303065448.2361488-1-mmaddireddy@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB57:EE_|PH0PR12MB8176:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c4ee52d-4547-48ba-a8e8-08de78f1f911 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|82310400026|7416014|1800799024|921020; X-Microsoft-Antispam-Message-Info: UGdEqvDXTjOA4xtMrrY6pkG2ysHdIvTSbuuw8W2EA0EwOpzhB4MCAElT1YzEZYmLBDHGAUHIGMDBVLf03uIF0kYBHlSOmFEj7So7udhvCEwfkzZmdpSRqyvx0Rw840jx/bum2fS2WPr2O7cB0Ecm0U4+cxQ7o3H6ayPSYWiA7pUiycVlxjzGPziQJB6C8QVOBukp5foM5mWjI3QFGEPCiI1ToRILYLvtN2YvK1eXKc6oBU9IP8+uXuJJRa3fcHFzk7ej1TsPGBU3RxieWbIDC7P5jKCu9IPfbEv7cnjooaVpSvubVqOP670x8HsyUAWd2dp/k73lj5VH2yKNQzRibkimszc8Z5WXrpwKgTzFz59PgiXIbl21WOc0vOMivKleUoSCp21E+IwRNDB3Gyb8tuoQfWRjb11Jk6qq3sIvdoDMBO7h67m65a/+WTw94vBK595UqQTyF5DsRkPbQDDlZyxKPjdnZI63hCs5jopptTTW01jYbRo0AGfqZ9nSAqP9+gxRmAkeAf4KjDVE7nlRWigRnHHMW7ztDJqcH9uSGEnVcqco7z42W57oEMEe+VxP51ILEIkkDf+u7BUD4Fl/shjUDZAc8xcy0gBc4fE+lg2Y+m2P/Ex3Mg9uCPjlqs3fJDxkWWuTVkP1Ygj0TcYG8ebZI2HSJncnvUTgPBoibqWFsVfyVA42U3CJaY1QfUClqA2hGpcaGwy7CkLjgAIe1sCkQ39v27DnO75exBKWZ52H9IFRCeQP3bVzwEtQsa8pCGfQnIZqtEFIi7vWuKwiK7+5l4I93u5KamzYBuXo35+UwdPtnn227jxYMuIjFaACW8bSPw/HPO6yfi4acSWu/pH269hp56FspWYXwTQRXk8= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(376014)(82310400026)(7416014)(1800799024)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: TZOoaJsKq5QS3auKswKv91I5C+7XL/W+6te4xmJtqkyUfYpBY9Pl43Fhb8M+pvXTrTaz/z46yYK8WQlFaV4yGYx5DIjfAQrje7zMXcfzz/XGKI+ssydFPJmBXtuZXVXXRrOYwSY8ppuWzvTrC9fkVJDDWDKzBgiS/p9R55DDcYclZ2C5JRTe9nyhZ33KZ0M7UqaH/Ij4qQ3qQ/bI2XitukwntlhoEa5qaGYZ/snVPBCuwhBX8L89xSNktp4eucCkOV6QTisyPSluf9bewmQeULWuvBbv66snNMcSCv4fu13mX0T5IF9aG2nmptcmRbXqr5RG0M6VN6Je2RqAvyCAvQeAJzu9cYYtnMasxiZT/0UEnpslb9V0bv/q48E1rr9ji36t+yaTEMoxHI0WzS+QdoYyQCqNrcQcyySLdhGx/oy5FPUtWFUYJ5vnfzP8QoJR X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2026 06:56:19.2465 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c4ee52d-4547-48ba-a8e8-08de78f1f911 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB57.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8176 Content-Type: text/plain; charset="utf-8" From: Vidya Sagar LTR message should be sent as soon as the Root Port enables LTR in the Endpoint. Set snoop & no snoop LTR timing and LTR message request before PCIe links up. This ensures that LTR message is sent upstream as soon as LTR is enabled. Fixes: c57247f940e8 ("PCI: tegra: Add support for PCIe endpoint mode in Teg= ra194") Reviewed-by: Jon Hunter Tested-by: Jon Hunter Signed-off-by: Vidya Sagar Signed-off-by: Manikanta Maddireddy --- Changes V6 -> V7: Retain FIELD_PREP() usage Changes V1 -> V6: None drivers/pci/controller/dwc/pcie-tegra194.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/contr= oller/dwc/pcie-tegra194.c index 2da3478f0b5f..b50229df890e 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -485,15 +485,6 @@ static irqreturn_t tegra_pcie_ep_irq_thread(int irq, v= oid *arg) if (val & PCI_COMMAND_MASTER) { ktime_t timeout; =20 - /* 110us for both snoop and no-snoop */ - val =3D FIELD_PREP(PCI_LTR_VALUE_MASK, 110) | - FIELD_PREP(PCI_LTR_SCALE_MASK, 2) | - LTR_MSG_REQ | - FIELD_PREP(PCI_LTR_NOSNOOP_VALUE, 110) | - FIELD_PREP(PCI_LTR_NOSNOOP_SCALE, 2) | - LTR_NOSNOOP_MSG_REQ; - appl_writel(pcie, val, APPL_LTR_MSG_1); - /* Send LTR upstream */ val =3D appl_readl(pcie, APPL_LTR_MSG_2); val |=3D APPL_LTR_MSG_2_LTR_MSG_REQ_STATE; @@ -1803,6 +1794,15 @@ static void pex_ep_event_pex_rst_deassert(struct teg= ra_pcie_dw *pcie) val |=3D APPL_INTR_EN_L1_0_0_RDLH_LINK_UP_INT_EN; appl_writel(pcie, val, APPL_INTR_EN_L1_0_0); =20 + /* 110us for both snoop and no-snoop */ + val =3D FIELD_PREP(PCI_LTR_VALUE_MASK, 110) | + FIELD_PREP(PCI_LTR_SCALE_MASK, 2) | + LTR_MSG_REQ | + FIELD_PREP(PCI_LTR_NOSNOOP_VALUE, 110) | + FIELD_PREP(PCI_LTR_NOSNOOP_SCALE, 2) | + LTR_NOSNOOP_MSG_REQ; + appl_writel(pcie, val, APPL_LTR_MSG_1); + reset_control_deassert(pcie->core_rst); =20 val =3D dw_pcie_readl_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL); --=20 2.34.1 From nobody Thu Apr 16 03:43:57 2026 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013041.outbound.protection.outlook.com [40.93.196.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9429438642B; Tue, 3 Mar 2026 06:56:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772520991; cv=fail; b=m8MM2JfZxoZP2+ggvRlUQYtLCwJt7w6hMB1TaRTqhqDGy1YuBpuHA56y78k0dGKrnHX2C60in4++c4jG+tYnHbI1c055oUGRBWWZFXO5S0V+cNI6480+o+KCd7toQ1g820VxFmR1eq27wiAuvhoGUEdHE991Y1/nrvDZmnxh7j4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772520991; c=relaxed/simple; bh=yozb2VvKWVSFwL8BHHbSLLJgSn572iR0w+YFowhtlFU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RNbOXMZ5BCQ22IK5lWKjUvXcBF4E8oIi1Y9RnFluMvVDWpd26F1up4xVStsQn+FPMmq2VEfOPG+byA4II+IR2arQlfoUtMPtDzQcEed/Uxu4A4IuM9TL3YfMrZ64a6ZNO+DNG/lJ3K/11336MPdsuGmMoOlkTyTjfRqaI8fMceQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=B5GrGtFy; arc=fail smtp.client-ip=40.93.196.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="B5GrGtFy" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZThN34GREUk4Lp3MLzed0i+jGWwMu+ZN4r5+JWNaM3AtHoqymk+lNM6xaKLT3CXKDgOqxgAROi6vuI+VwvGMiQmiiV6U5+c/24oZ1wAqXaBhXtuztndJRqJ7soePSNBM7QZNsmRbEwUYDjvHyPDfPIJfvydLev9q7KxchXGnLmdOO6U8ylZ8YCuYHs7gI16yI2Q0/VXCL5Rs9HInqnWkbmO3bHqOz9Wn18G5WQ6fJ4pwPMNgAKZs7eRnqOiMjPWR2WDmxYLJnBLVYRlk7dnYVAOvDjWkHYHULIBcKdwl+HJ+LFEmLh8lqd2HyImmS3diJUo8niy6GFdmOeyCREWVTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gUMPI6r70u93WUs5yKA/4uyPZ6A8GJ8521cCxlJTn/s=; b=aVtLkqzSGnM/NELmaY4LNEx3J1sn99QdHyWlWhA6XTYGT4bg2rGtcVF/Pt/cP9daeWiKC2/TLAr4GVN805wfpLCcvDS82RkhXw5e5cNfXlUyxuYoj6u3JvEYl/2KAl0wlB3Czy8huAh0tJ9dzSR74hb+Lv2dKNjHmJm/6wLQxB+ioXAZv9x8HdMkZqi8c/nz0VJH9vjBije6wqiHdk6eOZasYXxCbr2Y/PpHofyo0HFCT435QCFY5+imeOfDJrHV8GM1LBDEqLP5ioOWHCogpfZiqjv/K5G+2qRsiyoRWitFn3RdGa8ZEkshSxIRH/blHjuKhEd09cXQZnGLy5BRYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gUMPI6r70u93WUs5yKA/4uyPZ6A8GJ8521cCxlJTn/s=; b=B5GrGtFyAMfA1s9zB8Au7WikhsbWppyVACadDExlHWjA6FHWOYPes2fdD5ri3XjT0Fb3u8kl6Ah1kODpQlUrsUe6dQjIuPlfKUtWf//V1NxxSQ2PO64MMzKvhaDVunK4QZMC2/FyhCDO2NfoUSqQEkxk64rFpCW8RuTYY2nOkS1JVnvh5iZT7AMTxN78uyk85MzORWNV/yhhjvKRciGRgAuZjCz231fpJ2TLhaFpmWEz67PaPZ9UHLl2Q5CyYYjungKLC30B8MtJyzyzRFKPFYMYreG++6HtIej77+8Eegv+fOqbs4ejK2pKVx1eYzcgXnfkuQlAL5St6g4ZgWjR3g== Received: from MN2PR22CA0023.namprd22.prod.outlook.com (2603:10b6:208:238::28) by SA0PR12MB4384.namprd12.prod.outlook.com (2603:10b6:806:9f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Tue, 3 Mar 2026 06:56:26 +0000 Received: from BL6PEPF0001AB56.namprd02.prod.outlook.com (2603:10b6:208:238::4) by MN2PR22CA0023.outlook.office365.com (2603:10b6:208:238::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.21 via Frontend Transport; Tue, 3 Mar 2026 06:56:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL6PEPF0001AB56.mail.protection.outlook.com (10.167.241.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.16 via Frontend Transport; Tue, 3 Mar 2026 06:56:25 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:56:11 -0800 Received: from mmaddireddy-ubuntu.nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:56:04 -0800 From: Manikanta Maddireddy To: , , , , , , , , , , , , , , , , , , <18255117159@163.com> CC: , , , Manikanta Maddireddy Subject: [PATCH v7 08/13] PCI: tegra194: Apply pinctrl settings for both PCIe RP and EP Date: Tue, 3 Mar 2026 12:24:43 +0530 Message-ID: <20260303065448.2361488-9-mmaddireddy@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260303065448.2361488-1-mmaddireddy@nvidia.com> References: <20260303065448.2361488-1-mmaddireddy@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB56:EE_|SA0PR12MB4384:EE_ X-MS-Office365-Filtering-Correlation-Id: fc3784eb-031a-4f9f-e625-08de78f1fcdb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|82310400026|36860700013|921020; X-Microsoft-Antispam-Message-Info: /T8MVIX1m1j6DuynPRCOcVvAmD+vBGc39jmnpBJerIEsa2YmrJxiaEmTrWGwq2I8/E/8eJXEhlsbvXXll9d/3A1HPddEBOue/MmeKnPnpRSnm4boLyZJZx5RZmcWDRHf269YBGOZ1pYxyyDGl465AzjXsebVKd2ZDg18IWnnmahKmjGqJMKFBlAJP/SHZYlcXSFJZhUvnygYkFdiRoA3RqKCLT+3JMViPYcJ+ypFhy5fBbTbl5qJOKyqU/kbdnnyxNAOkXydEZwbvv+FQH6MMeqAbs5E5xAiKz+9V0b9C4JZczNQbevE46l5LmciAdGIBS/BIw0Rg6D9nRFv0DiczLKnbE0BcI8pQagq1qJQUptXGl3fn+5WuU0rkzI2sUr3gWRM7untD6KwyA4sVaxfVcE/8ZxRI5kc1W9fX7zJ1gHBMdjH2/ptfK+c2EuxWL4uN432blEJKC7JRF1gnWj71LZu4F86MyqmFVwWpipMT6oevK+TpdIJbJQPEGnLJGoibzchUP2e8ZjwCsNuTGCNWtLrz0Cc0CTprwOeOL91Go8RP3uATLt0a7Ylg/uW8bW1TxvgE7RHpV1KqcrM52XauNPtdJFIE+Z4mROTSlr5o6KQimWxHGbhH6M7mf7+zgl7VO383Lwh1LWJKpD984ppQuDgs/7CZkR2QgGlqYaPfcZrc9WB8xKO8x/U43e5brl9YmlnsZiuSmEeJqYrNquk3IHJWzWvwbTm9vKB7p+5yZDVkTJvvdZaOjEI8agOYH0UElHPajY37Z2cIrgbBp7TwVjbBIkN6CoGv63xf0t3J67ik9NtVRZ7mrqqEOXRh4gwXC4IJPE7+5szWzNMxcD3DZdqGiqFTWv8gDppIDERn5w= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(82310400026)(36860700013)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: b8RIpPM8tZ0fP7ZUdG557l68jMn+FwiuUbQne0fHeGfR13mooy1UCS5vfejt+nv9zChSiptcvoo/c8sPmH5dzXGNJN/ZaExa2qFEColSHco+Tzym9EcnDNHWzr4uw3rC+uRDZ0+2D9WNIDMP5X1ZATnII10J+OOJrIQskPm/eA+8ldk18+wgmhEz8b7NTODQ5dRiy9v60uVFz4LnjKVhgTZjyXqmahiylnOoC9Il5qYZEAUi3gLMn+8fNL9VhDt70ayG42BY3zIJly7lj80B4ll5vFZC+0nQ2NNkS7UK7bj18/3oY1USBWO7LPLF/dBHRPLXZbdcnkf4WKaZt4MBUndWB4fSl311v2wmalXruqIuoBQOwlLUaiJ/LbhgdO9GbpLE9kbfMdhme4BCFoOXjv5HV+VazOJB6j5MACcSOm9SzALpCrFa8TxwmUMXSKUf X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2026 06:56:25.6161 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc3784eb-031a-4f9f-e625-08de78f1fcdb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB56.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4384 Content-Type: text/plain; charset="utf-8" From: Vidya Sagar PERST# and CLKREQ# pinctrl settings should be applied for both Root Port and Endpoint mode. Move pinctrl_pm_select_default_state() function call from Root Port specific configuration function to probe(). Fixes: c57247f940e8 ("PCI: tegra: Add support for PCIe endpoint mode in Teg= ra194") Reviewed-by: Jon Hunter Tested-by: Jon Hunter Signed-off-by: Vidya Sagar Signed-off-by: Manikanta Maddireddy --- Changes V5 -> V7: None Changes V4 -> V5: Use dev_err_probe() function Changes V1 -> V4: None drivers/pci/controller/dwc/pcie-tegra194.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/contr= oller/dwc/pcie-tegra194.c index b50229df890e..5b79d3c28ba6 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -1598,12 +1598,6 @@ static int tegra_pcie_config_rp(struct tegra_pcie_dw= *pcie) goto fail_pm_get_sync; } =20 - ret =3D pinctrl_pm_select_default_state(dev); - if (ret < 0) { - dev_err(dev, "Failed to configure sideband pins: %d\n", ret); - goto fail_pm_get_sync; - } - ret =3D tegra_pcie_init_controller(pcie); if (ret < 0) { dev_err(dev, "Failed to initialize controller: %d\n", ret); @@ -2077,6 +2071,10 @@ static int tegra_pcie_dw_probe(struct platform_devic= e *pdev) pp =3D &pci->pp; pp->num_vectors =3D MAX_MSI_IRQS; =20 + ret =3D pinctrl_pm_select_default_state(dev); + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to configure sideband pins: %d\n"= , ret); + ret =3D tegra_pcie_dw_parse_dt(pcie); if (ret < 0) { const char *level =3D KERN_ERR; --=20 2.34.1 From nobody Thu Apr 16 03:43:57 2026 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012007.outbound.protection.outlook.com [40.107.209.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6976A37CD42; Tue, 3 Mar 2026 06:56:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.7 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772521001; cv=fail; b=hZWnYQ3d9UoBkmR3ArGpUMNxaFWpuIjr1heegFa6wdCZVQMnXZam2VcHF8FtUvs2YcwSc0ujUvt/k12cxR37Rpo4Wb7dl/ASacyPsy/dMRTVmZHWQHv6xkPx/rOLtWWusZlWB6m2VSrkck2U2XMtpDLBnoMsfaF3vBIT44pP7Og= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772521001; c=relaxed/simple; bh=5F829qE8+Se7dCbGbZuo4Zs0WQv8HjmZ/JmububE4YA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=I5owGvI5iulvzmpyoesIm/HQEiySi9nFQ/KVXj3cMNnp8/qW/JWw4KPN+N7noCoMiNWSY3HxErb0uoZghtdPzq1atdDBD9IkLKQBNuYwoeF4Us7dg8tww9EOh0zhF9GwjycEN9TB74itbB9Fg3vu9cjgepVQhJOx9Jsv5nZeoBY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=mcTLoeEj; arc=fail smtp.client-ip=40.107.209.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="mcTLoeEj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PbKOqp1LJ/Gd5Y0FgvyG4tH9jLXf9xRWiuksX08hqN9Mi+SA2hqYshS1DMpeH/m6WRJ1klwx+8dH32WKGp6FwiZvo/Y8vYBEp1Qre/EgA6O3VGsvb8ehHFW0LXZs5NSe6zLFQPaw5+jVGSBKulsETfYCBH1/K854Mtk91gX7f9ULkOa8zpOqMM8+4UmV4dYYJWGv/6sh7x2hpnH6Nls1jSvjbNMjDZ3Id75pSHpFK8UEpdiAwO5WuvZQLVqlF1LUw3tkf+9d6iryOgwRpU/PupsCjSODQA1HGk0hgasZ1reEWN+53E5Jr/+xGFvplYneNWZMr3Da7RwtLMm4GsTrDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6KP3Pq309nuPI1Vwwig3jioKsduRbBWROjoRrJTSZDQ=; b=jCjWF2HJHpi6mBgDt0Tm7ox5zEyzDMWvKTZgnNgudtvbQQR6kE5DJ7FoUA7L/4NNKAqD161QBkkyfOFMLlq1WFwWy90pVHsujKtfRZo7XQ8lgocJUeJ49p32HOFQgbbaaU1jFl5/n01UASHm5EGZrOuEVy+R0deDsFSxFrOINi0NagNQH8FkG2HM3N2gpr6YCGAPodPEeHkSr/TD24zixpKhVnziWwmaZQeZh7qBvMTL/axPFzt6O37WlOBpRcYT6ThVSfWeTKiX0J230ooZa4zaiLTQSy1FlA9CDHlEpNTQTcM9jeAQlXdA30saTGQe5P+2nnJgScrnAC79FiLAcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6KP3Pq309nuPI1Vwwig3jioKsduRbBWROjoRrJTSZDQ=; b=mcTLoeEj93NggGldXKpws7b9qNFP0lLd8ggcNncW4hmoAPHdE3GUxvVQeSANpua9jz58ijUKKInAyMOU22slsm/HqoFy3lOVUVH/+eIBsMxB7P8lFBnvpEMMRyalYa3aiprCpeF32cfizg3/8QdQ1KX8Gjq5EPaH3bFGq4Qj6n5n7APa5suVgt6KPkWnR4bfj612qh5d+5udymkfJi3sA9hy9o8kArmvWTTnMTpYvyMgNLeELobggTu6Y4OSvRLxjq4MZqUYRvZF9o/jLpSZRVAvC8+yKeaLsuDKbYPXyxKyjGYFGx8yvtpDlOCy+7JZmGLmManxlPdJys0Rb1Qu1A== Received: from MN2PR18CA0014.namprd18.prod.outlook.com (2603:10b6:208:23c::19) by SJ2PR12MB9191.namprd12.prod.outlook.com (2603:10b6:a03:55a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Tue, 3 Mar 2026 06:56:35 +0000 Received: from BN2PEPF00004FC0.namprd04.prod.outlook.com (2603:10b6:208:23c:cafe::95) by MN2PR18CA0014.outlook.office365.com (2603:10b6:208:23c::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.21 via Frontend Transport; Tue, 3 Mar 2026 06:56:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN2PEPF00004FC0.mail.protection.outlook.com (10.167.243.186) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.16 via Frontend Transport; Tue, 3 Mar 2026 06:56:35 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:56:18 -0800 Received: from mmaddireddy-ubuntu.nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:56:11 -0800 From: Manikanta Maddireddy To: , , , , , , , , , , , , , , , , , , <18255117159@163.com> CC: , , , Manikanta Maddireddy Subject: [PATCH v7 09/13] PCI: tegra194: Allow system suspend when the Endpoint link is not up Date: Tue, 3 Mar 2026 12:24:44 +0530 Message-ID: <20260303065448.2361488-10-mmaddireddy@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260303065448.2361488-1-mmaddireddy@nvidia.com> References: <20260303065448.2361488-1-mmaddireddy@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF00004FC0:EE_|SJ2PR12MB9191:EE_ X-MS-Office365-Filtering-Correlation-Id: e44867d0-f37f-4769-ddad-08de78f202cc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700013|376014|1800799024|7416014|921020; X-Microsoft-Antispam-Message-Info: jBEnVzENpK7sF9kY73gYlHq0sicuCYK2ve40EnTbDpC9NPfpnx8vchxj0kEIX0CBv37g0EI5JZ60ymGU1oKx+XR5FsOW5JP9+oRERITTLIGtT0kQiDcpvfKtSB86SyFF9cMuw7u3a0pTNa5eHT0eNTiD96JLoFx0VYgZ2iZJClzyfa8nIX9rabKlda7klZzCHkcmTzrLN2w+K/MjR19I37oFxY7XqnmxK8BQQ2IUoDqPKng+7R/BhwCIE7bz42qZvMc0DxZCHexl1pcA3K9jXYPQvKNzlQiWmbJLHg8KxW1FxIVqrJziG8UqaXToV0Jo6ycbYz8kPRjxo/rKSHsO7nm1ePGW7hbOOoHWCxWek/7SzgxI4qTvn4BWMPCZofA7yPmnCy98FYvn6vRfxYs7vypYMH1+uGIE6MOPJ8CcxUDhbdGknuoFmSTcb/YYkqo39azchzcvFZb3LampVr7mB4bbkhlcRBZy/i0yl+xwtKtiqKSvjWt1x4rjLHj49750VgwdlU9+VJVQQiNbJ3i7SfYIzEiPFfpE+CKqB5GZQ/FAjI4D+Saa3ZQwPd3OIoi8Vdw7rYbPDbHlNQq/N/kzDhW0utH9cVwc/TrOm5zIFaGZ3OiCPbyfY+5gv2gft4/J/4VRdVpuIthlT4SBs9CRLjdGYyiQWsBERnAbHsl42Dj7naEZV5fanzDlFqcWyxZiaE3y1TWxwIdwdo1LzBJyakdGytsfIxFfLG14FmO0CejPutGMdd8JjItbrmt3120drBdM+Wq9PuB1pv1EyaqRyHp9QSooC1snaMIauOekU8jJwMYi+qgdz4670K6tlGV0oCOWe4MsfIOCzS9CzcMtRsbZNaXWQGyCl4t7YW+Rvto= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(36860700013)(376014)(1800799024)(7416014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: WtTgYkVm4MPPk61c9khDl6VJTfs0PIOpg87tt+nFLBoTOaYbX0g1bF9NjqOrUotN6nPCLDA1XqEtU9JE0COYCnCVgax9vqA+jPBVqQPrgYK2k3A0id0BW5I6IkWw0NeLDoWanj1jnUcPS0p2LKH+EmljfT0ckeq+6Yh665OoU+4QJoiGN9R9jSgJTJpT/VQSYrv0tmfq4qMThcIEQNxRyuTaCuQkb/farcvXZG82/uboIthOhtVo4rCAv/JAWI0GzlzFgKCT6lcptgtpcfSnaXbjnV4GH2T253lxHVtNvngVmMg4NHIoClOpajWyDXvDeXi2KE417mdRS4XP2a8Ux50eMPhVNn7VegQJojxnSebQjdIJVK692z2494L/q1TwXS53PPpLhPl27GaJkiOK2P6sPiLHnkpOHxDXAnIoqfSDAr0V7y8gtJlQs5ccTtI0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2026 06:56:35.5252 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e44867d0-f37f-4769-ddad-08de78f202cc X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF00004FC0.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9191 Content-Type: text/plain; charset="utf-8" From: Vidya Sagar Only a Root Port initiates the L2 sequence. PCIe link is kept in L2 state during suspend. If Endpoint mode is enabled and the link is up, the software cannot proceed with suspend. However, when the PCIe Endpoint driver is probed, but the PCIe link is not up, Tegra can go into suspend state. So, allow system to suspend in this case. Fixes: de2bbf2b71bb ("PCI: tegra194: Don't allow suspend when Tegra PCIe is= in EP mode") Reviewed-by: Jon Hunter Tested-by: Jon Hunter Signed-off-by: Vidya Sagar Signed-off-by: Manikanta Maddireddy --- Changes V1 -> V7: None drivers/pci/controller/dwc/pcie-tegra194.c | 31 +++++++++++++++++----- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/contr= oller/dwc/pcie-tegra194.c index 5b79d3c28ba6..b2794be35cfe 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -2267,16 +2267,28 @@ static void tegra_pcie_dw_remove(struct platform_de= vice *pdev) gpiod_set_value(pcie->pex_refclk_sel_gpiod, 0); } =20 -static int tegra_pcie_dw_suspend_late(struct device *dev) +static int tegra_pcie_dw_suspend(struct device *dev) { struct tegra_pcie_dw *pcie =3D dev_get_drvdata(dev); - u32 val; =20 if (pcie->of_data->mode =3D=3D DW_PCIE_EP_TYPE) { - dev_err(dev, "Failed to Suspend as Tegra PCIe is in EP mode\n"); - return -EPERM; + if (pcie->ep_state =3D=3D EP_STATE_ENABLED) { + dev_err(dev, "Tegra PCIe is in EP mode, suspend not allowed\n"); + return -EPERM; + } + + disable_irq(pcie->pex_rst_irq); + return 0; } =20 + return 0; +} + +static int tegra_pcie_dw_suspend_late(struct device *dev) +{ + struct tegra_pcie_dw *pcie =3D dev_get_drvdata(dev); + u32 val; + if (!pcie->link_state) return 0; =20 @@ -2296,6 +2308,9 @@ static int tegra_pcie_dw_suspend_noirq(struct device = *dev) { struct tegra_pcie_dw *pcie =3D dev_get_drvdata(dev); =20 + if (pcie->of_data->mode =3D=3D DW_PCIE_EP_TYPE) + return 0; + if (!pcie->link_state) return 0; =20 @@ -2310,6 +2325,9 @@ static int tegra_pcie_dw_resume_noirq(struct device *= dev) struct tegra_pcie_dw *pcie =3D dev_get_drvdata(dev); int ret; =20 + if (pcie->of_data->mode =3D=3D DW_PCIE_EP_TYPE) + return 0; + if (!pcie->link_state) return 0; =20 @@ -2342,8 +2360,8 @@ static int tegra_pcie_dw_resume_early(struct device *= dev) u32 val; =20 if (pcie->of_data->mode =3D=3D DW_PCIE_EP_TYPE) { - dev_err(dev, "Suspend is not supported in EP mode"); - return -ENOTSUPP; + enable_irq(pcie->pex_rst_irq); + return 0; } =20 if (!pcie->link_state) @@ -2448,6 +2466,7 @@ static const struct of_device_id tegra_pcie_dw_of_mat= ch[] =3D { }; =20 static const struct dev_pm_ops tegra_pcie_dw_pm_ops =3D { + .suspend =3D tegra_pcie_dw_suspend, .suspend_late =3D tegra_pcie_dw_suspend_late, .suspend_noirq =3D tegra_pcie_dw_suspend_noirq, .resume_noirq =3D tegra_pcie_dw_resume_noirq, --=20 2.34.1 From nobody Thu Apr 16 03:43:57 2026 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012023.outbound.protection.outlook.com [40.107.200.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F97132D0DE; Tue, 3 Mar 2026 06:56:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.23 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772521006; cv=fail; b=dCgkdxGYAPg8lQZks31knezap+2vzbwxMpboRCxRifyquMr5UQAuDUisigAHNWjK45zwpdu5eHpwt5oHLfacBPAsTEp/HAg/JPhjsgXg+96S5ey4BiCFxR8FtGh8BxRXOEed1KQESfPIcdyXDw9y64/3AY1MFyTtahklb160xp4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772521006; c=relaxed/simple; bh=3OB7UB44JPaV6BYkpKzfld8Hs7QAfyG+nirRP2zcSzY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YjbbyFauA2phqm9QrWDBtaKQC5eKnTqLAatsyPck2eBVkx0O9OcyAub43+ugOZutKq54GhVko4tvxDftZMWEhUGqcE24KoSRa5qC+Q81esJ6ONlIC/uP30FeeD0MmHurAgMY1Uv6wqIRec0YMF+0xH0zVNPF8y5YY37OWo4SCfY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=SlRiOIVM; arc=fail smtp.client-ip=40.107.200.23 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="SlRiOIVM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=va9neVM1twkMlkh4acszJ7F6ZSvhQ5frZYVsleB04V/aGMJvL3t8aJgmRzc+fTTbDoUL/cH2QWvjOdpnkwHuKE0kQNNk1YmZh67mpK/yNtQF/qdQMHY7F/m28r7xe1p4nO4yNZPkh2QMNmt2pGFQVS7TaIGnHl2RZQOvBbS8myR+jFPmK5EeOe6W/bYClosPmAr0lK7PPhVEc2vDONcKk/sppNSoq9J7HFBflZ517VweAtFHy2gjqAj4NzoEtomiGXZMIbvZ8Y+S1dQEcQEVYTGOQPgVWSVzV3NWLZxgmpa+3+WQua4dazKGwdJFu31mwZT3qCYZiQmhCGGfSoYjFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c8YBOj0tLHn0ILffjS80mzSaWoughxh1QP/DIPl2dvY=; b=OyB7w3Z2zQbbl7KOdm08IiC12AOIggAYWz6CN7r1hj457e4y/rMLV+0Nw7n02UOzmKEJp7cQBROB/zNsMQrKezncRTwTIKzFczYXlcdpOO8rRWUm8knuC8H7+dRRemciTLnZCd/YEqToc2tHcIiGNQK8a3n+qdWx8Ubz5nPMjq7G3MVc2LlnevktT+3bV13GPAdVFZ+WsRIOjyBS+jMvzLkrR8YMUvqx3d5SSEkHxAULUw1ppzIcww1mtv3rGDAL3+8TJpVTMJPGOMGyCnkbPPfkmm5qf3+IslKEAAC3kaqBY5kok++tqsmJa+xthVFc3Xo8QvRZZd/xBbs6TfgBmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c8YBOj0tLHn0ILffjS80mzSaWoughxh1QP/DIPl2dvY=; b=SlRiOIVMO0hMKzstePxg1dS8VzPL+3XwTQH2ehMxcvwvCAAalaBthDGXMUt4rwtqWstYkND/FVCjJO0UIFkVuvP7J2WuzCj14aXTC651gKj1UumtxQKsNbWnA65ojUN2BlPH/QW9f7C4PWFlQ7P16bTnyZY271c+xb49sOZ5kG495uSYTXZzlvoaXpUnSvbXdV7Dg0zS2QYcjTEc1vB8JvQtmq2K6ytifKTtQod9fsQJJgyLZt3b1E/nWYYH60hBRpHlqsEyJ8k3guJcbdg3tu7vIgFksX8NugWCq/HKjO3Chfycz2Ln5h9LMBn909xQxBHsuCG01AJBSx/7ocUZuw== Received: from BL1P223CA0036.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:5b6::18) by IA1PR12MB7663.namprd12.prod.outlook.com (2603:10b6:208:424::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Tue, 3 Mar 2026 06:56:41 +0000 Received: from BL6PEPF0001AB52.namprd02.prod.outlook.com (2603:10b6:208:5b6:cafe::4) by BL1P223CA0036.outlook.office365.com (2603:10b6:208:5b6::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.22 via Frontend Transport; Tue, 3 Mar 2026 06:56:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL6PEPF0001AB52.mail.protection.outlook.com (10.167.241.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.16 via Frontend Transport; Tue, 3 Mar 2026 06:56:40 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:56:25 -0800 Received: from mmaddireddy-ubuntu.nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:56:18 -0800 From: Manikanta Maddireddy To: , , , , , , , , , , , , , , , , , , <18255117159@163.com> CC: , , , Manikanta Maddireddy Subject: [PATCH v7 10/13] PCI: tegra194: Free up EP resources during remove() Date: Tue, 3 Mar 2026 12:24:45 +0530 Message-ID: <20260303065448.2361488-11-mmaddireddy@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260303065448.2361488-1-mmaddireddy@nvidia.com> References: <20260303065448.2361488-1-mmaddireddy@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB52:EE_|IA1PR12MB7663:EE_ X-MS-Office365-Filtering-Correlation-Id: afdfcbd6-bbb3-4778-c958-08de78f205fd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|82310400026|36860700013|921020; X-Microsoft-Antispam-Message-Info: 7ATGtmlN4Nej6ghIFiqtkGqw7/4CkDuLKUVCJ/GvXnUYhAkOzUirUHNcYfeDTe7zqrdTQC3L6+vr6YGxlYzHMfpBvRmDyHEwDu7pPPI/8Rm4v0Sh8rl4HrX3XGFyZq/aBBpfiqIz/rMeElZZZw/mxl4zJtgA5XECHS8I8fBTJyOXFcEIqpSsuulhE3eeuru6VOvFCyOD9b1HqM3KmyJEzbPEoIybHEMeLvlOnt4wltcPnw0ZohH9p04gdEm1N285R6h0lSr8Mw7d9IZE6A98aCUFkX/vqTExr92wAp7jlAxSe8yO2YdREACJGyoUIZ52nO7SD9kgUIDVpHL0JapQ8tct3m0tbKsW2HDmUWUCpoyNu35bsBL8Y7ZiyeVKj4kHrFnEitSFbSr76bM6cqKzOfni188Cmq6HiIrZskby8CDTONcPCWupYqrmRG5bwhMAyDpiJ3Ud4m6vXqI9mayGfr6IoO2LEkOUuoJOqzRnnAgLWwJmXU4h4aOXo+vODdDEYl+wpcbPVhDoc7tWcecvPDrSHHaFBe6BJCG0iPUQKDYx0LLiFiiPYFKlqfyrWYNyJBM9lDIYlISCGxKSnJpXGRfD1ZO7rEcmemjP2fIYoKJjInzjRzbMYrFjgQA4tEj6iwGgBJPPo9iMg/M7fGaFOpBmtpTuau2sfGhe+obQwwMf769xPPiZ72DLi8gdqbNmUvfZp0bsC1xa2skrjDsD/boK0x5WBbyqG2S/IITYeVMargTkvyGWe9MEnr42Hhk1MAyNzMKiqD2p1IGPnkleSIDKDvpna5EylAkTBWy0/5YaTM2UPhHKSkHQZhXc8v+V+vSVuhC9eqUJFmCclwHufQJcUGs0ry1QjnmNEW2OWMc= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(82310400026)(36860700013)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Z63SR4YoWzQpzNLybrEu8qmP+EUAtmgwrSmdKGb4NssboBwYU/qkwPYeLZksMwp22k5UIBL1RIZYmyaTBpAxg2E/34p4zGl79TEJJCPBHchf5O/b9tI6YwrRklEtLjnwcaJ2uFVtFEzQT2BsKTEbIpwPJ3GD9N90MoTn9koG5wW9iYy3FiBZBNe2Y4VBFjSZ6Dp0ixKgrbMGeo3nFLgrgWv/gxhnbKZyp9LYL4FqAV99FvzDyt+EYxwoTqdHdO8exVw8yeqbsDFxTetWM1asjQcYkuUTmUuhKL0Uv8zfX+u+AYcVrf75M+GLOr2xxSvE6Jfvv7UQZtgMceky2fh6lzve++mmFFvySq7/S3BzdmMRrhxA1de4k3Kn1LDH0G8vWPVQvmvmW67uFL59xBnm0A9/AyO1N4EjXsEBLPdh1zlsBlR/HM8gavASTPX0Z24E X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2026 06:56:40.8891 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: afdfcbd6-bbb3-4778-c958-08de78f205fd X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB52.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7663 Content-Type: text/plain; charset="utf-8" From: Vidya Sagar Free up the resources during remove() that were acquired by the DesignWare driver for the Endpoint mode during probe(). Fixes: bb617cbd8151 ("PCI: tegra194: Clean up the exit path for Endpoint mo= de") Reviewed-by: Jon Hunter Tested-by: Jon Hunter Signed-off-by: Vidya Sagar Signed-off-by: Manikanta Maddireddy --- Changes V1 -> V7: None drivers/pci/controller/dwc/pcie-tegra194.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/contr= oller/dwc/pcie-tegra194.c index b2794be35cfe..1963165967b9 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -2248,6 +2248,7 @@ static int tegra_pcie_dw_probe(struct platform_device= *pdev) static void tegra_pcie_dw_remove(struct platform_device *pdev) { struct tegra_pcie_dw *pcie =3D platform_get_drvdata(pdev); + struct dw_pcie_ep *ep =3D &pcie->pci.ep; =20 if (pcie->of_data->mode =3D=3D DW_PCIE_RC_TYPE) { if (!pcie->link_state) @@ -2259,6 +2260,7 @@ static void tegra_pcie_dw_remove(struct platform_devi= ce *pdev) } else { disable_irq(pcie->pex_rst_irq); pex_ep_event_pex_rst_assert(pcie); + dw_pcie_ep_deinit(ep); } =20 pm_runtime_disable(pcie->dev); --=20 2.34.1 From nobody Thu Apr 16 03:43:57 2026 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013001.outbound.protection.outlook.com [40.93.201.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CDFD32D0DE; Tue, 3 Mar 2026 06:56:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772521014; cv=fail; b=PSfRAx2psa2TYHLf0GtwqSw7LUmT4wdLHy5QMjA+EnRdKpEfKdXk6Q3aAUknqXosAHVHm2Gon+DzsI5/OePixTjRkWDzjyAF0IRcq2KppuPE5DH/uu3ppysggwtnJ3gVKpNVQ5Dytj61WqyXSZ2krVk82d/KpsS+UU3TR51pUaw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772521014; c=relaxed/simple; bh=6w8pQ0aaxgTRBkysZ47o+/hfLTFyK2fv8l4b6BD5VKU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LfNoNl9yuJuqDUrDqSSscFdxz24TRPi6xkjSzz23xyowESgSW4zc9xMfRzJ/+ZQoOzpF+aF0V8m0nBkVW8Jqq7fSWAjLlyTYatbzMN/Sm23eKvhTG/VW2BK+jH+leJf10zmMuMx9yU8F1UK0z26GBjCeUIVQqw+5eqM3fDqScCg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=X8gLw3zk; arc=fail smtp.client-ip=40.93.201.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="X8gLw3zk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bxgegaYjNvymoszcCj030nKzimDew5bEopYZpjFv4wAgtuZdb88byX9rp3984Qw5TGd3gjMRDQhEQKYwQblaIDmFWsTB5MRC/IcU5ZPtRnGPl1Y3gcKfRQWWaPhrgTLSnkCVmgqKHPa4n50AF2miv+4S579x0bxlHogt3ABzsu0JItouL8DXkHxJySOeuSQNKnsNRSxg98M3oGhZg633wC8441fGe765FmbdzUFUblOkQMYYWhFjruoYVLsovzMIIDrBL8M2YZdnw8xYLFPGXTj6nmq3h0Ud86b5FBVtI8maWxWmMHzh0jli24LpqpZr+4m5ifFsmc9bgi1HwzD8uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ey3sIHcsYWGZTQEte0ZFjgncU3sKNgkiBB31h8W89PE=; b=mk4fBAvlOslOy4NqKai2I5dzmI+2BlXbmZxhIQhYO3jKwrF9kZAc7IIeb8lealqrhTRE0C60t45B6zzD9FYTA1ALenXSAlrNZYBiXRtTVKOIQwtphUbjkPFMX6NwQrQkqKvkCuCvP9ISfFECeuPNVyyAfVrFpJ+DOkDH3cjDYaK7vOE50ZrKaAYxQM0TbBGgsGy2ecCEohY2Md+edQFN5U9QB5SudtMqU9ICOzz0ifH3F52ZBHSynULIsIfaUMPOAVoa+TmJklVuQSVW7hrTx2deHE2SUob5KPevp0KBjsq/vX1FtkN5+EQIGAa38gkj/VB01HatG+2xd/s0jo9WZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ey3sIHcsYWGZTQEte0ZFjgncU3sKNgkiBB31h8W89PE=; b=X8gLw3zkkev0oiEpLnQ6+VEPvIru34XxgY+/mk7LNWX2mxmKQkFb9y3rMHsnkVvofvw1VOj/bZ1TxSlc9w7aEx28i9/QmqPNYVaKuUqW7XM7sgRRVTEdlJqKFBEcvWI+HbO6glbTPKXz2Ee5PdOsyAXn0qB3lM17HuT4YNqc6gZRktmDg+hZY0XSMPcq2u4my2mAf0T4r0hf2y82v3LfTvRncCQPNugz2E9RbRC2M1Dyf1xyRGkKfsGINlSEo4U7OKTwVwq2QtdJU1CMuxv0ZRM9z0w4GRGulmHd/VlbA4O1RkgJgpPjZ10zIn7wd3dJK2dV9n/GGaMUUP0JkAoHxg== Received: from BL1P223CA0028.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:2c4::33) by DS0PR12MB7655.namprd12.prod.outlook.com (2603:10b6:8:11e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.21; Tue, 3 Mar 2026 06:56:47 +0000 Received: from BL6PEPF0001AB58.namprd02.prod.outlook.com (2603:10b6:208:2c4:cafe::62) by BL1P223CA0028.outlook.office365.com (2603:10b6:208:2c4::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.20 via Frontend Transport; Tue, 3 Mar 2026 06:56:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL6PEPF0001AB58.mail.protection.outlook.com (10.167.241.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.16 via Frontend Transport; Tue, 3 Mar 2026 06:56:46 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:56:32 -0800 Received: from mmaddireddy-ubuntu.nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:56:25 -0800 From: Manikanta Maddireddy To: , , , , , , , , , , , , , , , , , , <18255117159@163.com> CC: , , , Manikanta Maddireddy Subject: [PATCH v7 11/13] PCI: tegra194: Use HW version number Date: Tue, 3 Mar 2026 12:24:46 +0530 Message-ID: <20260303065448.2361488-12-mmaddireddy@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260303065448.2361488-1-mmaddireddy@nvidia.com> References: <20260303065448.2361488-1-mmaddireddy@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB58:EE_|DS0PR12MB7655:EE_ X-MS-Office365-Filtering-Correlation-Id: fec3c2f4-09ef-466a-0e92-08de78f20978 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|36860700013|376014|7416014|921020; X-Microsoft-Antispam-Message-Info: UZyU8dRuOvf8ezQTzwmQZpjJ++gDVSY0dFKPxpHr4a2mY1e/kKpHco5S8rrq112KNEsgpjJxJgmKFndTVxiXTdRmJMznfFt7Qj4xaX6NbHAN/WsXC0Jw6uSsmkpwa5E2qOjPrlEMTtTeFcorS8kOtKwDo06lTj1swlLm+gltxLi8UUb87jMreb2C+xrKL7/e3a5mOM7cRrOnW+AKlgeMCWzxuzGpzCeGXdz4OPXm6NrxTfXOAOuJ/Qonl6vgA0PseWrcBsH75FMvMn5QKtjgcC7Hef6Lu6RT4NvCAUdxk/f5+tXAW5G747FCxZ7rt4KFK3tGqjODyo9OOYDanoOi8AYhqtZTeSZxWgQ+JL/gtZ/Fi/ZgAXeGs36euQ7wYKDNGPN+Q7j8z7Uwse3LmA6917jtBTUaSS0BhKr/2awAyITLpJ+QD4hr689kr3NgO7nhuKnvTdrsIKbKJgHml+Ra5WSjt69KLS+8zPobolgwsE4ewE40TXRIglWACHv+t/2PZRqbU0gL9jaasgwE6KhGvrXuInoYNYmROgepX0rz0toIQJLYiv8kdzl89iA21eUAyJiIaYqHSszQk+DQngfLTUtGL/I4rmLYtkAYgg5RZvgjppnelIXiddkx2W6P80LXAzOmP9N4COJuytKM0eFIHR/oNnEGa38erXgFx8tVPFaqbUJs/q3sLprv4Fwv0fIGEY8kdtDBg+tTcJXO+BPChYbjnzTwzcjwSYdIVXpleGgMkiSwCceuOP2SoBmOGeeAdzGLWIcMhAHuGi7r31qtknC9Jb2RrkT7D/OMSZ7MIPbJEsISK5ZaTSzeouA/x2x6AgCCQtQadYexT6ty3LHBkW7sISblO7gn4EsLlw+Xs2s= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(36860700013)(376014)(7416014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: KB03tdzl2Z6rbJLO8NwQWHOdDzoi+CXesYFmfCSlLHlGbp2EWX/nbw/L3E0ccuyTR0F9PzGEJVa3Ztk/BNsTmgvg/6iidzN0ALeodEqcqaKQ4l1vpilkizEJ6FblKbzunwn8iNCmBgjKWxbTh050xP85BTWZGAV1DuujnbZFN/TA59aSsoSdVWT7bExvyJ/tKolsbMDu5mz/OSSTATYk+Lbhx9ZpN7D3/LfxyamsJThokLptLFVuwIWvoUI4eR0058aVHQpoc/uvxAJDdoO4nocIWfuxVcqQxocrM8+fTutp7uuliy27Sd+B+NYKGG9TkhuZx063Pb7FL18iPHdtr9hTcf21WoswZY67LDTFn6TzLE0naplQ1dGH0v/2IDHJo2Xby/nKYNboyHp+mxJW9736YOUk27UIy17nHtxmXxXkVAJHvtebDPsA6cLqB7fo X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2026 06:56:46.7434 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fec3c2f4-09ef-466a-0e92-08de78f20978 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB58.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7655 Content-Type: text/plain; charset="utf-8" Tegra194 PCIe driver uses custom version number to detect Tegra194 and Tegra234 IPs. With version detect logic added, version check results in mismatch warnings. Use HW version numbers in Tegra194 driver to avoid this kernel warnings. Fixed version check to enable ecrc for Tegra194. Existing 490A check is left intact in case any HW relying on existing check. Fixes: a54e19073718 ("PCI: tegra194: Add Tegra234 PCIe support") Reviewed-by: Jon Hunter Tested-by: Jon Hunter Reviewed-by: Vidya Sagar Signed-off-by: Manikanta Maddireddy --- Changes V1 -> V7: None drivers/pci/controller/dwc/pcie-designware.c | 2 +- drivers/pci/controller/dwc/pcie-designware.h | 2 ++ drivers/pci/controller/dwc/pcie-tegra194.c | 4 ++-- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/con= troller/dwc/pcie-designware.c index 345365ea97c7..0dac5d2f5a83 100644 --- a/drivers/pci/controller/dwc/pcie-designware.c +++ b/drivers/pci/controller/dwc/pcie-designware.c @@ -559,7 +559,7 @@ int dw_pcie_prog_outbound_atu(struct dw_pcie *pci, if (upper_32_bits(limit_addr) > upper_32_bits(parent_bus_addr) && dw_pcie_ver_is_ge(pci, 460A)) val |=3D PCIE_ATU_INCREASE_REGION_SIZE; - if (dw_pcie_ver_is(pci, 490A)) + if (dw_pcie_ver_is(pci, 490A) || dw_pcie_ver_is(pci, 500A)) val =3D dw_pcie_enable_ecrc(val); dw_pcie_writel_atu_ob(pci, atu->index, PCIE_ATU_REGION_CTRL1, val); =20 diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/con= troller/dwc/pcie-designware.h index f4cf1602cc99..5bceadbd2c9f 100644 --- a/drivers/pci/controller/dwc/pcie-designware.h +++ b/drivers/pci/controller/dwc/pcie-designware.h @@ -34,8 +34,10 @@ #define DW_PCIE_VER_470A 0x3437302a #define DW_PCIE_VER_480A 0x3438302a #define DW_PCIE_VER_490A 0x3439302a +#define DW_PCIE_VER_500A 0x3530302a #define DW_PCIE_VER_520A 0x3532302a #define DW_PCIE_VER_540A 0x3534302a +#define DW_PCIE_VER_562A 0x3536322a =20 #define __dw_pcie_ver_cmp(_pci, _ver, _op) \ ((_pci)->version _op DW_PCIE_VER_ ## _ver) diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/contr= oller/dwc/pcie-tegra194.c index 1963165967b9..1c6543341fb9 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -35,8 +35,8 @@ #include #include "../../pci.h" =20 -#define TEGRA194_DWC_IP_VER 0x490A -#define TEGRA234_DWC_IP_VER 0x562A +#define TEGRA194_DWC_IP_VER DW_PCIE_VER_500A +#define TEGRA234_DWC_IP_VER DW_PCIE_VER_562A =20 #define APPL_PINMUX 0x0 #define APPL_PINMUX_PEX_RST BIT(0) --=20 2.34.1 From nobody Thu Apr 16 03:43:57 2026 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010024.outbound.protection.outlook.com [52.101.201.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B530D3859D4; Tue, 3 Mar 2026 06:56:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.24 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772521021; cv=fail; b=e83vMYVXqe/Id18XmRFlH2YW4gsAfZXEJjHvMZAwrWjHmsb8fflxcHz3sHPFPyeSwANpiKikfFoBk2ZM/hyAzf6nRt/72WWLwRrQI2QCDutcr12J0yX8damSlzrtqXYPjB7oevrAIxfanqS7GhRT/UPK4mwLXLuXpXLtuDmlCgo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772521021; c=relaxed/simple; bh=/BSRqoNw1ia8khKe0L7l0QhPSezijHsxWvM0mNZS6VI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SDRVOztbRPotQCI9pWHeukBVc0wW1KzYF3Xrq9g30tc0V//0QCyY4Y4QT8Q0b+YCAgGjbfITyfL6KHy4rBVDFXFq5x4GT/otpKvbvU1WrrpezmOaLrDx/zTHXDP6UUgAh891H42AdutmmArwIVrpfwY74qevEYTQlMTUOclzrBQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=HdDLBDfb; arc=fail smtp.client-ip=52.101.201.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="HdDLBDfb" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wGxExcBSPW77CdD9ySit9ltOyfAgU3NMePk4XCIR0+LZFLWLrDJvx2ejYrcyQnuTUKiu5ZtIVYr0JYJiXTufKTdjCKe12Jmw1gg8sxIBPBNILLbTnHCw45FGOk1FtlYq3qfZAjXNswI3M8d6tryMhhzgn6p5bY61rQc3InUO+OzYg9j8VMH4om+SbneLSgNjhjHBMsWs+tBpjGqeVSSQlXUwN31UELjl6FTnVchUmH3KZjbS/X8UTP7rj6/hwaAuuhnLQBW1rjWq5ZBj+Uzu77SsmvePu65uOH9IDC4xaCWZYlSlVcVSLQbmzzVHjun1+8iJyFp6QwBgzsu0huJqGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+YBaEZABFmaZ/Ip0SrvRvRXI/uqXp84yhbD9C1xeGoQ=; b=JnyqgUwKVGwIIOzaBqp/9U8H8KCLnjp3UNLTTRZf0iMilpKgcaVUIOyn5ONzeGN5YT2+zhC0rKsbCEfW/KIf/O8cwZjcHk/c9bp/sUb9SnpoTyn1kxy1JDJ7ZIcB+Pzl0F+UHLenMBUo+D1Du5N998bKdfqaNfAhfo/khCf7q8ggJQ1f/KhHReMsNJ2g3PWahSukCCh6RLGFx/N4Wx0POblo8WMQj3G8oes3rep2qBBwuBmfg/N5ONWb22e4E/fjq+1bWdeO4eHOAqXG8XK9ErW77wZVyBa6OykYnhI2WHtZv7m5D4eFSKY5KazhDUPVtxQn/UioyoGCDsdJ+oFhTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+YBaEZABFmaZ/Ip0SrvRvRXI/uqXp84yhbD9C1xeGoQ=; b=HdDLBDfby9acmV4td2Epz0RUZCvdcoqOQtKfff5UjiyexBR6JXcFQxLo/9rgPefWR39Wx3LpsGo1B+NIEy566DQkXYa8pK2yA7FKpenKoyla6cqSpaBjSS67EB4NQ9mhwAjkOC17EjbOUbt03WjMTTpRYV49pdNo+gmKYdv96w4qs0UbTW9sjezk3LpUm9WPK476SE1PgczB4TcAIWdZ8ep9ivN5+qXI99b5NtdkbBQV+vTmJy5m6vXHT77PV1vERoH/1YtoSe0wD3Q9aHZvCwYHVs86eVwiWwizPmqg03redN3NkozmZulYK6InK0cKTfRoz9MKaEPEFWCWBFx1tg== Received: from MN2PR01CA0046.prod.exchangelabs.com (2603:10b6:208:23f::15) by DS7PR12MB6024.namprd12.prod.outlook.com (2603:10b6:8:84::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Tue, 3 Mar 2026 06:56:53 +0000 Received: from BL6PEPF0001AB57.namprd02.prod.outlook.com (2603:10b6:208:23f:cafe::f4) by MN2PR01CA0046.outlook.office365.com (2603:10b6:208:23f::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.21 via Frontend Transport; Tue, 3 Mar 2026 06:56:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL6PEPF0001AB57.mail.protection.outlook.com (10.167.241.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.16 via Frontend Transport; Tue, 3 Mar 2026 06:56:53 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:56:39 -0800 Received: from mmaddireddy-ubuntu.nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:56:32 -0800 From: Manikanta Maddireddy To: , , , , , , , , , , , , , , , , , , <18255117159@163.com> CC: , , , Manikanta Maddireddy Subject: [PATCH v7 12/13] PCI: tegra194: Fix CBB timeout caused by DBI access before core power-on Date: Tue, 3 Mar 2026 12:24:47 +0530 Message-ID: <20260303065448.2361488-13-mmaddireddy@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260303065448.2361488-1-mmaddireddy@nvidia.com> References: <20260303065448.2361488-1-mmaddireddy@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB57:EE_|DS7PR12MB6024:EE_ X-MS-Office365-Filtering-Correlation-Id: 3f7d1b77-5e9a-48b0-d472-08de78f20d45 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|82310400026|376014|7416014|921020; X-Microsoft-Antispam-Message-Info: IeDb+8vc/abQGuZ1WuTiCVAidsDKDqmnOPhZvYF1Y9+O911inbZIDkVmKnsYZoI21Yc41s9Achwru/YcCfzz8AZrHB7m54obseUZrnRuojlXM8ZE1xj26UkP4TFS9/jIP4LZom+k9gaX3iWD6aqcLFkyllMbUvFnNoVizT5C/mc5pMPxrIj1XEFymge7SwedA9jTDsVFlwOO4wjtLCdaaoYCRx40I3gWGsd3hN2XVgjS3rcd066zeufjY2sYy/WKsmHNVUYOvII4oj/Lg26FgIDXc+MsoHl43aTrHhAw4iPCXaP2zYpU4W95+KUMA0C8KxJc73CcPDsRa6vV+XiQypnvdjs7i6UiI/hs/ECsRh6tYc9zEZpo1qqtPHHFzacnQgUYxcUhz14awaDERFJkmCw5Or5lXQ6ou0Tu8ng0ZTEC66NO3qv8HDA4HwDap1tcpD8K21XCAufl7c3ydpF4Q2o7JHyWllU+k8GQ1EdKwcL6xVYRZQ/WFRKyMwmwDfAE+NZXFh/lmDIihar7BpZxMqmiWOqsq+inhRQeZ9JsIBnwNhpKANT3H80/jA+hhgXD7ddFsIdbvQlSaABmpVaHU/YqWpc5bz/co8GS1srXaZbbmJ3DNG2Vw/iET2ttYAhDcH0EPVORWl9PpKkJrH48GLXs7nuGQAOguqLeDEq+zPvRghJh7/lynfEw6ibAdxxzDE3S9mQdLJyWzxiIL/80OjKRyakT4x+Xg/ciJtcPHn96btEB8Ml6UibQb9q9hiahTG1Q/WctBOp+Kaxv1N56fnZZvwSA4oIXx7nLjhPe3rwIYE0EdSjxmWd9hgaUnzJGb1A+u0kPKRjAQkcYB47g2/rMPGc//RqKJhG/GGHpVC0= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014)(7416014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: VF0iROJF0FhOSbfzrpuALU3snGtdqv+rYDpfvW9+s0VX/TCbR5aqHdh/Fpx9sYCaaaf/1Riqv9lrJG/mEBDAPhXb4/+E0CmknrOIS8kc1qsXzsLcMTMqU3MEA5NaOVBvRexg5gFDoEq5l3tPgwctPVJvWB9xbTzaJ0U2PEk0/CSqgNI+GV5s/5xzr3bXxI7EY8DUhXNd/HSfmnnQAvpRqfcFXAgtW2iixBR3XR26L8WJI9rDV2QbzEb3hLtVsCFW+p+y6q3lKsELLesuagvYmleSN0a9UyDKAqrxdnovhpvGSe2o2UnE+Hl+85RLmsK+BNmAvDUYgN5+zbW27fLu53qcRjZla6WBT8hvFLyd0HJ8TF4yvyhSL3M2/ZVL3/OuzwGQMo8IvXAIuRlzfks3ModOu2NqCQpv2axApV4hGnSYbiHzZ723IIV1VstmzXvM X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2026 06:56:53.0866 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3f7d1b77-5e9a-48b0-d472-08de78f20d45 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB57.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6024 Content-Type: text/plain; charset="utf-8" When PERST# is deasserted twice (assert -> deassert -> assert -> deassert), a CBB (Control Backbone) timeout occurs at DBI register offset 0x8bc (PCIE_MISC_CONTROL_1_OFF). This happens because pci_epc_deinit_notify() and dw_pcie_ep_cleanup() are called before reset_control_deassert() powers on the controller core. The call chain that causes the timeout: pex_ep_event_pex_rst_deassert() pci_epc_deinit_notify() pci_epf_test_epc_deinit() pci_epf_test_clear_bar() pci_epc_clear_bar() dw_pcie_ep_clear_bar() __dw_pcie_ep_reset_bar() dw_pcie_dbi_ro_wr_en() <- Accesses 0x8bc DBI register reset_control_deassert(pcie->core_rst) <- Core powered on HERE The DBI registers, including PCIE_MISC_CONTROL_1_OFF (0x8bc), are only accessible after the controller core is powered on via reset_control_deassert(pcie->core_rst). Accessing them before this point results in a CBB timeout because the hardware is not yet operational. Fix this by moving pci_epc_deinit_notify() and dw_pcie_ep_cleanup() to after reset_control_deassert(pcie->core_rst), ensuring the controller is fully powered on before any DBI register accesses occur. Fixes: 40e2125381dc ("PCI: tegra194: Move controller cleanups to pex_ep_eve= nt_pex_rst_deassert()") Reviewed-by: Jon Hunter Tested-by: Jon Hunter Reviewed-by: Vidya Sagar Signed-off-by: Manikanta Maddireddy --- Changes V1 -> V7: None drivers/pci/controller/dwc/pcie-tegra194.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/contr= oller/dwc/pcie-tegra194.c index 1c6543341fb9..a311c31109e3 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -1726,10 +1726,6 @@ static void pex_ep_event_pex_rst_deassert(struct teg= ra_pcie_dw *pcie) goto fail_phy; } =20 - /* Perform cleanup that requires refclk */ - pci_epc_deinit_notify(pcie->pci.ep.epc); - dw_pcie_ep_cleanup(&pcie->pci.ep); - /* Clear any stale interrupt statuses */ appl_writel(pcie, 0xFFFFFFFF, APPL_INTR_STATUS_L0); appl_writel(pcie, 0xFFFFFFFF, APPL_INTR_STATUS_L1_0_0); @@ -1799,6 +1795,10 @@ static void pex_ep_event_pex_rst_deassert(struct teg= ra_pcie_dw *pcie) =20 reset_control_deassert(pcie->core_rst); =20 + /* Perform cleanup that requires refclk and core reset deasserted */ + pci_epc_deinit_notify(pcie->pci.ep.epc); + dw_pcie_ep_cleanup(&pcie->pci.ep); + val =3D dw_pcie_readl_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL); val &=3D ~PORT_LOGIC_SPEED_CHANGE; dw_pcie_writel_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL, val); --=20 2.34.1 From nobody Thu Apr 16 03:43:57 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012039.outbound.protection.outlook.com [52.101.43.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECF223859D4; Tue, 3 Mar 2026 06:57:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.39 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772521026; cv=fail; b=tZfT+SHKE+J4yXSqDSzJ8XN3zjcxAp/dglaMGvieRG1gTAIWTLxAfjvbengcq8ir9JdPQgmKGWZZ/BSG33GbLRdV8UsHpIsNlY05VDnd3V7zJlprnb/Zk56IJEAiyp9yjC0QtpzIo9wp6clpXytfBSTkGiFUUkEsip51uTV/iiM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772521026; c=relaxed/simple; bh=2LN0OsQOovY0iGTPQ5gbZXb/G0MrPrDt5ATSHV4e4Cg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IK1oAbjeEfv8xay/okoDly/vja01aEzB5gl51EfrYK5C67bbKMP+kRt/TGgQYjgtwL/LwybL1UqGjUoIa70zGcMYRgbgAIAhsTB93lUufPvIT4YgzNE72uyohoyELnzdbU8VUzJfJM4gNeE7dFDc4BE4gXHx6Rbzo3wuXgqN/hg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=XVr8uQio; arc=fail smtp.client-ip=52.101.43.39 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="XVr8uQio" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hp5QilTolyFky2UeY0EIS875SUGa9mceNEcTM9INMDCuH11DTY+p3Epy547P3JcO7RdQRK9mFbseWGPxAdsydfD34gyCE6SIVCuEobDWxSfBN8dcHAAmtGyakPhSdNOMz+TPhQbqY8JWztheKHkvDpYZtm/J+G+FPZ/KL+PvPdsW+fzPs4EhEmUIUyl5GJciDa+s00KHBlASXwg0/tFjURXy0rCbTPhMPqUBaL0qB1/X0VadgkytoVbLMZeuxCkcBbOuDz2hBiSJi7ghq29uMyw+5+p7207IOdER+u/um2Naj9WdSnqKop/W2ucWApR4vStZHUpqNHBoC/qeD1rCXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bYFCrfIEaXfKJvIgaTn/ie6Nf/ZG+VsRXY+9lGL7Igo=; b=E1fCS38+j1KFff9YzQoLJ6pKj4hEMury7cdOWKEXOeTrl7abjFptKE1QPbW0jgTp21ffvtkGub/1X+9VRqqW0I7yMiUmuyd43zhaupSwX1DwsTKm2lb7wMMsXj/AwQDVyDttLeonP2fP7+xnH0ITH5PieUduQq3mz0eiTMrJmDk1UdMvIQSTIEQuzZK56qOV3mt2FoOu3vE7MblyIL51jdQaVkyrk6hPxhJ8wZ+qf0XL7tU14dwr5po01JD1xLcRNHii8ckusyhLRlTjpkdHPuqTXFAiKTbZDRXrnYUCLAhk+X8tmAGNM7cVNZyj1zBa4SgIAHFT+aWQDO7B325iHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bYFCrfIEaXfKJvIgaTn/ie6Nf/ZG+VsRXY+9lGL7Igo=; b=XVr8uQio/OkilFNuz1iKC1T51ZdTNP0U2O9BaX9Bj6TBeCQrlh9/OyiCBXrTr5F+5vudgXN2WSYj+cPfj5A8keENnNZPsj2AiNkAvlNwmTKrYDHtWMcYnPjU753+N/gjQfTj+g4rGir7jZWm8bB8SOsHVAgAmaeR7ka8Az7Mxcd72cWxgmvZ/j/IXSPQr99MF1oJ4NIyhWO2JftBP2FT8mIa5eFQc0zfBNExOPzLOmmIrtCtkjY4hOfmFJ+D9Xtx87cqbjppY3w8RS+1juWM4cOprN14VNw8UXW1w1yTvrQFYzQ0BYznl97A4EPW8A728miIBMouleLU8Cl+/oA1fw== Received: from BN9PR03CA0393.namprd03.prod.outlook.com (2603:10b6:408:111::8) by SN7PR12MB6692.namprd12.prod.outlook.com (2603:10b6:806:270::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.14; Tue, 3 Mar 2026 06:56:59 +0000 Received: from BN2PEPF00004FBF.namprd04.prod.outlook.com (2603:10b6:408:111:cafe::2a) by BN9PR03CA0393.outlook.office365.com (2603:10b6:408:111::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.20 via Frontend Transport; Tue, 3 Mar 2026 06:56:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN2PEPF00004FBF.mail.protection.outlook.com (10.167.243.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.16 via Frontend Transport; Tue, 3 Mar 2026 06:56:59 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:56:46 -0800 Received: from mmaddireddy-ubuntu.nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 2 Mar 2026 22:56:39 -0800 From: Manikanta Maddireddy To: , , , , , , , , , , , , , , , , , , <18255117159@163.com> CC: , , , Manikanta Maddireddy Subject: [PATCH v7 13/13] PCI: tegra194: Free resources during controller deinitialization Date: Tue, 3 Mar 2026 12:24:48 +0530 Message-ID: <20260303065448.2361488-14-mmaddireddy@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260303065448.2361488-1-mmaddireddy@nvidia.com> References: <20260303065448.2361488-1-mmaddireddy@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF00004FBF:EE_|SN7PR12MB6692:EE_ X-MS-Office365-Filtering-Correlation-Id: 8db696cd-464c-4477-5b80-08de78f210d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|82310400026|36860700013|921020; X-Microsoft-Antispam-Message-Info: BxIRFB4ucn+KkeT66+TIbFAdEQSLa2jcIJKXD8g3hme3RStLfy7vZ7TtP2dP0oAb5JH7QH5lU8BvFE36XX9GhU+FRrKL04cKqxDKfpFUgD6vrlRiRxi4tQto8RfIpKwyLACH4YJ1fTpXyey5g6ZhUWzYwFFlUo6ct0HqHg4D3LjOYWSAwTRZ/6NXzN3aLgBpNj99vexThMiGK2z+MyQI0TEHuybe9XpECSU+SjvHJb32LzOqHS7VbexL1IzAzI9wKhGWy945ITJCgb4TsYLXEXXYdmKnhYIucio/CzRINErQk24o6sMT5TZeImFNIN8pSU/rSxT6OWLuLvSat3rHCFPxN1e8VKzrbtmsBk+IUvi+TkHYcScJHeIIyMfcXv2hwHInMhriqBFWR3ncU8SZbBbLHLUSl5nVidlGy3gZDJQPqaRE81NwlV9qS+L75qCO6sJQ+ZbApyIwaSfO04ZE5OhlhNzIg36UpNiSfLT0tRtKT/IfS/Ld7/iMaPLkW/0QxF0Pr+ljIO1rMGw2uMZnrarjUvE+JqDB4io503qv9GcDX8Rk4CF+wfVub30EFQ987C815bLFf1/XZ+3ZEYDkcZKimOAlOPGXmFEjafzYxh4+uMUYnJ6NDRphn4QT3YCZd+2oM0NfOA4uxp6eAsCdZDuU81WTAE66aTpwUDkl82+QUXG8P5OkMUD2UUmTztPUIsAHM9t2q4WW6vL7YGS1RoxvOluewcQPwUGFSfETl90BnLHaVcTlODtD0YWy4tJjI+PcuH6Ksu0RG6tEKGisD417I+Ag3FwS82XFyNjlaLzW1III3Py0mF+vLvfNq/q8Oiel/GfQ1AgXe719jNqwnAmjT83ox4c3g/6vrGezWzA= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(82310400026)(36860700013)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: s+HmuocoG2SVbBPEJLpBk6UoJzOL3rkbQI2TCmPns67+TgXI1jiSjrP8aNVgnafqPrXRgl+IsSw8nzaD9zJzPTCcpzhC3IKVAFr0KBm2Xf1cras9VIypiXjyWsIJInyKa4vXRgyDDCJwf3angMTXwuEHQuFG2frgPdCfh5bh88Ar6ewjB8XPboon5SX/IFa2QByxcTe30+N1CDecK4md4olQJ7lHLpyQlwtCKFMFrfyJWxyf3Q8sAPRbQtzykDSI/QvD8mHdxnMgjb4mi6T3SwAWa0FNykqFdAZvyk1yIDR2OhJJu3/eDqqgy92VvIxIeIyPPRpyJl+yabLtp4xu1HCa03jDk567r4gSSf1jNEwlxsdgn9O1ApoX2FIrch/dRtyA+SenfR3Z9sxrvaFUYbM4PoDkK9F90AdvqTaatvwA/vlFG+KPVWl5a7hIxw/N X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2026 06:56:59.0759 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8db696cd-464c-4477-5b80-08de78f210d1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF00004FBF.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6692 Content-Type: text/plain; charset="utf-8" From: Vidya Sagar Call pci_epc_deinit_notify() during controller deinitialization to free the resources allocated by Endpoint function driver. This is safe to call during PCIe assert sequence because we don't expect Endpoint function driver to touch hardware in deinit function. Fixes: 40e2125381dc ("PCI: tegra194: Move controller cleanups to pex_ep_eve= nt_pex_rst_deassert()") Reviewed-by: Jon Hunter Tested-by: Jon Hunter Signed-off-by: Vidya Sagar Signed-off-by: Manikanta Maddireddy --- Changes V5 -> V7: None Changes V4 -> V5: Remove pci_epc_deinit_notify() call from pex_ep_event_pex= _rst_deassert() Changes V1 -> V4: None drivers/pci/controller/dwc/pcie-tegra194.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/contr= oller/dwc/pcie-tegra194.c index a311c31109e3..b1ae46761915 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -1624,12 +1624,16 @@ static int tegra_pcie_config_rp(struct tegra_pcie_d= w *pcie) =20 static void pex_ep_event_pex_rst_assert(struct tegra_pcie_dw *pcie) { + struct dw_pcie *pci =3D &pcie->pci; + struct dw_pcie_ep *ep =3D &pci->ep; u32 val; int ret; =20 if (pcie->ep_state =3D=3D EP_STATE_DISABLED) return; =20 + pci_epc_deinit_notify(ep->epc); + ret =3D readl_poll_timeout(pcie->appl_base + APPL_DEBUG, val, ((val & APPL_DEBUG_LTSSM_STATE_MASK) =3D=3D LTSSM_STATE_DETECT_QUIET) || ((val & APPL_DEBUG_LTSSM_STATE_MASK) =3D=3D LTSSM_STATE_DETECT_ACT) || @@ -1796,7 +1800,6 @@ static void pex_ep_event_pex_rst_deassert(struct tegr= a_pcie_dw *pcie) reset_control_deassert(pcie->core_rst); =20 /* Perform cleanup that requires refclk and core reset deasserted */ - pci_epc_deinit_notify(pcie->pci.ep.epc); dw_pcie_ep_cleanup(&pcie->pci.ep); =20 val =3D dw_pcie_readl_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL); --=20 2.34.1