From nobody Thu Apr 9 14:56:44 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20CC1374E53 for ; Tue, 3 Mar 2026 03:55:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772510151; cv=none; b=tOL2Fqok+r3gFiQeQK5zFNte/wEnIXZNuLw3VcDFlDxqVskss/dRxmS3JeWW883nnSYcHX2MPQs1IrGp/gMkC1/3Oj64cGAKYHbBRN5zB9GevCPlI1jm9btRApt78Ao/WtmKzAlVDDxKDVw6oEec2uA2CuEhuyG88D4jB1SBiK0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772510151; c=relaxed/simple; bh=PeWITXGrlGcq5P+cy/UZDlrwa45k6ULiQ9Ocax7o+nQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fK2dUBohkPMziknC9ERWcuncud2KHJr14ryAPpoxunhBNK5S40qvZqNr2hL9vv3B5bw5b1OCnGFsuojxt4kLm+Qxneo4N1N1l6LEfF3u4LlKbQxbTYnvRJ4penOJLU7fVJZzWW0cBlKEcAoRYYg4a8aHo+TM71R+3xUd+Kd1icU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Jn1tcuFy; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jn1tcuFy" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2adff872068so26057645ad.1 for ; Mon, 02 Mar 2026 19:55:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772510149; x=1773114949; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YzNRJhWIi16/zzfaCP1ohKWTS+93+7FOMiA4THS2R7Y=; b=Jn1tcuFyHay4PGoYp+l6EXD5PbdV8y5lHXrJVhwEB+CK4iLDoR4yUgBQ70X4rPJcSo cysDiz4cX8hv89Acv88y0kLoFOYiMYlFpBDF745Tkn6Lz7fekZG0pg8j1M42YlomumIe 6CrVt5ylEza67491a/l/BwS6Fc/FsZsXL7YIYqCq3u0GKA4TA56/at835UQNIY8uqNXz V3vEXZ3kKIQgc5ylQPrRfWZ+X6DlyhDFU9vmkTRZ0MJujdDo5ScX0zFt1pZH4WB7j0dt bnDQRI/QPF5SbkvFn3AxhoVzEYz52P0y3nnuSqxAsyUkZiqtoDH/W62oHUssRBCEO/lw nSSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772510149; x=1773114949; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YzNRJhWIi16/zzfaCP1ohKWTS+93+7FOMiA4THS2R7Y=; b=lgjjGPbAAhwNZ583uz42NxAYmUrkacydi9J/a800ovhKHp1gxl3y+BnnBVM2EaW7nG cKjawxZkTjULLmw0FBjeSy9D9a4ZGt/AOJXgM4QmbHNbKnrAkCFWKQbqMPprHg+y0NFT X92L+6jEGocXFgKeucvgyaRnq3NWgpv5JvQWM7jnzqkJxNmVJhq0ns+/l3L5kRgMn4El K9VeUo2FrMmwizbFkNCPohUO4MzEtFN4g3u/AuHvK2zPkXam1wE01u0zlbvPCMEzBwWZ KZK2F6g6P8/M+4bqEsmcdFbbSLq1uaFbCzYW79QKbEENIgRcB5KvJnT8kbVmXpltwIp9 w7Rw== X-Forwarded-Encrypted: i=1; AJvYcCVxMNleUQNaQd9EyRy5a7Mbx5qUTUvxYS1oidCXkRgRlZPw7a72nwESH0/yToaL/C1uye77SCep1ijDSM8=@vger.kernel.org X-Gm-Message-State: AOJu0YwXzDDoFI799SWG1gjm4BRyWCyzUl4pVlaknS4VI4Er0W3d8bfl W3O8E82WshDkz17RBeSPGaN2jCDWb6I1DRTRBGEkcNZ7SxLAbt0XHz7g X-Gm-Gg: ATEYQzws3RA6u+4Nq6ppgPJAAiuqNMgFDzDXni0Iqifwx/WwRN3iCkoilUmGkzQXiIK AG3JWzhG+ytNveXkVGypSkdXW/+d4Tqy8C0mzeSC9yNL4wS5JuFg4OQqDBkHKVnCo9P4N8K4LKH nY0lnv2cjVXuPhVvQcd7mKPLgfC9OPaddoFwIm0byN5QXOXs2kL96IuHsSt2P1L+FzLaCgmG327 MxJBlXTSOOcYn8IJ5VLaWfwT/qhl6KkmYnew3mHnBsO8/1dM2tn6lIkEnP+ZhDefuroxPRjzegp 6T7nNqBx1my95KxJ396RESXVVRBjYFK9nDOHJBhO8Rxavo2kNnlIC8sSBIi8m9+sd6/Db5WLnWy ZLabmbLmU7/58HqDxzkeqKZ+tyqqquzUgNR6bF8ZWANzl9sB4ZDJeyyvYPfd3CpJs5rryvgx+Qt FVwS1/1uwIjZjhVAHbFWFC1Qdb6ccf51IOlQUfyroQpx/Jg2aLnvXG0Bp/A2pIFiQ58hhCywUus 4sA49io54Cj5rdL6PUA28DU7+d8bnHo/cM3f7uVUET8Ag1i+PvArqtgiNW0 X-Received: by 2002:a17:902:c94b:b0:2ae:5442:45cf with SMTP id d9443c01a7336-2ae54424962mr52815935ad.33.1772510149374; Mon, 02 Mar 2026 19:55:49 -0800 (PST) Received: from cmpatel-home.hsd1.or.comcast.net ([2601:1c0:5780:9200:f389:ec50:2d31:32f3]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb6ba5eesm157089845ad.68.2026.03.02.19.55.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 19:55:48 -0800 (PST) From: Chintan Patel To: sumit.semwal@linaro.org, neil.armstrong@linaro.org Cc: dianders@chromium.org, jesszhan0024@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Chintan Patel Subject: [PATCH v2] drm/panel: novatek-nt36672a: Convert to mipi_dsi_*_multi() helpers Date: Mon, 2 Mar 2026 19:55:08 -0800 Message-ID: <20260303035508.8288-1-chintanlike@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert the driver to use the non-deprecated mipi_dsi_*_multi() helpers and mipi_dsi_msleep(). Switch DCS command sequences to the multi context API and accumulate errors via struct mipi_dsi_multi_context. Replace open-coded error handling with the multi helpers and convert nt36672a_send_cmds() and power sequencing accordingly. Signed-off-by: Chintan Patel --- Changes in v2: - Address alignment feedback from Doug. - Restore original power-down ordering. - Drop return value from nt36672a_panel_power_off(). - Consolidate error handling around dsi_ctx.accum_err. .../gpu/drm/panel/panel-novatek-nt36672a.c | 98 ++++++------------- 1 file changed, 30 insertions(+), 68 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c b/drivers/gpu/d= rm/panel/panel-novatek-nt36672a.c index 29e1f6aea480..3ebdc3048b26 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c @@ -79,70 +79,53 @@ static inline struct nt36672a_panel *to_nt36672a_panel(= struct drm_panel *panel) return container_of(panel, struct nt36672a_panel, base); } =20 -static int nt36672a_send_cmds(struct drm_panel *panel, const struct nt3667= 2a_panel_cmd *cmds, - int num) +static void nt36672a_send_cmds(struct mipi_dsi_multi_context *dsi_ctx, + const struct nt36672a_panel_cmd *cmds, int num) { - struct nt36672a_panel *pinfo =3D to_nt36672a_panel(panel); unsigned int i; - int err; =20 for (i =3D 0; i < num; i++) { const struct nt36672a_panel_cmd *cmd =3D &cmds[i]; =20 - err =3D mipi_dsi_dcs_write(pinfo->link, cmd->data[0], cmd->data + 1, 1); - - if (err < 0) - return err; + /* cmd->data[0] is the DCS command, cmd->data[1] is the parameter */ + mipi_dsi_dcs_write_buffer_multi(dsi_ctx, cmd->data, sizeof(cmd->data)); } - - return 0; } =20 -static int nt36672a_panel_power_off(struct drm_panel *panel) +static void nt36672a_panel_power_off(struct drm_panel *panel) { struct nt36672a_panel *pinfo =3D to_nt36672a_panel(panel); - int ret =3D 0; =20 gpiod_set_value(pinfo->reset_gpio, 1); =20 - ret =3D regulator_bulk_disable(ARRAY_SIZE(pinfo->supplies), pinfo->suppli= es); - if (ret) - dev_err(panel->dev, "regulator_bulk_disable failed %d\n", ret); - - return ret; + if (regulator_bulk_disable(ARRAY_SIZE(pinfo->supplies), pinfo->supplies) = < 0) + dev_err(panel->dev, "regulator_bulk_disable failed\n"); } =20 static int nt36672a_panel_unprepare(struct drm_panel *panel) { struct nt36672a_panel *pinfo =3D to_nt36672a_panel(panel); - int ret; + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D pinfo->link }; =20 /* send off cmds */ - ret =3D nt36672a_send_cmds(panel, pinfo->desc->off_cmds, - pinfo->desc->num_off_cmds); + nt36672a_send_cmds(&dsi_ctx, pinfo->desc->off_cmds, + pinfo->desc->num_off_cmds); =20 - if (ret < 0) - dev_err(panel->dev, "failed to send DCS off cmds: %d\n", ret); - - ret =3D mipi_dsi_dcs_set_display_off(pinfo->link); - if (ret < 0) - dev_err(panel->dev, "set_display_off cmd failed ret =3D %d\n", ret); + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); + /* Reset error to continue power-down even if display off failed */ + dsi_ctx.accum_err =3D 0; =20 /* 120ms delay required here as per DCS spec */ msleep(120); =20 - ret =3D mipi_dsi_dcs_enter_sleep_mode(pinfo->link); - if (ret < 0) - dev_err(panel->dev, "enter_sleep cmd failed ret =3D %d\n", ret); + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); =20 /* 0x3C =3D 60ms delay */ - msleep(60); + mipi_dsi_msleep(&dsi_ctx, 60); =20 - ret =3D nt36672a_panel_power_off(panel); - if (ret < 0) - dev_err(panel->dev, "power_off failed ret =3D %d\n", ret); + nt36672a_panel_power_off(panel); =20 - return ret; + return 0; } =20 static int nt36672a_panel_power_on(struct nt36672a_panel *pinfo) @@ -170,52 +153,31 @@ static int nt36672a_panel_power_on(struct nt36672a_pa= nel *pinfo) static int nt36672a_panel_prepare(struct drm_panel *panel) { struct nt36672a_panel *pinfo =3D to_nt36672a_panel(panel); - int err; + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D pinfo->link }; =20 - err =3D nt36672a_panel_power_on(pinfo); - if (err < 0) - goto poweroff; + dsi_ctx.accum_err =3D nt36672a_panel_power_on(pinfo); =20 /* send first part of init cmds */ - err =3D nt36672a_send_cmds(panel, pinfo->desc->on_cmds_1, - pinfo->desc->num_on_cmds_1); + nt36672a_send_cmds(&dsi_ctx, pinfo->desc->on_cmds_1, + pinfo->desc->num_on_cmds_1); =20 - if (err < 0) { - dev_err(panel->dev, "failed to send DCS Init 1st Code: %d\n", err); - goto poweroff; - } - - err =3D mipi_dsi_dcs_exit_sleep_mode(pinfo->link); - if (err < 0) { - dev_err(panel->dev, "failed to exit sleep mode: %d\n", err); - goto poweroff; - } + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); =20 /* 0x46 =3D 70 ms delay */ - msleep(70); + mipi_dsi_msleep(&dsi_ctx, 70); =20 - err =3D mipi_dsi_dcs_set_display_on(pinfo->link); - if (err < 0) { - dev_err(panel->dev, "failed to Set Display ON: %d\n", err); - goto poweroff; - } + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); =20 /* Send rest of the init cmds */ - err =3D nt36672a_send_cmds(panel, pinfo->desc->on_cmds_2, - pinfo->desc->num_on_cmds_2); + nt36672a_send_cmds(&dsi_ctx, pinfo->desc->on_cmds_2, + pinfo->desc->num_on_cmds_2); =20 - if (err < 0) { - dev_err(panel->dev, "failed to send DCS Init 2nd Code: %d\n", err); - goto poweroff; - } + mipi_dsi_msleep(&dsi_ctx, 120); =20 - msleep(120); + if (dsi_ctx.accum_err < 0) + gpiod_set_value(pinfo->reset_gpio, 0); =20 - return 0; - -poweroff: - gpiod_set_value(pinfo->reset_gpio, 0); - return err; + return dsi_ctx.accum_err; } =20 static int nt36672a_panel_get_modes(struct drm_panel *panel, --=20 2.43.0