From nobody Thu Apr 9 14:57:53 2026 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C44739098E for ; Tue, 3 Mar 2026 01:03:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772499827; cv=none; b=foL8kwUVxj3/AQQ0ZocCsQel7y4hSmAjGMOf0KxaH/4HAim7+gZcfKljkr7ZDyx3hYRVEJZ9cTPvVPj6cvetsTtHSJxVv298YYC63f3TeA7lx0D+Qo2BPUs2Ad8JChoydzMpnOE23ae9+lcuNgWCuTE9IJzO6ARtOqCQ+oqE+94= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772499827; c=relaxed/simple; bh=pTeCDbjvTiiUAOXjZcIhypV8QrnHWDghRWwRc0wsuoo=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=VBC5ftlk+8vJtIcmrzQZW2WjXz1VfPwb6SweyEl+080Tj8N5C/ZuyTFTzkR/cDvwo8QyUlj3qYSuSBuTK1AC+pALGcnAMD6ZutLoIs2NGipwADakAAOAae7YzD1F8ELGnDkbFpj33IC03LN+x+/H2FtmJeHs88lXEk2SYolzwrg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--elsk.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=AOtUwuR6; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--elsk.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="AOtUwuR6" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-c70ea91bfe1so3265353a12.1 for ; Mon, 02 Mar 2026 17:03:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772499826; x=1773104626; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=09UyxpKF6NpXT/Wg8MZmlZIu9b9OBO/RRnEFMaqWU8o=; b=AOtUwuR6fDFGIWDdi3nJ1Q74aMauMBdie2pTGWixoVy/M9ajVevb51k+p894SsaDv8 9TvUZs/7kz9x9mD6DIzk0x6SGOgoLGJloAT9JyWEp+NXr3YH2t7m2O05jyqm+9Hxv8W4 wRAy+/XVNEo6x+OR4SB77ar2vY6RJpUHA8UvhDOJ4BjHdQawy8J4bKODvTe1UxVSd8yC KfsBz++ZNC11zoPgI1WfL/PFtS/5risq7CRToovWOCwyog2y/klxMHXYVE1yCRQFH51X pZCXLGPq7+1LEK6tp0wexgBofh5Bz3tMFLZNKNGUix+SIEIs/cjwUCDkQOpBush1HAsq DiSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772499826; x=1773104626; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=09UyxpKF6NpXT/Wg8MZmlZIu9b9OBO/RRnEFMaqWU8o=; b=w8A/yE9Hso7x9AWnO2Kq82l7P1tQZE5HmA3l681QfhR7JGZS33CFMaoCJ1f7xI3+Ut kHEytLNe2c4GQUCDouyWTAbIPFwE2UlT2Rncf0eEgKVnQR1nqTHgyS5euQyKXHenWVsS G2rbacHj0JIPUpMgoHXvuhmjCMrslcOZBzaWCyfQD3If9hGrf2fmmhzPPyjto3SLxDTH DiT387eNWhG92LFDTWaMjVAONytFe0yy4Bi5DDddum92/B44Xz3Z/pXkjmi10tI9EnEy VP+Ep9I8q4W0x5PBiBYUj9Lf8BxcvzIvGYAjOD1R2dngGJBI//XfegDdrI5TdTvmFPKX wB/g== X-Forwarded-Encrypted: i=1; AJvYcCWvGml3Evrx/CWFccTF/KB3xux+CUT+iUQTa6dQWPCxBzGHQ52ZuVJLNmwMGO/xBpK22LmQ85WmUfRws4U=@vger.kernel.org X-Gm-Message-State: AOJu0YxoAEiwtj0016A6ts4FvV5RkISLdzGhesyZ1JvcYe23+r6UUdUK HhqH384bGLH2Y3b2KP0QbBDkIHc/Ce1Qg+8KjT+WDLnAwNy9iSoQ8gu7d45EuvfXxxZr9lpQ1Q= = X-Received: from pgbcp11.prod.google.com ([2002:a05:6a02:400b:b0:c6e:28c3:dd4c]) (user=elsk job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:3297:b0:38b:ea2a:284c with SMTP id adf61e73a8af0-395c3a3a7fcmr13772754637.20.1772499825245; Mon, 02 Mar 2026 17:03:45 -0800 (PST) Date: Tue, 3 Mar 2026 01:03:39 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.53.0.473.g4a7958ca14-goog Message-ID: <20260303010340.306164-1-elsk@google.com> Subject: [PATCH v1] objtool: HAVE_XXHASH test uses HOSTCFLAGS. From: HONG Yifan To: Josh Poimboeuf , Peter Zijlstra Cc: HONG Yifan , kernel-team@android.com, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Previously, HAVE_XXHASH is tested by invoking HOSTCC without HOSTCFLAGS. Consider the following scenario: - The host machine has libxxhash installed - We build the kernel with HOSTCFLAGS containing a --sysroot that does not have xxhash.h (for hermetic builds) In this case, HAVE_XXHASH is set to y, but when it builds objtool with HOSTCFLAGS, because the --sysroot does not contain xxhash.h, the following error is raised: <...>/common/tools/objtool/include/objtool/checksum_types.h:12:10: fatal er= ror: 'xxhash.h' file not found 12 | #include | ^~~~~~~~~~ To resolve the error, we test HAVE_XXHASH by invoking HOSTCC with HOSTCFLAGS. Signed-off-by: HONG Yifan Reviewed-by: Carlos Llamas --- tools/objtool/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile index 6964175abdfd..b8b8529f8ea9 100644 --- a/tools/objtool/Makefile +++ b/tools/objtool/Makefile @@ -13,7 +13,7 @@ endif =20 ifeq ($(ARCH_HAS_KLP),y) HAVE_XXHASH =3D $(shell printf "$(pound)include \nXXH3_state_t = *state;int main() {}" | \ - $(HOSTCC) -xc - -o /dev/null -lxxhash 2> /dev/null && echo y || ec= ho n) + $(HOSTCC) $(HOSTCFLAGS) -xc - -o /dev/null -lxxhash 2> /dev/null &= & echo y || echo n) ifeq ($(HAVE_XXHASH),y) BUILD_KLP :=3D y LIBXXHASH_CFLAGS :=3D $(shell $(HOSTPKG_CONFIG) libxxhash --cflags 2>/de= v/null) \ --=20 2.53.0.473.g4a7958ca14-goog