From nobody Thu Apr 9 16:34:58 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3771382F0A for ; Tue, 3 Mar 2026 06:13:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772518439; cv=none; b=gQZQcHIVnPJzv2+Q//GQYqmCwRzojmUq8sGQoIPfMSTfd/H2QF2GxA54Iwu4Yw3Y/jQ3nF5e9XOCABtPkM9RhIQ9KxX/D377Hx4BCzkvOqxfdGr9uhc2+nOB2sO2os/jcKVUALXbuhvienliUG1oW0DFTnZHDUE8uqPo47L8LWo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772518439; c=relaxed/simple; bh=2NiZAoDC3alIu0louVywwr639R2HWq7OVqahJ+UY2qs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rwr9/R5Uiqt08gN/9g/FxHia+Wnl8dRUGPmdgZF558VcgXias7B+GnrK1+fF5BA8SqKnR8FW7JvilAwL5XngKCV+Z+rt8giGa2ZReBdljnJe023LmemiRpotuFsGtvRZITzdcko2tXhNCiLpevycFQB6sDLaeQLGSVcpkHBUIhM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=RdQ9h3Us; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="RdQ9h3Us" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2ae46fc8ec1so14459415ad.3 for ; Mon, 02 Mar 2026 22:13:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1772518435; x=1773123235; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gUpkwHwpX2KwRPifYdo4IGj691Egz/3WoBPDe25QAL0=; b=RdQ9h3UsQiD6V/BKBw+xY0wBto5UiKVJhlxbU4j2Hi0qGvtksGENLY6CMtXoO7Hf/a 6vLi9GU/Up/6BnYhGcdCELhWkcttK7UbqwQcV3l6OdPzX1/ddDbxZDP2qsLT5H62eGAi bfM/p/fG2e/FlZIWQAQyC2s2bgAwCkbWFdiOk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772518435; x=1773123235; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=gUpkwHwpX2KwRPifYdo4IGj691Egz/3WoBPDe25QAL0=; b=pB90xp+uETd1DvQjGdvxSyKyYXXsGiuvFIHwnlOu4lE91XWGsqgoP1GpAabTKYCeHJ WU7z/liAEoqx5GGWCBu75lrYCmUFZBzqrHuuiGuyaKwWf6sxHEQgMZIlX90inGgLz+Xj zxo3sL0N1Ouh88QBjWbEVnuGHVrgJeizzFeTGZV/7fFP/iQZMr0iDYczGKoVep7qSivA jnMhdpsSznLY1XZEAh83vpnikFL+oUXz+Scf2nXH9CRErx4LZ9mMqi+dx0RCafBF4eTb E/xBQz3unBCp9G6MraoiC6+5gB9Ngl0DmAHyCfZMG62EMjSTzkS4++d6nDUwr6d+qF8/ jyLA== X-Forwarded-Encrypted: i=1; AJvYcCXJOSvRJTXR9cOcTAo0IVIwEq4LpPGy+eL3b0N0Yk2Mq92zVk4V5EtC/Jf9jQa3IQDQ8+tLq3ZBoShySss=@vger.kernel.org X-Gm-Message-State: AOJu0YydXYdOdmsCoLliQtHLJtUSJIBNcVhw94ormlfPJwpiW/ndkIpK 7k8HKxXXyeD4gOrYH9hBI/KOtS+V32BEs70cPvoJQ9vUnxCnc9FsH4rwqtrDm5/ZuA== X-Gm-Gg: ATEYQzz5AeQTdjmPvuDKX2KgWiR0NuYMSdarCTFRix5nTlKnQRaFtks1q6rDNaYgywN WvgmJSUWZCoilBXTudcXFrr7YZFuLMj/zbXZtdapzpy6otk/UFH5dOn0xB6+wnPncxavKJmuQ7L sBuD2TBxxxWZgGJsfUOZgePCxS23iviAsVFVywSanGdUtYbQ7Ur20zsNJY9XirK172vmrfObDPS Uwr1FRVPa/u4pRVM6s8CrsUPvkiYikXtCzbni0YqSRaN5l3PqSjlTzRjdkpGxvs/nbvDGFXMbyg bl/zDLTVE86TaKBZdi1rkN7GoJcwyTxVmPLucaalSQWrrItRA6uL/0snHnoXmWtSQ7w2FqmttsP wB8jLT+TPyfFI7AzG+U0YIfQkUWdIRjPqQUnnZMp5qpHfjz3AOUu/cMxYe/rxOpF/dFD1WtkFAh xdIsUjICzNpz75tWYC7HQdBY5/e4NUE8Co2Hr8m+T9ERUkxbkBv3LZfxL1Qwlhyuszln3VZhvGD BuiNz+K+/g8pqzgxD2dhfcY9jtd3U/z/A== X-Received: by 2002:a17:902:f605:b0:2ae:4fc8:3f5d with SMTP id d9443c01a7336-2ae4fc8413bmr60047075ad.48.1772518434943; Mon, 02 Mar 2026 22:13:54 -0800 (PST) Received: from jingyliang-input-linux.c.googlers.com (111.169.168.34.bc.googleusercontent.com. [34.168.169.111]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb6fe4f3sm152639735ad.91.2026.03.02.22.13.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 22:13:54 -0800 (PST) From: Jingyuan Liang Date: Tue, 03 Mar 2026 06:13:02 +0000 Subject: [PATCH 10/12] HID: spi-hid: add power management implementation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260303-send-upstream-v1-10-1515ba218f3d@chromium.org> References: <20260303-send-upstream-v1-0-1515ba218f3d@chromium.org> In-Reply-To: <20260303-send-upstream-v1-0-1515ba218f3d@chromium.org> To: Jiri Kosina , Benjamin Tissoires , Jonathan Corbet , Mark Brown , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-trace-kernel@vger.kernel.org, devicetree@vger.kernel.org, hbarnor@chromium.org, Jingyuan Liang X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772518424; l=5475; i=jingyliang@chromium.org; s=20260213; h=from:subject:message-id; bh=2NiZAoDC3alIu0louVywwr639R2HWq7OVqahJ+UY2qs=; b=xTK6qEpzG/F1jIuNi2IahxlTcrTi8zoxhftG8itoIwOTbVRnoTrMkT/BMzRjaNtHEQhGmbviq M3CBY14dXgSDE+8gnxfC1va3/UGPdCQCTCkJ+y+nSwaRTGTN4SEpWs3 X-Developer-Key: i=jingyliang@chromium.org; a=ed25519; pk=VTYSdqslTtYOjWWoIGgYoWupGWqNSidrggReKMgfPo4= Implement HID over SPI driver power management callbacks. Signed-off-by: Jingyuan Liang --- drivers/hid/spi-hid/spi-hid-acpi.c | 1 + drivers/hid/spi-hid/spi-hid-core.c | 107 +++++++++++++++++++++++++++++++++= ++++ drivers/hid/spi-hid/spi-hid-of.c | 1 + drivers/hid/spi-hid/spi-hid.h | 1 + 4 files changed, 110 insertions(+) diff --git a/drivers/hid/spi-hid/spi-hid-acpi.c b/drivers/hid/spi-hid/spi-h= id-acpi.c index 612e74fe72f9..2c1e4de99fea 100644 --- a/drivers/hid/spi-hid/spi-hid-acpi.c +++ b/drivers/hid/spi-hid/spi-hid-acpi.c @@ -238,6 +238,7 @@ static struct spi_driver spi_hid_acpi_driver =3D { .driver =3D { .name =3D "spi_hid_acpi", .owner =3D THIS_MODULE, + .pm =3D &spi_hid_core_pm, .acpi_match_table =3D ACPI_PTR(spi_hid_acpi_match), .probe_type =3D PROBE_PREFER_ASYNCHRONOUS, .dev_groups =3D spi_hid_groups, diff --git a/drivers/hid/spi-hid/spi-hid-core.c b/drivers/hid/spi-hid/spi-h= id-core.c index 02beb209a92d..797ba99394f9 100644 --- a/drivers/hid/spi-hid/spi-hid-core.c +++ b/drivers/hid/spi-hid/spi-hid-core.c @@ -35,6 +35,8 @@ #include #include #include +#include +#include #include #include #include @@ -236,6 +238,81 @@ static const char *spi_hid_power_mode_string(enum hids= pi_power_state power_state } } =20 +static void spi_hid_suspend(struct spi_hid *shid) +{ + int error; + struct device *dev =3D &shid->spi->dev; + + guard(mutex)(&shid->power_lock); + if (shid->power_state =3D=3D HIDSPI_OFF) + return; + + if (shid->hid) { + error =3D hid_driver_suspend(shid->hid, PMSG_SUSPEND); + if (error) { + dev_err(dev, "%s failed to suspend hid driver: %d", + __func__, error); + return; + } + } + + disable_irq(shid->spi->irq); + + clear_bit(SPI_HID_READY, &shid->flags); + + if (!device_may_wakeup(dev)) { + set_bit(SPI_HID_RESET_PENDING, &shid->flags); + + shid->ops->assert_reset(shid->ops); + + error =3D shid->ops->power_down(shid->ops); + if (error) { + dev_err(dev, "%s: could not power down.", __func__); + shid->regulator_error_count++; + shid->regulator_last_error =3D error; + return; + } + + shid->power_state =3D HIDSPI_OFF; + } +} + +static void spi_hid_resume(struct spi_hid *shid) +{ + int error; + struct device *dev =3D &shid->spi->dev; + + guard(mutex)(&shid->power_lock); + if (shid->power_state =3D=3D HIDSPI_ON) + return; + + enable_irq(shid->spi->irq); + + if (!device_may_wakeup(dev)) { + shid->ops->assert_reset(shid->ops); + + shid->ops->sleep_minimal_reset_delay(shid->ops); + + error =3D shid->ops->power_up(shid->ops); + if (error) { + dev_err(dev, "%s: could not power up.", __func__); + shid->regulator_error_count++; + shid->regulator_last_error =3D error; + return; + } + shid->power_state =3D HIDSPI_ON; + + shid->ops->deassert_reset(shid->ops); + } + + if (shid->hid) { + error =3D hid_driver_reset_resume(shid->hid); + if (error) + dev_err(dev, "%s: failed to reset resume hid driver: %d.", + __func__, error); + } +} + static void spi_hid_stop_hid(struct spi_hid *shid) { struct hid_device *hid =3D shid->hid; @@ -1155,6 +1232,13 @@ int spi_hid_core_probe(struct spi_device *spi, struc= t spihid_ops *ops, dev_err(dev, "%s: unable to request threaded IRQ.", __func__); return error; } + if (device_may_wakeup(dev)) { + error =3D dev_pm_set_wake_irq(dev, spi->irq); + if (error) { + dev_err(dev, "%s: failed to set wake IRQ.", __func__); + return error; + } + } =20 error =3D shid->ops->power_up(shid->ops); if (error) { @@ -1186,6 +1270,29 @@ void spi_hid_core_remove(struct spi_device *spi) } EXPORT_SYMBOL_GPL(spi_hid_core_remove); =20 +static int spi_hid_core_pm_suspend(struct device *dev) +{ + struct spi_hid *shid =3D dev_get_drvdata(dev); + + spi_hid_suspend(shid); + + return 0; +} + +static int spi_hid_core_pm_resume(struct device *dev) +{ + struct spi_hid *shid =3D dev_get_drvdata(dev); + + spi_hid_resume(shid); + + return 0; +} + +const struct dev_pm_ops spi_hid_core_pm =3D { + SYSTEM_SLEEP_PM_OPS(spi_hid_core_pm_suspend, spi_hid_core_pm_resume) +}; +EXPORT_SYMBOL_GPL(spi_hid_core_pm); + MODULE_DESCRIPTION("HID over SPI transport driver"); MODULE_AUTHOR("Dmitry Antipov "); MODULE_LICENSE("GPL"); diff --git a/drivers/hid/spi-hid/spi-hid-of.c b/drivers/hid/spi-hid/spi-hid= -of.c index a20c8146230b..bc1d3c5a4dda 100644 --- a/drivers/hid/spi-hid/spi-hid-of.c +++ b/drivers/hid/spi-hid/spi-hid-of.c @@ -227,6 +227,7 @@ static struct spi_driver spi_hid_of_driver =3D { .driver =3D { .name =3D "spi_hid_of", .owner =3D THIS_MODULE, + .pm =3D &spi_hid_core_pm, .of_match_table =3D of_match_ptr(spi_hid_of_match), .probe_type =3D PROBE_PREFER_ASYNCHRONOUS, .dev_groups =3D spi_hid_groups, diff --git a/drivers/hid/spi-hid/spi-hid.h b/drivers/hid/spi-hid/spi-hid.h index 1fdd45262647..5651c7fb706a 100644 --- a/drivers/hid/spi-hid/spi-hid.h +++ b/drivers/hid/spi-hid/spi-hid.h @@ -40,5 +40,6 @@ int spi_hid_core_probe(struct spi_device *spi, struct spi= hid_ops *ops, void spi_hid_core_remove(struct spi_device *spi); =20 extern const struct attribute_group *spi_hid_groups[]; +extern const struct dev_pm_ops spi_hid_core_pm; =20 #endif /* SPI_HID_H */ --=20 2.53.0.473.g4a7958ca14-goog