From nobody Thu Apr 2 01:54:51 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2382B3CD8A6 for ; Tue, 3 Mar 2026 21:15:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772572545; cv=none; b=aUgLyEDFQmMr60ViVAoxEVqL/jr66hmXCsVnKzfM4KR5GdHJ3fPKgSrcpoAG6XYq+jKw54p0nZaJl8eH1eo0C0Scro6Az7FZRmIOYJFetd1Sd9KcRcM9yRhdzN0wxnzgFXBhUrDHSWLcDdJw80KupQouRMOOQge8lfiC6RMPgcw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772572545; c=relaxed/simple; bh=WKMW8HVlmZaoyJE5jsAXtcRs0N48w7Ua2f/NenCBzOQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GxObK2wuV/GWht6vhdyjXZpBSXZsAOSXPvGLNHlpMSqfz5jf6qMOfe3al/Tf8kMZRRnrwQHELdSCnYpR3dbcA4xDEPj+rtYyNV2D1px7TbIBQ7vsBAhZGpTL8jyDH1Z0wl0j01MjPhPG4aaUpj7bDokO8dSwSeoGXtN4bv0DF70= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OCESQA4c; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=LXsthQwA; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OCESQA4c"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="LXsthQwA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772572538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=irBf4YUdN1+vibh8PKUSXKnT1yGXKOqgKyvxp0mJGPY=; b=OCESQA4clh8Axb1EjczquFMRnGOxVQ0eJn0FXweTVNSIxFkuzc2tNJ9bFvcsjNAOLNxk9z Tzwha96xnUDt8Puun9MztQK61kbNN+O9W/1yep/mDbg01mbH1wtQMk3u13R44FXdv7jg+o TRHQ8bldEBnrh6Kg+VGFCL1XExIfl38= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-lPpEFVrbONOiIB7yeq2gtQ-1; Tue, 03 Mar 2026 16:15:37 -0500 X-MC-Unique: lPpEFVrbONOiIB7yeq2gtQ-1 X-Mimecast-MFC-AGG-ID: lPpEFVrbONOiIB7yeq2gtQ_1772572536 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50341fddb89so461430781cf.3 for ; Tue, 03 Mar 2026 13:15:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772572536; x=1773177336; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=irBf4YUdN1+vibh8PKUSXKnT1yGXKOqgKyvxp0mJGPY=; b=LXsthQwAvI+GKiRoth6wdOJ4d7t29LFNUXcVJ7W4ht7TxVbYapOiZeMa03RzTM+PD9 Gp9Tl3ywuJnCudUgdsoXbCtDX69Otr7tPpVE/kWlvKblfsKuQfxSv/EBRgUbAbrrALDG Z/djSv+b/2AZo4oK8tNCMVv3mi5v0Gveo3xEz//MQwR4+9T/blKHIoSy2n/oT21ooltw RFmsGWmfjaHkxtDVWgNSBoKEeOUmNEIhs3DZtjNyvHy3JBDLV0+LnyxoZFMuWN5EHG9K BRsNOAyVtb4MXTkr5Pg8hZZ4KnOKzO8HHIwLTuRUnNdk2ms3l8CovFKVrIQJF2/Bi4TK nfyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772572536; x=1773177336; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=irBf4YUdN1+vibh8PKUSXKnT1yGXKOqgKyvxp0mJGPY=; b=DTRBzHZYYSHkij3MMTfH+LXsfQirUy1lXhqtrqYv1URWy0ai/KfSuyB3TbGDOeiTNz Xu1MsGmmJ4CpMQbBKhGgQE05ltYWjHbzRirVWrFmI7EU4+ivFWMfWodHk/0PnrLUAniI Uq4leaZ0f4AwDA1dzKnEWDpRsXJNmnnCMg4JGsk9n5Nl+Y21aRwDycrq/wy1PJ66LWjI xDCMn13baGWUKiFVuHNtJW5d3pySAvXDjTIcGNZyOQ0h3XQ34f5ZHlmcC7haVUCnPN42 1Orwiee56GqoP95845dTs68MAOBRbVfbzcniXQIcO3OFOvcx5W0vyVNVI75356zzzvbZ Tv0g== X-Forwarded-Encrypted: i=1; AJvYcCXtOlYYJxWRIKYG2abSMIsFyBd1pWPrryHnCG3cOD8PjNI1e5IDgwcQxx8QFlKd2X1gdvijBAV5GYaTaak=@vger.kernel.org X-Gm-Message-State: AOJu0YxQCWkROqVDISiLuD+65Ox2j/KiZnxXLUlE1SITCzxUF/pn0WA/ NZTKCUTUx95ZzNAyYVUKJEvSVqlMEc5flA90xOGlQ2GF6BKSMpuMkwe1WciWb5pqukxlp7StzJ0 ckNExV5WxRfp1P0hw5DHkOG51/6TMpNKrGbCKABjFGiYO5fBhh2W9x4q5xqWwyKKWMg== X-Gm-Gg: ATEYQzzRQrEY2sS0lutPrFyOOvS9w4OgMxAkwUYBe0DhPJ1kh2RcYcJhZKYjipV5IH8 so0b/0x0oIMfqoI84njGMvFB0VGk9ukEezekEvNOCqPNW4YSfEPRE3aCNMLrn8nNggS2/Yksf4/ jw5wyOUzaRs56SkyQAKusSFGDxguxuVlN5GU8KACAn1pAzXbZ2NBUnJl0erAiHqcoVtcViP1nKT U1fjTP8yIP7P+u+jyC4ZCs5psgaC7f9/fKg0x531QUhAtG4NBKOq7AHMSlXMDjy416ZeJLQm6+n 182KQZxk6wPNcbMB9BxlOn+WufUqmUgAW1V4Kp4gGHu9sDj1wbTAr83S0UnFh14zyOnWjjD+gCy 9ujGhiCtuU3hOtKeu8EE+GhEWSw== X-Received: by 2002:a05:622a:1891:b0:502:9abb:c919 with SMTP id d75a77b69052e-5075287910dmr225478251cf.10.1772572536449; Tue, 03 Mar 2026 13:15:36 -0800 (PST) X-Received: by 2002:a05:622a:1891:b0:502:9abb:c919 with SMTP id d75a77b69052e-5075287910dmr225477351cf.10.1772572535732; Tue, 03 Mar 2026 13:15:35 -0800 (PST) Received: from [172.16.1.8] ([2607:f2c0:b1e3:9a00:3c7:56c2:f819:96d2]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5074481c0e5sm156286991cf.0.2026.03.03.13.15.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 13:15:35 -0800 (PST) From: Peter Colberg Date: Tue, 03 Mar 2026 16:15:22 -0500 Subject: [PATCH v3 02/10] fpga: dfl-pci: set driver flag to disable SR-IOV on remove() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260303-rust-pci-sriov-v3-2-4443c35f0c88@redhat.com> References: <20260303-rust-pci-sriov-v3-0-4443c35f0c88@redhat.com> In-Reply-To: <20260303-rust-pci-sriov-v3-0-4443c35f0c88@redhat.com> To: Danilo Krummrich , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Miguel Ojeda , Alex Gaynor , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Greg Kroah-Hartman , Dave Ertman , Ira Weiny , Leon Romanovsky , David Airlie , Simona Vetter , Jonathan Corbet , Xu Yilun , Tom Rix , Moritz Fischer , "Rafael J. Wysocki" , Boqun Feng Cc: linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Courbot , Alistair Popple , Joel Fernandes , John Hubbard , Zhi Wang , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-fpga@vger.kernel.org, driver-core@lists.linux.dev, Peter Colberg , Jason Gunthorpe X-Mailer: b4 0.14.2 Set the flag managed_sriov in the pci_driver structure to show how a PCI driver may opt into disabling the Single Root I/O Virtualization (SR-IOV) capability of the device when the driver is removed. Merge the function cci_remove_feature_devs() into cci_pci_remove(). Signed-off-by: Peter Colberg --- Changes in v2: - Demonstrate flag managed_sriov for dfl-pci driver. --- drivers/fpga/dfl-pci.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c index e25205c6d8f00cec579016acade28e743812c924..2410e6f3efe100a635eebfdb21f= 28f62a3759890 100644 --- a/drivers/fpga/dfl-pci.c +++ b/drivers/fpga/dfl-pci.c @@ -125,15 +125,6 @@ static int cci_init_drvdata(struct pci_dev *pcidev) return 0; } =20 -static void cci_remove_feature_devs(struct pci_dev *pcidev) -{ - struct cci_drvdata *drvdata =3D pci_get_drvdata(pcidev); - - /* remove all children feature devices */ - dfl_fpga_feature_devs_remove(drvdata->cdev); - cci_pci_free_irq(pcidev); -} - static int *cci_pci_create_irq_table(struct pci_dev *pcidev, unsigned int = nvec) { unsigned int i; @@ -425,10 +416,11 @@ static int cci_pci_sriov_configure(struct pci_dev *pc= idev, int num_vfs) =20 static void cci_pci_remove(struct pci_dev *pcidev) { - if (dev_is_pf(&pcidev->dev)) - cci_pci_sriov_configure(pcidev, 0); + struct cci_drvdata *drvdata =3D pci_get_drvdata(pcidev); =20 - cci_remove_feature_devs(pcidev); + /* remove all children feature devices */ + dfl_fpga_feature_devs_remove(drvdata->cdev); + cci_pci_free_irq(pcidev); } =20 static struct pci_driver cci_pci_driver =3D { @@ -437,6 +429,7 @@ static struct pci_driver cci_pci_driver =3D { .probe =3D cci_pci_probe, .remove =3D cci_pci_remove, .sriov_configure =3D cci_pci_sriov_configure, + .managed_sriov =3D true, }; =20 module_pci_driver(cci_pci_driver); --=20 2.53.0