From nobody Tue Mar 3 03:20:24 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1ECC312819 for ; Mon, 2 Mar 2026 18:13:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772475204; cv=none; b=r/RRnYWTGhk739ZwQ/eveGWOAvSsAATtmoJuIC39olOPYlKh/6or/IMQqmXlDbIVPvvIbihEuf/lDZfPWJ3ccaiaefiz182z2i2Zgj78hW5Rmk3kXh8bwGGFpg9XRirzl5ltcrwE/SZzWXVnseQnyQb8b2SuUA3alOTAhKG3E84= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772475204; c=relaxed/simple; bh=X9pFxZzMqkOXOXtjPC/JVKM4MxUqs2nrYJdjE2X9+yA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=Cv+Pg/evblo/PwwlSQwQBm2ZfvhsJvxv0UIogsP2ZThsFHSDDq07mpvtOFvlf0D0xiw2RJ6aVm9TIDI/bdgXDr1MLrlISK6trTQTMw+8oKqfzZZnTNxNYP61557DxsY04MuG60ShMccsfz11Lj/jOBfU/eokjruJt1KWecetK7U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZLAiSYRS; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZLAiSYRS" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-824c9da9928so2928025b3a.3 for ; Mon, 02 Mar 2026 10:13:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772475202; x=1773080002; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=hnWhypid25+2v4/CmwVulpRAOWew3H3syajXEsdh0sA=; b=ZLAiSYRSNd4car2FpLXzc8AKt4jIsO36jFPAdRCBC/ghNSqWNlt1vGaSAumgkz2nrJ xbIDvrQXKzL5h/eWmka6yF0F/zFRY3SuiUsHwrpSBYLDpkFK36eMQ2Z2b7lf77f5Dg/P Wh7tAbp6W7KULfCyIZmz28eV7WQunmLADkBYm7oeQ7L2R9Izi51s+tR4lUDtGCkUIAgf 1grMClDn7wSlS5Shw3iqrodI4Z9huH7GR+zrZUnlik1+uHHjFUB7B3CY0IxABdYnzviW UEWE7qxwXragc87MPogGU41EoYokjBqlCX7K6fW8GQ2CEKIDuEdNISVhKergxKzG1ycg jIYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772475202; x=1773080002; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hnWhypid25+2v4/CmwVulpRAOWew3H3syajXEsdh0sA=; b=OXWyHdwTA19T3MX/YLSclOm0bnXmBVKnPRK5vc8ER5AWs9jP+mTmG9XGDqOuPkVvME QppPWMq6GPgeLDLEKa8713Ey0oMx+muTZG4NvZGyxnXVzr47My1euJK3WmrU9LQz9PyD UQLQRRzwvKeKFUU2gOJd/x6utDlXKJmSryllxMJ//ME7Ty/Yl3B58Bo5vyujkpWRaYpw nM34tK/1tb6KPRs8DE1vEHmrjLyDQKRf7YrDeFOrSWmXtgr0NMXhkNHfjsv1aPLeKhdY tN4I8gos1qwddfw5PBU8FZ63DfFiIimN1NUnH88p3uUPlT4pkanqV9sDsW/u5xurie1E dYew== X-Forwarded-Encrypted: i=1; AJvYcCW0kaqEsQfl3a7WsAxfq5WW0em2pRx9W/eLtKYeZsuvwjFhzEaWnHp1Xw0gyAqeLwkFj96xAt2kQ2r0ylU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8Is/ICU9EjCOcsHNAhkdi3EKcp1PRhYZl17e7wz9fqx3gkx0B 0eY9scCJjW2sOqAZVUlvPLRV8pBXC/73fOG5Kprj5xrZBEAHZ/ZC5mIf X-Gm-Gg: ATEYQzw2PkFlMK5TRxCHdTgWO7ef9IMNyXQeLBpEUKCFctZ33pVK3vMWElR1f0rc8T9 sYfpQJj3VvjAF7+Tq04qCxlIE9Bp97NcghXSkMZ4PkQv7FZibhYouLhazMvBv8vML/TKrnOSmLv Zh9KbYDQJyN+J96NIkreET2j04gzmcHEy3G4+LIQndFMW4s4VLTKsDoIQKZV63NqaXfFGCAR2zy priYJAQebe8zOw/j7P3jKsiMWEQ1+INB1RF9cCdKHLHseW0G0fIN9NipIsEUbEvqmT0oXHz7WWE RPr6M9ise0JJjNTeyY7vSVBq4ULESBsEXPfZy3KBqBzPXFBrJVUsji0mdVHigOBdd/3GuqJYgd6 bMUgorrDTwfFSD+wrWZD+zIxSwEJl8litDldtkuGAUI6nfM3JqVhCMtfUloLGZkOwlFPTED2Rhh Ha5iekIbEVojNd1A2fvaCZOcTWNjqg/llcgjT5 X-Received: by 2002:a17:90b:3b8b:b0:359:8632:5e39 with SMTP id 98e67ed59e1d1-35986325f9dmr4652923a91.5.1772475202326; Mon, 02 Mar 2026 10:13:22 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9009:3f2:4c92:fc5c:54e5:712e]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35901883a0bsm24608201a91.6.2026.03.02.10.13.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 10:13:22 -0800 (PST) From: Felix Gu Date: Tue, 03 Mar 2026 02:13:17 +0800 Subject: [PATCH] pinctrl: microchip-mssio: Fix missing return in probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260303-mssio-v1-1-ea0fdf3bf202@gmail.com> X-B4-Tracking: v=1; b=H4sIADzTpWkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDYwNj3dxioBJdc2MTYxNL00RDC5M0JaDagqLUtMwKsDnRsbW1AIvNzr1 XAAAA X-Change-ID: 20260303-mssio-7343495a184f To: Conor Dooley , Daire McNamara , Linus Walleij Cc: linux-riscv@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772475199; l=1266; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=X9pFxZzMqkOXOXtjPC/JVKM4MxUqs2nrYJdjE2X9+yA=; b=cYspcSg2cni4FEWF1uboSvnd1CiyndInwPoVrAX1RlAaSyS6iRlllrsyLXTvMue2o2G90tCPd KJL+YEOurDvDBdY9wf4whkeVrXurUzX0DUKbv3pxtCMd+5h/49rpwA/ X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In mpfs_pinctrl_probe(), when pctrl->regmap fails, it just print out an error message without return, which could lead serious errors. Fixes: 488d704ed7b7 ("pinctrl: add polarfire soc mssio pinctrl driver") Signed-off-by: Felix Gu Reviewed-by: Conor Dooley --- drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c b/drivers/pinct= rl/microchip/pinctrl-mpfs-mssio.c index 3d5ffd6cb14b..15d73ea1028c 100644 --- a/drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c +++ b/drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c @@ -686,7 +686,7 @@ static int mpfs_pinctrl_probe(struct platform_device *p= dev) =20 pctrl->regmap =3D device_node_to_regmap(pdev->dev.parent->of_node); if (IS_ERR(pctrl->regmap)) - dev_err_probe(dev, PTR_ERR(pctrl->regmap), "Failed to find syscon regmap= \n"); + return dev_err_probe(dev, PTR_ERR(pctrl->regmap), "Failed to find syscon= regmap\n"); =20 pctrl->sysreg_regmap =3D syscon_regmap_lookup_by_compatible("microchip,mp= fs-sysreg-scb"); if (IS_ERR(pctrl->sysreg_regmap)) --- base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31 change-id: 20260303-mssio-7343495a184f Best regards, --=20 Felix Gu