From nobody Thu Apr 9 19:19:02 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01A644963A4 for ; Tue, 3 Mar 2026 15:33:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772552002; cv=none; b=eglKCYuL2Ga9CKYYIHvQGXD4Qs7abJzco0TjukHOZh76Bv2YJjZMrteRtM3KHML1UB2/bb3/1W/HPQD3GKSnVc+2Ak/V0dKIPmaH4fl8QhbvjiUrMkFrzxGXTLINcBwluNe5b6Q96xaSlIKnWdR8971RgoW5bi9h0RFA0FtQ2E4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772552002; c=relaxed/simple; bh=fqgV7d8c4BXshhw1gqL0HWfj9aw9iK9J0f1QWTNLAG8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bqWr0L05Xir2gChbHsl1doJzUHW5XGkhqls2lY+/TX6oM1vHjZg9OZtXRY79vczEcHjKAXFXo0O8Cy7ZoVrvc2y6tAUvomNOoEMmRybx5l3P83r4utQM3JvV+bR8/NhbyROsj868Wckab9Nd9IJ3hHifmAnXKOlHab1f2EZ/wLc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=6v6wjDFM; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="6v6wjDFM" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-4327790c4e9so4375655f8f.2 for ; Tue, 03 Mar 2026 07:33:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1772551998; x=1773156798; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=G3vNgmqYmO5UknTO3x1kCPV7VqUspCxEKfK8SFuWCw4=; b=6v6wjDFML2kSoar097A1ilQQaeZWCO1xsLsZCZo4rp0U7Pi3tz0RjNeoMIabJKMp9W +2hH1wZkn3nPzu4TqrcXDCXhay91goZks6+yfoHD4yRv6o2QnPB48vdCkL8at/triQlr /36QobsF8AABOKZj2qH6Ucv4rEqNbU8ArdTA0J759qzcgmUGCEP4riho8grtmB0h9vwL egIIYOWXFjf/6GFWBy8ODksnRJOwyyQg23q6Vi49o0GiKdc2BfumHNswFSnLwbCZv4e8 FRp5ukQ9EEqIYp37YIHO/34YBjy5l7GRAjBF+OGAxru5HQnrSNJdkx6anNiwYvlRA2BN Eh5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772551998; x=1773156798; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=G3vNgmqYmO5UknTO3x1kCPV7VqUspCxEKfK8SFuWCw4=; b=BpGoM7K61RFs+xT0iSSN5sGOf8G5K8kGnM8R5s4t8/e49YylTo3/3NVSqulhAf8qIL FXRNCXj/XauB3H3QCAFXkzyak7ib6JtzU7ece+M02dCA3gdixcUSZsk/OhsjcgsRIVQA 4cKDZi6OoNMgIct79FYrIsVy5swX60higjepFetrpQflzrN6EUiGqYIm7nMpzPUQRuH9 MsX6SXzH8p76+jRVR/p7q7LNx+QtuaJIb8SraA+yMOQY0ThAOFhfstPr5ZieGBptWNBg Z/a0sJoJiABa29Eo2chHRt5oSal6hU4LKcNFx6DZEaQJpBQ4BL8PJm8DE3GqjVyVF6sq yrjQ== X-Forwarded-Encrypted: i=1; AJvYcCVTXaDBe14rkmL9nefUjqXCM1PVzs1D1s/9ZdVJ+VSWRbIUgpMAk2eFZbx+qv6suvxVJSGZgD2KdcIQ8Yw=@vger.kernel.org X-Gm-Message-State: AOJu0YyWDWDfxTZg+1GmbrCPbuznBQl8OqX06A/Ld7UU28DL1gM3Tlk7 2N75Kd8j7tNxJxz0zATI554ivh1JGSx6eLRQniyHnfOc0rLlOYa7RXu6/g3N3gQFVvk= X-Gm-Gg: ATEYQzxzxTuggr2xrZY8ylcEFV0Q6cFCQCGH2eoFdv6m87aIpb/OWpgbvF8w4NmUELd UZ+ZYr9co79Ceyzs5jTqeYEKX2IiJtfWyfqovpWiw0UhAdIy7lfKmHWLzkyZUgZZZV+XCQHVeB1 B64WBQR4U1REBsRACqJEmJZ42Ua3GS/kHxDcmHjntzb74opsl+Zhs5eFGBnW9CRunIWTKYmNOVK qKgE9mvTlYkIF5B0qSd6lJRtv7X+v3lO7NVRJ8Qlstd+yT+sbnYKYymTH93KS+kgb3NPQZVr6Vb RnlK4204ueadf4aakUcV4/JQp4E2TKpWn91vm1jBLN96n0TFtwLwEKW2eLIpJ411xvf8bcARaHm 4pnWJcTqdenqeedjLgtCiF5HW/ln1vgZVByHKOHf6fxeGxTJRcRwrF3SLv3zUqGDtVdbE5gESy4 sEywkAt7Wht0cdIj1KcdOlagehlE99w6IJBMo1fiNKItfeDFxfJIKsYIMPPVNXXlOgsHV5+FPQl n4= X-Received: by 2002:a05:6000:2c0b:b0:439:ae3f:9405 with SMTP id ffacd0b85a97d-439ae3f976dmr19319559f8f.59.1772551997972; Tue, 03 Mar 2026 07:33:17 -0800 (PST) Received: from alchark-surface.localdomain (bba-94-59-44-101.alshamil.net.ae. [94.59.44.101]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b55d15besm19799447f8f.30.2026.03.03.07.33.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 07:33:17 -0800 (PST) From: Alexey Charkov Date: Tue, 03 Mar 2026 19:32:53 +0400 Subject: [PATCH 08/11] power: supply: bq257xx: Add fields for 'charging' and 'overvoltage' states Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260303-bq25792-v1-8-e6e5e0033458@flipper.net> References: <20260303-bq25792-v1-0-e6e5e0033458@flipper.net> In-Reply-To: <20260303-bq25792-v1-0-e6e5e0033458@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2470; i=alchark@flipper.net; h=from:subject:message-id; bh=fqgV7d8c4BXshhw1gqL0HWfj9aw9iK9J0f1QWTNLAG8=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWQu+68m4TXJxnziurrwTi+7asHlm2ZcfFB01O3RxuQ/U xOi7d/P65jIwiDGxWAppsgy99sS26lGfLN2eXh8hZnDygQyRFqkgQEIWBj4chPzSo10jPRMtQ31 DA11jHWMGLg4BWCqiywZGc42fXUpn3t4t+XRdMY5jwIkTYVeHbZr/PHQScq9s6VcP4LhfynngW/ TJh58teSL2moHd6Gr69+az1f6euXuiaBesxT79fwA X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The driver currently reports the 'charging' and 'overvoltage' states based on a logical expression in the get_charger_property() wrapper function. This doesn't scale well to other chip variants, which may have a different number and type of hardware reported conditions which fall into these broad power supply states. Move the logic for determining 'charging' and 'overvoltage' states into chip-specific accessors, which can be overridden by each variant as needed. This helps keep the get_charger_property() wrapper function chip-agnostic while allowing for new chip variants to be added bringing their own logic. Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index deb60a9bd222..951abd035fc5 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -64,8 +64,10 @@ struct bq257xx_chg { struct bq257xx_device *bq; struct power_supply *charger; bool online; + bool charging; bool fast_charge; bool pre_charge; + bool overvoltage; bool ov_fault; bool batoc_fault; bool oc_fault; @@ -99,8 +101,10 @@ static int bq25703_get_state(struct bq257xx_chg *pdata) pdata->online =3D reg & BQ25703_STS_AC_STAT; pdata->fast_charge =3D reg & BQ25703_STS_IN_FCHRG; pdata->pre_charge =3D reg & BQ25703_STS_IN_PCHRG; + pdata->charging =3D pdata->fast_charge || pdata->pre_charge; pdata->ov_fault =3D reg & BQ25703_STS_FAULT_ACOV; pdata->batoc_fault =3D reg & BQ25703_STS_FAULT_BATOC; + pdata->overvoltage =3D pdata->ov_fault || pdata->batoc_fault; pdata->oc_fault =3D reg & BQ25703_STS_FAULT_ACOC; =20 return 0; @@ -471,14 +475,14 @@ static int bq257xx_get_charger_property(struct power_= supply *psy, case POWER_SUPPLY_PROP_STATUS: if (!pdata->online) val->intval =3D POWER_SUPPLY_STATUS_DISCHARGING; - else if (pdata->fast_charge || pdata->pre_charge) + else if (pdata->charging) val->intval =3D POWER_SUPPLY_STATUS_CHARGING; else val->intval =3D POWER_SUPPLY_STATUS_NOT_CHARGING; break; =20 case POWER_SUPPLY_PROP_HEALTH: - if (pdata->ov_fault || pdata->batoc_fault) + if (pdata->overvoltage) val->intval =3D POWER_SUPPLY_HEALTH_OVERVOLTAGE; else if (pdata->oc_fault) val->intval =3D POWER_SUPPLY_HEALTH_OVERCURRENT; --=20 2.52.0