From nobody Thu Apr 9 19:19:02 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C69C494A1E for ; Tue, 3 Mar 2026 15:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772551999; cv=none; b=WK/6xHcwEINGIMAGiCFmIu9Yso5Cc8zJeWR5/Ibo0aWPVRj8h0trcbyZYTwRr+ESS0PvNRGqo3U36nMGeVxL7lGS/85Lc1wZWk89MVUmCuQW+DH9+p0m5T/70Yv8IuFso14pYDlg5HW1ESyQ9D+pTtoVMzlxMcGWEJNs/L6t1y4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772551999; c=relaxed/simple; bh=rZeSH+p/sWb94+YtWuBoX7zwjk1MlkPbjBLWjAkhzPY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KHvGJ4suSaX/nOT+nQ3p0YmDsq4bO28b6TgvHdMgPY9hWju/U/6iDFKKpTXigvQ4UXqf6TLxx19oo5ay4wbAE7/FJvfu7uuZ9Q84tOYWYBbEX+gy6jM58T5Xop/TGSGDk4gH5zxK0gorEnoZyiYDmCBMWdu21KWzLHJC9J+FukE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=itZwBtvw; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="itZwBtvw" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-439aa2f8ebaso1919947f8f.2 for ; Tue, 03 Mar 2026 07:33:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1772551995; x=1773156795; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=I8FV20nY94XdgsSpk3nNKgaUktiutL3Fj9XNodWc9Os=; b=itZwBtvww5qi7F4KxnyEbu42CJ8yOLlHtb4q+fHda0i3MivUngVPJAaNxrseMTsTRz RsNxa9vx1nrn5995xbjzIgrNdOVxTXJR0XxKLqSOEBJmT92AgKEeId3NigNj3ohoMeHl eM+Rpa7oy7Nm6FC7MWJTgPoysiglM+nsJ/4Vp3H1sdGxNY4wWctPg91yNhpzTjZEescg BE+Y7/GxCPW2oApGdTqDUZA60edRWma5V77XElzkolhhxKxFmkoJ52jPsKpm4zx/1UcN uX+F/tIzgXPI5Urgsboh+XbiwManZl5bZnt9HqkWg3wk255kKA7WpuN/u9DDQD6jIo4f WqOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772551995; x=1773156795; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=I8FV20nY94XdgsSpk3nNKgaUktiutL3Fj9XNodWc9Os=; b=a68jcLogyKSN862WtWtY4tO0jNCqwhgtAJGBCy6MsXGGp5M0KW8uOOtv22qDsLKW4y SN/3LgkrzjdaeBJX9+iJgg2ZfjtTXU8T4VaEosITOkg55kyGHPK3yUsfR34WHtl2YWYz S+qNG63Ds9JndWL3WFx8LchEgUo46nBl7c1X1RPJjnRxsXmhcl71Trt8QP5aPu1Wc9ci f/uvBVnh9//PU6nJtbLYf6ZpXHf5mK3PaICdUBMU7ua3bdnA5zkgQcryCC9oq5hB+Xgv g/t/v4luz+oReyy9SSxs4H1yJZhKwn1w88BwlTPb1uQK2BYkfeTk/7uyg/qanQKrpHQZ BckQ== X-Forwarded-Encrypted: i=1; AJvYcCURP+8Kt2dIbkaEZZyHnsE7uTpXcmt06As7/qVEdGWtBqPpZ5a6Oj96/cxsXqIz8FIQ3CsCwvN0+bfI2FM=@vger.kernel.org X-Gm-Message-State: AOJu0YxAT5EBB4/jrU1Dw71qBvs0JEU08DyTxlPq53Lz4WrDRTGbimnz ow2Ji9TYopJIG1X/MjEXRpkhpAbKEqoc5TABoIBND3l17kMT9MweHcpbARw20GA81UE= X-Gm-Gg: ATEYQzxvjbkzKQAGOtvAX5RFsHJYZIsg3WEV3YyUtayot3PST5I2HxpFCHhPL5/n1Fw 2eBOraN7wmemRREkEOpzuVM5AXB1fyGd14dLV0bnGuVoE86gyF6Fus7fA6IOV5xtcU/s010akmX UgNsrMg1J8xT5zWqSNGnwaTr00+7NFG/isfVx2rnFJobeiXZV7tMizp5icS0sGVQ7maZmX29owO BQZ2b10FWWXadoYGp6tJsJwTHbvcmUNmbGYTPcFk1dvrxP4A0QIGEA8lX1cA65dBShIDNWd3cYF OYvvMbZGWDtVtyeeGDHdG2IGtIDMILfYNr3ZJ83G5bBTK8Z7m7/sfIWwaPnMJSNc/sWk3dN+Z3r U10IGOIbNGGl2lrp/Wo0bthpeuIv0jpoenuR0+Gp9dScFFvfvbCKH3BBVPT1cMjVvoF5y3qcCR6 vrv9SQrhJfrAE+kl9YWdPfhMRcw0tvl9j4cR7oncq0QjCpy1QXIug5YM3snhstu6PyZoKZ0k4qh 68= X-Received: by 2002:a05:6000:4009:b0:439:b4dc:1e20 with SMTP id ffacd0b85a97d-439b4dc2140mr14752521f8f.50.1772551995515; Tue, 03 Mar 2026 07:33:15 -0800 (PST) Received: from alchark-surface.localdomain (bba-94-59-44-101.alshamil.net.ae. [94.59.44.101]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b55d15besm19799447f8f.30.2026.03.03.07.33.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 07:33:15 -0800 (PST) From: Alexey Charkov Date: Tue, 03 Mar 2026 19:32:52 +0400 Subject: [PATCH 07/11] power: supply: bq257xx: Consistently use indirect get/set helpers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260303-bq25792-v1-7-e6e5e0033458@flipper.net> References: <20260303-bq25792-v1-0-e6e5e0033458@flipper.net> In-Reply-To: <20260303-bq25792-v1-0-e6e5e0033458@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3364; i=alchark@flipper.net; h=from:subject:message-id; bh=rZeSH+p/sWb94+YtWuBoX7zwjk1MlkPbjBLWjAkhzPY=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWQu+69mqXngfuiPb/FH0y/uX75w/RRvA75267Ovm1vbu rawHXm4r2MiC4MYF4OlmCLL3G9LbKca8c3a5eHxFWYOKxPIEGmRBgYgYGHgy03MKzXSMdIz1TbU MzTUMdYxYuDiFICp3v2L4b+38RUfhkfpP3tabvRuDxS58S7I29fUwPVH7OOvpmou1S8YGS4uvB1 tsULRr2hy6OxS11Xbp2uyK8+0b9qy8qzi9wVmnXwA X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Move the remaining get/set helper functions to indirect calls via the per-chip bq257xx_chip_info struct. This improves the consistency of the code and prepares the driver to support multiple chip variants with different register layouts and bit definitions. Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index e14dd16f9d08..deb60a9bd222 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -30,9 +30,15 @@ struct bq257xx_chip_info { int (*bq257xx_hw_init)(struct bq257xx_chg *pdata); void (*bq257xx_hw_shutdown)(struct bq257xx_chg *pdata); int (*bq257xx_get_state)(struct bq257xx_chg *pdata); + int (*bq257xx_get_ichg)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_ichg)(struct bq257xx_chg *pdata, int ichg); + int (*bq257xx_get_vbatreg)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_vbatreg)(struct bq257xx_chg *pdata, int vbatreg); + int (*bq257xx_get_iindpm)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_iindpm)(struct bq257xx_chg *pdata, int iindpm); + int (*bq257xx_get_cur)(struct bq257xx_chg *pdata, int *intval); + int (*bq257xx_get_vbat)(struct bq257xx_chg *pdata, int *intval); + int (*bq257xx_get_min_vsys)(struct bq257xx_chg *pdata, int *intval); }; =20 /** @@ -489,22 +495,22 @@ static int bq257xx_get_charger_property(struct power_= supply *psy, break; =20 case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT: - return bq25703_get_iindpm(pdata, &val->intval); + return pdata->chip->bq257xx_get_iindpm(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX: - return bq25703_get_chrg_volt(pdata, &val->intval); + return pdata->chip->bq257xx_get_vbatreg(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CURRENT_NOW: - return bq25703_get_cur(pdata, &val->intval); + return pdata->chip->bq257xx_get_cur(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_VOLTAGE_NOW: - return bq25703_get_vbat(pdata, &val->intval); + return pdata->chip->bq257xx_get_vbat(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX: - return bq25703_get_ichg_cur(pdata, &val->intval); + return pdata->chip->bq257xx_get_ichg(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_VOLTAGE_MIN: - return bq25703_get_min_vsys(pdata, &val->intval); + return pdata->chip->bq257xx_get_min_vsys(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_USB_TYPE: val->intval =3D pdata->usb_type; @@ -632,9 +638,15 @@ static const struct bq257xx_chip_info bq25703_chip_inf= o =3D { .bq257xx_hw_init =3D &bq25703_hw_init, .bq257xx_hw_shutdown =3D &bq25703_hw_shutdown, .bq257xx_get_state =3D &bq25703_get_state, + .bq257xx_get_ichg =3D &bq25703_get_ichg_cur, .bq257xx_set_ichg =3D &bq25703_set_ichg_cur, + .bq257xx_get_vbatreg =3D &bq25703_get_chrg_volt, .bq257xx_set_vbatreg =3D &bq25703_set_chrg_volt, + .bq257xx_get_iindpm =3D &bq25703_get_iindpm, .bq257xx_set_iindpm =3D &bq25703_set_iindpm, + .bq257xx_get_cur =3D &bq25703_get_cur, + .bq257xx_get_vbat =3D &bq25703_get_vbat, + .bq257xx_get_min_vsys =3D &bq25703_get_min_vsys, }; =20 /** --=20 2.52.0