From nobody Thu Apr 9 19:19:02 2026 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1913E492519 for ; Tue, 3 Mar 2026 15:33:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772551993; cv=none; b=ckXdhCodLSsSAwUjX/6AfVUO3eJg37FfPwgzRBAub2JrBNhSc8/q9b0JBy2m/kAQwU00yKOEmY5FkGqbHY6JpkyfBEnNL6R8AQkvtrKbUgxB8AtuMB+Us6quQF/0sa7EXbh/TD8/7KoxEyOZpWIKkYWlMjqzfI84+bMvvhKn9O4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772551993; c=relaxed/simple; bh=Q9D7eBKxq86MNvlgm1qDMnqHysA/422W4yV9eBroyC4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QomuSXJcB+ldG8EOja3psSIMZvyGHqBFvXhP/CCrSppavO6IZPrHjtCYMEeNKupfjmFpCaoCqIC+vUiq7dmTpPiK+wuqssxRv9aS7mGBRR4FhC+bDUfcXsIumyjaa3q9o0Igp0cJu42eSGltNCFdTeSPezH4yGTcEqbhIqWk3hE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=R+wGD6+j; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="R+wGD6+j" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-439afc58ac7so2791661f8f.0 for ; Tue, 03 Mar 2026 07:33:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1772551990; x=1773156790; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Sz4biLahYPKsT9J1ufLdEia90vJM1vdO3bq5iy8XGEM=; b=R+wGD6+jlr/0q2tFQ1AgxZsPUTeQvTgKbmBzi2ZlxBvZKtl6RziVZVBinpcyNPxb2V 7LLIImtxaMXHIL5CbfLu2i7SFvq4PCusmafP05rIBvZ3rRnC6Fdtf01NPdEkshYNL/fm FR19vuzD0sDzgRPl3COcFf2P1MiiNl4fYAGn1weLMNpmj/ceF3bRewLUqZ2DvbZmbJlz 4ANhAnOQ+KZNLvQhCCsow7xoEKUWHx+vRVIhxQb1+T6gSqaCOikHSqQmiqRcuI2grg8G QISALlVUH1NNtZIpltdlgfbmnLaENKDYwQ5KueBW0mrFFz/J3uHAli3rEIW0bES7Se7n fJdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772551990; x=1773156790; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Sz4biLahYPKsT9J1ufLdEia90vJM1vdO3bq5iy8XGEM=; b=YHThxSsup0kUvDv0grbPlH256Yhk9t3vhPpxxrQ0paW09+2Lm3yXnEkZI2EwRsl3Q7 BdPNxR4R0pBQGQtCCxcRdfPa6oqfrccw/2dIpaEDAIkxLy+wVXtnfsmSjoABf1g5BosF v5YTuoX7fy1pgnUnv9ZUW/8p3xrW05odu6dVz5LRy3EAw0r+Nzv+lSd+uwgmujPiGqmQ rxuuoaEGajcxSHg1+PhLLlo6OeZmD4KejeAxkjCYG6U8UoUvumPSpocmt1LAzRW+Bb30 zcFPylCbgydcFGggZQspNzu7KNcqtcgNFpozyXfYsRbifU1qNY0+R1fS9iDbRAyKeKg8 gRpA== X-Forwarded-Encrypted: i=1; AJvYcCX+sCr/OWJyjX1pkj2b16v9OX1pz4AiFb959q7k7fRJF6iDhpw9kvggj+Py6fBaUQ2pdifUFNiAVqmYVNE=@vger.kernel.org X-Gm-Message-State: AOJu0YyqQdzKXDFx6XfL8whYOwJvv9qbzS2ahxBksFugbyQ7NDqP89nh MdqDz5nqW1o8t3JVY294G8UWPeWrGGIMXcWIS0i85/QR2UGNiZoFwPCnANQdhNDtjcw= X-Gm-Gg: ATEYQzzXlwZ2AaJjt6Htqwe+hUTyu26pbxS0iV9hbEvBf8+TI3iJ1UGI35I6xtpLjR1 +ZciRV1xOfaZBtKgB75xoIyj1KfYCR3Ep6le7sWmw4w6QdSy63BURPjdQjqmQaCiLFjk5jk4MZa 2ng/wco0oUFUQCxj7SJQVlYMQ0r1zRNoVKIjSzWS3D20n6OKl7sIPYaSpulhrJnvT2ZUdUWdyrH VbZaSPOFpo1Rd9okNuRRPWuSA5K+1xmOVtFaZK67e5aF82XtJMDoOcRWpkrWL3Cp3+hLiMWXDCs LlYZ8q3SYLXW3VriXBzPZYWexD1i9G+UJjLXUJ7uMuvHzSv9prc/C2nu4OEi7IaB0/969gBEeEK tVWc8nBXJSlZEgOz6hd8Rq7O/7uPIw6gAYl3bZW9Hbwcs548ylulzJrzmUgInLbPbOItIVvQZZP CUkHRfx5EzpOIgwjFCKyfQRnSkgJ6PdmF35B19IUiWqyNuqxndTBTYc770ZHdvtSpS+RsrzQN29 u0= X-Received: by 2002:a05:6000:1847:b0:439:b6d6:728 with SMTP id ffacd0b85a97d-439b6d60a8bmr14024221f8f.58.1772551990320; Tue, 03 Mar 2026 07:33:10 -0800 (PST) Received: from alchark-surface.localdomain (bba-94-59-44-101.alshamil.net.ae. [94.59.44.101]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b55d15besm19799447f8f.30.2026.03.03.07.33.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 07:33:10 -0800 (PST) From: Alexey Charkov Date: Tue, 03 Mar 2026 19:32:50 +0400 Subject: [PATCH 05/11] power: supply: bq257xx: Fix VSYSMIN clamping logic Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260303-bq25792-v1-5-e6e5e0033458@flipper.net> References: <20260303-bq25792-v1-0-e6e5e0033458@flipper.net> In-Reply-To: <20260303-bq25792-v1-0-e6e5e0033458@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov , stable@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1911; i=alchark@flipper.net; h=from:subject:message-id; bh=Q9D7eBKxq86MNvlgm1qDMnqHysA/422W4yV9eBroyC4=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWQu+6927vSyU6pnYy6ZvRLuM2vfKCc+Y4+B7pY9/Zvv+ CcrxL3Q7ZjIwiDGxWAppsgy99sS26lGfLN2eXh8hZnDygQyRFqkgQEIWBj4chPzSo10jPRMtQ31 DA11jHWMGLg4BWCqeV0ZGXbrrJ3AIPAw0E9vWZjBDK/ck/c53F9M/6i3n7+xh4fT6BzDX2GdwCs 9D+T35Xgd+rR3z/RTC2Ywun848zzsjb/brNlTGrkB X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The minimal system voltage (VSYSMIN) is meant to protect the battery from dangerous over-discharge. When the device tree provides a value for the minimum design voltage of the battery, the user should not be allowed to set a lower VSYSMIN, as that would defeat the purpose of this protection. Flip the clamping logic when setting VSYSMIN to ensure that battery design voltage is respected. Cc: stable@vger.kernel.org Fixes: 1cc017b7f9c7 ("power: supply: bq257xx: Add support for BQ257XX charg= er") Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 02c7d8b61e82..7ca4ae610902 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -128,9 +128,8 @@ static int bq25703_get_min_vsys(struct bq257xx_chg *pda= ta, int *intval) * @vsys: voltage value to set in uV. * * This function takes a requested minimum system voltage value, clamps - * it between the minimum supported value by the charger and a user - * defined minimum system value, and then writes the value to the - * appropriate register. + * it between the user defined minimum system value and the maximum suppor= ted + * value by the charger, and then writes the value to the appropriate regi= ster. * * Return: Returns 0 on success or error if an error occurs. */ @@ -139,7 +138,7 @@ static int bq25703_set_min_vsys(struct bq257xx_chg *pda= ta, int vsys) unsigned int reg; int vsys_min =3D pdata->vsys_min; =20 - vsys =3D clamp(vsys, BQ25703_MINVSYS_MIN_UV, vsys_min); + vsys =3D clamp(vsys, vsys_min, BQ25703_MINVSYS_MAX_UV); reg =3D ((vsys - BQ25703_MINVSYS_MIN_UV) / BQ25703_MINVSYS_STEP_UV); reg =3D FIELD_PREP(BQ25703_MINVSYS_MASK, reg); =20 --=20 2.52.0