From nobody Tue Mar 3 05:05:26 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2711431AF31 for ; Mon, 2 Mar 2026 23:02:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772492528; cv=none; b=WqJUxANdD1enDpCG6yaondrd3dvsO9qDKbznz3LwdgJ2cOt29OMa2Qkd79OXNwaJhZFnPEG0LiykE70IAkkZJZFgo/+bCjTU2ty8tT4ZuBXJBYuYnCYU0OivISO3JyGmVa29u0KzNMAJgyljANgL34Ol8sbQi0XC42V7bzf92TQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772492528; c=relaxed/simple; bh=1zAr0Zf85PBf7/Rh8qavxPEJLsNQewWny61GtNvPRxI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ac0jCmYrF0JzAgQqFMKHITIBnXlg2mPQC+/FeKAVUB7KOhG0xbaCnoilvJJaZdQJRIqcNFIrZlAwyx80xGbSycUgdK9y3HFrIepQoJ5+qjMo0lumrjb7WJoqhF6Z4sW3AkI9kHbBMSfMePyQCW2IKa0Ctup1RXUsZbIN8vb42/E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hLNIpElk; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hLNIpElk" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-48373a4bca3so30423415e9.0 for ; Mon, 02 Mar 2026 15:02:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772492525; x=1773097325; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=38elZ9Mqi1kIyTUdjlGj0GQti9oP3Rth6xiqlYhvdME=; b=hLNIpElk1AV5fAq9G2Q7vc9Rk1jB7Y/mH/ndfCov/FjPFj6h0HOCkXS8VtvijqVAXo AS55X4Tvmfc9hxpNmADnCbFZh3bMXa3ZAHEkJBfn0zwh1XboBF+YYrqquVcmd9JKzT1C fFWmVxjcqZmRoZDP5wEQMWDJFumO+IsfYJOh8FVlwUeq2ZOGlq52F/IIy1cp/gQRqgRZ dv15DmBM7cFzipunSg8iIgLXx2XfUqGtZXQuU753Hh4Slg6RqBHqEcpIRmG+zsqTgZmN ET9OFChmzmyD6LWZN7un9UXxzP9ydXLSofiTpfxdb7mxH730a8dOlxlh/95HNmwbOEuR 6Rsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772492525; x=1773097325; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=38elZ9Mqi1kIyTUdjlGj0GQti9oP3Rth6xiqlYhvdME=; b=GOBX3pHK8CG+3w22vz9BHfXwlmzBRTBrGex6uQee8V9huiXl8DSPvfoSnZR5uy/nLa GcfSf17J/fG9DV7ggCDlaxrF/9EsgoxwCDcjp5i6rNQl39/k1zpLnHT1VRps6XWIN8ro EzfsRRs0FWxEv7YhsAIoFzgt+X5gGoZzsVCjF0g9fKI8TsfBXy5fq5nwrmoqZbcYbJMR vKUNYmiwPvqfahMAoSbgXk09NXp/gF0TvCzso5jmSlyFnvzooGzBZxWuT4DzZxN5SncW cT5ZBNrqwYFPVTktXA9fbhfHhkepcF0wVQAgp1mjRZg0/edA27jUQjcW+FEWJiNygfCq Z9+g== X-Forwarded-Encrypted: i=1; AJvYcCWXwcIqV5wcfxkJ2NjARKfKiMPBfoGuwCwfhvlt2r0eJQ/wxujYDlH8n7gH5YqHRFzSEjEhYM/KljgYY0U=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1Gcl4kAGiEr5n5H5JoRFL1Vdqodxc8lOyfeB6Lo9n1MF+2sEN WROhC2prlpcccaA7v9L5lLvgFb0QqewoVHfnX3fgLqv484EntrVZ8b5q X-Gm-Gg: ATEYQzx3JgI3b/PSwhYH+hqdu/4kajTkBYHuw90l2C8+Qj0BtMoNjO74z0ZfcM2KiQj 57Mdf4elsnyJqjdiHS0MHMm1XU1PWMx2/wkl+BZqnaF23KoM6Fd/Ph0Ew0Vj9RMtTS04TtJ5qAO aIJlEAWnyOWxyszsFhKJm+ZYXQLYyn57ciFwZLOtOw8q30pmvKrwBx6dDv493dnq7RHIzhNDrPa 9b0QEJuY/zcE5BBQawhBhYnlhKHIuH4wcmvSPXIpETbW17c3gg1WNIGiSeq67aW10HqkE/HKY3L EoFbFkw7zlxvUSXYJZ77q4aEF1N3Vxe57pwashnYoOhAGm874+32kPLcUjCQIihVCVuIh0iOMVe USTpwu2QGStvCMJqi/J9w94+U8TzySNvmA4SKxEzhLQP3d1p8WLXqw9WgB+DD67tUGW0Edv1QuJ rJF4IlIOzyF6qiuIwq/zux X-Received: by 2002:a05:600c:6217:b0:476:d494:41d2 with SMTP id 5b1f17b1804b1-483c9bc5c06mr239092445e9.29.1772492525302; Mon, 02 Mar 2026 15:02:05 -0800 (PST) Received: from localhost ([2a03:2880:31ff:58::]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd7031f3sm390474325e9.6.2026.03.02.15.02.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 15:02:04 -0800 (PST) From: Mohsin Bashir To: netdev@vger.kernel.org Cc: alexanderduyck@fb.com, alok.a.tiwari@oracle.com, andrew+netdev@lunn.ch, andrew@lunn.ch, davem@davemloft.net, dg573847474@gmail.com, donald.hunter@gmail.com, edumazet@google.com, gal@nvidia.com, horms@kernel.org, idosch@nvidia.com, jacob.e.keller@intel.com, kernel-team@meta.com, kory.maincent@bootlin.com, kuba@kernel.org, lee@trager.us, leon@kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux@armlinux.org.uk, mbloch@nvidia.com, mike.marciniszyn@gmail.com, mohsin.bashr@gmail.com, o.rempel@pengutronix.de, pabeni@redhat.com, saeedm@nvidia.com, tariqt@nvidia.com, vadim.fedorenko@linux.dev Subject: [net-next V4 4/5] eth: fbnic: Fetch TX pause storm stats Date: Mon, 2 Mar 2026 15:01:48 -0800 Message-ID: <20260302230149.1580195-5-mohsin.bashr@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260302230149.1580195-1-mohsin.bashr@gmail.com> References: <20260302230149.1580195-1-mohsin.bashr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" With pause storm protection in place, track the occurrence of pause storm events. Since there is a one-to-one mapping between pause storm interrupts and events, use the interrupt count to track this metric. ./ethtool -I -a eth0 Pause parameters for eth0: Autonegotiate: off RX: off TX: on Statistics: tx_pause_frames: 759657 rx_pause_frames: 0 tx_pause_storm_events: 219 Signed-off-by: Jakub Kicinski Signed-off-by: Mohsin Bashir --- drivers/net/ethernet/meta/fbnic/fbnic_csr.h | 1 + drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c | 3 +++ drivers/net/ethernet/meta/fbnic/fbnic_hw_stats.h | 1 + drivers/net/ethernet/meta/fbnic/fbnic_mac.c | 15 +++++++++++++++ 4 files changed, 20 insertions(+) diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_csr.h b/drivers/net/ethe= rnet/meta/fbnic/fbnic_csr.h index e68c56237b61..72eb22a52572 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_csr.h +++ b/drivers/net/ethernet/meta/fbnic/fbnic_csr.h @@ -627,6 +627,7 @@ enum { FBNIC_RXB_ENQUEUE_INDICES =3D 4 }; =20 +#define FBNIC_RXB_INTR_PS_COUNT(n) (0x080e9 + (n)) /* 0x203a4 + 4*n */ #define FBNIC_RXB_DRBO_FRM_CNT_SRC(n) (0x080f9 + (n)) /* 0x203e4 + 4*n */ #define FBNIC_RXB_DRBO_BYTE_CNT_SRC_L(n) \ (0x080fd + (n)) /* 0x203f4 + 4*n */ diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c b/drivers/net/= ethernet/meta/fbnic/fbnic_ethtool.c index ade9e667640f..70c995b8d1bd 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c @@ -1754,6 +1754,7 @@ fbnic_get_pause_stats(struct net_device *netdev, struct fbnic_net *fbn =3D netdev_priv(netdev); struct fbnic_mac_stats *mac_stats; struct fbnic_dev *fbd =3D fbn->fbd; + u64 tx_ps_events; =20 mac_stats =3D &fbd->hw_stats.mac; =20 @@ -1761,6 +1762,8 @@ fbnic_get_pause_stats(struct net_device *netdev, =20 pause_stats->tx_pause_frames =3D mac_stats->pause.tx_pause_frames.value; pause_stats->rx_pause_frames =3D mac_stats->pause.rx_pause_frames.value; + tx_ps_events =3D mac_stats->pause.tx_pause_storm_events.value; + pause_stats->tx_pause_storm_events =3D tx_ps_events; } =20 static void diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_hw_stats.h b/drivers/net= /ethernet/meta/fbnic/fbnic_hw_stats.h index aa3f429a9aed..caea4be46762 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_hw_stats.h +++ b/drivers/net/ethernet/meta/fbnic/fbnic_hw_stats.h @@ -54,6 +54,7 @@ struct fbnic_rmon_stats { struct fbnic_pause_stats { struct fbnic_stat_counter tx_pause_frames; struct fbnic_stat_counter rx_pause_frames; + struct fbnic_stat_counter tx_pause_storm_events; }; =20 struct fbnic_eth_mac_stats { diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_mac.c b/drivers/net/ethe= rnet/meta/fbnic/fbnic_mac.c index 805107ba3b10..53b7a938b4c2 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_mac.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_mac.c @@ -418,6 +418,18 @@ static void __fbnic_mac_stat_rd64(struct fbnic_dev *fb= d, bool reset, u32 reg, stat->reported =3D true; } =20 +static void fbnic_mac_stat_rd32(struct fbnic_dev *fbd, bool reset, u32 reg, + struct fbnic_stat_counter *stat) +{ + u32 new_reg_value; + + new_reg_value =3D rd32(fbd, reg); + if (!reset) + stat->value +=3D new_reg_value - stat->u.old_reg_value_32; + stat->u.old_reg_value_32 =3D new_reg_value; + stat->reported =3D true; +} + #define fbnic_mac_stat_rd64(fbd, reset, __stat, __CSR) \ __fbnic_mac_stat_rd64(fbd, reset, FBNIC_##__CSR##_L, &(__stat)) =20 @@ -812,6 +824,9 @@ fbnic_mac_get_pause_stats(struct fbnic_dev *fbd, bool r= eset, MAC_STAT_TX_XOFF_STB); fbnic_mac_stat_rd64(fbd, reset, pause_stats->rx_pause_frames, MAC_STAT_RX_XOFF_STB); + fbnic_mac_stat_rd32(fbd, reset, + FBNIC_RXB_INTR_PS_COUNT(FBNIC_RXB_INTF_NET), + &pause_stats->tx_pause_storm_events); } =20 static void --=20 2.47.3