From nobody Tue Mar 3 05:10:21 2026 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9269E382364 for ; Mon, 2 Mar 2026 21:34:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772487276; cv=none; b=IV2bJXHfg/pBz6GWz0uXLoN9N6s7lBEnYsIj7xNCtJIIZkC5cS8AeK1RylwaU7KeaqD7D6/i4gSvdCw8RlUNB7HN7LPMqWgHOd8fqesNY6SrjetcBNwWee3JMY9v8ieW/o8VcgybGpP2iBGkj3fzSO2+z+L90Youhwr5KrpArIQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772487276; c=relaxed/simple; bh=VTv6p9V1KuY3NuOQ/g19x6YUh6QjpeorFmtw98a94Do=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Qu6nE7j6jIRNX7Xoem7NsaOxlfLKuKk2TnEv7rjrPBR/ikA2cDvXWrV2J7F5SSBZFVWnk79nc2spbmbCl19+QEpno3x6YvUX4ReFHrahPfDALEhbotkNoMU2R2F05W+6yy8V/4Mrnk4Bjjqjc+9nKqfrUaiAGHuh2Gpy/BCvWuI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F4TeNGza; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F4TeNGza" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-2be1ab1fa7dso594750eec.0 for ; Mon, 02 Mar 2026 13:34:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772487275; x=1773092075; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dex6BTSk/FD4IJdE9hg782BTunzN70oc+BYZl89/r7o=; b=F4TeNGzaP+0QRL5KFTTu8RSVBaeFeELUm9vGR+zBmAiw3ntAgPpG4C3L7GhI8eIOIu hOf4EYMHZGlr+3VRRYqV6P2+aKgv6yjJwD3/gAu/5cUb9v7lmA7iOjJRVHANrKVgQV6l Ln9sdjor9qOIlwhp230/iEhntiOcMEBFgb3KqFoGKZD/fDskKxZjQ++clvSoDMQb5fuE o0zCBcdk4PgsFO5bgwK1eauGIL4N2ZZi/yyLDUEskK/fSMLPMkPgbCA8dpqShrVS6yK+ St0xz4EBbhGvkFI2IaXA9HxTRNOzV85zPiy/IVrcy4k1lQiTVuBCXUlGZmaW7uHykc2p ATeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772487275; x=1773092075; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dex6BTSk/FD4IJdE9hg782BTunzN70oc+BYZl89/r7o=; b=NVGhBMTgojduira0QhgPXPdrSctq0tJBdOFk+GRcBxOgnLJYjP/fSi/qAxw6OGPnRq hAuZVH+nnX+5n32JPjgQpHBwv04VtXXT90XIh3DjyliaBDwA6a/DEg5jWKMNgVJ/Nbhp YqeH5T2qUe8EOGxHbC8REBEz74gTcw1gKCkGujnOqRwGKkKeaQ5Vph+MWczC1qu3T0UF Di8y9rDFuN3k+91xt50Ba3Bp+GIzYZmDC1ofpHvztdQX6y3DhJSnV+m96LWFP/ZLFlTB WHcTtK5N/0nNpfQrUTRbY+vqnfaew4uOb9GZFZFwhCg4reDMDY9GHqx03FgkK1neCM66 GYqg== X-Forwarded-Encrypted: i=1; AJvYcCUuuAsAxFmXPwKAluqjr+D23a1iOntPmqatJfue+dqErO0gu0XEbNyj1MoNF/s4BXXjWNTQZcf5TCeymBA=@vger.kernel.org X-Gm-Message-State: AOJu0YwfmkqWNXzowCnoTuq2e29s547LG1svhexpzykB8BZookkthaQS mQ7nLxsk5aJX+SH6LKUhTsiEQp1HC8sgX2DDRK47VllImrk/nDugSU/O X-Gm-Gg: ATEYQzz07umXVwP3NZDlcs8ZTnecftSVMmT/2ZIYGpNnlW41fdTNDU53U//FUQT7VEt ZA65VuQNbAOir5KWhcPKYjsZwsKzzQfoxkgAoonsf5NwR0F6bl+8B+OcdYZJ+XblLNX3ZbC+83C X7cfGv7M+d2DPvWFJOA+ZNxDLOedZNznnn45NIuNTkXATfuIGTE8Dx+RKMjoYIUKFP/DVZpF90s m2EjDXl7NKYHZAD4BbOzoEtUeXIqlmT5SmoSHJTdbf4jhWQOAWWyzIZ496dmSFEFtK/wc5Ez+GZ kfei0YR8VFITIBEDzG2A0VyGaV6cRSkQLSH3qGBcARg2qt70fTFINU3XT5bafYhblsM/nwHFgVs +YvUjofeIG+YWQ4wExPKprfJuKYoq/3SPRAu9vcnikkBC9+CAewzc0Ht+e8+SeTqhcD3xi3Za5g RwdF2q+ow7pls8upEWIFT4VoQLxkQCWo+8diREEd/aO6xVj2rzcd11WT1xIFR+lecIbIEQn05kl PU626/ODaC061MO6baEdei7SK7rY+9WjRulN6nVfs1LVBHdelR2VOetSLS4x88BuLNBgrX1al9W aQx5SXLPi2elUjGBVRLnCnIOdNPadd5d70G7bSA= X-Received: by 2002:a05:7022:4381:b0:11a:51f9:daf with SMTP id a92af1059eb24-1278fc56a82mr7378968c88.14.1772487274540; Mon, 02 Mar 2026 13:34:34 -0800 (PST) Received: from arch.lan (c-98-51-119-100.hsd1.ca.comcast.net. [98.51.119.100]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12789a52ab0sm20032605c88.15.2026.03.02.13.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 13:34:34 -0800 (PST) From: Milos Nikic To: jack@suse.cz Cc: tytso@mit.edu, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Milos Nikic , Zhang Yi Subject: [PATCH v2 1/2] jbd2: gracefully abort instead of panicking on unlocked buffer Date: Mon, 2 Mar 2026 13:34:24 -0800 Message-ID: <20260302213425.273187-2-nikic.milos@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260302213425.273187-1-nikic.milos@gmail.com> References: <20260302213425.273187-1-nikic.milos@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In jbd2_journal_get_create_access(), if the caller passes an unlocked buffer, the code currently triggers a fatal J_ASSERT. While an unlocked buffer here is a clear API violation and a bug in the caller, crashing the entire system is an overly severe response. It brings down the whole machine for a localized filesystem inconsistency. Replace the J_ASSERT with a WARN_ON_ONCE to capture the offending caller's stack trace, and return an error (-EINVAL). This allows the journal to gracefully abort the transaction, protecting data integrity without causing a kernel panic. Signed-off-by: Milos Nikic Reviewed-by: Zhang Yi Reviewed-by: Jan Kara --- fs/jbd2/transaction.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c index dca4b5d8aaaa..04d17a5f2a82 100644 --- a/fs/jbd2/transaction.c +++ b/fs/jbd2/transaction.c @@ -1302,7 +1302,12 @@ int jbd2_journal_get_create_access(handle_t *handle,= struct buffer_head *bh) goto out; } =20 - J_ASSERT_JH(jh, buffer_locked(jh2bh(jh))); + if (WARN_ON_ONCE(!buffer_locked(jh2bh(jh)))) { + err =3D -EINVAL; + spin_unlock(&jh->b_state_lock); + jbd2_journal_abort(journal, err); + goto out; + } =20 if (jh->b_transaction =3D=3D NULL) { /* --=20 2.53.0