From nobody Tue Mar 3 03:24:07 2026 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0975B2BE057 for ; Mon, 2 Mar 2026 20:04:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772481876; cv=none; b=MAlWNZBL6AjHEFKR3lhXeQ8brBTp/mY8bnnBNBNW8+kZOVE3zQB+JEFl8JyFRtcrCGCor9rLuDOSRAqpZlbCI8SKE6cMezB98/EZ0UAuO//QFUnFYhi0aDIh+t4kZbjYFjj//wj6idusFQ1Mw95ysNJoBTlyoindRMvRcKACw0c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772481876; c=relaxed/simple; bh=utvSQT+CD876dWtO/rYeq0KvioAFMUKDbiWIBTyjCJI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TAX7eqqgR9OZkAVvoBfda4OBdKFoFejkHfw+mvS8klPBqvvh3jLHe5klVsqBMv5G7xmun5MoRHbEGwzTfGnY84onguHIhHoxnhgc532OdyjcOXUhmTuyDrFFwp4s2lFgL+LaFZ3cZ51XLEHHMTHyz2s036VeZYv5J7SVWl4bygA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=ua6Tp8zN; arc=none smtp.client-ip=209.85.160.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="ua6Tp8zN" Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-506aa68065eso47616881cf.1 for ; Mon, 02 Mar 2026 12:04:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1772481874; x=1773086674; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/DwHuUppa6SUbjaq5sts8sylTJtYfwzEq1GPQR1viLM=; b=ua6Tp8zN8afYajBVTkhJMd9GOwokzgJ1+jPSqx3QRC/EntMWbJl7oA2+UWRFwKCrwO ZTGyS7sX9smsv61syDnKyqMPg+dzD/MSXSXKuZM+cn2Q0G9m/Zqwb7tYOV09pL2ELSD3 pUF4tczTp6s+V3kbDsDoJwV88Vb5zE42K3ePwg+dSOKABhHuGZHhDxaeLzf/aOifavxr 66Vryfd0L29Mg0hmz9UEUXKwojdwzBKQ7VGYxNOUF/uBO4zq6WtgHACtRT44I2o4JiMf X4twmEnHKXR+8F1eI76fUueb8o1lMK3qMwRebm8SXpx/9p0I/NLI+bRD3T2SOcm7SPE0 WMxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772481874; x=1773086674; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/DwHuUppa6SUbjaq5sts8sylTJtYfwzEq1GPQR1viLM=; b=ZBN35w0G+LZ5nUrY0gMElNB3E4OJ2CGG8+Eap31D93kajTu1uOx49kRvUfTQQpzzxG k3oq7qrwGkcICtNbg8cyPHMay6H4BTfpU9VRowd7695D3MyBixeuduuh+Mjf53mtfmf1 nWXbpJFzOU/NfROM0iqqHid86SUnN1R/boQ2YRfkdB2j+tKpgtbd8v3Lu1TeqA7f22rK KFXvYL+fpFdLBC4euIq2KDd4jk2Obn0l3rsMOSNmg5VLLCukiqKNkh9YHhkRVXCzX/FP tW72HJj5l3piezS+Syw9drCNOpVMaKx45b50+JyDTmJM9L/dpuRHAYkd5eZAnqlL2Gcn gt9w== X-Gm-Message-State: AOJu0Yx/VCkNzICB5rMR3PWJ0pC7q6p4oenzTSt0w0NU4eqBODBbJSnU 15JoaA1jvOA3HxCB8dR8PFF/RpGJJHA+f3WDXzWEh0QfcOW9R6V+FTsz4tKNq7XS8Ic= X-Gm-Gg: ATEYQzyHo3ylL9oPeACF628/GsefdU7YBKgZ09WOHTn+L8hv1f0/aK6/z7jIo5CSVxJ 3xOqOVYd+ShztBInEbW3xHSQaf/MoYoPtt6B/+AE20y/NOPmB8ykw/LE78cS1BVj5yRc6Fa3qQn MZeoEbnd6mDv+04QnfnwUraRSGIGXehkx0XTBikn1eJpeBZBiL3tsycYqWoG1nDNmquBKgaWM5b WrZz7qNqPGd9QPguwzuKLKT+NrbUbWVyWUy+/rzz+YHb2pLvxPOktHNtSK17YkAnBJgsLonwnJG qPoAHvgsWYpBtw6lP2s754fUNG0cPMlVy0Kbm4c3mNYxD3WKokcPgpLpaOmxdxZaZwhL1aoNIbT gScDbcfhUx42StuHaYV/MqWYA8Y7Hpka7k4SwNpnuAPgPO0mLhV+1mq8/X2O8WC743SpUBelJf1 9ZzZIHd1EC8SOw2Q/Jn2SBIG8PyhLFVF1euyhhAISNxNXtneySvLGlvKJoQbsL0TzSDbK8Pkemg j0blRiLF7jw8o88TfQdB1mqcg== X-Received: by 2002:a05:622a:1387:b0:4f4:e6b7:df20 with SMTP id d75a77b69052e-507528deb18mr192396701cf.32.1772481873860; Mon, 02 Mar 2026 12:04:33 -0800 (PST) Received: from gourry-fedora-PF4VCD3F.lan (pool-96-255-20-138.washdc.ftas.verizon.net. [96.255.20.138]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-899ebb09772sm52419146d6.12.2026.03.02.12.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 12:04:33 -0800 (PST) From: Gregory Price To: linux-cxl@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, dan.j.williams@intel.com Subject: [PATCH] cxl/acpi: fix CXL_ACPI=y + CXL_PMEM=m link failure Date: Mon, 2 Mar 2026 15:04:29 -0500 Message-ID: <20260302200429.803417-1-gourry@gourry.net> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit e7e222ad73d9 ("cxl: Move devm_cxl_add_nvdimm_bridge() to cxl_pmem.ko") moved devm_cxl_add_nvdimm_bridge() from cxl_core into cxl_pmem, creating a symbol dependency from cxl_acpi to cxl_pmem. When CXL_ACPI=3Dy and CXL_PMEM=3Dm, the built-in cxl_acpi attempts to link against a non-built-in cxl_pmem, which the linker cannot resolve. CXL_PMEM depends on LIBNVDIMM, so LIBNVDIMM=3Dm constrains CXL_PMEM to at most =3Dm. Change IS_ENABLED() to IS_REACHABLE(), which returns false when a built-in caller references a modular target, preventing the link error. The result is if the pmem/nvdimm symbols are not reachable at build time, then at runtime it will always return -ENODEV. Fixes: e7e222ad73d9 ("cxl: Move devm_cxl_add_nvdimm_bridge() to cxl_pmem.ko= ") Signed-off-by: Gregory Price --- drivers/cxl/acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c index 127537628817..7065413eda9f 100644 --- a/drivers/cxl/acpi.c +++ b/drivers/cxl/acpi.c @@ -952,7 +952,7 @@ static int cxl_acpi_probe(struct platform_device *pdev) if (rc < 0) return rc; =20 - if (IS_ENABLED(CONFIG_CXL_PMEM)) + if (IS_REACHABLE(CONFIG_CXL_PMEM)) rc =3D device_for_each_child(&root_port->dev, root_port, add_root_nvdimm_bridge); if (rc < 0) --=20 2.53.0