From nobody Thu Apr 2 20:28:05 2026 Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 292D64266AF for ; Mon, 2 Mar 2026 17:44:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772473487; cv=none; b=Dezzqqujx3VCLhg9e/G0Y3X9ZUv4ckWnpG3vSukdHxNXwNBsi3UlvFEPcU2+GVHdTTxryD5uOv3+ulg6bZDLicOty0O/jG1HwsuvlTlBoen7CoFsqR2t2LHtKQXcWhrlckLW51uI1wmcjklA8jufvjVoGmZ4o1px0+oBFV2d5m0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772473487; c=relaxed/simple; bh=y5qEG/+/6It2T4A1pcBf/sFhTz5T+iolclq51Ufqb0s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D2P/1jWWi/bH9ltPosXn+iijvpVYoB6m4NfHEX9QVS4/p8OFLDXHodxRSEp9DH5uARBAHgT+vYv9gmLSn9A756JITvXHYXNHg7q2DH4YSM22COnj6CjT6P3kV/E6KMmc9ng8052D2RKjRHD8yr/OMg7xIcPR5B18i0GMKgviduA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=UXEqG0Xl; arc=none smtp.client-ip=95.215.58.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="UXEqG0Xl" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1772473484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bbx5Ke9Aq9lZyiv0R/6JM7JwEg3U+66HaEJL2A8Ih/Q=; b=UXEqG0XlKlyU8KSEoi2a7eGVm/1IXVL0yxF61ad4SDv7w8bU4zvSD51RMMlSvleg9UT52J rbekMVMQq5VbazkkvyAHvIjZZfJvfrK08vEjXpNMKZPmtnemTPcGqxvGpBVQO5q1srzw53 uQg5cAKxYDevWdRLs5+mWfWOkXEfRtg= From: Denis Benato To: linux-kernel@vger.kernel.org Cc: platform-driver-x86@vger.kernel.org, "Hans de Goede" , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , "Luke D . Jones" , "Mateusz Schyboll" , "Denis Benato" , "Denis Benato" Subject: [PATCH v3 1/2] platform/x86: asus-wmi: adjust screenpad power/brightness handling Date: Mon, 2 Mar 2026 18:44:30 +0100 Message-ID: <20260302174431.349816-2-denis.benato@linux.dev> In-Reply-To: <20260302174431.349816-1-denis.benato@linux.dev> References: <20260302174431.349816-1-denis.benato@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Fix illogical screen off control by hardcoding 0 and 1 depending on the requested brightness and also do not rely on the last screenpad power state to issue screen brightness commands. Fixes: 2c97d3e55b70 ("platform/x86: asus-wmi: add support for ASUS screenpa= d") Signed-off-by: Denis Benato Signed-off-by: Luke Jones --- drivers/platform/x86/asus-wmi.c | 34 +++++++++++++-------------------- 1 file changed, 13 insertions(+), 21 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wm= i.c index 7c0915e097ba..8925a0ee26af 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -4419,32 +4419,24 @@ static int read_screenpad_brightness(struct backlig= ht_device *bd) =20 static int update_screenpad_bl_status(struct backlight_device *bd) { - struct asus_wmi *asus =3D bl_get_data(bd); - int power, err =3D 0; - u32 ctrl_param; + u32 ctrl_param =3D bd->props.brightness; + int err =3D 0; =20 - power =3D read_screenpad_backlight_power(asus); - if (power < 0) - return power; + if (ctrl_param >=3D 0 && bd->props.power) { + err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_POWER, 1, NULL); + if (err < 0) + return err; =20 - if (bd->props.power !=3D power) { - if (power !=3D BACKLIGHT_POWER_ON) { - /* Only brightness > 0 can power it back on */ - ctrl_param =3D asus->driver->screenpad_brightness - ASUS_SCREENPAD_BRIG= HT_MIN; - err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_LIGHT, - ctrl_param, NULL); - } else { - err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_POWER, 0, NULL); - } - } else if (power =3D=3D BACKLIGHT_POWER_ON) { - /* Only set brightness if powered on or we get invalid/unsync state */ - ctrl_param =3D bd->props.brightness + ASUS_SCREENPAD_BRIGHT_MIN; err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_LIGHT, ctrl_param= , NULL); + if (err < 0) + return err; } =20 - /* Ensure brightness is stored to turn back on with */ - if (err =3D=3D 0) - asus->driver->screenpad_brightness =3D bd->props.brightness + ASUS_SCREE= NPAD_BRIGHT_MIN; + if (!bd->props.power) { + err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_POWER, 0, NULL); + if (err < 0) + return err; + } =20 return err; } --=20 2.53.0 From nobody Thu Apr 2 20:28:05 2026 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DDF0366DB7 for ; Mon, 2 Mar 2026 17:44:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772473488; cv=none; b=l5BTrZzaUE5Y8lRGnJfVvRCLM2FOYOYRGHb6L2pDkfPMLr72PHfQ0HIo/zGRdpPqKPUuNp/ai4Ifi+VR0S63B573NL6X8MnX9hxjVq6wuQxVOM79RP43b6W29vWYgchxm2lo140L7NC1fybW7VHg0elLKNZson/z77u80ERSDNw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772473488; c=relaxed/simple; bh=1MIPsiRa8Yv9adNUzqXgh8FjwkZk06M73yufRfmTA2s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=A6IkveCDizELVHmYsqsE/pkuWNH1V9USGen1jqZyxkjELS9hFBor0Gp4mWHgiIb0kvuSyAjt8T+xxZMlN2tmSJnCCLigGwdXqBYP86UovvqZQQe9OE3phminSSWLc73VoSAQ4FKCQobPoc10DDw4Rgk0ToBcTMm4Q9bXakgTm4s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=OrR6H2mW; arc=none smtp.client-ip=95.215.58.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="OrR6H2mW" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1772473485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C6JYsOd8TdlbqACv3cEvQ1Kk9syE/nyQz9k47IUD4dU=; b=OrR6H2mWrydhvGBZ8pshN3p207t7Yl/I95Lpv0XrNUNGdR57DDzizxn0f+kM5xBqNJ4xgT n4iPFkg4mCvEDgNz5axBWHSXaUx5tOA7JEyjcLQNGkMerciocKb+kVE5l9iED1Wp9ca7ka oDmFhSc1wxSHDdwwY9+cR0lMB0BrNyc= From: Denis Benato To: linux-kernel@vger.kernel.org Cc: platform-driver-x86@vger.kernel.org, "Hans de Goede" , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , "Luke D . Jones" , "Mateusz Schyboll" , "Denis Benato" , "Denis Benato" Subject: [PATCH v3 2/2] platform/x86: asus-wmi: fix screenpad brightness range Date: Mon, 2 Mar 2026 18:44:31 +0100 Message-ID: <20260302174431.349816-3-denis.benato@linux.dev> In-Reply-To: <20260302174431.349816-1-denis.benato@linux.dev> References: <20260302174431.349816-1-denis.benato@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Fix screenpad brightness range being too limited without reason: testing this patch on a Zenbook Duo showed the hardware minimum not being too low, therefore allow the user to configure the entire range, and expose to userspace the hardware brightness range and value. Fixes: 2c97d3e55b70 ("platform/x86: asus-wmi: add support for ASUS screenpa= d") Signed-off-by: Denis Benato Signed-off-by: Luke Jones --- drivers/platform/x86/asus-wmi.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wm= i.c index 8925a0ee26af..17e2dcaf2b4c 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -125,7 +125,6 @@ module_param(fnlock_default, bool, 0444); #define NVIDIA_TEMP_MIN 75 #define NVIDIA_TEMP_MAX 87 =20 -#define ASUS_SCREENPAD_BRIGHT_MIN 20 #define ASUS_SCREENPAD_BRIGHT_MAX 255 #define ASUS_SCREENPAD_BRIGHT_DEFAULT 60 =20 @@ -4408,13 +4407,13 @@ static int read_screenpad_brightness(struct backlig= ht_device *bd) return err; /* The device brightness can only be read if powered, so return stored */ if (err =3D=3D BACKLIGHT_POWER_OFF) - return asus->driver->screenpad_brightness - ASUS_SCREENPAD_BRIGHT_MIN; + return bd->props.brightness; =20 err =3D asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_SCREENPAD_LIGHT, &retv= al); if (err < 0) return err; =20 - return (retval & ASUS_WMI_DSTS_BRIGHTNESS_MASK) - ASUS_SCREENPAD_BRIGHT_M= IN; + return (retval & ASUS_WMI_DSTS_BRIGHTNESS_MASK); } =20 static int update_screenpad_bl_status(struct backlight_device *bd) @@ -4454,22 +4453,19 @@ static int asus_screenpad_init(struct asus_wmi *asu= s) int err, power; int brightness =3D 0; =20 - power =3D read_screenpad_backlight_power(asus); + power =3D asus_wmi_get_devstate_simple(asus, ASUS_WMI_DEVID_SCREENPAD_POW= ER); if (power < 0) return power; =20 - if (power !=3D BACKLIGHT_POWER_OFF) { + if (power) { err =3D asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_SCREENPAD_LIGHT, &bri= ghtness); if (err < 0) return err; } - /* default to an acceptable min brightness on boot if too low */ - if (brightness < ASUS_SCREENPAD_BRIGHT_MIN) - brightness =3D ASUS_SCREENPAD_BRIGHT_DEFAULT; =20 memset(&props, 0, sizeof(struct backlight_properties)); props.type =3D BACKLIGHT_RAW; /* ensure this bd is last to be picked */ - props.max_brightness =3D ASUS_SCREENPAD_BRIGHT_MAX - ASUS_SCREENPAD_BRIGH= T_MIN; + props.max_brightness =3D ASUS_SCREENPAD_BRIGHT_MAX; bd =3D backlight_device_register("asus_screenpad", &asus->platform_device->dev, asus, &asus_screenpad_bl_ops, &props); @@ -4480,7 +4476,7 @@ static int asus_screenpad_init(struct asus_wmi *asus) =20 asus->screenpad_backlight_device =3D bd; asus->driver->screenpad_brightness =3D brightness; - bd->props.brightness =3D brightness - ASUS_SCREENPAD_BRIGHT_MIN; + bd->props.brightness =3D brightness; bd->props.power =3D power; backlight_update_status(bd); =20 --=20 2.53.0