From nobody Thu Apr 16 05:17:35 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 281383859F8 for ; Mon, 2 Mar 2026 13:41:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772458893; cv=none; b=oxHD/B7j5DVG8Hc8nK2flBmO3/3/Vv+8qIs60LcmSpZW+9a05FEimHC3UWjk5ulxx5iv0YzDgPqQ5iLwFtjlxk5lSJ35UhDBEu10N26JHmB35Omj0WYpjNRV33Pqz5KWPmDwkNaAvEcZfN00lbd7ThZw6ikF8p7PLv4SnoMOphw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772458893; c=relaxed/simple; bh=BeJmXbNjoTu7+hHdqxvNZAqQtEzTchLcnDzAK50yUcY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZINbP+GY7RTJRubJfB+NMhoJM8NzOFYzzxfP+KkFVNuR5MK9Qk7k8L0pvSDCSnolt1BPawwul4AxhQOa+uyrObXyhUfok9m0an+2FPwQQ6cTlI2sqzaDcmSKdwUZsyV4mqvSX7wXuXmhdEtSW4b66XBN6adG+A7luP9gzGgpFJ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kh7RFisp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=L3jGm0hG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kh7RFisp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="L3jGm0hG" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 622CcQ3D2504591 for ; Mon, 2 Mar 2026 13:41:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=3FvuMRTJ9t5Oa3prM87UIj2ZcMgQFfKYy0B Eopqkflc=; b=kh7RFispu0Iu1Fv1+SHRLwEdXJTooXZHWkzTJNjOC2F04tuAY50 fjXDRPg+RwH+WdHTXUqSmgu3FqvewLehBkK2uQGvShNK9dLNm3kLXUqjSa6Q5kz6 H3NsH6jPLAAvW5ENVxOCzBopCvpmN4QfV0D9PFRo464Zaqo8PvwQDYVqiAIi/bn5 0Z786QymS6rQXB2Xh4GofXseLiSKgv3841q3cHXu6bVuTnpKOU38TqmOkW0jz5sw hfDc2mm/eiu1EuWGVvLbMNDxD987SvGoin2DZJf3ER6oUq0c/amlS1o8o4zQr5ow jmqMF4sxqn8FIEgIv9oJRaN9yw4cjNAaRbw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cn5hesevn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 13:41:31 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ae4cdfc468so11623475ad.2 for ; Mon, 02 Mar 2026 05:41:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772458891; x=1773063691; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3FvuMRTJ9t5Oa3prM87UIj2ZcMgQFfKYy0BEopqkflc=; b=L3jGm0hGw4v1rpCWigNk1UWRQGcNm8WQW2ayVNZWZawCW3FJiG/aub1L2Zs3rywYN7 zD+AnR7vJpgvgEI+2NU8XEIqMtGlYyDcE2Q6vopqCFFT0qehIsGulNV4DFUW9vsi2BqI Z7GDXDVjor9bWQ41Pd1jHsvHKGPjNYljVVsuNoiDRN61OHhdkEv+bSCh1zA8Bnp8wUwV Cv11+H8hR90X5Oo94gIRvGix4xFhpf5SeoF+4dDcVYO4UqIYJKcQej/6uQE50Zn8rndW RjDH8ypzHoQxPkbwntyN8tWZHkWRlAytRUIr6UQ1jtC3d0QvPRZtZDY6kMIBgO89NUNY vi+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772458891; x=1773063691; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3FvuMRTJ9t5Oa3prM87UIj2ZcMgQFfKYy0BEopqkflc=; b=SXaNogxPoPkzBe2+QPM28fe6Kw9CV8skN3Qfi+h2Y8hCxpe1aqohwXxlihXSr9Cj3y MNdo/QXItdkDa8WIv2oRY75yJ9Qzxvb5FHQvCWyDJgYeerVUR9DqCCXoE5F1j+xh+XOn X049c5AQolGBbnJ3TwnVBgX67tGaMPJQdP6s1921apGKXn3unoqA3tW33Hh76bpXlZon 9kLYZmmXX7H7YGSHo5xlQX0RnrLVjozDgAAm0ZH0Wd5su2HVszxStR7aMHRKjjTD5SWn h0yH0kLhE3WaoBDFD0LU346J7hz8S0T9gB2XKYNht9LqBDwF0awd4KFEvl7zGDNAQjrd jWmA== X-Forwarded-Encrypted: i=1; AJvYcCUGvCQaBwRJajy5JA7OEbBlhjGRYOrCD1LEwuzRkP9uuz3oxsqtRLVu2vOg179gtN+idLNYIiTxIrI569s=@vger.kernel.org X-Gm-Message-State: AOJu0Yyil3Bf4S0HF5QGEuPaYANDq+izHrCQAR3Lhsww9qoxTG6sJIzy fcZ/Nc1D1eetIm3in7spgNtLPUD8hk31xW313efGbKfpNw0VFetLJmnMDwc41PTNgGZddps9ncX DjYXQS+/U1DzTBGEHpx0aEMtSGS15xtgHMpyYv21uoOYbw9WirHmn1XJMN5zxFb3F1Y0= X-Gm-Gg: ATEYQzxuHF34EI+3TInDsO4yQ6CxFCfZe/izGWEh+2by44+rZ1hzBmxd51WCERLaCJG 5VOdUkLFET/tVlUq9FHE+OdXZr4VHcg6GxN+y5GrRAlGASD4DacveF0GcXTSFE5OLeh1hTBjJsc UuCdwjgwlMDjoI8Ufvtig3y0eZqD4xXHLJMHeZwOYAheOVMQ7WjVUaw23xp0sbUG1C4OeFwuIm2 tW3bEQUhHDv06j7/oO8KSN8dX4zz6JfUBG0FdQO2wg8tutsrIzncNmaOC7jzVqncQCBNPVrn+fz a7vHgTEcUPc0kvifusi3bAdiM63jDr7YsDa1TKUTiizqw55jfovCCe1qnj7k5932m8Y3lnT2VDp 7yODiGqva/khemBG9tWM/Dnr1HJgR4N/OXUon6pX0hg== X-Received: by 2002:a05:6a21:4982:b0:395:d4e4:2bde with SMTP id adf61e73a8af0-395d4e432bdmr6390687637.30.1772458890616; Mon, 02 Mar 2026 05:41:30 -0800 (PST) X-Received: by 2002:a05:6a21:4982:b0:395:d4e4:2bde with SMTP id adf61e73a8af0-395d4e432bdmr6390658637.30.1772458889986; Mon, 02 Mar 2026 05:41:29 -0800 (PST) Received: from work ([2401:4900:88da:227d:c631:5c3c:695f:8a61]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70fa632ddesm12292498a12.13.2026.03.02.05.41.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 05:41:29 -0800 (PST) From: Manivannan Sadhasivam To: mani@kernel.org Cc: qiang.yu@oss.qualcomm.com, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , stable@vger.kernel.org, Loic Poulain Subject: [PATCH] bus: mhi: host: pci_generic: Resume the device before executing mhi_pci_remove() Date: Mon, 2 Mar 2026 19:11:16 +0530 Message-ID: <20260302134116.18960-1-manivannan.sadhasivam@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=BI++bVQG c=1 sm=1 tr=0 ts=69a5938b cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=8Mze1DJ7461ulW_4NyAA:9 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: yoezYH37ecwlumMCnjJNnM7Qgl47kpnm X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDExNCBTYWx0ZWRfXxwzsqe/AfsFz MmfLkYPUXjNaRNj0iGdsridBnjC9Mzo+ziusF6tfI5vuU/655b/X6xklAecZYIpLEqxKlh9Br/G Hz/3oUeW+OlkxB25iw5WyCY/20fEJztFr5cNg4ijrYPJ4H2PTRCjxhP7BsyJ5r7upGX1VMW+BHf lAm121PlUf38UkKzEEU0PFN+4p1DH/ZjF5yWO75ikubcb2SHgOlC7b5bame3UH4TYArOLeUlY2s dvxnMBdn00tpKPr8vsiDUdNK5SuvLV0TEwlgjBZHUKHC6j8jSDzZnz9wM5LzwPHQm4WLbd1SfRH KULATMbvkS+ZamxYCLt0R6UNyykY8qkpxOJPzCtU/M/2RWpdJnfhSzBWpWCWtHX4vt8txOxsO0P kX6ILZpKgTdUfHoJaLhr4IyQk4IgLFn4H+VrYBRiIar3ZfJyp0T+InhBRTZ511ZmogwOLjeIDCI 49UtKuiE5ZbnZkWobXQ== X-Proofpoint-ORIG-GUID: yoezYH37ecwlumMCnjJNnM7Qgl47kpnm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_03,2026-03-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 phishscore=0 spamscore=0 adultscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020114 Content-Type: text/plain; charset="utf-8" mhi_pci_remove() carries out device specific operations that requires the device to be active. But pm_runtime_get_noresume() called at the end of the remove() will not guarantee that. So use pm_runtime_get_sync() and call it at the start of remove(). Cc: # 5.13 Cc: Loic Poulain Fixes: d3800c1dce24 ("bus: mhi: pci_generic: Add support for runtime PM") Signed-off-by: Manivannan Sadhasivam Reviewed-by: Loic Poulain --- drivers/bus/mhi/host/pci_generic.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_= generic.c index 425362037830..fe3aefa15966 100644 --- a/drivers/bus/mhi/host/pci_generic.c +++ b/drivers/bus/mhi/host/pci_generic.c @@ -1440,6 +1440,10 @@ static void mhi_pci_remove(struct pci_dev *pdev) struct mhi_pci_device *mhi_pdev =3D pci_get_drvdata(pdev); struct mhi_controller *mhi_cntrl =3D &mhi_pdev->mhi_cntrl; =20 + /* balancing probe put_noidle */ + if (pci_pme_capable(pdev, PCI_D3hot)) + pm_runtime_get_sync(&pdev->dev); + pci_disable_sriov(pdev); =20 if (pdev->is_physfn) @@ -1451,10 +1455,6 @@ static void mhi_pci_remove(struct pci_dev *pdev) mhi_unprepare_after_power_down(mhi_cntrl); } =20 - /* balancing probe put_noidle */ - if (pci_pme_capable(pdev, PCI_D3hot)) - pm_runtime_get_noresume(&pdev->dev); - if (mhi_pdev->reset_on_remove) mhi_soc_reset(mhi_cntrl); =20 --=20 2.51.0