From nobody Thu Apr 9 12:06:27 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DA933630B1 for ; Mon, 2 Mar 2026 12:00:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772452802; cv=none; b=ZTEmbJ/HbTldVTV0eoPnn7Pws+0m7FwRjKlsbtnVhXy2hE0Pj+RFgueaG0iyj2zBAjXoWr/R6Jiq8DMFWFC1YXHue2FId1xrjPCoh2bp68zL+ENwwEOY6h5mMF0JDyF3wie4oIvXRzjqa3JriWijdGOLf8G5U639XzutEvRgq0o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772452802; c=relaxed/simple; bh=i5Q4r678rjgEAb/Qaeot2fwaegmoPEhaSak2t0Gmiho=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=P1ihJNkHpMYHzoHiQ3G73krPorOVJQJFaKQ/olm0A1KqYVU6betq90m2nFosjLb9r0PdQD5a5/vV0C5TeItuy0Jc9YIUHZyO250PUPadDUi9Lzq1kyGQn20HVi6C44B0RiV1JvKAlIcwHZWueueYF4W8zXx5Bp8ipRKvc9TAWXY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DFsXZlYd; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DFsXZlYd" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4834826e5a0so50261485e9.2 for ; Mon, 02 Mar 2026 04:00:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772452799; x=1773057599; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=e3FjBQtVGlu6A8tGrJ9zirjh6wKPE2tAkDBcrCReDYU=; b=DFsXZlYdjc09J+RaHvY4s2sEgE+hwc8o9Ls4U4Q0dVvp2HZNJuJMOPzNFUsN9Xc9Ka XLNzysJRXwAYndFdUIdQlI78qokEJ1nOYxhfvXLudJWiCd1FSO0aOlpwnNfj1+Gel66v 3GEKmzCWmqctOb99wZF2Ep3wDcZMjeqvc+1TdzWMOhcQ22fuApZgJH/u80rekGo+EveK n/yFfhkqOJQG+PCp4DFqHTn/tftf4IAINBcAyJ85NC3lznQYAyLBmfKKxHMOUk+Wps9d sYPRleuCLy9M4qyDYDAfKSiiA8ONz8Q1eZHo+6vb2EoXXJPYK8/Pd3pV6baWJMMwd2WM M/Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772452799; x=1773057599; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e3FjBQtVGlu6A8tGrJ9zirjh6wKPE2tAkDBcrCReDYU=; b=F8lbHO20LRaK7HTrEZ52Wukl03bF8yyJ4sbOd7k6lhHWHMEsFvtmcvycQxIOgkCEQZ e7UTtgApUXiT7EHsoAH53ulAMSvUM22sJeL94PxQwdaB+BlwiEsmJFEPc6zEn0hnSszN 8Q9zzIPtZs8MlVZnUdIM/an9NrY0GjKHhpaNWkZvpnIBfZ2Xs+9jye5y+U5t49J9U7qk WjoKBLW2IIsFOv1t++P7/7HvnEb01yt8AK99YziC0Bj7YArOjhzzAnycNVaiTcAk4uVe UBYwqVSOU5+YDTAM6n7iYGk6HS1wnSV1fS2UZ197Ne8HVmtVe5BYw/33C5dKoifIme17 fbzQ== X-Forwarded-Encrypted: i=1; AJvYcCUEQIxKX95QycJtsO4KbhjVp9fDoTzpT99PliJBUTI2zb65+edtUpzhuyoKIocXd4qzovRSXdf/HCLKiKI=@vger.kernel.org X-Gm-Message-State: AOJu0YyW130gGbDZQBXbAylGDE7Z+KXgaaqdgHb5LfeQktoDwPVpeZI/ q2J3jpd1FwsbmuaYQ9R/UfvSa9vZx9oFrAsRRwGgP6qz3suC99olW5jV X-Gm-Gg: ATEYQzy2AqfEBcTUF7UZ45ZLTmnrWqUk7qd/Qn5fFCgTut0c/WEuaGzOEQScws7az9Q 5J9aIm1s6dr1u2fvxSWFAHFL9/kp+b+yie2SqKjnciG4HD3IQDiqnRQRZhZ01iwLtbdabTczV3m MH++S9ICPw2CzoTd2mJ4dfCzsgBnRxGd0EznKnyEcr3j3x6P107SbvhM15Lfuq/OfRZiacbfvfc ZtnjVsiBsnB0nDP7zFkmXt9Cs5ZFO6qxqVjbELkaC4kPLu6aj/Fi8XiWbiCCZHlbA4Q7FSGlqW7 4ikTPGOf5E+eJcx08APladR+c45PmzHrVT8SPZBEXGAg9iSXbnzleccyPEdlP/qYt+T2BfWYFTZ ZkKC5yz9EvPBW6ktVeLyKoh9mdemJb/o53KzP7nayO1paemLl/HP12OD17HoyXLj+dCh8lr+EMF CpXfgzMwHEJp6jZfdlC38mYAHL1GUwFfJFVyoVmdXBPg== X-Received: by 2002:a05:600c:3486:b0:480:3a72:524a with SMTP id 5b1f17b1804b1-483c9bed89emr237248255e9.19.1772452798746; Mon, 02 Mar 2026 03:59:58 -0800 (PST) Received: from localhost.localdomain ([90.167.55.231]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd75df9fsm475345415e9.13.2026.03.02.03.59.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 03:59:58 -0800 (PST) From: "Jose A. Perez de Azpillaga" To: linux-staging@lists.linux.dev Cc: Greg Kroah-Hartman , Dan Carpenter , Andy Shevchenko , Andrew Morton , Randy Dunlap , Abraham Samuel Adekunle , Artur Stupa , Rodrigo Gobbi , Navaneeth K , linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8723bs: fix operator spacing in rtw_ieee80211.c Date: Mon, 2 Mar 2026 12:54:44 +0100 Message-ID: <20260302115501.31596-2-azpijr@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add missing spaces around binary and ternary operators to improve readability. Also adjust line wrapping and indentation to align continuations consistently. Signed-off-by: Jose A. Perez de Azpillaga --- .../staging/rtl8723bs/core/rtw_ieee80211.c | 89 ++++++++++--------- 1 file changed, 48 insertions(+), 41 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ieee80211.c index 6cf217e21593..ba7b8ef78b4c 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -187,19 +187,19 @@ u8 *rtw_get_ie_ex(u8 *in_ie, uint in_len, u8 eid, u8 = *oui, u8 oui_len, u8 *ie, u cnt =3D 0; =20 while (cnt < in_len) { - if (eid =3D=3D in_ie[cnt] - && (!oui || !memcmp(&in_ie[cnt+2], oui, oui_len))) { + if (eid =3D=3D in_ie[cnt] && + (!oui || !memcmp(&in_ie[cnt + 2], oui, oui_len))) { target_ie =3D &in_ie[cnt]; =20 if (ie) - memcpy(ie, &in_ie[cnt], in_ie[cnt+1]+2); + memcpy(ie, &in_ie[cnt], in_ie[cnt + 1] + 2); =20 if (ielen) - *ielen =3D in_ie[cnt+1]+2; + *ielen =3D in_ie[cnt + 1] + 2; =20 break; } - cnt +=3D in_ie[cnt+1]+2; /* goto next */ + cnt +=3D in_ie[cnt + 1] + 2; /* goto next */ } =20 return target_ie; @@ -450,8 +450,8 @@ int rtw_parse_wpa_ie(u8 *wpa_ie, int wpa_ie_len, int *g= roup_cipher, int *pairwis return _FAIL; } =20 - if ((*wpa_ie !=3D WLAN_EID_VENDOR_SPECIFIC) || (*(wpa_ie+1) !=3D (u8)(wpa= _ie_len - 2)) || - (memcmp(wpa_ie+2, RTW_WPA_OUI_TYPE, WPA_SELECTOR_LEN))) { + if ((*wpa_ie !=3D WLAN_EID_VENDOR_SPECIFIC) || (*(wpa_ie + 1) !=3D (u8)(w= pa_ie_len - 2)) || + (memcmp(wpa_ie + 2, RTW_WPA_OUI_TYPE, WPA_SELECTOR_LEN))) { return _FAIL; } =20 @@ -513,7 +513,7 @@ int rtw_parse_wpa2_ie(u8 *rsn_ie, int rsn_ie_len, int *= group_cipher, int *pairwi return _FAIL; } =20 - if ((*rsn_ie !=3D WLAN_EID_RSN) || (*(rsn_ie+1) !=3D (u8)(rsn_ie_len - 2)= )) + if ((*rsn_ie !=3D WLAN_EID_RSN) || (*(rsn_ie + 1) !=3D (u8)(rsn_ie_len - = 2))) return _FAIL; =20 pos =3D rsn_ie; @@ -581,17 +581,18 @@ int rtw_get_wapi_ie(u8 *in_ie, uint in_len, u8 *wapi_= ie, u16 *wapi_len) authmode =3D in_ie[cnt]; =20 /* if (authmode =3D=3D WLAN_EID_BSS_AC_ACCESS_DELAY) */ - if (authmode =3D=3D WLAN_EID_BSS_AC_ACCESS_DELAY && (!memcmp(&in_ie[cnt+= 6], wapi_oui1, 4) || - !memcmp(&in_ie[cnt+6], wapi_oui2, 4))) { + if (authmode =3D=3D WLAN_EID_BSS_AC_ACCESS_DELAY && + (!memcmp(&in_ie[cnt + 6], wapi_oui1, 4) || + !memcmp(&in_ie[cnt + 6], wapi_oui2, 4))) { if (wapi_ie) - memcpy(wapi_ie, &in_ie[cnt], in_ie[cnt+1]+2); + memcpy(wapi_ie, &in_ie[cnt], in_ie[cnt + 1] + 2); =20 if (wapi_len) - *wapi_len =3D in_ie[cnt+1]+2; + *wapi_len =3D in_ie[cnt + 1] + 2; =20 - cnt +=3D in_ie[cnt+1]+2; /* get next */ + cnt +=3D in_ie[cnt + 1] + 2; /* get next */ } else { - cnt +=3D in_ie[cnt+1]+2; /* get next */ + cnt +=3D in_ie[cnt + 1] + 2; /* get next */ } } =20 @@ -614,9 +615,10 @@ void rtw_get_sec_ie(u8 *in_ie, uint in_len, u8 *rsn_ie= , u16 *rsn_len, u8 *wpa_ie while (cnt < in_len) { authmode =3D in_ie[cnt]; =20 - if ((authmode =3D=3D WLAN_EID_VENDOR_SPECIFIC) && (!memcmp(&in_ie[cnt+2]= , &wpa_oui[0], 4))) { + if ((authmode =3D=3D WLAN_EID_VENDOR_SPECIFIC) && + (!memcmp(&in_ie[cnt + 2], &wpa_oui[0], 4))) { if (wpa_ie) - memcpy(wpa_ie, &in_ie[cnt], in_ie[cnt+1]+2); + memcpy(wpa_ie, &in_ie[cnt], in_ie[cnt + 1] + 2); =20 *wpa_len =3D in_ie[cnt + 1] + 2; cnt +=3D in_ie[cnt + 1] + 2; /* get next */ @@ -625,10 +627,10 @@ void rtw_get_sec_ie(u8 *in_ie, uint in_len, u8 *rsn_i= e, u16 *rsn_len, u8 *wpa_ie if (rsn_ie) memcpy(rsn_ie, &in_ie[cnt], in_ie[cnt + 1] + 2); =20 - *rsn_len =3D in_ie[cnt+1]+2; - cnt +=3D in_ie[cnt+1]+2; /* get next */ + *rsn_len =3D in_ie[cnt + 1] + 2; + cnt +=3D in_ie[cnt + 1] + 2; /* get next */ } else { - cnt +=3D in_ie[cnt+1]+2; /* get next */ + cnt +=3D in_ie[cnt + 1] + 2; /* get next */ } } } @@ -660,20 +662,20 @@ u8 *rtw_get_wps_ie(u8 *in_ie, uint in_len, u8 *wps_ie= , uint *wps_ielen) while (cnt < in_len) { eid =3D in_ie[cnt]; =20 - if ((eid =3D=3D WLAN_EID_VENDOR_SPECIFIC) && (!memcmp(&in_ie[cnt+2], wps= _oui, 4))) { + if ((eid =3D=3D WLAN_EID_VENDOR_SPECIFIC) && (!memcmp(&in_ie[cnt + 2], w= ps_oui, 4))) { wpsie_ptr =3D &in_ie[cnt]; =20 if (wps_ie) - memcpy(wps_ie, &in_ie[cnt], in_ie[cnt+1]+2); + memcpy(wps_ie, &in_ie[cnt], in_ie[cnt + 1] + 2); =20 if (wps_ielen) - *wps_ielen =3D in_ie[cnt+1]+2; + *wps_ielen =3D in_ie[cnt + 1] + 2; =20 - cnt +=3D in_ie[cnt+1]+2; + cnt +=3D in_ie[cnt + 1] + 2; =20 break; } - cnt +=3D in_ie[cnt+1]+2; /* goto next */ + cnt +=3D in_ie[cnt + 1] + 2; /* goto next */ } =20 return wpsie_ptr; @@ -751,12 +753,12 @@ u8 *rtw_get_wps_attr_content(u8 *wps_ie, uint wps_iel= en, u16 target_attr_id, u8 =20 if (attr_ptr && attr_len) { if (buf_content) - memcpy(buf_content, attr_ptr+4, attr_len-4); + memcpy(buf_content, attr_ptr + 4, attr_len - 4); =20 if (len_content) - *len_content =3D attr_len-4; + *len_content =3D attr_len - 4; =20 - return attr_ptr+4; + return attr_ptr + 4; } =20 return NULL; @@ -1007,20 +1009,25 @@ static int rtw_get_cipher_info(struct wlan_network = *pnetwork) int group_cipher =3D 0, pairwise_cipher =3D 0, is8021x =3D 0; int ret =3D _FAIL; =20 - pbuf =3D rtw_get_wpa_ie(&pnetwork->network.ies[12], &wpa_ielen, pnetwork-= >network.ie_length-12); + pbuf =3D rtw_get_wpa_ie(&pnetwork->network.ies[12], &wpa_ielen, + pnetwork->network.ie_length - 12); =20 if (pbuf && (wpa_ielen > 0)) { - if (rtw_parse_wpa_ie(pbuf, wpa_ielen+2, &group_cipher, &pairwise_cipher,= &is8021x) =3D=3D _SUCCESS) { + if (rtw_parse_wpa_ie(pbuf, wpa_ielen + 2, &group_cipher, + &pairwise_cipher, &is8021x) =3D=3D _SUCCESS) { pnetwork->bcn_info.pairwise_cipher =3D pairwise_cipher; pnetwork->bcn_info.group_cipher =3D group_cipher; pnetwork->bcn_info.is_8021x =3D is8021x; ret =3D _SUCCESS; } } else { - pbuf =3D rtw_get_wpa2_ie(&pnetwork->network.ies[12], &wpa_ielen, pnetwor= k->network.ie_length-12); + pbuf =3D rtw_get_wpa2_ie(&pnetwork->network.ies[12], &wpa_ielen, + pnetwork->network.ie_length - 12); =20 if (pbuf && (wpa_ielen > 0)) { - if (rtw_parse_wpa2_ie(pbuf, wpa_ielen+2, &group_cipher, &pairwise_ciphe= r, &is8021x) =3D=3D _SUCCESS) { + if (rtw_parse_wpa2_ie(pbuf, wpa_ielen + 2, + &group_cipher, &pairwise_cipher, + &is8021x) =3D=3D _SUCCESS) { pnetwork->bcn_info.pairwise_cipher =3D pairwise_cipher; pnetwork->bcn_info.group_cipher =3D group_cipher; pnetwork->bcn_info.is_8021x =3D is8021x; @@ -1089,21 +1096,21 @@ u16 rtw_mcs_rate(u8 bw_40MHz, u8 short_GI, unsigned= char *MCS_rate) u16 max_rate =3D 0; =20 if (MCS_rate[0] & BIT(7)) - max_rate =3D (bw_40MHz) ? ((short_GI)?1500:1350):((short_GI)?722:650); + max_rate =3D (bw_40MHz) ? ((short_GI) ? 1500 : 1350) : ((short_GI) ? 722= : 650); else if (MCS_rate[0] & BIT(6)) - max_rate =3D (bw_40MHz) ? ((short_GI)?1350:1215):((short_GI)?650:585); + max_rate =3D (bw_40MHz) ? ((short_GI) ? 1350 : 1215) : ((short_GI) ? 650= : 585); else if (MCS_rate[0] & BIT(5)) - max_rate =3D (bw_40MHz) ? ((short_GI)?1200:1080):((short_GI)?578:520); + max_rate =3D (bw_40MHz) ? ((short_GI) ? 1200 : 1080) : ((short_GI) ? 578= : 520); else if (MCS_rate[0] & BIT(4)) - max_rate =3D (bw_40MHz) ? ((short_GI)?900:810):((short_GI)?433:390); + max_rate =3D (bw_40MHz) ? ((short_GI) ? 900 : 810) : ((short_GI) ? 433 := 390); else if (MCS_rate[0] & BIT(3)) - max_rate =3D (bw_40MHz) ? ((short_GI)?600:540):((short_GI)?289:260); + max_rate =3D (bw_40MHz) ? ((short_GI) ? 600 : 540) : ((short_GI) ? 289 := 260); else if (MCS_rate[0] & BIT(2)) - max_rate =3D (bw_40MHz) ? ((short_GI)?450:405):((short_GI)?217:195); + max_rate =3D (bw_40MHz) ? ((short_GI) ? 450 : 405) : ((short_GI) ? 217 := 195); else if (MCS_rate[0] & BIT(1)) - max_rate =3D (bw_40MHz) ? ((short_GI)?300:270):((short_GI)?144:130); + max_rate =3D (bw_40MHz) ? ((short_GI) ? 300 : 270) : ((short_GI) ? 144 := 130); else if (MCS_rate[0] & BIT(0)) - max_rate =3D (bw_40MHz) ? ((short_GI)?150:135):((short_GI)?72:65); + max_rate =3D (bw_40MHz) ? ((short_GI) ? 150 : 135) : ((short_GI) ? 72 : = 65); =20 return max_rate; } @@ -1117,8 +1124,8 @@ int rtw_action_frame_parse(const u8 *frame, u32 frame= _len, u8 *category, u8 *act =20 fc =3D le16_to_cpu(((struct ieee80211_hdr_3addr *)frame)->frame_control); =20 - if ((fc & (IEEE80211_FCTL_FTYPE|IEEE80211_FCTL_STYPE)) - !=3D (IEEE80211_FTYPE_MGMT|IEEE80211_STYPE_ACTION) + if ((fc & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE)) + !=3D (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_ACTION) ) { return false; } --=20 2.53.0