From nobody Thu Apr 16 06:43:54 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B1F43876D2 for ; Mon, 2 Mar 2026 08:56:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772441783; cv=none; b=QZNdr7gxUf0DYh2vmNB5MUyND9zq9/txLTEGHa0yhjBgtBtUOxjEK62uZkpwIdaa7GdTshxIyL5HPRF7uv1ZKwkrlDTJYcN+V4IhKoo17FYZle+/8I+CEaelNlLVA3wnyfkFhOFRcf+vAK1Mreu+U54XJHclUt62NKsHJvRTmYY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772441783; c=relaxed/simple; bh=YSle7age6/sGC4mrbcE1fgXH371qq6gkeUXhaxiCOyc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HrK4sF9pSFR72+WEgYu39q8ZON/zSZmJTFpW+S2gWzO0d3eRgW3Xd6L9DvzZXsq1M8AASJ471l7x+2KsX7DE9OsPGKkN9mF1sXGht4EQ00SFcRoeZauAoFyhBHR5rhzxUOX+JOZ8dthfpeSu3LacczYo4NLUQE8cuFX8QNJ4fU0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DFoyPolg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZdYbXWWX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DFoyPolg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZdYbXWWX" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62287jb73223985 for ; Mon, 2 Mar 2026 08:56:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=WApl3fPUusQhgCuPfXm41GbJ+B8rlZDv+NV xfvyf6qI=; b=DFoyPolgCp/EYJgTV2hvkk8ihX/ytfIJn6J2abn+QncUKRTGVtK ZJaGh0+irgpLI9LzNxJAiQqLowGytkcMZACEy7YbRvUi2yLXgofgdA6VHT0D2egw eMY1xNtX3jke5KRM6u3PpNWMHV1E6kQgjRtfK1Zp18uOjU4r9tXUIIxAw8PQ4fR2 US3h82xcsjtRf7jIrhVfR/ZQaMwNDATh67Koj62swj8hQSa111zk2wdNYKmU9uaI tMaH8YqTErI+yAq2e4oy/rwPuEuP+fuxHo8ReRliAFqJCTgFVrctkJesR00O0t8J 3LA3KVQweNdMi7BviEhGu+6p4Z+Nh6KKP/w== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cn0b1hdg1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 08:56:21 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2aae0d40a47so287459255ad.2 for ; Mon, 02 Mar 2026 00:56:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772441781; x=1773046581; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WApl3fPUusQhgCuPfXm41GbJ+B8rlZDv+NVxfvyf6qI=; b=ZdYbXWWXk/8frrMJjQZbAI5xHLKBu2yTfU6wagp9E4Ywxoy2BrmGAzjeinAD3Rkz6P +MLLzSvapC2xx025J605XhBi/Yegw5pN9YidtDsG5Kh5155EEcxsJqqCgEow0vWnauVs xb1vv5jk1i3P9lXXgDJT04SD87QFYAiMJzPQRMYpx1R51cWbFoXrEUJqDwH1rH9G1Yws 89OfQP8QrOIKSoKJhAmO1NHyY7LnYYm/Tf0XHSIO21InPraj8m0PRZ3TMjokBqtaCl7W xFYF7ESTvZqdCJ8HrUFKbAG6R3m4Ku4tD603jXwKInMh4oUc1FDyHhTMjMbfbNOxch0R uBxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772441781; x=1773046581; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WApl3fPUusQhgCuPfXm41GbJ+B8rlZDv+NVxfvyf6qI=; b=bXYD0Knr1lwSZ1zNnqcZNcr6LCI7Rg/zNqSYO9cR6HDqf4/+uqcZ3+Z+BahnqJBj1b HzYBxsGFg7yci/+co+We4LfaT/ZUv3ElJ10HEnHpT+HxdKD4idJjS9RCKjgrrbjxMNDG mMuWvB0MAeluvX+CL9t3cju6AiwxFBe7Ey6q4jL8mWXqVzAI7l0XIauVd2lrrJDuGj0M /nWQYbpC5OwJ4S6NJZIcjtzfavT73DbYfjTC2sIiBvOq/punBRYXJoIjQY5u+UeYA7b+ RzLNocn9k1WPiWW5pl/OKCJNfuh/WcefDeHE3Lkk0dpxLJyk5xBIrtucW1tpkinnKDg7 MoKQ== X-Forwarded-Encrypted: i=1; AJvYcCVx8uDpFyhg6o8pLmevuelGuXMCFUOjBp2fcjKDySEtUm4ECp2a0nm2TK8826W8CGSWL5OpwYKzsqUWu3Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yxx9fBS/9KvjUzN4UH4wjAncpXB+KGPRthDQP7jcvk0g/fqZ8xk OM7PjaVjxWu4krCBk0VBlaNl9wL6GiwAATyatQ3WwYmOLlvgD0dqPjQfmgKSCQWDovMbAAJoTwj ctUVvWqU+pbwO7Rvz7/3mDH/Obrsgr4QIsbODeN9X9p6jfA/Ds9jr/hwuVMPIDXciI3M= X-Gm-Gg: ATEYQzyWhESKhiUJTVfGZwIEldSNULh62mDdjucLnzJyIJmMUIyRs5hsdvVSKqFwPw0 2LcTjjyTJlRL8kzwxqPSStYHIuFJ6QbKWTt/BXTQxcxSO0QBDat8EsCN6geuLgekeoxEmaoZ8qG i8ZUvyQ1BXg2haMZDXEydK/RxcZWhtPPN97y+ET3q+6kZJDsnVzl1g9ZM6CQPpRhO3irEWY+bzH hrVLC6hBtQYJSCO2cHGF1bJ+Y0BmArrL+2KNs+df/Q3UFpsOH7y28/wdiySzcrZvvy8HQVTOjgv 1g86yBE7Zd/3Am/Hui9it4irtVfKStaHYMysDNQvirPS7/cK4Awsj6phphldqGDjGuyKNUtxtGs hNx6ybgIo3ECfD5iClo1/P2/3xi1j/B3ne9e+cVlykDr0cIE= X-Received: by 2002:a17:902:d508:b0:2a0:d33d:a8f0 with SMTP id d9443c01a7336-2ae2e4d0a96mr130649795ad.50.1772441781159; Mon, 02 Mar 2026 00:56:21 -0800 (PST) X-Received: by 2002:a17:902:d508:b0:2a0:d33d:a8f0 with SMTP id d9443c01a7336-2ae2e4d0a96mr130649365ad.50.1772441780596; Mon, 02 Mar 2026 00:56:20 -0800 (PST) Received: from work.lan ([2409:4091:a0f4:6806:40ee:341f:1665:8aed]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3590158f6e0sm20781263a91.1.2026.03.02.00.56.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 00:56:20 -0800 (PST) From: Manivannan Sadhasivam To: mani@kernel.org Cc: sumit.kumar@oss.qualcomm.com, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , stable@vger.kernel.org Subject: [PATCH] bus: mhi: ep: Protect mhi_ep_handle_syserr() in the error path Date: Mon, 2 Mar 2026 14:26:12 +0530 Message-ID: <20260302085612.18725-1-manivannan.sadhasivam@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: XxMws5WtpcyEqNePROZ7iQ7PwzUMbug0 X-Authority-Analysis: v=2.4 cv=Hol72kTS c=1 sm=1 tr=0 ts=69a550b6 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=AUlretI1EePZII7xc8UA:9 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: XxMws5WtpcyEqNePROZ7iQ7PwzUMbug0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDA3NyBTYWx0ZWRfX4cTounmF6LYv GBCVVbOUxAcztUQdc7w67meLJBcXZvQLaxyG/gjYoE3yLtsU6aHE8hG+3T97TTsL5/qx25XIKdQ fOvqljDt7nqIo1spSmWYqyzhbsiYzhkCH3VnQK7djtqq8MvoxHQ0a8S2ikzgb5J/KRkMjJSxyJd QGeu+wxsXnha1Tcg7EXfpTYMVgaRT8ff1oA7k729hZOKQs+0LSMUYjHuLamzKBovUsmLc/ajQys IG9x7RUDXB6b6fzjxLA+qTRzXj/3amCTGTJcTinR2R2D5tfHZnwzPcCtoBbllKO7of8M0opSOik 6IhdVofJ933CHssoaN4YRET9swFOu5EezR/6r6bJ9+C2y3XHXp6HVN4eoLQkaIfY+nzhP7Y1aq9 YrKmCr+FhvVfx56Nhrkv6+EiA83Da1YSOGTOd1CnBhYL9gfm7Z/pkNqLKXL2pt7ulv1LmzhHL4P BrnDl1gSH1kPoLm5o0w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_02,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020077 Content-Type: text/plain; charset="utf-8" All the callers of mhi_ep_handle_syserr() except mhi_ep_process_cmd_ring() are holding the 'state_lock' to avoid the race in setting the MHI state. So do the same in mhi_ep_process_cmd_ring() for sanity. Cc: # 5.18 Fixes: e827569062a8 ("bus: mhi: ep: Add support for processing command ring= s") Signed-off-by: Manivannan Sadhasivam --- drivers/bus/mhi/ep/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c index e3d0a3cbaf94..6a6aa2c28760 100644 --- a/drivers/bus/mhi/ep/main.c +++ b/drivers/bus/mhi/ep/main.c @@ -232,7 +232,9 @@ static int mhi_ep_process_cmd_ring(struct mhi_ep_ring *= ring, struct mhi_ring_ele ret =3D mhi_ep_create_device(mhi_cntrl, ch_id); if (ret) { dev_err(dev, "Error creating device for channel (%u)\n", ch_id); + mutex_lock(&mhi_cntrl->state_lock); mhi_ep_handle_syserr(mhi_cntrl); + mutex_unlock(&mhi_cntrl->state_lock); return ret; } } --=20 2.51.0