From nobody Thu Apr 16 06:47:02 2026 Received: from canpmsgout12.his.huawei.com (canpmsgout12.his.huawei.com [113.46.200.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A297737FF62; Mon, 2 Mar 2026 06:51:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772434317; cv=none; b=EhnY400UXaVbS3Fg1coXmZQze4RTSx2fJ+N6A7M7pyQoV5dPGXHfNfQEFZ9TBvFspkSyIT1/ewEBFZ45nltYrufDENYVipaZGvVtYevRLR1RK6nkcTHCPy//Rch+2Rs3rDngoqyzgz9yaLsCtI2Rogw9BIdjVzfybz51ti/dVSw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772434317; c=relaxed/simple; bh=NXL1fSdw2j8VrVqLQwKYTnfZ2QpPruguXE/wymW+wo8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hPqO1q7ygemFZ8nIcAmtevoVXvZgUNtcnTyiy+mH3xO3cv78QFE7eoXBs+ZDgwCUoEwM6N1BeJInIdl6Ymd3ovTlgzcKkrCJNr18K0bytUs49Dxbp3JIclC1/hr1Xz6Yx9P5mrHmSkG/TkRhhFBffrx/eTYzHUiTTBteEnEKHhE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=h-partners.com; dkim=pass (1024-bit key) header.d=h-partners.com header.i=@h-partners.com header.b=dP7Mgxo7; arc=none smtp.client-ip=113.46.200.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=h-partners.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=h-partners.com header.i=@h-partners.com header.b="dP7Mgxo7" dkim-signature: v=1; a=rsa-sha256; d=h-partners.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=jcMQo5PHKJimYbvXJBwbsloW3Yqpul6ZzVeuzezcJ8E=; b=dP7Mgxo7mKsZ2MoDMMFcxuhhKeaSxpHSe/YD0AtGODmhZlJv9nZUtEvFew1tYRsde1lqvPOAL ACyJUXKXAIDQD4AT8+kX/uX+UPAQQppLLxeunY6traTsAveR5EYzk2ImO8gsbi9cvnOdCzQmVl9 yCzc2CkgjIjrW8QNGuyYq1Q= Received: from mail.maildlp.com (unknown [172.19.163.214]) by canpmsgout12.his.huawei.com (SkyGuard) with ESMTPS id 4fPTxm6SxvznTW0; Mon, 2 Mar 2026 14:47:08 +0800 (CST) Received: from kwepemj100018.china.huawei.com (unknown [7.202.194.12]) by mail.maildlp.com (Postfix) with ESMTPS id C16674056C; Mon, 2 Mar 2026 14:51:46 +0800 (CST) Received: from localhost.huawei.com (10.90.31.46) by kwepemj100018.china.huawei.com (7.202.194.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.36; Mon, 2 Mar 2026 14:51:46 +0800 From: Xingui Yang To: , CC: , , , , , , , Subject: [PATCH 1/2] scsi: hisi_sas: Correct the printing format issues Date: Mon, 2 Mar 2026 14:51:34 +0800 Message-ID: <20260302065135.841653-2-yangxingui@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260302065135.841653-1-yangxingui@huawei.com> References: <20260302065135.841653-1-yangxingui@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems100002.china.huawei.com (7.221.188.206) To kwepemj100018.china.huawei.com (7.202.194.12) Content-Type: text/plain; charset="utf-8" From: Yihang Li There are some print format errors, fix them. Signed-off-by: Yihang Li Signed-off-by: Xingui Yang --- drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/= hisi_sas_main.c index 30a9c6612651..00e4b59ff711 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_main.c +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c @@ -1326,7 +1326,7 @@ static int hisi_sas_control_phy(struct asd_sas_phy *s= as_phy, enum phy_func func, =20 if (sts && !wait_for_completion_timeout(&completion, HISI_SAS_WAIT_PHYUP_TIMEOUT)) { - dev_warn(dev, "phy%d wait phyup timed out for func %d\n", + dev_warn(dev, "phy%d wait phyup timed out for func %u\n", phy_no, func); if (phy->in_reset) ret =3D -ETIMEDOUT; diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas= /hisi_sas_v3_hw.c index 2f9e01717ef3..6a841d53bb10 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c @@ -896,7 +896,7 @@ static void setup_itct_v3_hw(struct hisi_hba *hisi_hba, qw0 =3D HISI_SAS_DEV_TYPE_SATA << ITCT_HDR_DEV_TYPE_OFF; break; default: - dev_warn(dev, "setup itct: unsupported dev type (%d)\n", + dev_warn(dev, "setup itct: unsupported dev type (%u)\n", sas_dev->dev_type); } =20 @@ -2847,7 +2847,7 @@ static void wait_cmds_complete_timeout_v3_hw(struct h= isi_hba *hisi_hba, static ssize_t intr_conv_v3_hw_show(struct device *dev, struct device_attribute *attr, char *buf) { - return scnprintf(buf, PAGE_SIZE, "%u\n", hisi_sas_intr_conv); + return scnprintf(buf, PAGE_SIZE, "%d\n", hisi_sas_intr_conv); } static DEVICE_ATTR_RO(intr_conv_v3_hw); =20 @@ -3293,7 +3293,7 @@ static int debugfs_set_bist_v3_hw(struct hisi_hba *hi= si_hba, bool enable) u32 *fix_code =3D &hisi_hba->debugfs_bist_fixed_code[0]; struct device *dev =3D hisi_hba->dev; =20 - dev_info(dev, "BIST info:phy%d link_rate=3D%d code_mode=3D%d path_mode=3D= %d ffe=3D{0x%x, 0x%x, 0x%x, 0x%x, 0x%x, 0x%x, 0x%x} fixed_code=3D{0x%x, 0x%= x}\n", + dev_info(dev, "BIST info:phy%u link_rate=3D%u code_mode=3D%u path_mode=3D= %u ffe=3D{0x%x, 0x%x, 0x%x, 0x%x, 0x%x, 0x%x, 0x%x} fixed_code=3D{0x%x, 0x%= x}\n", phy_no, linkrate, code_mode, path_mode, ffe[FFE_SAS_1_5_GBPS], ffe[FFE_SAS_3_0_GBPS], ffe[FFE_SAS_6_0_GBPS], ffe[FFE_SAS_12_0_GBPS], @@ -3650,7 +3650,7 @@ static void debugfs_print_reg_v3_hw(u32 *regs_val, st= ruct seq_file *s, int i; =20 for (i =3D 0; i < reg->count; i++) { - int off =3D i * HISI_SAS_REG_MEM_SIZE; + u32 off =3D i * HISI_SAS_REG_MEM_SIZE; const char *name; =20 name =3D debugfs_to_reg_name_v3_hw(off, reg->base_off, --=20 2.33.0 From nobody Thu Apr 16 06:47:02 2026 Received: from canpmsgout12.his.huawei.com (canpmsgout12.his.huawei.com [113.46.200.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A28EE37FF5A; Mon, 2 Mar 2026 06:51:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772434316; cv=none; b=lBHDRbLu1kVtfxbYdEiQmqttoNl3trcUak765k0lPhPVkKO7rgApszfMc3x0gsFCucswCGAu8PIHbai3Uv4eBm7ZEkRs0KBJkP2tyWZfaMse9fyHQPbN6V/2tXBquRVQSuAX7liiXzzkwD1gNwwIr8yAOP9j3WV00pUDzQx4jus= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772434316; c=relaxed/simple; bh=gOOUmEidWugFLrAOFqpFlVsAFFE67AjmXaoJeKiLGto=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tpiSJWRBGkHU5tWHvwSoyOxmBPBGWYnzgJJHFaAwpTXj2DYTtL3fQthkK98nQlPXUYCBIaUssczz0Ju1UXp/E6RpYxPRpMbC/xRtAZxuJZld4HgEvWbsgvZz6GG3HEGq+1Wwt+GlbpaxnwfAOGoxTT/gkcmm9npboWhRKzbNL60= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=h-partners.com; dkim=pass (1024-bit key) header.d=h-partners.com header.i=@h-partners.com header.b=WM/DmGAu; arc=none smtp.client-ip=113.46.200.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=h-partners.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=h-partners.com header.i=@h-partners.com header.b="WM/DmGAu" dkim-signature: v=1; a=rsa-sha256; d=h-partners.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=x96wp+U8AgQxI7Ntyo5v9hm0QtD55MbMieSRSZ4rJ0o=; b=WM/DmGAulW8eqjUr7m3SFab1RS1knOGSAE8B1TUfKdq0Vv7Pn4kazeNDT8Cbs/m7qit//9RYn q5/nuk278hIwHTgMbF7RPlZwpkRxmH9IGZgQSQ+iez9ajRfAVK5ZZAwiHOjl3fvb5UdDAGXRqnM MzJeJiqWB1rdqqlNfOIQack= Received: from mail.maildlp.com (unknown [172.19.162.92]) by canpmsgout12.his.huawei.com (SkyGuard) with ESMTPS id 4fPTxn2Ds7znTW0; Mon, 2 Mar 2026 14:47:09 +0800 (CST) Received: from kwepemj100018.china.huawei.com (unknown [7.202.194.12]) by mail.maildlp.com (Postfix) with ESMTPS id 30E6640562; Mon, 2 Mar 2026 14:51:47 +0800 (CST) Received: from localhost.huawei.com (10.90.31.46) by kwepemj100018.china.huawei.com (7.202.194.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.36; Mon, 2 Mar 2026 14:51:46 +0800 From: Xingui Yang To: , CC: , , , , , , , Subject: [PATCH 2/2] scsi: hisi_sas: Fixed the risk of overflow in bitwise logical operations Date: Mon, 2 Mar 2026 14:51:35 +0800 Message-ID: <20260302065135.841653-3-yangxingui@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260302065135.841653-1-yangxingui@huawei.com> References: <20260302065135.841653-1-yangxingui@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems100002.china.huawei.com (7.221.188.206) To kwepemj100018.china.huawei.com (7.202.194.12) Content-Type: text/plain; charset="utf-8" From: Yihang Li Fixed a few constants defined via macros that had overflow risks. Signed-off-by: Yihang Li Signed-off-by: Xingui Yang --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas= /hisi_sas_v3_hw.c index 6a841d53bb10..ba9d6877483a 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c @@ -432,7 +432,7 @@ #define CMPLT_HDR_IPTT_OFF 0 #define CMPLT_HDR_IPTT_MSK (0xffff << CMPLT_HDR_IPTT_OFF) #define CMPLT_HDR_DEV_ID_OFF 16 -#define CMPLT_HDR_DEV_ID_MSK (0xffff << CMPLT_HDR_DEV_ID_OFF) +#define CMPLT_HDR_DEV_ID_MSK (0xffffU << CMPLT_HDR_DEV_ID_OFF) /* dw3 */ #define SATA_DISK_IN_ERROR_STATUS_OFF 8 #define SATA_DISK_IN_ERROR_STATUS_MSK (0x1 << SATA_DISK_IN_ERROR_STATUS_OF= F) @@ -444,7 +444,7 @@ #define FIS_ATA_STATUS_ERR_OFF 18 #define FIS_ATA_STATUS_ERR_MSK (0x1 << FIS_ATA_STATUS_ERR_OFF) #define FIS_TYPE_SDB_OFF 31 -#define FIS_TYPE_SDB_MSK (0x1 << FIS_TYPE_SDB_OFF) +#define FIS_TYPE_SDB_MSK (0x1U << FIS_TYPE_SDB_OFF) =20 /* ITCT header */ /* qw0 */ --=20 2.33.0