From nobody Thu Apr 16 06:50:31 2026 Received: from sg-1-103.ptr.blmpb.com (sg-1-103.ptr.blmpb.com [118.26.132.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC6CF25DB1C for ; Mon, 2 Mar 2026 06:18:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=118.26.132.103 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772432298; cv=none; b=ENRvyc2hDjK0CXy3yzTsQbjpu2O2doGhryoD8/fHAIcvj+1wI73+6GRJ/zzsrS9ECTIpibBsfaSCo3wKlT7gNUOD51cDozrn9KtN+1PtWqYV0RpLYfcoPLt5O9FHUwJCpcLWtX5/RecTy1NRr4p000sxfAwp8VZWX1GSkB0r/fw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772432298; c=relaxed/simple; bh=qtTKkeuNsiHkhHGWvIO94lYqO8t5vbPdBvDrQjNFXgQ=; h=Subject:Mime-Version:Content-Type:To:Message-Id:From:Date; b=I/pJJztEgqo38PpV2oK/k3n0a3e6VsOc2MZizra2Ej+D872mS7sGTUD8ebQxeWAxagyH9zueNahv1lB3/fhHhgxD3Cx1heUtbmsYNmgqz5RjilE+aZBQp/mlDcN9/OLrjElRb9GY8PTPSTGGNRwC/lM9PmX1IdidhkBXfsnkOG0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=EkfFFQk3; arc=none smtp.client-ip=118.26.132.103 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="EkfFFQk3" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=2212171451; d=bytedance.com; t=1772432278; h=from:subject: mime-version:from:date:message-id:subject:to:cc:reply-to:content-type: mime-version:in-reply-to:message-id; bh=9dg5GQNUSNXJ5dswg9F2BRKfvGZtOl1PVgPaWT+8PTo=; b=EkfFFQk3S9cKn3gToNrYgrERLb+HcC/f0eSam+K1zoipp2lpP7SXAPW1WWaogRGJFZgTI9 Gb8P8HKMDcsDhynuLdSP3CnbsDFg9V0h0dr2nBIEU4lov+3bkGEnXXqPZYgiAlMHVhi05D Dm4kF19JQ7VblR+y2ppglms7XZABUjgT3+yrgQT33wz/HqOCEmZJZazkbHOHpET1BPi3DJ k2Je61oQe+3C1J0nInsQJNa7HQV/Nc3OQyELZPIfOn9lqSa6r84sQpjKWoefTSsZtpHYrP +MwUMAUZSYygn1HWsT19a2fiDphyNdMfPJtYFkzoqfVZ/VkaXL9ilIsLGPw6kg== Subject: [RFC] ipmi: ipmi_ssif: require minimum response length Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Original-From: Jian Zhang To: "Corey Minyard" , , Message-Id: <20260302061746.1579192-1-zhangjian.3032@bytedance.com> Content-Transfer-Encoding: quoted-printable From: "Jian Zhang" Date: Mon, 2 Mar 2026 14:17:46 +0800 X-Lms-Return-Path: X-Mailer: git-send-email 2.20.1 Content-Type: text/plain; charset="utf-8" A valid IPMI over SSIF response must contain at least three bytes (NetFn/LUN, Command and Completion Code). Some DMA-only I2C controllers may return short reads instead of a proper NACK when the response is not ready. Treat such short reads as incomplete and retry until a full response is received. Signed-off-by: Jian Zhang --- drivers/char/ipmi/ipmi_ssif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c index 37a5cb5c53f1..64ee939a7a4b 100644 --- a/drivers/char/ipmi/ipmi_ssif.c +++ b/drivers/char/ipmi/ipmi_ssif.c @@ -1300,7 +1300,7 @@ static int read_response(struct i2c_client *client, u= nsigned char *resp) while (retry_cnt > 0) { ret =3D i2c_smbus_read_block_data(client, SSIF_IPMI_RESPONSE, resp); - if (ret > 0) + if (ret >=3D 3) break; msleep(SSIF_MSG_MSEC); retry_cnt--; --=20 2.20.1