From nobody Thu Apr 16 06:50:31 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8711379EEA for ; Mon, 2 Mar 2026 05:50:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772430652; cv=none; b=LNL0oKdrxgDSnYGIdntadLxjNsCiwmhO+AH0wH336k4U5bHwjeBiREBmIZQuvmg1/LuJK+Ka2F+/207mzzMiJESsbWoMvxQvFacju1YPgAzR9IvkXz/GULJbCtP+/6RtSvNhuidsr1eOy0CSE6wRiVyB8+76kIGvqFQUSy7FwYE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772430652; c=relaxed/simple; bh=Lju4CWP3V8ABLB9X0SzpJ74BRzmxxmjnvWfRf+lmAZ8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dSNJGLG7nS1GMMVV8b84eKNaYxOgqBr2Klk0KY+GFVtNqEA/rLK4QC/ZUApE04QHqHGY2G2MDddTiMbnL7tQCPQPQm2jbZgX1cpSzBeV/+e+AOjOY2DYvBQQQuNdGAPAihwVrCEdU6y5nIVdBxlzGemiWyOExuGlNEXc42Kg9aE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aG7zdkQj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cmOfgQxd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aG7zdkQj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cmOfgQxd" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 621MlIsn3611934 for ; Mon, 2 Mar 2026 05:50:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=J1C4lzpd3bnHoLcJu0iuRLe4fMG9cPL26Tz 5T+lx3rI=; b=aG7zdkQjnT7fIMbx0usGgpjqHRjHguZPe7O7mwOHz+G0dwd93yv ateTOcs/C9nJ+7V3qIlvcyLr4MLEtjphtaSJ1cBSVRf2MqeaWhLvCDgc14jko0Sn WTULyynOMU8ArnuI1iFwSPjLqRZcT6CrBx94rcSr/Z3Nvf8PXK82Z/+tXdbdxPuL 5j1TMVUNIMUKXTrdRviMlQqUqQ6tVCgL1tnIun8mnf2BAAGSdMwMzUQxAiXg4v6V aOYCb5viaN3hjLLKAnIILmWUF6kTF25EeEUWNqL63aaNybR/9AB4PSut0RMq7xdH 6zKb+DUob/vlafuK2UKCD9VGHeyjp5+96sQ== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cksfyv30r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 05:50:32 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ae50386da7so3546685ad.0 for ; Sun, 01 Mar 2026 21:50:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772430632; x=1773035432; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=J1C4lzpd3bnHoLcJu0iuRLe4fMG9cPL26Tz5T+lx3rI=; b=cmOfgQxda1P3nod6iy2whMyVmwc6vDWtXy/qs9di6I8geAUyK92IhTyj+nYhqBM88d e++K7FXB7sjwfo0Iqub49WTtYIHJI8ugc9J7or+Ii1YJVzGWt3T7RjFIpjPE7p3RgZm2 YegQHmcX2XEO1mKHOllhXKkEhOApJFCyk7/Oa9rNmCvhmlsM56uJzUrAEvbwLLxWnn4q QE06xaqyv0KAYpJ7+IWUUg72+8zBoNlT9sGiyoWm2OxY7rDp3pUDqQ/uxRRVdR8Q4E1K u/zXzarg8wAUjbUpyDveDu1fNVSAwE4NsaHi++l5P7TlZBB0R0qTaxdMlDnM8c5c5E/v pNbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772430632; x=1773035432; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J1C4lzpd3bnHoLcJu0iuRLe4fMG9cPL26Tz5T+lx3rI=; b=fv114O635TOr4esFat5Y6bAVi1rmOmjhu21wXaKR8kYzl68zRcWFibW23FiMdCdvvf QPuEohK5vTzQdC+HO6RRZavni6PeySdBFnyoFG8a6mY+cZxLO1zLCwUOpcVnBg5XblYY t4nKuBo9+liKh046ZqSgQFFbirvyz5KsE77rQh7F97gWFHCetDBJsf3cDgOEyi4Wj8YF bBApIF8ocfJ5B/8HlWs85UG1sEnxCSODYEiSKCBGUTCHZu1+NEDrDi1BUtzQH54sw4xb bgc/Wz7BM6iErZ3c+fel/76pbbfVuc5bWoF8uB20dFxU9r0LDE3HXj6d+/QpAYVIt16t mA6w== X-Forwarded-Encrypted: i=1; AJvYcCW5Lt7Bp90qKeeNDLO+oyuvoeoCvKs7hOK23cly9BXsKP32OPS+F66scFMaya7TeUbwAo6yOB73Vdmyjo0=@vger.kernel.org X-Gm-Message-State: AOJu0YxyCVd102EUatT4ETxrTrQIjBu8MN2quK19MTFvcAlVbdimwoW5 R5gAwVaKXRNC8ovutnLXD3nuh6RplSVnzUOOB3eWraGFdOOuzyiE9T2OiUgs4v9UnY7YMQVgilu ZFxI3cblcCyem5FHD9a31gGT2+6EMy5SVWOzsopbb4t2ig2gpNF9DXirjZ7w6425qdyw= X-Gm-Gg: ATEYQzxUaJYholNQBxwrTR16cKjI6jhwbkmlsdkmIDoF6XfoMrMBK36JsiEgxCktntE LAGqModrSBueWp/1TNGdDXWvocWJYPzjPNIXYkErdros+jgmHs0wO/Q8Q915AZ3CfxmxwdJGfwf rYQKZWE6nw8Pv0qW3TlJ0bQDZm1R9UV6jPAlR3WB99FHbRzcgBnzQhs2vTPUBTfSBrHjMNl7woP ik6melqY2L3E7dbHPgFm9S7dSYnjlAxPCAfgrk7IB8PzBo7r5HMOt/euigZhDtlHTaLBNgN6Snd tVfioFJCnrOlkFxVpHl0FOWC/ljT2lNpK6cCmw2uRk1bkvlmUxXy/SxQrWSSR9JmlkEtcVbneyX gA7v58pgp75GkQFi2/CGMU3bPEjAFUbwkBR8Uf/DDO5KABLs= X-Received: by 2002:a17:903:2f46:b0:2aa:d2f4:9c11 with SMTP id d9443c01a7336-2adf78db637mr150838125ad.5.1772430631696; Sun, 01 Mar 2026 21:50:31 -0800 (PST) X-Received: by 2002:a17:903:2f46:b0:2aa:d2f4:9c11 with SMTP id d9443c01a7336-2adf78db637mr150837705ad.5.1772430630877; Sun, 01 Mar 2026 21:50:30 -0800 (PST) Received: from work.lan ([2409:4091:a0f4:6806:40ee:341f:1665:8aed]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae3a9baf93sm64857195ad.27.2026.03.01.21.50.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 21:50:30 -0800 (PST) From: Manivannan Sadhasivam To: mani@kernel.org Cc: mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Bjorn Helgaas Subject: [PATCH] bus: mhi: ep: Test for non-zero return value where applicable Date: Mon, 2 Mar 2026 11:20:21 +0530 Message-ID: <20260302055021.8616-1-manivannan.sadhasivam@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDA0OSBTYWx0ZWRfX41GtddymSzz2 n+LuiP4PLl8QUAYI+IHf2njGZeVIFW8TIoPHEjjnrBncMyBPTdZWuh7kiPdhVWQprpjJu6x5d2P JCdLD0yxU1o/95KXjwyMqKJWXV0VXqwMwogVt1DY4CN4vzLTMCUozTxOmrTPRvWOqesBE4gf3ip I9j09rhvcN0KTwGLh/TFYbZWsSz/rTPFpf3Of7AfEMraTNUAzTIHLliMANcZE8T4BUBPtke3Mqw dWh2UM/eqsULdkvUqwm07gy/GrEsJ9Zs5UR3ZEZZKc4WdDGZ01KZeG8FUke4BI/rVCQIp3H7E9R 0QnlFM3P93hdGY1CZnGoRZ0q4ZRtWnzp3KLGUrzoT77ZAv10ts6BId0jSTgeiTxNijd4iitgcdJ gNuWFoqCePlDyucp/GgWvC8CWg9cKDTOyBPmzo5mLh7tEIQUKhpD6dsAojV5qxIIoQlY/iBNKCy vzfktTWu8JQqziCGILA== X-Authority-Analysis: v=2.4 cv=avS/yCZV c=1 sm=1 tr=0 ts=69a52528 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=sJQNH4r01jd-CmyNH9wA:9 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: J7NtbJmGAJqfO_mGqow4PHQM9dw6d4lh X-Proofpoint-ORIG-GUID: J7NtbJmGAJqfO_mGqow4PHQM9dw6d4lh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_02,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 impostorscore=0 clxscore=1015 suspectscore=0 phishscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020049 Content-Type: text/plain; charset="utf-8" Instead of testing for negative error code, just test for non-zero return for cases where there is no positive return value. This helps to maintain code uniformity. No functional change. Reported-by: Bjorn Helgaas Closes: https://lore.kernel.org/linux-pci/20260227191510.GA3904799@bhelgaas Signed-off-by: Manivannan Sadhasivam --- drivers/bus/mhi/ep/main.c | 10 +++++----- drivers/bus/mhi/ep/ring.c | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c index e3d0a3cbaf94..0277e1ab1198 100644 --- a/drivers/bus/mhi/ep/main.c +++ b/drivers/bus/mhi/ep/main.c @@ -367,7 +367,7 @@ static void mhi_ep_read_completion(struct mhi_ep_buf_in= fo *buf_info) ret =3D mhi_ep_send_completion_event(mhi_cntrl, ring, el, MHI_TRE_DATA_GET_LEN(el), MHI_EV_CC_EOB); - if (ret < 0) { + if (ret) { dev_err(&mhi_chan->mhi_dev->dev, "Error sending transfer compl. event\n"); goto err_free_tre_buf; @@ -383,7 +383,7 @@ static void mhi_ep_read_completion(struct mhi_ep_buf_in= fo *buf_info) ret =3D mhi_ep_send_completion_event(mhi_cntrl, ring, el, MHI_TRE_DATA_GET_LEN(el), MHI_EV_CC_EOT); - if (ret < 0) { + if (ret) { dev_err(&mhi_chan->mhi_dev->dev, "Error sending transfer compl. event\n"); goto err_free_tre_buf; @@ -449,7 +449,7 @@ static int mhi_ep_read_channel(struct mhi_ep_cntrl *mhi= _cntrl, =20 dev_dbg(dev, "Reading %zd bytes from channel (%u)\n", tr_len, ring->ch_i= d); ret =3D mhi_cntrl->read_async(mhi_cntrl, &buf_info); - if (ret < 0) { + if (ret) { dev_err(&mhi_chan->mhi_dev->dev, "Error reading from channel\n"); goto err_free_buf_addr; } @@ -494,7 +494,7 @@ static int mhi_ep_process_ch_ring(struct mhi_ep_ring *r= ing) } else { /* UL channel */ ret =3D mhi_ep_read_channel(mhi_cntrl, ring); - if (ret < 0) { + if (ret) { dev_err(&mhi_chan->mhi_dev->dev, "Failed to read channel\n"); return ret; } @@ -591,7 +591,7 @@ int mhi_ep_queue_skb(struct mhi_ep_device *mhi_dev, str= uct sk_buff *skb) =20 dev_dbg(dev, "Writing %zd bytes to channel (%u)\n", tr_len, ring->ch_id); ret =3D mhi_cntrl->write_async(mhi_cntrl, &buf_info); - if (ret < 0) { + if (ret) { dev_err(dev, "Error writing to the channel\n"); goto err_exit; } diff --git a/drivers/bus/mhi/ep/ring.c b/drivers/bus/mhi/ep/ring.c index 9375b16ff2a5..405ce16c02a8 100644 --- a/drivers/bus/mhi/ep/ring.c +++ b/drivers/bus/mhi/ep/ring.c @@ -49,7 +49,7 @@ static int __mhi_ep_cache_ring(struct mhi_ep_ring *ring, = size_t end) buf_info.dev_addr =3D &ring->ring_cache[start]; =20 ret =3D mhi_cntrl->read_sync(mhi_cntrl, &buf_info); - if (ret < 0) + if (ret) return ret; } else { buf_info.size =3D (ring->ring_size - start) * sizeof(struct mhi_ring_ele= ment); @@ -57,7 +57,7 @@ static int __mhi_ep_cache_ring(struct mhi_ep_ring *ring, = size_t end) buf_info.dev_addr =3D &ring->ring_cache[start]; =20 ret =3D mhi_cntrl->read_sync(mhi_cntrl, &buf_info); - if (ret < 0) + if (ret) return ret; =20 if (end) { @@ -66,7 +66,7 @@ static int __mhi_ep_cache_ring(struct mhi_ep_ring *ring, = size_t end) buf_info.size =3D end * sizeof(struct mhi_ring_element); =20 ret =3D mhi_cntrl->read_sync(mhi_cntrl, &buf_info); - if (ret < 0) + if (ret) return ret; } } --=20 2.51.0