From nobody Thu Apr 16 07:08:33 2026 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4585172617 for ; Mon, 2 Mar 2026 00:31:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772411520; cv=none; b=ID1p3uqgmpUDpEaCKxk25U3m0tl4HmQd3oEWkp7gByZRdxTf0HF8q+OvK9JS6qejsBHbs9nteNdPOFlY72ypbVc5Civ0wuQLdmgpnIXVtqR96eVpbQm6wzC31SnsGC4GW2eWiqpMIiZlqlgjqACrsqHcJUzLbn8h7YKjfExvl/c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772411520; c=relaxed/simple; bh=AlrKbqDeHRNXNb4EDS6ApO+T0fQy/Ymm4/uVtcv5ddg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=D96SM9ZPQjS1kA2LpKNkpIDv5RH2VWbvbJil3vdKnFSkrMlA+df7rCxlRth4U+1aqGjg6d98tUhhq7XrhmK1T7z7zcjQ+oTDYnRhEb0wdLo7eexShLCGk99VsAS6H/O8KESNmXfS89pr9S5xusBL8coSR4bmWc9Cyw/D7z98qqw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cvMgTN2D; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cvMgTN2D" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-124a635476fso4544597c88.0 for ; Sun, 01 Mar 2026 16:31:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772411518; x=1773016318; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aa44Hm0AKiWgB7Fd7mIwjWSqvDDfhYq64s8ZEZ38CMg=; b=cvMgTN2Dx3VxpoDFfDdGAhHRC9Vdc54ier4nbq1SzuGG2T31NtLR/bx4rlfpcawODr KmDpx8yAPnBrG/xYwavqB5E37uzmJlfUHkqmeuJHPC775frl+Zp85bCzxsNQeH29QfyW 2V7Qd+/l2+hxtDU3ZeCfEqrkUptbjXv2QKne3HKl+lwv1xmi5uvB7LDaVfJx3Jz5agPC uLvU5oox8lSq0OyynyDFYc1mxTG0/X5Ba6ahncy8X3CKZdqJkw+kGIyKSCCsQrNIhR16 1OKgw3G6yH3ioFkS97L8e20931sfKU5IkRLwNzgRZeUW2zoe/3Gr8a7OgngVeP4X5WwI u7Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772411518; x=1773016318; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aa44Hm0AKiWgB7Fd7mIwjWSqvDDfhYq64s8ZEZ38CMg=; b=ONCv/OKDuKbeu8vSLj1T2+2/0ujda+HTOYbbUIbKW3Ehoz30naOKYCqNoat0dRq9gQ bBGX6ZxTg9yUdLkvjg4R7FkJNzrpEgSZke4fk/nBpeDg7a0SYzL3BotVo1iavBALxRc+ MxIdPp9RBr0UKgil3zy9QJjpgHfCFCXSYIKjhxmzW7yDK8uKlt2K23FAH9HexE5CFQIM tUDi8v/SUiiPi7oQ6LztarMAVCKwfZxEQxOX80wmoPAX7YZfkFYRDe9TsrNpkt+Gca+2 vLoifJVoI4aMckuVuCpvfEQ1xy4FwbIMtl3v+N3pwZoq9B/HEDpzkDReAXi52+FUNahl /HDA== X-Forwarded-Encrypted: i=1; AJvYcCX7IVaiU3A+qbw/3M5g6C1VNMV5RcFuDZy7pgTLvg/ltkXmF3NkwtujeSsY9BKAJrG4IS5JbkSmLA8bYBA=@vger.kernel.org X-Gm-Message-State: AOJu0Yzlk1s6uoQJt4KK15ZRsySHZLxK6CHLqoGvW4voB9R/Lhw++o1q ulzruJ0YGSrmIpRIJ5MbftHwO2Dx9t7hkv3kmxP3HqF0uNPl3IWKrIEPd92jYTOl X-Gm-Gg: ATEYQzxq31uge1I2s9eCVs5WiA8ssYhSy1mW56UR0L4XAP/nzXM0FQsmRXO7mME+DnI EBhWuK2vJIKf1Rg8oC3N++LTB/D+H8/8RcQKZBl22cDyPxGKgybWEeakgbNzC8Wf3aahRmhj3ZA geub/HgMdA46JgmPzaROhEcBa2j1wCNedohhp9uaUH1KcsmkFnEwklg0Z8q0HR1CyZOa8d85eRO 7vakgb5p5RzagfheTa4vdnfHR4RpM81PvB/U3dzFJoIwVJqXRrUkVUx42RNBC7VlRLTTpqLoRrS 1kiXapdS1b2nJ1ctN6ACwn67cANozkLd+Fk9EIC1TthSlYLaRSy04RXFvLol1h2cfMWvCmwX1K+ dsU4fdfcIb2+sdWQgZ2NyBE1AYQque+JxKhgpygNLE8PD+Zt0ySuz8mOplOm71sfJNx0G3TtAVX McbTW3HFPd3IytB5pIXeDdO9n6U5BC9U5jZwCgsJUip4mFr6il7c8rsEUNHjDkgfyzKeIZJNbTA 4zBjWYlz/KeYFw6kJvRFBAtC6SP5ogs1xpAN/yq7ewsfwrwk93LewmXbq3RTNfwFgXsn4c9DT+p WsfwGwOHxASPGRZVSmFQViPcq6t3 X-Received: by 2002:a05:7022:698e:b0:11b:ade6:45a7 with SMTP id a92af1059eb24-1278fb7de0emr3640973c88.1.1772411518251; Sun, 01 Mar 2026 16:31:58 -0800 (PST) Received: from arch.lan (c-98-51-119-100.hsd1.ca.comcast.net. [98.51.119.100]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12789962f89sm11506020c88.0.2026.03.01.16.31.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 16:31:57 -0800 (PST) From: Milos Nikic To: jack@suse.com, tytso@mit.edu Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Milos Nikic Subject: [PATCH] jbd2: gracefully abort instead of panicking on unlocked buffer Date: Sun, 1 Mar 2026 16:31:35 -0800 Message-ID: <20260302003135.93802-1-nikic.milos@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In jbd2_journal_get_create_access(), if the caller passes an unlocked buffer, the code currently triggers a fatal J_ASSERT. While an unlocked buffer here is a clear API violation and a bug in the caller, crashing the entire system is an overly severe response. It brings down the whole machine for a localized filesystem inconsistency. Replace the J_ASSERT with a WARN_ON_ONCE to capture the offending caller's stack trace, and return an error (-EINVAL). This allows the journal to gracefully abort the transaction, protecting data integrity without causing a kernel panic. Signed-off-by: Milos Nikic Reviewed-by: Zhang Yi --- fs/jbd2/transaction.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c index dca4b5d8aaaa..04d17a5f2a82 100644 --- a/fs/jbd2/transaction.c +++ b/fs/jbd2/transaction.c @@ -1302,7 +1302,12 @@ int jbd2_journal_get_create_access(handle_t *handle,= struct buffer_head *bh) goto out; } =20 - J_ASSERT_JH(jh, buffer_locked(jh2bh(jh))); + if (WARN_ON_ONCE(!buffer_locked(jh2bh(jh)))) { + err =3D -EINVAL; + spin_unlock(&jh->b_state_lock); + jbd2_journal_abort(journal, err); + goto out; + } =20 if (jh->b_transaction =3D=3D NULL) { /* --=20 2.53.0