From nobody Thu Apr 9 15:00:50 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C6E34219ED for ; Mon, 2 Mar 2026 15:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772467064; cv=none; b=PgnjNyrIw7AvE8CWXd2S6HSz1jqfr5CEyLkObhhiSU7iWf4ENGC1+iCxWvVg51l6yal+7PnVocdjSVvg0flCMDsvTbpLj2XGMNKdgoRmfW+TbYpOSaqiJu8jYJQyF78A9eAD5MN+5TmeVd4/PWNNLw/5CKMCtVSX2Nx17j4Z8Jk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772467064; c=relaxed/simple; bh=6dN4XjHr+6OQnOzxmGwMll0VZH7PW0q5aNlxk1E5+Hg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sJE+Bzif/ky0Dv7mte2Ce4tzcM4BrLwx0B+N3J8osM7sFpZDJt3vpXlmivI9IaDlPyLZYvNdf6bAIbe03CJGdqRlgfZOna1c3UOYWt1ieGscYCdJNwPVcyvGXwo1G6hcdENs4POHN9eNbLvvCLACq6+66Vh/+7u9BwxSa36T6KM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=L6SDHWoD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WHjXsyt4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="L6SDHWoD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WHjXsyt4" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62294W2x3752705 for ; Mon, 2 Mar 2026 15:57:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9iGVNuTYeeAltbq14HNN1Bd2g5XTMHQ/MFj6N7hyZ8I=; b=L6SDHWoDuyS8pwP/ BWEWgMtQNT4qHpXHmncz+8QDZEMvIHQH2z8zGA3D4C6XvWXS3ZodhKqc2RN6zfKE MQNd0+b1EtnEV1ZLVtXzebhTyRdKfeF5o9vGd214a0ZRIQPHJmksT+nslXZ9gjOn rCJmc5n5BBCK1yghxPxkgvMbX54XET/YeqaZ32sPiP5j4JiBZvHulSQWYqxizXNk +9JpZbLooBzyjFK5bBmh16tJF2WbxLDPYvUAWbCFMzVTokT2FjQ/O6OhexVIstqh tipLAZXSlJAQXfQxcJ3vvkvRIe9LgUIqiYD4k/Qt93hCbIiKNZ+N1ZKhLy4oxskM ctVcYA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cn7kq9dfc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 15:57:42 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cb5359e9d3so3751719685a.2 for ; Mon, 02 Mar 2026 07:57:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772467062; x=1773071862; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9iGVNuTYeeAltbq14HNN1Bd2g5XTMHQ/MFj6N7hyZ8I=; b=WHjXsyt4wgctG9kBrd+2P1kFpQt/0F0Gj5zwN2bqGWxbXW60HIPNtRVCRJz3LwlRYt hCcbbslwO/93Dz2dz36EMC/9GTNEOO43iUsXsR9AzttzgTlneeX27+f+eC+34FWhotRZ BGS2mluv9jrWE1HD6fZhKOvlob23xT8ahzhoRbqJzb20Y4HvcpVLzhJZVOOaZOqLGHfl nmNSQ3USWbCiKDq1fvEr/9uUvuV0rJyCVcws+nIh0bl6byjURV2hdb4rINg6VoK6rh4N w4UB0vzDTd4dtfScSX80KDJ7Q+j+5dY2wGo6Ht//Df2HSiZd6A7JF/qWsa/nKStkTEXx 0+tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772467062; x=1773071862; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9iGVNuTYeeAltbq14HNN1Bd2g5XTMHQ/MFj6N7hyZ8I=; b=O5tYojpvJ1rCmFM6Z9GMMi1BWR/0m7Hh3RCKyAAQX/jPqPFSf8mKnJfjMK2wGFs1wC XLsQA9lSnTREMOl/PkPhX9e1GSvR4QkdtQDwO9Z5BWriQuSESBqGn+Ph86cg9DzI9f/7 p5GWYAC2WeQGfIl7lXoOIuferYVVRc0FWSdWzSNodoNIfS19biwoKsw2ECwvv78baCbg O57DLIB6M850zjjefMIJ3da6XNJmvrsmLIrNolyOpaqCgvcpFvTFpE/b6i5GnRK1+GMw lAuOMx9qH659jS7LkrXfKkCYg6bf/gcWR8SMBabC5LSC6yHWxfG0Tqh7kLIX298zokqh FEsQ== X-Forwarded-Encrypted: i=1; AJvYcCVl5ZFn5XDJAdDjGy2LiKuy/d+wPmmSqA/bJgCLH9mHIYJ/+h6We52ZpSQ/mRtK+YC5pmAaSjWMuU/sxDY=@vger.kernel.org X-Gm-Message-State: AOJu0YzrjGiSNae/sERZIZgzhjSJoreeXUCb2GVtalPQETLDe4RMYq8q 3nUsQxWxE7MMsUjMT3n5JkEBdFNck8VwrYRmAKl7JKtaqXAeLbPidPz6olNfGfjY3WM0P1nvwal 8LDo7uHHIYAouQVQA7DSaMCC7w2JW7dtChJuhGWjPdqdA8bPGT6xBGzC1Acg7bdsFODzgXywWKd 8= X-Gm-Gg: ATEYQzwpaK/FgXZy3kYT7YzppIy+NEzyab492JlxIy1SkiJhazWEnBB37UN9EW3Wa4T 5XgKRKiRjsosVkgBK4c1FDIPZtCKoiwb+J8EkZdxRE1dyCtJAKTjSRLs7PUgz5pgPqWCCSQEmka AFxsKZXxbeSCjntUGVy8M1wOs3phSnNzj7l4+zyz8p//08RO+LYVbuDz+KW7E9X3f8LJJbDSmFs 3nIjvtlcXbTmc2y3weiFMve9CM10kJwdwHdaURtxhns3r9C3NrZ28fnhPQSfIT4MyhcxLEwcxCY w7TM5+VzYS3jP1WTYF3phAqCbMx/NeAUim0Vb+Itcsr7ASthDVNvaJx5THjWkBnC04fn5Kg9gPq 4dDptn+fVczNod6+meNfRzmSZVYOlcWOoYVJnRpbnnoR4x7GQCryq X-Received: by 2002:a05:620a:4509:b0:8c6:e11c:5ebc with SMTP id af79cd13be357-8cbc8ddd208mr1694529285a.18.1772467061628; Mon, 02 Mar 2026 07:57:41 -0800 (PST) X-Received: by 2002:a05:620a:4509:b0:8c6:e11c:5ebc with SMTP id af79cd13be357-8cbc8ddd208mr1694524985a.18.1772467061130; Mon, 02 Mar 2026 07:57:41 -0800 (PST) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:87af:7e67:1864:389d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b41831easm11282438f8f.12.2026.03.02.07.57.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 07:57:40 -0800 (PST) From: Bartosz Golaszewski Date: Mon, 02 Mar 2026 16:57:15 +0100 Subject: [PATCH RFC v11 02/12] crypto: qce - Remove unused ignore_buf Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260302-qcom-qce-cmd-descr-v11-2-4bf1f5db4802@oss.qualcomm.com> References: <20260302-qcom-qce-cmd-descr-v11-0-4bf1f5db4802@oss.qualcomm.com> In-Reply-To: <20260302-qcom-qce-cmd-descr-v11-0-4bf1f5db4802@oss.qualcomm.com> To: Vinod Koul , Jonathan Corbet , Thara Gopinath , Herbert Xu , "David S. Miller" , Udit Tiwari , Daniel Perez-Zoghbi , Md Sadre Alam , Dmitry Baryshkov , Peter Ujfalusi , Michal Simek , Frank Li Cc: dmaengine@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, brgl@kernel.org, Bartosz Golaszewski , Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2012; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=DfH5Bb+Cx5AadRW9+jaH1GcMtyO0VLpMWlVREcJBr7o=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBppbNkOhcfZbOa+wMaID6vgraXOKRBMT7qNcfsB Wzz3K6XPTyJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaaWzZAAKCRAFnS7L/zaE w+OID/4mTtlXpEUiB3RNmRgLvY6eej5CSRNCAUPyC2kO/mA+7dv6YhEYDmXv1jpNLaNml/Ahwqa Pp9geYv7K/Dp9cQXoZlWCNRCZ1lWarrGJhSNhWaix+8xVHLCJJDXpP/gd/J1llkVo2gTEhSBSl6 t2QQMk802Ju777yCvSsPxucUjOcq1V5i4TmuvTUT2+p2SdSl7rcxNKHW8zVeKN9OJ9PjO5F657l LNEnuAlD4iMlfsLKMLvKjusBOCO6H9kS6aLEo0KvSwZmQFsGUL8n3P93O2R56Ey4EJEUHoiNJ4k hG3tFVMb1tNFJf1J8LagBHhRU9avV+NK1Xl+Fmu+qUvN/43k/YNkPeK0aThQoZc8Y3YZaaKaT3X mDRoTu6uIunjByGj0HVODLCdmK6cYN12YGT8F4Xhr2tGs4nJPLsQ7ngqpJLspGr3yWJq54Qtpmt qVPRygk6pldWuE21E9oZr2qYuo2P/JEbnQvawoASRmxFfH0uN4UGgH3B1usJRNoRzwF0m3CYRg8 sHQbbyFUDTbU9YyjAu12sHfMfrboLyGQa0V79cZtLMH65Ub2SKCmigDTGL4OUt/Th2kytc7mHQ8 MugneSEySKGuYI+BR85fQpW8kzYQLvQyyJpAVPg7oHWNSYyP3BaP0C3nAqxE/NpqA8CnM4kSQPV KQyk3QdCdJ/ngqg== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-ORIG-GUID: tLxCrb1gB5tEDC7FnmsJ-mEe0UUBr3HK X-Proofpoint-GUID: tLxCrb1gB5tEDC7FnmsJ-mEe0UUBr3HK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDEzMyBTYWx0ZWRfX4R79jURlRoES qrRDLoyssF0Sgv+k4FIbAANrrruw/NfQivslgk9qW4MYn3hG35UQBZvhsdgyx2l+tcyVzFVT8Nx iEYPU0k8CeUkJDC9COFgMtDHKSVZxzjqTrG0wl66oqpzmpUJ7ZyEsy7ltxJXvbfDbBcfKk2weT4 5LiOyhWDWe/6KQvC5oCJPqMuDgViEjOgRx29VOmigrnDTvphrjLBqOqxEE7WO3RfviGmtZQQC7y fOylu6JBsQtgS+s8Fx4cYagHOIAxrGhU/c+X7/ro1htlXjvfnELgBhEwq4mPnLky+a9+3ttkfod yIKatnhWfPpMbjcyuv5kJEdrHx+V00j2YDhLVs59onLSIhpzTeoFXbuiV/N+osdIHd7ARe4x+ym 2glxtCi5iooAcepj+vXaB9bNzJlXd2p/h9nWmtKap7clSoMSydQYnlNJ3JEO7qBQJa2ugIdrHwF pDEMVHdaLZwjnb3LHgg== X-Authority-Analysis: v=2.4 cv=GLkF0+NK c=1 sm=1 tr=0 ts=69a5b376 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=tWRRbWwrKX-5tUpmLDIA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_03,2026-03-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 spamscore=0 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020133 From: Bartosz Golaszewski It's unclear what the purpose of this field is. It has been here since the initial commit but without any explanation. The driver works fine without it. We still keep allocating more space in the result buffer, we just don't need to store its address. While at it: move the QCE_IGNORE_BUF_SZ definition into dma.c as it's not used outside of this compilation unit. Signed-off-by: Bartosz Golaszewski Signed-off-by: Bartosz Golaszewski --- drivers/crypto/qce/dma.c | 4 ++-- drivers/crypto/qce/dma.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/qce/dma.c b/drivers/crypto/qce/dma.c index 68cafd4741ad3d91906d39e817fc7873b028d498..08bf3e8ec12433c1a8ee17003f3= 487e41b7329e4 100644 --- a/drivers/crypto/qce/dma.c +++ b/drivers/crypto/qce/dma.c @@ -9,6 +9,8 @@ =20 #include "dma.h" =20 +#define QCE_IGNORE_BUF_SZ (2 * QCE_BAM_BURST_SIZE) + static void qce_dma_release(void *data) { struct qce_dma_data *dma =3D data; @@ -41,8 +43,6 @@ int devm_qce_dma_request(struct device *dev, struct qce_d= ma_data *dma) goto error_nomem; } =20 - dma->ignore_buf =3D dma->result_buf + QCE_RESULT_BUF_SZ; - return devm_add_action_or_reset(dev, qce_dma_release, dma); =20 error_nomem: diff --git a/drivers/crypto/qce/dma.h b/drivers/crypto/qce/dma.h index 31629185000e12242fa07c2cc08b95fcbd5d4b8c..fc337c435cd14917bdfb99febcf= 9119275afdeba 100644 --- a/drivers/crypto/qce/dma.h +++ b/drivers/crypto/qce/dma.h @@ -23,7 +23,6 @@ struct qce_result_dump { u32 status2; }; =20 -#define QCE_IGNORE_BUF_SZ (2 * QCE_BAM_BURST_SIZE) #define QCE_RESULT_BUF_SZ \ ALIGN(sizeof(struct qce_result_dump), QCE_BAM_BURST_SIZE) =20 @@ -31,7 +30,6 @@ struct qce_dma_data { struct dma_chan *txchan; struct dma_chan *rxchan; struct qce_result_dump *result_buf; - void *ignore_buf; }; =20 int devm_qce_dma_request(struct device *dev, struct qce_dma_data *dma); --=20 2.47.3