From nobody Tue Apr 7 17:15:10 2026 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C1643FB076 for ; Mon, 2 Mar 2026 13:32:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772458343; cv=none; b=ssVUYcp/FmuW/X0FKC3mNanJG1DUpit90oaZLNjnp/NgqOQc/BoFH5A1oqCJZ/CGlGwRHUrMesDTy1BYkEuLpM6vSOFEGHyBA2GNFKTCCy4RoWOIOQ+biNuMgL7JfWbT6EO1B0JDjv02tsKCpy8Crf/C4LudQzGu1XThyRKoeBE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772458343; c=relaxed/simple; bh=YpM1lHLHES0D2RDGEBro9MqKfLBBWbbGMNDTqVCiga4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FT03gIvJ3J4GDmBDNL+b+iCfhG9IubAuxEsxal+8v/Fb7Rpic5EAyFGh/4ZBs+wcFc1+wd6RVRgc0/Fvd3YBTMQniV+V0WRkz9GGZsaE7Gmr5buHSkHC8Fn8k5h0uS/w3J8MqbRi9YLn58V3RjzaoYyaToFIhhavZAV4R61ezEI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rdG1s2G5; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rdG1s2G5" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-65f980cea07so6297393a12.0 for ; Mon, 02 Mar 2026 05:32:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772458339; x=1773063139; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PHqedqbcEfS+s76zrbM+gGzB6LORzSXrgaPJoZBxb/k=; b=rdG1s2G5CodWoDA1whho6wtk+8mex4QP09bq+LbCIM46xyw2usnZUQH6FAxhU7yfpU jFA1Dg5QPPw11CkYESffVFrOy4f3xoQfhThbY5+NrDWVeERnSppbAjjGQjSOv4bb7NCk fzA9u0mk75OwZZvDesV6261ILKhXLD4RkduI8e//PLov55dSJ7HwrroFej4C3UmoBVW6 vTnO4pLY7w4ZThma5I2vAotKcTWK51kwL/+9+rqS/2fDwZIDZZ/6BIUhKVfBoDhxk6Lo RD4emsZ/SMRZtyCfiRiTgTL7j5jHUR1geY2yZMUJ/+qUhISaVRYSbzdqF41kV8DY0/J4 gwIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772458339; x=1773063139; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=PHqedqbcEfS+s76zrbM+gGzB6LORzSXrgaPJoZBxb/k=; b=Vgn276hONUgkycETNQtOi81oFarXrmnA6t8wapJWdUNx2nxdjFoZcA7l98IqUdSRy0 DWl4VDuoxxY33HHhFWGJWCaoBjeZ8ajR5ZpgX2T0jTcH3NxKxJaisxBO0PxkNDu1yfd4 AUTw8Jq6MSU0m4ImVAa/IkCdqdKgAyZv1z4X1NirJ2KLNcMr6FpP13GFSQzVJBiPEAfv qlP+JA/tAuDNbl2z8Twpm6DnSbN2yDHuMcVQDptS9p552ALUG7uNE2EWWhWa9Wdj+rxe JBec8Pm26P415vHfk9KqQi3cwB/SNp9Y+Hb4zEyjpPs3FYkxrtho6C0l/8o/YPWELfIb 2DyA== X-Forwarded-Encrypted: i=1; AJvYcCWn8aVmDfmxLpkCPHQc6nWOcBolq24Hw22d8cjX/Koq1HZv4INcOQ+2NAvr9Xxf/KUHHIfVL36qAR7NOYs=@vger.kernel.org X-Gm-Message-State: AOJu0YwKtURTQ971EjXvqpKqXaMMAZ3OI9DQIZdqR049Ty3kp2ShGb+D 9a602vodRR3+mCWrOpS15cMqLaC/sp5aV1eN1exAd7WqwJv+j8ESAKsgPMm1vCP3E6g= X-Gm-Gg: ATEYQzz1g+TbCvFx4De/qogJixkxCLsuNbjXaHKqBu30AO6DuLN++InrZ2O8hjau7y9 4b8z+t29UTygq/fi19pys9xp2h2qC6rRrg1viKFxtBn6r/TitstkbBsU2OljY7DOojMH2/ne4GU dxD2Vjb0y3hnylskgr5xq0tt4Ktdpx1egnEaofSCipEYvUIPlqfeZ7jakiiuUm5zKFpD6KEpJgs tfAbXez7EwQReFzehPmXeRWquAFmImmOa5/+gxmdSSBLRg5hL6pa9FJAp1/W43wTwHu29MLNaDF P1xXW4a7NXCT+uiKzNrvYYCyXCV/JYm1+LZAVRSsZawLZGSomVw3RsXxNcGQYTp67u8On4w1ePS p65eBF1dBSZvM0TDwCOBKscRt4LFUMCaRupRTJbyGWgIJG2GJuPR3Nbp4xbn7nwtDY8XUU3u2F3 KmRHuYmGMvJZyX/0F8ALivO1HcYBRkq/FZZZl0b4oHJ8OEvpj4/cvO8EPcrWs4hTXIcQKbXMRiC Fj3FSvzxUnF0AA= X-Received: by 2002:a05:6402:398b:b0:65c:2af1:b7e2 with SMTP id 4fb4d7f45d1cf-65fddee587dmr4953593a12.27.1772458339270; Mon, 02 Mar 2026 05:32:19 -0800 (PST) Received: from puffmais2.c.googlers.com (221.210.91.34.bc.googleusercontent.com. [34.91.210.221]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65fabf6d1c6sm3282988a12.17.2026.03.02.05.32.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 05:32:18 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Mon, 02 Mar 2026 13:32:04 +0000 Subject: [PATCH v3 05/11] power: supply: max17042: use dev_err_probe() where appropriate Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260302-max77759-fg-v3-5-3c5f01dbda23@linaro.org> References: <20260302-max77759-fg-v3-0-3c5f01dbda23@linaro.org> In-Reply-To: <20260302-max77759-fg-v3-0-3c5f01dbda23@linaro.org> To: Hans de Goede , Krzysztof Kozlowski , Marek Szyprowski , Sebastian Krzyszkowiak , Purism Kernel Team , Sebastian Reichel , Rob Herring , Conor Dooley , Ramakrishna Pallala Cc: Peter Griffin , Tudor Ambarus , Juan Yescas , Amit Sunil Dhamne , kernel-team@android.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.3 dev_err_probe() exists to simplify code, harmonise error messages, and set the deferred probe reason if relevant - there's no reason not to use it here. While at it, return the actual error from devm_regmap_init_i2c() rather than overwriting with -EINVAL, when relevant. Reviewed-by: Peter Griffin Signed-off-by: Andr=C3=A9 Draszik --- v3: - update commit message regarding devm_regmap_init_i2c() --- drivers/power/supply/max17042_battery.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply= /max17042_battery.c index 07759d4fdc37..b9277f81a25d 100644 --- a/drivers/power/supply/max17042_battery.c +++ b/drivers/power/supply/max17042_battery.c @@ -1053,16 +1053,14 @@ static int max17042_probe(struct i2c_client *client= , struct device *dev, int irq chip->dev =3D dev; chip->chip_type =3D chip_type; chip->regmap =3D devm_regmap_init_i2c(client, &max17042_regmap_config); - if (IS_ERR(chip->regmap)) { - dev_err(dev, "Failed to initialize regmap\n"); - return -EINVAL; - } + if (IS_ERR(chip->regmap)) + return dev_err_probe(dev, PTR_ERR(chip->regmap), + "Failed to initialize regmap\n"); =20 chip->pdata =3D max17042_get_pdata(chip); - if (!chip->pdata) { - dev_err(dev, "no platform data provided\n"); - return -EINVAL; - } + if (!chip->pdata) + return dev_err_probe(dev, -EINVAL, + "no platform data provided\n"); =20 dev_set_drvdata(dev, chip); psy_cfg.drv_data =3D chip; @@ -1090,10 +1088,9 @@ static int max17042_probe(struct i2c_client *client,= struct device *dev, int irq =20 chip->battery =3D devm_power_supply_register(dev, max17042_desc, &psy_cfg); - if (IS_ERR(chip->battery)) { - dev_err(dev, "failed: power supply register\n"); - return PTR_ERR(chip->battery); - } + if (IS_ERR(chip->battery)) + return dev_err_probe(dev, PTR_ERR(chip->battery), + "failed: power supply register\n"); =20 if (irq) { unsigned int flags =3D IRQF_ONESHOT | IRQF_SHARED | IRQF_PROBE_SHARED; --=20 2.53.0.473.g4a7958ca14-goog