From nobody Sun Apr 5 19:42:18 2026 Received: from mail-yx1-f54.google.com (mail-yx1-f54.google.com [74.125.224.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FC8A4964F for ; Tue, 3 Mar 2026 00:33:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772497986; cv=none; b=GPmqNJtYDKDGTfhGCcOmWccQIQZ6pSYaS5ag2c7Q4fx8i95aVNy9OqMv1nknagum798/QSKXeuNHYCv/bcZsmKOwZQhBhoh5dCj6MBdAdEsPkmrsmFfigZAfuOL9P6W/zIK+ds06oTIsupFys0do4HzE9LisbK//wcP7wrs8TgM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772497986; c=relaxed/simple; bh=OKYgKlSTeG4GSRH5iOsE/UaIFTSGi8cSgGLLV4ZpEA8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=a9txZahGdbuwu9D1cgEbxdOXf2WSNOHp1wibV6zFUTh2iXtGG68ESKhvB3UtDiUlc+QTF6++1eF68Khj6kEoqXDFOmJPmo4zPybs+HwhWJSLOM+UyJSBWB8sQapEL1tgsWHal6zQVuaPp/IbmyCZSdy5zktN2Xvu92gHs4ZUwEM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eQZu/LYQ; arc=none smtp.client-ip=74.125.224.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eQZu/LYQ" Received: by mail-yx1-f54.google.com with SMTP id 956f58d0204a3-64ad9fabd08so4163505d50.2 for ; Mon, 02 Mar 2026 16:33:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772497984; x=1773102784; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=8gRXaYxmpUNBUEUdJFcpug3buWfv3yzf3AEaknZ0Z1k=; b=eQZu/LYQV41Epc5ciB3Wj6JFCUIkzI/S8feSjLKd6/vYeX1fEXtgXYvPsd208hiivm 0S0FvSxggtAFmBkRrFw7zzoiGZudeyaursq3Rn6wK0EbEXffbZre1zuVYffhgPw/6d70 GcEAgVZC8GVXpwwWekFdy31UL4Vm7+OTdK3NKxkAnDlnfL1Hoc/VkSssPnr1AX8aR5O0 2KQOSn0io8sXPNu3UHLEN0vrNFmIHx/Q0OFt7Ye01S8h48JNJc/Ljihv4+7MUj2ZDGjq 9ZpSeUUyq2qjNcKCqNYMq95kSU9DioXPf1wcIms5P4lVSpFtntKGD6iF0uyJ2JHiew2x 9ong== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772497984; x=1773102784; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8gRXaYxmpUNBUEUdJFcpug3buWfv3yzf3AEaknZ0Z1k=; b=r83Gudov7DAhhGtl3xd3V5H1lzIxozEjVL3KAHXt4K0J6AEhKluir9c5nWjKkP7kga aLfv12ZCjcAIkmQbisS6QtDlPxtkwJjee6Alssh7+GvoEglBBU6vfAP/VgAPCfBC7QuE w/Y6kUKOhlZga/QZiKQMPMeHGij6aONTBdfvKa1YVomWx7ME3XOR6XrFBIH9sRQRJDC4 mMZaMDi/kWZcf4Wvlm/LMG9v7R9+/TMDS/ljtaG+FnldIFJZsNeyQvKEf4f7NMKw/2Si +ac5OuuHYnvlVJuURcaJ+CXOIQyF2dShNrPVrxAqgdYXuWwPv1L9I5fL6003xdhj7uI/ +uLg== X-Forwarded-Encrypted: i=1; AJvYcCUvM7WOcJiMMV60fiCHYSFfKOTa34ae8rP5eCco4EFs4UXbkAP+cEG8uYins7zHXfpHf8a8s2ehrx1ZFSQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxgxi82k4gPM2+eXO9BCJHdHA54ava0P5MNN+QtmF9rt7X7XDcu t1Kfwi5OOCONeMmPD3ZH188uIe/2xivDurS3I4N+l1uuSdELTNVVYhBA X-Gm-Gg: ATEYQzxqUp1wsmszzaFtRwvGIO1aU3fJbeNpSiNkVI+OgE8FatHQUGeGRXsRe+c7uPV V4wuNu+S4op3VtHSTjQGaltUIcAHMOmAMR6HBbgQqCR5i4wo1GxHJCxwoxfTfvwd2+Yrz6GbmmQ X56vMWarAxWPOlE7w+Ov2t2NJP7RakhdUdqbK0KIr9b7ZMl+3yJcVrcQ+W3Q/W2R9qyN4iEN7+n TxR8jnrCNb6yhI9329IXz7Qbkcna3SCyEAAvEZ0vajfLAdKdnRriBaoTCVsUToskEJ08hHs8r2P obAxu1Ra0ZM6GQqwZ1AbjKsULgXfuv879jHbAYM2AvOkyUq1QxoVdt97lR0e1SbVwLIk0C+Ud5/ YEKLn8uea96pA77R04M0glKMi9obaJD54EsLhaiphWF6C+XGdbWvtfMR+Vgl3tJLUPgi1hpLKBT sabuFa5LK4iz+GjCrOO/ggEg== X-Received: by 2002:a05:690e:174b:b0:64c:9c10:c16 with SMTP id 956f58d0204a3-64cc2224ed0mr8535381d50.53.1772497984218; Mon, 02 Mar 2026 16:33:04 -0800 (PST) Received: from localhost ([2a03:2880:25ff:41::]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64cb7572340sm6178927d50.1.2026.03.02.16.33.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 16:33:03 -0800 (PST) From: Bobby Eshleman Date: Mon, 02 Mar 2026 16:32:56 -0800 Subject: [PATCH net v2] net: devmem: use READ_ONCE/WRITE_ONCE on binding->dev Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260302-devmem-membar-fix-v2-1-5b33c9cbc28b@meta.com> X-B4-Tracking: v=1; b=H4sIADgspmkC/33NQQqDMBBG4auEf+0UE1urrnqP4iJNJnUW0ZJIs Ih3L3iArh98b0fmJJwxqB2Ji2RZZgzKVApusvObSTwGBVObtjamIc8lcqTI8WUTBdmosTfn+1Z 3obOoFD6Jg2yn+cTMK8ZKYZK8Lul7foo+0x+yaNLU3L2zrPnah+4RebUXt0SMx3H8AL1y5Tq2A AAA X-Change-ID: 20260223-devmem-membar-fix-3a5cd9618f8a To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Mina Almasry , Kaiyuan Zhang , Stanislav Fomichev Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bobby Eshleman X-Mailer: b4 0.14.3 From: Bobby Eshleman binding->dev is protected on the write-side in mp_dmabuf_devmem_uninstall() against concurrent writes, but due to the concurrent bare reads in net_devmem_get_binding() and validate_xmit_unreadable_skb() it should be wrapped in a READ_ONCE/WRITE_ONCE pair to make sure no compiler optimizations play with the underlying register in unforeseen ways. Doesn't present a critical bug because the known compiler optimizations don't result in bad behavior. There is no tearing on u64, and load omissions/invented loads would only break if additional binding->dev references were inlined together (they aren't right now). This just more strictly follows the linux memory model (i.e., "Lock-Protected Writes With Lockless Reads" in tools/memory-model/Documentation/access-marking.txt). Fixes: bd61848900bf ("net: devmem: Implement TX path") Signed-off-by: Bobby Eshleman --- Changes in v2: - add ASSERT_EXCLUSIVE_WRITER() to mark write-side critical section - add READ_ONCE() in validate_xmit_unreadable_skb() too - Link to v1: https://lore.kernel.org/r/20260223-devmem-membar-fix-v1-1-37d= cae1e49f8@meta.com --- net/core/dev.c | 2 +- net/core/devmem.c | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index c1a9f7fdcffa..9036fcf9f965 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -3987,7 +3987,7 @@ static struct sk_buff *validate_xmit_unreadable_skb(s= truct sk_buff *skb, if (shinfo->nr_frags > 0) { niov =3D netmem_to_net_iov(skb_frag_netmem(&shinfo->frags[0])); if (net_is_devmem_iov(niov) && - net_devmem_iov_binding(niov)->dev !=3D dev) + READ_ONCE(net_devmem_iov_binding(niov)->dev) !=3D dev) goto out_free; } =20 diff --git a/net/core/devmem.c b/net/core/devmem.c index 8c9aad776bf4..69d79aee07ef 100644 --- a/net/core/devmem.c +++ b/net/core/devmem.c @@ -396,7 +396,8 @@ struct net_devmem_dmabuf_binding *net_devmem_get_bindin= g(struct sock *sk, * net_device. */ dst_dev =3D dst_dev_rcu(dst); - if (unlikely(!dst_dev) || unlikely(dst_dev !=3D binding->dev)) { + if (unlikely(!dst_dev) || + unlikely(dst_dev !=3D READ_ONCE(binding->dev))) { err =3D -ENODEV; goto out_unlock; } @@ -513,7 +514,8 @@ static void mp_dmabuf_devmem_uninstall(void *mp_priv, xa_erase(&binding->bound_rxqs, xa_idx); if (xa_empty(&binding->bound_rxqs)) { mutex_lock(&binding->lock); - binding->dev =3D NULL; + ASSERT_EXCLUSIVE_WRITER(binding->dev); + WRITE_ONCE(binding->dev, NULL); mutex_unlock(&binding->lock); } break; --- base-commit: 9439a661c2e80485406ce2c90b107ca17858382d change-id: 20260223-devmem-membar-fix-3a5cd9618f8a Best regards, --=20 Bobby Eshleman