From nobody Thu Apr 16 08:34:49 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 011A82139C9 for ; Sun, 1 Mar 2026 17:08:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772384927; cv=none; b=iVrEctv1X52fhnkH9FOipV/sjg54h4EIqz4Ijl0e7KFRySV0Hr7yEIRCJAuTtl1r2ZY3KDtM1tS7mtr4miXTFPAE6Qm9TZOJO7FfiNllJHlXW1Vrnqwt5+9WoqxILptqoFgGTVifPEg2nZyfFm+smGWWmkQtFuqaPBRvvrh9rH0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772384927; c=relaxed/simple; bh=yRcPxQvhGF4Ecv8niJ2audTUHBcYg9U8KcKsj1DASZI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=lBGQOrAH0Jbu6SPS+r7Wkvh0AwoLen3xU5rTP5W5ODnRsxMP8chS2OBnJmTUZj1a0CDyErpxlKqBIbFLcnKs/l9Mx5+vF/o8Xsz59OpYCYAtO0KYS2OojGZAMl9tciqlQlyQWPysnjzx1sh55LVjUn0qc+WLTTG2sJb/XgSHyag= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DaL4ONfe; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DaL4ONfe" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c6e1f417918so1003324a12.3 for ; Sun, 01 Mar 2026 09:08:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772384925; x=1772989725; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=JC8dtCejMLT5Ebas54y2Sb5Ey1Dlmdy+AbqrqYYmf+k=; b=DaL4ONfeVzP0B7gbzDeGEKvBjLLXzLadxcKSGR53fVSRzPIs8c14Pef0N/MJc6tfXu 6PPkxv4WrEUJl9sHOCg5UoozCmvlOLLEFCApuP3zg0LKGtlNZ5SPOKSk9X1xNCbPOxHs s4sKQZqJj7FnBIrBSqugOmFb/xeEUcvPpvU2mkicR5p7pMm50ZqI9L6bvmAaWYQCLdyh IpQ7FTNZ7sM+v6swyl4hA3YX8V5m1f56HNSeDA7FIFNBzb6NBW6jbPem4cEZeyZvT0MN KiYZdWbS0fdrXeD3VYJtLvS6JwEAlNBLAkuA0eko3pxRicg8Qnu+N7i3uSh1PqirxOue 8gzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772384925; x=1772989725; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JC8dtCejMLT5Ebas54y2Sb5Ey1Dlmdy+AbqrqYYmf+k=; b=xDudqJxMTOCiab289lQB2Tplm8YC4B9z7yXqxWhCkylzc/LHDXuA5MQJmy7+2loQ/y 6fw4gEiYInBlmWcKtTQXs3Iea4LInkOfu+akxsH1V4chp7mqXfi1MzIGpuRmD5dfHyUd +GFn6xhDeMhZBtk+hQniA2db+l7ytP13DO+sVJtqgi2wAY0yzY8JWB6FbC5DkAKSBs5Y /6X5SmwOwpCrbRgqyimg8h5oF59yaDny9OLLiCkMg8PCmYiIROB/uZ7zDfy5A/6BVPSw bevvVLxvvcZYXjgrU0YdPpTdEQQDLmcIxI7VxD9LkKoiQu8JVr0AwwmnsRuO8wiyJztv oHKw== X-Forwarded-Encrypted: i=1; AJvYcCWV7EbcIhkXOV0FDYvsQN+K1ga1G5AgnNZSU1uLAMQDaf3jFa3kzXN3/rJCjN+F6iL4LWONwzFcmOE5DcM=@vger.kernel.org X-Gm-Message-State: AOJu0YzUfUUEKiwKbjPfmdqnq0SjPcmdZyUD4emZEWIfCD8pdF7tNH2u lOSjcprWv/l3Q9OxS40HuLhbEFxvGu6hCrvQL3NlFzyU9jJYmqBBVGRH X-Gm-Gg: ATEYQzwq/LPrKjLphcUrNGHCSXMMg8gT5NJ1baSkdjh3WtoEvliQLB9hctJ5XonLICa hM8wTC/57mHOFtC+oLo21fb7qsbVAZHzN3obzJ2r2VjqTHjfBH18SxOQvs85Ub2f6Qqa6XtN8BY 2kT0iIiSEQNdFw0gM2keyROF14hK1aL+2cp+eblGYIKo3hKo7w+mfKRdsmwj6lrQ1LFuUUN+JYM 54YndkdoFvmDfmQiDo7sBYMM5fjfkbOfwv3yRZN+zWG9xm+OBYCaWhfORjx5HQ3zToLR++ljOAt M9IgoWO+ZxGm0/V67okWVao54YKpVOk6K4/o1auJeaaTaFX77elOL8tiNRPTy87vsKcQrHtQQlA uCWWNEMq/g0kMAnci4sfoyCEvANv42w+2Uk2rL3ibPc72bgyftGZytwwPGu95W2LDmIP/pXGxFZ g168fXOJudoewNGtgCG8ay7F06PtGJngoPMJ7L X-Received: by 2002:a17:902:e884:b0:2ad:ae41:76c2 with SMTP id d9443c01a7336-2ae2e496e4dmr118882715ad.26.1772384925120; Sun, 01 Mar 2026 09:08:45 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9009:3f2:fcc8:844a:f21c:8d7f]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb5b257esm113727485ad.4.2026.03.01.09.08.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 09:08:44 -0800 (PST) From: Felix Gu Date: Mon, 02 Mar 2026 01:08:40 +0800 Subject: [PATCH] spi: axiado: Fix double-free in ax_spi_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260302-axiado-v1-1-1132819f1cb7@gmail.com> X-B4-Tracking: v=1; b=H4sIAJdypGkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDYwMj3cSKzMSUfN0kQ4OkNIskExPL1CQloOKCotS0zAqwQdGxtbUATZB QCVgAAAA= X-Change-ID: 20260302-axiado-b10bf8b449eb To: Vladimir Moravcevic , Tzu-Hao Wei , Swark Yang , Prasad Bolisetty , Mark Brown , Harshit Shah Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772384921; l=2297; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=yRcPxQvhGF4Ecv8niJ2audTUHBcYg9U8KcKsj1DASZI=; b=6ZyludJkVlCPWMcgh0edieK7UilddIXrENzghd58O7RYYEezPlqmEAkZztl66/zJRQ+npqbeV Uk98OQPSAFoCPV+XJQpBmGIpVwAwS1M7RjQGYCVPeocfqiPnTaDYOMb X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= ctlr is allocated using devm_spi_alloc_host(), which automatically handles reference counting via the devm framework. Calling spi_controller_put() manually in the probe error path is redundant and results in a double-free. Fixes: e75a6b00ad79 ("spi: axiado: Add driver for Axiado SPI DB controller") Signed-off-by: Felix Gu --- drivers/spi/spi-axiado.c | 31 +++++++++++-------------------- 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/drivers/spi/spi-axiado.c b/drivers/spi/spi-axiado.c index 8cea81432c5b..8ddcd27def22 100644 --- a/drivers/spi/spi-axiado.c +++ b/drivers/spi/spi-axiado.c @@ -765,30 +765,22 @@ static int ax_spi_probe(struct platform_device *pdev) platform_set_drvdata(pdev, ctlr); =20 xspi->regs =3D devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(xspi->regs)) { - ret =3D PTR_ERR(xspi->regs); - goto remove_ctlr; - } + if (IS_ERR(xspi->regs)) + return PTR_ERR(xspi->regs); =20 xspi->pclk =3D devm_clk_get(&pdev->dev, "pclk"); - if (IS_ERR(xspi->pclk)) { - dev_err(&pdev->dev, "pclk clock not found.\n"); - ret =3D PTR_ERR(xspi->pclk); - goto remove_ctlr; - } + if (IS_ERR(xspi->pclk)) + return dev_err_probe(&pdev->dev, PTR_ERR(xspi->pclk), + "pclk clock not found.\n"); =20 xspi->ref_clk =3D devm_clk_get(&pdev->dev, "ref"); - if (IS_ERR(xspi->ref_clk)) { - dev_err(&pdev->dev, "ref clock not found.\n"); - ret =3D PTR_ERR(xspi->ref_clk); - goto remove_ctlr; - } + if (IS_ERR(xspi->ref_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(xspi->ref_clk), + "ref clock not found.\n"); =20 ret =3D clk_prepare_enable(xspi->pclk); - if (ret) { - dev_err(&pdev->dev, "Unable to enable APB clock.\n"); - goto remove_ctlr; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, "Unable to enable APB clock.\n"); =20 ret =3D clk_prepare_enable(xspi->ref_clk); if (ret) { @@ -869,8 +861,7 @@ static int ax_spi_probe(struct platform_device *pdev) clk_disable_unprepare(xspi->ref_clk); clk_dis_apb: clk_disable_unprepare(xspi->pclk); -remove_ctlr: - spi_controller_put(ctlr); + return ret; } =20 --- base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31 change-id: 20260302-axiado-b10bf8b449eb Best regards, --=20 Felix Gu