From nobody Thu Apr 2 12:36:47 2026 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A3B135AC10 for ; Mon, 2 Mar 2026 10:50:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772448634; cv=none; b=H+fAMPl1/+zRh9FAxiXUEUxrwK6VJ7jU8gAPy3f3i0zNeJgDzxHWMVuHGtylEmqb1OPIpEvXchpHhAyamoCyPvyWSv0r66hvboZvomKiBSXMO7/YLyDtZtsv75EQxkF4/ymouKyDQrRX1aaqmbfOVC2YavodgHK9ShVL/lTq6js= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772448634; c=relaxed/simple; bh=3WJk29Oc6ASs5QbTykgT/4YsAbA7z1k86z1JB86Wapc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CVpS6/+0+3yflXLmPPv2c3viXZPFP97dQLLf8JVarURsYPJCxLk97FI3LnNEvsbDvX+Id/RNh3P3FxgQ6Gi/9DJdd+JoYPNY0YLu3jsfmjZ6uodOCvK3Tm6foySCHEnRJabWqZydAPG6K9lAmt8vpmeqa55QWafiLpR1j+DQHdo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=tGevLxj7; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="tGevLxj7" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-65a26c220b6so5539805a12.0 for ; Mon, 02 Mar 2026 02:50:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1772448630; x=1773053430; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fb2xAImtJ+lQV4+0+mQF2V3ooZDMtzcy+tKq3+ul2r4=; b=tGevLxj7jVrB5i0jAOwS33nlQ26ydkSQ3r6n0C2AnxAQ0TRRh5Yyag8DpHNcCSpfEy w+Iowob9KqME29GRS5KQ49/86KM04pCBsFfEqGHoqubeNhuhYI4E5tTaJQ/3whGUJ58e urT02IaMIVkv9wMX1QXWrQZYUa1JZen7LLUVsYPG3FBnE+R5ET+UfFW5UCFxNuU/hodc 0unVGp4ui2KQuCWlvYMn79uA1dINBuqT+EzPLlJG0cZJ4KkljUJr+TQzd/KWi2kBEDlf 2nMQZ3tUbDPfZXGFfP4N6qfAT9eaD+mgSNQT+ue8MJPBWC1UMULxGsBYalqtyMGZ10tm zJkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772448630; x=1773053430; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=fb2xAImtJ+lQV4+0+mQF2V3ooZDMtzcy+tKq3+ul2r4=; b=Ub0A8lqV/X+l5cg3GQglThld8EJVM0Q8I2Y8FH0H5XrquPTEqXi8zHlpoLxlha/rks t59KSRqex+DE9wL/iLFY5AzEeNl0P3Z7XiocxxqWUctJoSrxGqIok7mClB/uUBXBra8/ 7bxUHfFbYLJwz1ylUM6rdXmsN4IbvE8HBAuhS6LRMq0N/Vv8Kj7lCOoajCMbWFfffcO7 nrH9B41OUwfXP7YEAeYtnjX0i9zbYPQGp47zfq+rzbHmHegqnBxTSPqnckxNFkO70Wl7 jq5KYvtfKu15f0tnPWaIUi0X7AoRPrYBLXjuuUEnd0gk5XR/9Y45wOcHnlvB5BXUEtZV ohEA== X-Forwarded-Encrypted: i=1; AJvYcCVtp8d++4bMLL0MamXptd2DRom3+C7MCAK4catClBGKrG3EEmobf2doa8bFyn0GQG5RmewbJvQZfhEbCXc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/wL6bH0oZTbezjZx4/dIJ3NAhXBMYt4XXXauA0dCFH1h8W7FH d25mcu8638R4YQnw1SkhBQB5zgXXTEX6zbX5z/VPsw0BXKRCEUsRhqe5G5nPgY7QZ5wfGDiDWir OR9Ra X-Gm-Gg: ATEYQzwfcUeup3+e0g1kPciYknzJeLC1Y68aR9WaYFq41wm0YsEvJd3f4rNYWKl8mA7 CBlEVsUYNI3kckSEtdIde/rzrlf1ql9eLrPgSzpiI7HME9Ox4XoJ4zeACC+sIYS0zE3zMQuxUnb zQJy6ojyc67kRiCUCjbO9oW+xwSPy+uDiaSZmvzmDi5Wi1+Tdrd0KhRxBgPL9oTT72MKzOefIqM JWKYiABx7rta4jXDDyzHqMzoF//zO/BBI5DXZNff7mDtntNf2EqfxX7IPvjqdRvcZ6IZLMeEXI9 yv4GYFIOVYOfTZkBHGTpt79qze3y28SjY+cpviejY9kjnBo7xW1XqvYN1oI90Mpfks4bP6z9GeD eH0c+lZxyATWbJAYfhrjuVybtnx3VKC9JW2oATaSGr1TK5MXXARWHQpfC6p9ip3WGCqMc3iuAHJ CLg4dy7TZXqpNEX+NJTNXEDmBqlZUiygwP6uMAoFmWqe+sDl65Mv2DK/b9PR8nqjBJ7s12Ad7+r qt+o8BXEq3j4oECmtgd X-Received: by 2002:a05:6402:2111:b0:65f:71ed:7ab9 with SMTP id 4fb4d7f45d1cf-65fddceee18mr7094753a12.22.1772448630129; Mon, 02 Mar 2026 02:50:30 -0800 (PST) Received: from [172.16.220.227] (144-178-202-139.static.ef-service.nl. [144.178.202.139]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65fabbd98bcsm3511769a12.0.2026.03.02.02.50.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 02:50:29 -0800 (PST) From: Griffin Kroah-Hartman Date: Mon, 02 Mar 2026 11:50:27 +0100 Subject: [PATCH v4 3/4] Input: aw86938 - add driver for Awinic AW86938 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260302-aw86938-driver-v4-3-92c865df9cca@fairphone.com> References: <20260302-aw86938-driver-v4-0-92c865df9cca@fairphone.com> In-Reply-To: <20260302-aw86938-driver-v4-0-92c865df9cca@fairphone.com> To: Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Luca Weiss Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Griffin Kroah-Hartman X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772448626; l=3554; i=griffin.kroah@fairphone.com; s=20250804; h=from:subject:message-id; bh=3WJk29Oc6ASs5QbTykgT/4YsAbA7z1k86z1JB86Wapc=; b=yAD7qSNA38IhaULQIDUEm3f5FzrrD8mZ4sgoaUHU2Gy4KL2uEAbON2sQr6KXtKOD0RIZAKcPP bVXbNLa119tAlVNZMP/fC22naYzwoWIMI9shRJmKAv/5XMd4mX3lClC X-Developer-Key: i=griffin.kroah@fairphone.com; a=ed25519; pk=drSBvqKFiR+xucmLWONHSq/wGrW+YvcVtBXFYnYzn8U= Add support for the I2C-connected Awinic AW86938 LRA haptic driver. The AW86938 has a similar but slightly different register layout. In particular, the boost mode register values. The AW86938 also has some extra features that aren't implemented in this driver yet. Signed-off-by: Griffin Kroah-Hartman --- drivers/input/misc/aw86927.c | 52 +++++++++++++++++++++++++++++++++++++---= ---- 1 file changed, 44 insertions(+), 8 deletions(-) diff --git a/drivers/input/misc/aw86927.c b/drivers/input/misc/aw86927.c index 7f8cadda7c456d7b5448d1e23edf6e3f2918ba32..e59b958fac1a1144307cb216560= f522485ad26e9 100644 --- a/drivers/input/misc/aw86927.c +++ b/drivers/input/misc/aw86927.c @@ -43,6 +43,12 @@ #define AW86927_PLAYCFG1_BST_VOUT_VREFSET_MASK GENMASK(6, 0) #define AW86927_PLAYCFG1_BST_8500MV 0x50 =20 +#define AW86938_PLAYCFG1_REG 0x06 +#define AW86938_PLAYCFG1_BST_MODE_MASK GENMASK(5, 5) +#define AW86938_PLAYCFG1_BST_MODE_BYPASS 0 +#define AW86938_PLAYCFG1_BST_VOUT_VREFSET_MASK GENMASK(4, 0) +#define AW86938_PLAYCFG1_BST_7000MV 0x11 + #define AW86927_PLAYCFG2_REG 0x07 =20 #define AW86927_PLAYCFG3_REG 0x08 @@ -140,6 +146,7 @@ #define AW86927_CHIPIDH_REG 0x57 #define AW86927_CHIPIDL_REG 0x58 #define AW86927_CHIPID 0x9270 +#define AW86938_CHIPID 0x9380 =20 #define AW86927_TMCFG_REG 0x5b #define AW86927_TMCFG_UNLOCK 0x7d @@ -173,7 +180,13 @@ enum aw86927_work_mode { AW86927_RAM_MODE, }; =20 +enum aw86927_model { + AW86927, + AW86938, +}; + struct aw86927_data { + enum aw86927_model model; struct work_struct play_work; struct device *dev; struct input_dev *input_dev; @@ -565,13 +578,26 @@ static int aw86927_haptic_init(struct aw86927_data *h= aptics) if (err) return err; =20 - err =3D regmap_update_bits(haptics->regmap, - AW86927_PLAYCFG1_REG, - AW86927_PLAYCFG1_BST_VOUT_VREFSET_MASK, - FIELD_PREP(AW86927_PLAYCFG1_BST_VOUT_VREFSET_MASK, - AW86927_PLAYCFG1_BST_8500MV)); - if (err) - return err; + switch (haptics->model) { + case AW86927: + err =3D regmap_update_bits(haptics->regmap, + AW86927_PLAYCFG1_REG, + AW86927_PLAYCFG1_BST_VOUT_VREFSET_MASK, + FIELD_PREP(AW86927_PLAYCFG1_BST_VOUT_VREFSET_MASK, + AW86927_PLAYCFG1_BST_8500MV)); + if (err) + return err; + break; + case AW86938: + err =3D regmap_update_bits(haptics->regmap, + AW86938_PLAYCFG1_REG, + AW86938_PLAYCFG1_BST_VOUT_VREFSET_MASK, + FIELD_PREP(AW86938_PLAYCFG1_BST_VOUT_VREFSET_MASK, + AW86938_PLAYCFG1_BST_7000MV)); + if (err) + return err; + break; + } =20 err =3D regmap_update_bits(haptics->regmap, AW86927_PLAYCFG3_REG, @@ -599,6 +625,9 @@ static int aw86927_ram_init(struct aw86927_data *haptic= s) FIELD_PREP(AW86927_SYSCTRL3_EN_RAMINIT_MASK, AW86927_SYSCTRL3_EN_RAMINIT_ON)); =20 + /* AW86938 wants a 1ms delay here */ + usleep_range(1000, 1500); + /* Set base address for the start of the SRAM waveforms */ err =3D regmap_write(haptics->regmap, AW86927_BASEADDRH_REG, AW86927_BASEADDRH_VAL); @@ -717,7 +746,14 @@ static int aw86927_detect(struct aw86927_data *haptics) =20 chip_id =3D be16_to_cpu(read_buf); =20 - if (chip_id !=3D AW86927_CHIPID) { + switch (chip_id) { + case AW86927_CHIPID: + haptics->model =3D AW86927; + break; + case AW86938_CHIPID: + haptics->model =3D AW86938; + break; + default: dev_err(haptics->dev, "Unexpected CHIPID value 0x%x\n", chip_id); return -ENODEV; } --=20 2.43.0