From nobody Thu Apr 16 08:25:56 2026 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B5E782899 for ; Sun, 1 Mar 2026 14:50:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772376616; cv=none; b=AP8vqD+HcS3/ALTuBX061aO54WYvGAy6uvirHvPSifTsu7WXesKdPobGmvzVymgcszgg1b3kEzJkAHcW2VVpfD7VKw5ngDLxH+7OV3/8TZt/g4hdDrde1nO57Xv/ErfE3ajxiqr2JV8dsYFy8h+AAhG6/vrmAugWy0vlkhknJcc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772376616; c=relaxed/simple; bh=R389vc8f9ygNLP37okERd6Iml+DXYhbm7Kjr8iEqF10=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qmb0FvbwG3J/f75EQPeLQ2z/hpbcx0nomeFgAiEaHlhDgb+bXkVjO3FT/HFTQuv2hcFgBPIZ3od1ncspgIy9x8AznFdiza6/By3Ii11W52FGM6izYSEX1ib40Jwx08oE9orReXchhhvKYTP8bAiL9VT11xFn3oW83b8H1TZ7n5E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Iqm7eIQJ; arc=none smtp.client-ip=209.85.160.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Iqm7eIQJ" Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-506a67282a0so37437691cf.0 for ; Sun, 01 Mar 2026 06:50:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772376614; x=1772981414; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jMNSOkyr1OQmwknC/40Y8S8bviPWaYmHo+yrz5Q3E7M=; b=Iqm7eIQJgZ+2Gb+7qJRgK/K3mWoYKr0K9YTO9OP0Z7F2YnUPGO5ZMFN5o7Z9KBpkL5 Fvx0NRGMyKD5qEIi8bSbAka5ZrRTa3bMD60w6jfwZuqiNUTglzSmIZxI3ZIXRjKShUOi QYUMBxhBCb7vgNJzIiCkkj8M0uaulEIkNQiOYcFEwHKRVJlYb87veDon/wuNYmBz7lic Qxk3Pih3jk12EgsJZ7l2ig92/Gr7+TBcZVX8MUOIplGCSVioiBT7K5YulUHZCuh5FqM1 mTEWp9P+NY7qhYUH7dMXzi/BXDnCF0lcMIh7Jd87Kfr8jqem7g8Be1A6AQgCWm2bisu/ da2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772376614; x=1772981414; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jMNSOkyr1OQmwknC/40Y8S8bviPWaYmHo+yrz5Q3E7M=; b=jyjjD6VM1gB7Fots8IvpvNaAhZOMuhMqToGxXiH5J0RzvHsPep/Auql39Mz3GczZmI x1SbsNmw0pfLaf1uxcOpCG/CMCsZl3zO59nRwdXm926rMVuaUeTWVb8YKchEtA7eOIJD JaBt9bqNFWOkQGO4661MIL9f4r+3m5XlBIZmQIkl/MeyvbevhLCz+BnRnOelE1XrTQSZ v6KJAmeYwMXvl48DUo5PwH5aw8QrgYFSBJOVXCJ37w9CHtT7Ra/7m8u/QHfM+06Cm70W S+Lv9TvouBMbd1wbrfAK6vO7r1pdk44222UNDJzmKPRyUjUhmkbeQu+Ju49GDK76eqXj bS7A== X-Forwarded-Encrypted: i=1; AJvYcCVP98IYNYWyyGyRDRS/sfwUAOkCqjqcCZXfxOQvliETdUuJmnGd4qAEU9oBYa/2HEdeD7Ix/nR9ey1U3fw=@vger.kernel.org X-Gm-Message-State: AOJu0YyTZBE1u5149jQhuS3kEtCaeLYWGwKBp9fkj1sOagpB7tc388iD YXxdFyL/Iy0CBdxICjGDQvwhMdcR9bewwjjCkkK2p/vnmZYdcwu2rzi6 X-Gm-Gg: ATEYQzy/61xIIdIXRqNIiAwhd+GdDwM5w/tEW8wEfQIOIJH+AjOIiTsRThDgPx/95BW PzUTsopcxiD38K4D7Cgj55yT82qyVrOF6oPin8O3Zf2BDWWkti92VX93bd+rqIE4+7yrsjd1k+y WJWJ8O4S67HPR37kzMA+vASRBl564ijvqqp2O0p5RDyia5Zu1OKB7d5LGDwnzVqAr+jKptYzbwV LIgmgYP4G16BQVgVv3unWC5+I6z8evCHLcq2Vf5F+bPDYXMZew2vS6VJ/SAJRPtEWqJbMKzVwjg P6Cm6OKyzWZynOPHjYR/5O+PUUoPZa/nPVvnRj5pXhH3QMT8z9ssUHMGDDmjVuCB2Nlwp9Qax3g C/K+zkLwFD0Iuu08flP+V17o+KIGUT7aGizbVYkLSle/v11U4F5C8HySGLwtaCnzx6p8qPNRb9z tLaBwVMIKzV/nIKBf8/vVFv+f5zco= X-Received: by 2002:ac8:5991:0:b0:501:44a7:ad50 with SMTP id d75a77b69052e-507528d2800mr117305101cf.26.1772376614382; Sun, 01 Mar 2026 06:50:14 -0800 (PST) Received: from new-nest ([94.19.228.143]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-899c73a25e4sm84714256d6.50.2026.03.01.06.50.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 06:50:13 -0800 (PST) From: Andrey Skvortsov To: Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Andrey Skvortsov Subject: [PATCH] bus: sunxi-rsb: Always check register address validity Date: Sun, 1 Mar 2026 17:49:39 +0300 Message-ID: <20260301144939.1832806-1-andrej.skvortzov@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Samuel Holland The register address was already validated for read operations in regmap_sunxi_rsb_reg_read before being truncated to a u8. Write operations have the same set of possible addresses, and the address is being truncated from u32 to u8 here as well, so the same check is needed. Signed-off-by: Samuel Holland Signed-off-by: Andrey Skvortsov Reviewed-by: Chen-Yu Tsai Reviewed-by: Jernej Skrabec --- drivers/bus/sunxi-rsb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c index b4f2c64ac1810..daf0ea563e477 100644 --- a/drivers/bus/sunxi-rsb.c +++ b/drivers/bus/sunxi-rsb.c @@ -445,6 +445,9 @@ static int regmap_sunxi_rsb_reg_write(void *context, un= signed int reg, struct sunxi_rsb_ctx *ctx =3D context; struct sunxi_rsb_device *rdev =3D ctx->rdev; =20 + if (reg > 0xff) + return -EINVAL; + return sunxi_rsb_write(rdev->rsb, rdev->rtaddr, reg, &val, ctx->size); } =20 --=20 2.51.0