From nobody Thu Apr 16 08:36:15 2026 Received: from sonic302-20.consmr.mail.ir2.yahoo.com (sonic302-20.consmr.mail.ir2.yahoo.com [87.248.110.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9CF519EED3 for ; Sun, 1 Mar 2026 12:23:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=87.248.110.83 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772367798; cv=none; b=JM2JwSYuo9NenOWCByefY7IfdfsFte6Z0sBeQkrlDcLljRNArgj6CXWYkO7PzZZbmn4SzKCHim/YZh53BiuOM/p9yfTm9Fru4wMz9jG9PKzp65pJU01MniGZ1KHrNv1XH95XglpSq3NuPi5x5zdHLKRPWERusooQM3b4RUBmxZw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772367798; c=relaxed/simple; bh=0n9CQEnb8/1swuDU2igeiPoDmdNypCeegoMYWhLBwuA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:References; b=ddJ5iMGHkVVxFtD2sOacYJZ/Qnb5vO3g+vq0RvJw0OpBtQPa+4GdD69BXSVxjgRoOQvSUIi4lysLUb0zPbQT3Nnaf4Ss4/gKVEgCkO4YoZXnv1FxVtLLOLQPa3xAPMNZy8R9CTONbBXTugE8d9yhSy5SJUQb+zUhd+NyH4z6lBI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=yahoo.pl; spf=pass smtp.mailfrom=yahoo.pl; dkim=pass (2048-bit key) header.d=yahoo.pl header.i=@yahoo.pl header.b=ZmMgHVT+; arc=none smtp.client-ip=87.248.110.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=yahoo.pl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yahoo.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=yahoo.pl header.i=@yahoo.pl header.b="ZmMgHVT+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.pl; s=s2048; t=1772367789; bh=IQJlk8l41h57Oau1XI+KCQR7I6Tu4lnhPIT0mluCmjY=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=ZmMgHVT+GSRPKWharf74P9puj0xALwSFszpsche81WQRb6uWN1xPeok2ZY91NIQ5vUakR9hJNsx6YklIKn6KeF9ISZpuwF3Y89HAFGwBZfC/3DE1p2fDjaUhsOtYkfT5LSh+/1yq19wiiIfT4zVHeh/AFZ4Y0hw3Z2snBiFMUfgBuB0PmvVU2PE7CqJPBn8a/vcXiHL11eftcoZbb6PWExrMCJl9HvZEaogw5mEACUFSacQ2old3B0tBBJGuCRJNS6X2x7FmV1uMiMyumt4sIuGiU22BhVlSrNdpqRXIqhJKAFrpWcsg/mHFlmcqtRF+OeD6s6v9KFmI3z/idvDgSQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1772367789; bh=zUM77Ab5ZMl6LJ5oxRCQHm1D6Tp6Oq6BPMRZ4c6auq0=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Wv0VUby1yD/1LkIAkdOW0J6aI4ITmrmrVfhHX6NkN64nWSQt6gx3LQLAzes3VMDVqVXdFPVaeaZQ5uVypJil/cveb5jM/LcqhZuYpn0e7xZgoTddiRJQHDSoUUqJiXudPnDx53NatzGl57PYGu5lIiR9CqKUgHAenhB/Q2BK5OrvmKMfTrLja0AqYnD2m28w6nIPUDFyZLfQdObcmKmkXcH96i11PtViM2FUZy5RlEYvR+PJ2P5pGtG1OpRLXWtdV/OENnn9Yk14aSy6pvWSDCaPlnlVDKLTPg0gGV7Ox8kd3esxYP5nba1jFKQ51+oGwbNc7dHHbpJByUHUWweKkQ== X-YMail-OSG: 5bNjWD8VM1kGNY8E0NVmMHTH5ZkY.nbNffkbzqDOQ5fFaSbWfqW6Y9aqDjXH1Qa ldN22FVc5LzyEQC5Wj7tu._ipG6v7vMXQnL6kp0.M4AJDKvsfd3LMVBXUajmwlY3yxfINawRFCFG eEvzKHi_zsOwMhDihPDhdiCfsHLSnYXnklelxR.gSfmcMda0CvWdjRb9z.HJNH7mY4cii4VvZGdW iY4KNntQK4ng627Rv4_fNhr5vAm4JypRJINDgJLyqz1hUvk0X9xKGtNqv7vP5z50IIOhcg84s1fG zZO16UZXUP1qap.P8nN9JX.Poi2kxpctFXE862G4GG.NcKBfaOtPMWbIXZEzjQ4xvEVlvHRmtHAQ wn4RJeXIBHB.RfssSXL8U1rd_kOdyqXsh9x.rcjvTsPn1dwB6_JfGm7BgBisYTrPgPTVeNu39Y73 5gZoz3EqGX_MfAl4w5.gzlc0Rt6iVH2Pr_gqQ.yq3AgG4vWalsvWNINub_YcGECLWHk7KrkZpW2q awmmSljiZ0vs7zFpV3HXROwHzhyN8TbBOa9akwqqrSqwDYIyJkZnrHymxEGsbNO62xCgd2zdKF5a cYHCPyGAJ3rn5dudezJRxgoVWf9nzfSh2tojprTUX3XywMeoo6_eCx3uSx_PeL7meJbFVnn9pWLH atCgmowYuXzQQ20VbPohoYmZF6aizcupGWDk8ZsvyLmUMISv_hHXiEWzrHzciQtX7N3nWHaFhC.F MWTuJcHSJ2eKeCcPOBustBWP0mcuwI.RsLjC0XM6Qd2gax4gETgSDybBAKtNBL6fyQoMlwUC0kES mwpz7Fl9ynozNIK0MMfgqc9KJv5i1gpW.XBG3dWoIB7t9InP8bg7r9hPqlfi.nZY8Rh.pHQCWHE5 621C69oYDQkPi7nkGLxUQCxBVG9tNT6Sh5C6FH6N_44Gsm5oMpzMA9ZV4Hlu9vZRiwLjE9Q.F_uH 5IJpzZOta_oPVsf9I2YZirMkwt4.IOAoGt.WjyhXBQITTV8BNYVGwKprCAb1o2fvIz1vUmGAIHse d1Wjn7jSjSLgclDhXaDZQlIghTrPyzvD5pEAOOtyBUT2Hu_59X.cWK3WEIS86QNUt_LPC19yv7q. xL3fQ_5i8QoK4YVcBciwgwBnR90JukiRxstoLtY6bs8E4b15EhFosSfWE5RS8WMiOL5vZtSnhNZY 72VuEnNh4I_4arc3Qvrim3fgFBdh4arJQ7Amia82t6CQAt.eTr0YKmTEXvc8nbEHjgjnWDZ2IaIs sSztf_dAcOviUE8x_eQb_EVMrYoWgovNnpPqZ3ZVLKQj_59k50ptFAAdstIhnvYkyV63B4yjJi2V G2xwe9YrzwC4x7St0Cgjpbx.NbamcKJMmUoXMzde4y5j3Zgq2xgYNOE5FWRgYLwSUgGY6yEb0HEf Cu6T2GE_pqDufyz5TYAsKH0oFGXpnAVno4MvoDByV.CzdCu7JQ6txBKQKy2hDUhpoCK5keVZt19n 4xydnwLI_avc.2isyl7vDS97jhIEA.mYQibK4FjX81khaIfNIpeJAiBiFox25TgW0_D2iDXlk.Zw 1KEVPfpjZ5khNkVX8tPgRakryw5_MWJENbKaNLedsJCN3ovkdD_rD6Y86dRvk2DCqFZr2SZjtZCu _t1ivogDIa2IUhbOZjuaDoNd3c1PE2fcRdJyYSewTqFXB0Y150NDGD_xmYHOt4Ntx9HjBhTOASF8 nsSP.DTgLXrn8Qbn7toUVGAM5rT2SBAbQcBXPiAd0IciBH0cdhr1TeXaQUgzSX.Jb2oqXnQw0NFf c1tWBQSXZbf1B.TMIqopYQe9KJWGMMF7LFpcaoy9jmbaouOzLmLR_5dMRoqoKiPfYAvGZwLCy6nM kkXgkxl3aTD_K4_mZdTf46vO45MeJPH83v0NOgeMqRRoFJlduzzMLxNjwxtkIdGMgnqVAuNG6VRA 225e_QGMGWeloL8Y3Z_O0f7dTEVjn0d5E7TRcnndYvL6aqxx22Mins04uVYZN4mu.v4XNMcBo8z1 yFMfoxyZhnqvJrtl0EGQe2n0LZwkXvpZJwZpqaAj6DKVfioIn6vO3XjUK_4MJnNVD.2.C5S0oeEP yO7tLBPYf3IcZ18KhcEd2anabnY_8IGjVrmnTnwOMgCqiLPOGRWZSDaA686YkVZYjwF2zhQ4igVr L4RSOM9wvzMGJojmFAjccAvOGCs08Aa_pk6Ff3DLcrserjaV5fxMBIQSmKfkWjstGLte0I1bTOzW FN5DXHJqAD.LPARHoffckwusgFATHK.PbfBV2DIPEQCBM_dZrIqc- X-Sonic-MF: X-Sonic-ID: aafc7c08-e6ce-488d-9f72-c2072f5681d4 Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ir2.yahoo.com with HTTP; Sun, 1 Mar 2026 12:23:09 +0000 Received: by hermes--production-ir2-bbcfb4457-d9ssk (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 269077dfba5a73e3246f5329f26f66e4; Sun, 01 Mar 2026 12:12:57 +0000 (UTC) From: tomasz.unger@yahoo.pl To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Tomasz Unger Subject: [PATCH net-next v4] NFC: pn544: i2c: Replace strcpy() with strscpy() Date: Sun, 1 Mar 2026 13:12:54 +0100 Message-ID: <20260301121254.174354-1-tomasz.unger@yahoo.pl> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable References: <20260301121254.174354-1-tomasz.unger.ref@yahoo.pl> Content-Type: text/plain; charset="utf-8" From: Tomasz Unger Replace strcpy() with strscpy() which limits the copy to the size of the destination buffer. Since phy->firmware_name is an array, the two-argument variant of strscpy() is used - the compiler deduces the buffer size automatically. This is a defensive cleanup. As pointed out by Jakub Kicinski , firmware_name is already bounded to NFC_FIRMWARE_NAME_MAXSIZE via nla_strscpy() in net/nfc/netlink.c before reaching this driver, so no actual buffer overflow is possible. Signed-off-by: Tomasz Unger Reviewed-by: Simon Horman --- Changes since v3: - Reworded commit message: removed "bug fix" and "buffer overflow" language as pointed out by Jakub Kicinski ; firmware_name is already bounded via nla_strscpy() in netlink.c - Changed submission target from net to net-next (cleanup, not a fix) Testing: - checkpatch.pl: 0 errors, 0 warnings - make M=3Ddrivers/nfc/pn544/: compiled successfully, 0 errors, 0 warnings drivers/nfc/pn544/i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nfc/pn544/i2c.c b/drivers/nfc/pn544/i2c.c index a0dfb3f98d5a..b31b5bef7187 100644 --- a/drivers/nfc/pn544/i2c.c +++ b/drivers/nfc/pn544/i2c.c @@ -526,7 +526,7 @@ static int pn544_hci_i2c_fw_download(void *phy_id, cons= t char *firmware_name, =20 pr_info("Starting Firmware Download (%s)\n", firmware_name); =20 - strcpy(phy->firmware_name, firmware_name); + strscpy(phy->firmware_name, firmware_name); =20 phy->hw_variant =3D hw_variant; phy->fw_work_state =3D FW_WORK_STATE_START; --=20 2.53.0