From nobody Thu Apr 16 08:29:58 2026 Received: from mx0b-0064b401.pphosted.com (mx0b-0064b401.pphosted.com [205.220.178.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C61B345038; Sun, 1 Mar 2026 10:48:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.178.238 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772362143; cv=fail; b=SRuZSIyrYH8u0/qwIj6mOxS4PG6SFphEe9DhzztcuCUPWO8VwJ8uLdaq3WXrlfe7UGo9SbVoxp1IhJLEkRNSbBjrZjXf2l/oIBvauLTqt+67pUJNgjAjquqJnOyn3AkkVKRbGkzUn57hnVujdwc0pTrWD5wh02rmCIN1w/4TKCA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772362143; c=relaxed/simple; bh=V5PqaMi/A/zkReEZYmsiui5xTmvOlENN2Uohhsw//U0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=T+HbIO5YWTDybmC8QLTdarXGBI2DylF2XhknL+vGSSG4uDPCk+1dW6cdZuUW7XydU4avpkN3bwJI0CD/GVLNW3MIusoPcilJgGr07lKqNfBlfDAsZ4qqfz3JRdVia0kaMFIHx2DddXq05sDLKr42PtomVSqMCC4bcwvXJCisoUk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=pass smtp.mailfrom=windriver.com; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b=hoJA4VDU; arc=fail smtp.client-ip=205.220.178.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=windriver.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b="hoJA4VDU" Received: from pps.filterd (m0250811.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 621Ae2oU3617745; Sun, 1 Mar 2026 10:48:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to; s= PPS06212021; bh=2JHu37lJsE9EfEYYHfia9R7J3IwNIwitwNHyS3zu1iA=; b= hoJA4VDU/i4ZX3G8OiYzpyePT9jkC3GjCpflOnYEPEqI8do0wRyx9ttG4NKTi9J8 Wl+QC1yZ5wxlYYC4mPsJf1LO2crLkYaEFqp+MfBbk4cAUdF1fRC9V2UX/vvKuaje DpcemMND1qw1KmKn9amGgA82Jt1IZyMSzmCQ+33DqIwSuwWAspavaYX7yTcoyDSq cYSj27kcKeCE3WvGfNFBswDwbvZKgbqRmg3ihymrJ7y9xbavHlAk9VplqqHm8EHX xtWgnqDkEOYkyim0PU74+ZGVvJnxWfNZwYAQlb7BWR2FOUvWfkAvMBVXgq5WOvnM sNEPHRaLjOtgfnSJoIh1zg== Received: from cy3pr05cu001.outbound.protection.outlook.com (mail-westcentralusazon11013067.outbound.protection.outlook.com [40.93.201.67]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 4cknjvhe4f-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sun, 01 Mar 2026 10:48:32 +0000 (GMT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nB34ojD4givDYzTv3ck/XIbb1BbCmPO87itlKJ5drUIko5EpwUldTKx9+ebE/OfYcLFhFYfiQiHz8Oi6NCzofTTY2W8N4035wYOUbs1EJojfMq13XHuQMzZpcLaG36W8potnidDUx97D1FXHFaMvfevVKg2j3AtqCiQ57qBtjAfr5JSV7UQ1Glv5u9QlTEy1zvgvttpBnL1rhQvgS/J3Sccna3AmQHKcVZOZX6GX0Qd7uWu5GDodLykjPz9tERb52wmLQUQe+ORRtUX8pWXprsix9lvA9rMrRgk6CiHmyjvyTbcq/EBfO98lLmIRDe7MHjBj5a5gn10WzlTVsqh+AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2JHu37lJsE9EfEYYHfia9R7J3IwNIwitwNHyS3zu1iA=; b=WyKZD/NT9uEEQH/bqZ4exRJGfH04xvrcslyZJ5vfuVmgUWpWMXHjuwuFnzW/c0OSP5XZeVRs6JY+zDzw3JVzNcRlAvjMGpKKrqVtAnNgBQCRKTKfkQCcF5+U/Smb4Ba7V1QIngu00pAJOKhxWMe6iPUDaCaX25WPGoP/RNDeLwdSTOC6CkmBh0BV9a4N3ZZZ0vinUfsylEOtCKZVBx36ELSuyB0h0Inw5m1cwC+CxlnAT7Twkr6o/oUD8A1OhkQIYiAzXoS6lFhwLTJ56eZp9ewN2g0lOrHaPhU3rR4MKPVH1YSZpFjZxyuyp1K3oVGsLrU1ZNJ7Rad8ydNDov2jKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from DS4PPFD667CEBB6.namprd11.prod.outlook.com (2603:10b6:f:fc02::53) by MW6PR11MB8311.namprd11.prod.outlook.com (2603:10b6:303:241::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.14; Sun, 1 Mar 2026 10:48:30 +0000 Received: from DS4PPFD667CEBB6.namprd11.prod.outlook.com ([fe80::5f46:caa4:60d4:f669]) by DS4PPFD667CEBB6.namprd11.prod.outlook.com ([fe80::5f46:caa4:60d4:f669%2]) with mapi id 15.20.9654.014; Sun, 1 Mar 2026 10:48:30 +0000 From: Xiaolei Wang To: sakari.ailus@linux.intel.com, tarang.raval@siliconsignals.io, laurent.pinchart@ideasonboard.com, dave.stevenson@raspberrypi.com, jacopo@jmondi.org, mchehab@kernel.org, prabhakar.mahadev-lad.rj@bp.renesas.com, hverkuil+cisco@kernel.org, johannes.goede@oss.qualcomm.com, hverkuil-cisco@xs4all.nl, jai.luthra@ideasonboard.com, Xiaolei.Wang@windriver.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] media: i2c: ov9282: Convert to CCI register access helpers Date: Sun, 1 Mar 2026 18:48:07 +0800 Message-ID: <20260301104809.3505257-2-xiaolei.wang@windriver.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260301104809.3505257-1-xiaolei.wang@windriver.com> References: <20260301104809.3505257-1-xiaolei.wang@windriver.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SEWP216CA0119.KORP216.PROD.OUTLOOK.COM (2603:1096:101:2b9::9) To DS4PPFD667CEBB6.namprd11.prod.outlook.com (2603:10b6:f:fc02::53) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS4PPFD667CEBB6:EE_|MW6PR11MB8311:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b04f93b-cd9d-4f83-166c-08de778013b4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|921020|38350700014; X-Microsoft-Antispam-Message-Info: xunFYlggSF6KQenP6CwpObBULN6UUB+TtKgdFI0JAn3jF5YsbLIDOrdz1uFliah9CJyIiBI9gBCtGuQ+fIaeR01KFkjKk18Bk2zc/UlqJRKapTkGtn9S1vrLeULR7x8xSjO+AOEP1K5JUbkIzogxzlkD8UzsSgL2qr/qvKa9PE99Y0ACeQ/zuN8QPO4RPp+DomHLRmBpthy+8KIvc8MuV26IksLeUPdcWxr5+f1Ok6PnmUDUoUfo1V+9TsLTPeaHLBQH9sVTKGWU3NqMy5Cy4UqCWg4plCWnuBnnzTr8loLjAoqjBKODftCQceohNMTo30bdgWEVFgJcdjLP1foy0ZXIk5kieAXJ1O69fcRVfZhnfe5R7Bcgk5gmrXQITJSwfyGRK/q2UKvRS0cqsKAhn+L7GicZnZwKUDM2dg0vtHB4ZEX9LNBeJ2qfrH7uXP6spA5v/ZGFTjjDEgx5zfyRdrfxhu9pV5TROwUG//u52e4/PFZ3fmNowviEfI5nooLj8JOMTNJOdqGWcOosdKMtu3u+16Cc/DDL3QDte7XnU3X+Odl4cGchmDebKoARJPcPZeuroxwavjt17nyvPyjP72q5+YZ60LCKDvRBFyjK4DjYnqX7aZtFn2p4akER06S2wVXPuataSEVADTkMMnZrrjHXN6gsRsqzUscdTYJZi1Z3UpfqCOk/M1zfE4VhOfctuFumV8lb2DM4G8ZY0OXZwR5pT4ycdQBX78SCdEgXrRD300YZN2TjXjEUkFdy2NuFBdUxg5VksATZ7hd0/oetKzPJxlPi3JqJtRIIYmYRPKoxKEkqvdtOMscGc03wIFYa X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS4PPFD667CEBB6.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?M16FykB3rGIoHHxDZukr8o1h+VjyeyFjEkJzSglv5TmxKUYgdczvaUY2A7nH?= =?us-ascii?Q?6khfuNfdPo2eRCshpEhgNTBl3s9ORI0ubQ1Mc5ZtSoVqnGGpwOxiWdZfeFm3?= =?us-ascii?Q?YoIVFIf/aWoXfgoqj+FuB+mQZ64MKqSbWG3SvATCBeTOvUi94M8uyef9oVR8?= =?us-ascii?Q?Cp7sOJtqwzzdMk5ZtMlOk6FpoMKf5N8O0Ts/nKcQKGp+2kBSb6KdMJceU7Ao?= =?us-ascii?Q?MeOE627roddIVMcDGLEwGTnWf6OJyEPJmqnEN90HYR/d1x4kgIayXprd4gLs?= =?us-ascii?Q?zjljrVAZa2eQ0YXFoVsBs/LQrnA9nGEWRtHUNfz4T9Y3zk0geuQzLNgfuQjB?= =?us-ascii?Q?Q4P3A8xx6fDigZnU5u1mqdjFiockn9UN4mFHBNVgJMLIMjeRmBXd0xEqse7J?= =?us-ascii?Q?rLBLVFOO0Ey9kpy0i0ECPNoLfzIkmYtLZ20Q3RV6ADShAk6RRNcYiPezEclu?= =?us-ascii?Q?tCCt4UHgpfGskkUaNifCpLTm1K6XJ+zds/EbxtjgbTxKNVUI4iMX8zRilsdt?= =?us-ascii?Q?CGLCPZOwmyrD1K919TWIO+AtX68MMeNarFfIIHvvAt9hHK51Q1nXtzz1V9Wh?= =?us-ascii?Q?e9Q7NoFmC5mqrDGTo29ESnZjrAgpcC8xRmiREUOTui+8oQsXWEfgEn+/0LIn?= =?us-ascii?Q?+tPzrZkZkgql7yCClmpnu7ivJHibvowip37uqKsikJsBcbn/tCF922WuuHyR?= =?us-ascii?Q?HxZCZ/UPN1MiD/5fk4cUi8bRc8tmxL45LUD0aviOxQ7OTM/KxvRP+baGz4PO?= =?us-ascii?Q?7PH1Eje2jmW/b6z16YO3ept0jy3GA98K0LiuPPNUpja9tCbO/jDg2fMGW10V?= =?us-ascii?Q?S9AUZDB2VpY/RJdSlFvKkVZemZy8i0GKjzd4vPHfVYUx8af+4tnSaXNTjYKA?= =?us-ascii?Q?q1EX3+4Kj86Ogw+gMLGvOzFzvnVtMDaImZCFFx9i4xHM+KVNs0QCchKyizwM?= =?us-ascii?Q?mGraLl6HC5GBWHGTvxt/RVc2MRGplx90XKGHVQJHJMZUs+Ek3Jn+TyDZbYQQ?= =?us-ascii?Q?spPE9dxsMmgUmOfrpcMplY1lwg9HUGmh4y9pBo4P1P8BMV9nJYKkX4G11fHT?= =?us-ascii?Q?y/JYQtJpcRQRerOQWNX9z4MJFGxHPU6/s+wNkTDaarGVAI8BkYwGTCjfQ36m?= =?us-ascii?Q?q/+XbVRhqiV2579FjgbbTdfh+At0Bi8tM2Ef4Mia5pbdO7mLjQceZF7NskJI?= =?us-ascii?Q?Ucy5zo4ubdd3bGVNFuSQ/lDMaAB0PCtTgrTRg46fMC2vwiyLuGMKAbHOvOnF?= =?us-ascii?Q?gv8NkUEsLmC3sc0dMTAtDplHvFlZOVUCFDghFT0i721tponAt63iHCZaoYcb?= =?us-ascii?Q?go7wY2VdTf2uEV0VDXM03CTo0oJjjHhz4rTcJvMB9XKPjGqJw6Wo/fA0pc9k?= =?us-ascii?Q?mYbb2rHn9a21d+L7yf6bKQ6Fi15F4JLIcA/QDgKNj3wAFoJm30wx7MwpNAOy?= =?us-ascii?Q?SZcBTDm6OhnL799XGq59+nn0QuHH7vdSSWvS6uFbNKdS8RY7lg0YVverB3m5?= =?us-ascii?Q?oiprcYEtdLVYTt1JDRx2OjTGumHbAU79dWt7p6Rf7ClGFQMPLAeEZkJjwyXc?= =?us-ascii?Q?51D0RliOT8MbN2wR5Ba6ZJNr+SuXaxsCnfD7aKrv8k1rJH4vD65ixe1pGIzd?= =?us-ascii?Q?RCIXJNnDTDY/WaS5HGrukBm2MhhQvg+hf9hab62SeH1hv4Ct6/x9y6ZUjyeU?= =?us-ascii?Q?Tbzv6NIQY1g5SFqx7cspzx+CCw94x4vhZmxtEed8GJKPFCeygZGFucibmA6z?= =?us-ascii?Q?XE64TupAs6JXT3ZwI+8MGGco3qxVblc=3D?= X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b04f93b-cd9d-4f83-166c-08de778013b4 X-MS-Exchange-CrossTenant-AuthSource: DS4PPFD667CEBB6.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2026 10:48:30.6711 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 06bJYYOg6cRzug2NyiKWBFiwlonvVGpCzSnbwKoHoCLS0TETwX4cuNCMwEaqzpkFDlGWynAPYMkaITnq5NoLy8e/doFbQ9vMmmqFqc6WN0Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR11MB8311 X-Proofpoint-GUID: fx7b2yj4g9Y3gJGfKwEIZJrDfBBmG7h_ X-Proofpoint-ORIG-GUID: fx7b2yj4g9Y3gJGfKwEIZJrDfBBmG7h_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAxMDA5NyBTYWx0ZWRfXzYigpa0bHYml 6j1PSwCgMxjWHnJNj8jLRFFpzYR8dOiAwuExdtqymq6Q58ElF/VCv0VDdo+16puQoTN6Aq2fHJ0 9L/jMmZxC6UdQSc60FPxrzLA3t4hYWvNDD68322x/ssAgt1gBFupYRDqnxNPq26cHQeU2Z0MVic QIPh2ov5Z2di8r1r967BqTu9crjx3t0z96tBYd+WZyiXrtjRly009dNp25r5h1ovGbexfApxpPm MXnlKHz4nC7NXxlt1pDbu5H8Dw6oK1zgMu/dPZMAlQZzNrt8DpSQ4SL+vrkwefv2erY3Ed7Q/xe hhb3S3c4XO5mdA7huwF53CtxXsKQD5WsL5YnkLFRXXdzSRtuapHVuPffIBOtG3sRk6R3yy+siRi 8jCEMZcjxVNDiXcE2rFNif+vPjQFIh3nai0ome4VaiPXjQkx0Jz/FZY+Ane4COPevTrTxBMDaei R7xmd4njRqWVg3rF4DQ== X-Authority-Analysis: v=2.4 cv=P/g3RyAu c=1 sm=1 tr=0 ts=69a41980 cx=c_pps a=R3Nq4yRH+PcKhTCrdXTq7w==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=bi6dqmuHe4P4UrxVR6um:22 a=klDOsUkWDRETUCZYPvoE:22 a=t7CeM3EgAAAA:8 a=F-GWxTvL4KY9s68XaQkA:9 a=FdTzh2GWekK77mhwV6Dw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-01_01,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 phishscore=0 spamscore=0 suspectscore=0 clxscore=1015 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603010097 Content-Type: text/plain; charset="utf-8" Use the new common CCI register access helpers to replace the private register access helpers in the ov9282 driver. This simplifies the driver by reducing the amount of code. Signed-off-by: Xiaolei Wang Reviewed-by: Tarang Raval --- drivers/media/i2c/Kconfig | 1 + drivers/media/i2c/ov9282.c | 293 ++++++++----------------------------- 2 files changed, 64 insertions(+), 230 deletions(-) diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index 5eb1e0e0a87a..3027e71fd8fb 100644 --- a/drivers/media/i2c/Kconfig +++ b/drivers/media/i2c/Kconfig @@ -690,6 +690,7 @@ config VIDEO_OV8865 config VIDEO_OV9282 tristate "OmniVision OV9282 sensor support" depends on OF_GPIO + select V4L2_CCI_I2C help This is a Video4Linux2 sensor driver for the OmniVision OV9282 camera sensor. diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c index ded9b2044ff8..8bfaa3ae4be5 100644 --- a/drivers/media/i2c/ov9282.c +++ b/drivers/media/i2c/ov9282.c @@ -12,38 +12,40 @@ #include #include #include +#include #include =20 +#include #include #include #include #include =20 /* Streaming Mode */ -#define OV9282_REG_MODE_SELECT 0x0100 +#define OV9282_REG_MODE_SELECT CCI_REG8(0x0100) #define OV9282_MODE_STANDBY 0x00 #define OV9282_MODE_STREAMING 0x01 =20 -#define OV9282_REG_PLL_CTRL_0D 0x030d +#define OV9282_REG_PLL_CTRL_0D CCI_REG8(0x030d) #define OV9282_PLL_CTRL_0D_RAW8 0x60 #define OV9282_PLL_CTRL_0D_RAW10 0x50 =20 -#define OV9282_REG_TIMING_HTS 0x380c +#define OV9282_REG_TIMING_HTS CCI_REG16(0x380c) #define OV9282_TIMING_HTS_MAX 0x7fff =20 /* Lines per frame */ -#define OV9282_REG_LPFR 0x380e +#define OV9282_REG_LPFR CCI_REG16(0x380e) =20 /* Chip ID */ -#define OV9282_REG_ID 0x300a +#define OV9282_REG_ID CCI_REG16(0x300a) #define OV9282_ID 0x9281 =20 /* Output enable registers */ -#define OV9282_REG_OUTPUT_ENABLE4 0x3004 +#define OV9282_REG_OUTPUT_ENABLE4 CCI_REG8(0x3004) #define OV9282_OUTPUT_ENABLE4_GPIO2 BIT(1) #define OV9282_OUTPUT_ENABLE4_D9 BIT(0) =20 -#define OV9282_REG_OUTPUT_ENABLE5 0x3005 +#define OV9282_REG_OUTPUT_ENABLE5 CCI_REG8(0x3005) #define OV9282_OUTPUT_ENABLE5_D8 BIT(7) #define OV9282_OUTPUT_ENABLE5_D7 BIT(6) #define OV9282_OUTPUT_ENABLE5_D6 BIT(5) @@ -53,7 +55,7 @@ #define OV9282_OUTPUT_ENABLE5_D2 BIT(1) #define OV9282_OUTPUT_ENABLE5_D1 BIT(0) =20 -#define OV9282_REG_OUTPUT_ENABLE6 0x3006 +#define OV9282_REG_OUTPUT_ENABLE6 CCI_REG8(0x3006) #define OV9282_OUTPUT_ENABLE6_D0 BIT(7) #define OV9282_OUTPUT_ENABLE6_PCLK BIT(6) #define OV9282_OUTPUT_ENABLE6_HREF BIT(5) @@ -62,14 +64,14 @@ #define OV9282_OUTPUT_ENABLE6_VSYNC BIT(1) =20 /* Exposure control */ -#define OV9282_REG_EXPOSURE 0x3500 +#define OV9282_REG_EXPOSURE CCI_REG24(0x3500) #define OV9282_EXPOSURE_MIN 1 #define OV9282_EXPOSURE_OFFSET 25 #define OV9282_EXPOSURE_STEP 1 #define OV9282_EXPOSURE_DEFAULT 0x0282 =20 /* AEC/AGC manual */ -#define OV9282_REG_AEC_MANUAL 0x3503 +#define OV9282_REG_AEC_MANUAL CCI_REG8(0x3503) #define OV9282_DIGFRAC_GAIN_DELAY BIT(6) #define OV9282_GAIN_CHANGE_DELAY BIT(5) #define OV9282_GAIN_DELAY BIT(4) @@ -78,28 +80,28 @@ #define OV9282_AEC_MANUAL_DEFAULT 0x00 =20 /* Analog gain control */ -#define OV9282_REG_AGAIN 0x3509 +#define OV9282_REG_AGAIN CCI_REG8(0x3509) #define OV9282_AGAIN_MIN 0x10 #define OV9282_AGAIN_MAX 0xff #define OV9282_AGAIN_STEP 1 #define OV9282_AGAIN_DEFAULT 0x10 =20 /* Group hold register */ -#define OV9282_REG_HOLD 0x3308 +#define OV9282_REG_HOLD CCI_REG8(0x3308) =20 -#define OV9282_REG_ANA_CORE_2 0x3662 +#define OV9282_REG_ANA_CORE_2 CCI_REG8(0x3662) #define OV9282_ANA_CORE2_RAW8 0x07 #define OV9282_ANA_CORE2_RAW10 0x05 =20 -#define OV9282_REG_TIMING_FORMAT_1 0x3820 -#define OV9282_REG_TIMING_FORMAT_2 0x3821 +#define OV9282_REG_TIMING_FORMAT_1 CCI_REG8(0x3820) +#define OV9282_REG_TIMING_FORMAT_2 CCI_REG8(0x3821) #define OV9282_FLIP_BIT BIT(2) =20 -#define OV9282_REG_MIPI_CTRL00 0x4800 +#define OV9282_REG_MIPI_CTRL00 CCI_REG8(0x4800) #define OV9282_GATED_CLOCK BIT(5) =20 /* Flash/Strobe control registers */ -#define OV9282_REG_STROBE_FRAME_SPAN 0x3925 +#define OV9282_REG_STROBE_FRAME_SPAN CCI_REG32(0x3925) #define OV9282_STROBE_FRAME_SPAN_DEFAULT 0x0000001a =20 /* Input clock rate */ @@ -139,16 +141,6 @@ static const char * const ov9282_supply_names[] =3D { =20 #define OV9282_NUM_SUPPLIES ARRAY_SIZE(ov9282_supply_names) =20 -/** - * struct ov9282_reg - ov9282 sensor register - * @address: Register address - * @val: Register value - */ -struct ov9282_reg { - u16 address; - u8 val; -}; - /** * struct ov9282_reg_list - ov9282 sensor register list * @num_of_regs: Number of registers in the list @@ -156,7 +148,7 @@ struct ov9282_reg { */ struct ov9282_reg_list { u32 num_of_regs; - const struct ov9282_reg *regs; + const struct reg_sequence *regs; }; =20 /** @@ -188,6 +180,7 @@ struct ov9282_mode { * struct ov9282 - ov9282 sensor device structure * @dev: Pointer to generic device * @sd: V4L2 sub-device + * @regmap: Regmap for sensor register access * @pad: Media pad. Only one pad supported * @reset_gpio: Sensor reset gpio * @inclk: Sensor input clock @@ -209,6 +202,7 @@ struct ov9282_mode { struct ov9282 { struct device *dev; struct v4l2_subdev sd; + struct regmap *regmap; struct media_pad pad; struct gpio_desc *reset_gpio; struct clk *inclk; @@ -241,7 +235,7 @@ static const s64 link_freq[] =3D { * register arrays as some settings are written as part of ov9282_power_on, * and the reset will clear them. */ -static const struct ov9282_reg common_regs[] =3D { +static const struct reg_sequence common_regs[] =3D { {0x0302, 0x32}, {0x030e, 0x02}, {0x3001, 0x00}, @@ -305,11 +299,6 @@ static const struct ov9282_reg common_regs[] =3D { {0x5a08, 0x84}, }; =20 -static struct ov9282_reg_list common_regs_list =3D { - .num_of_regs =3D ARRAY_SIZE(common_regs), - .regs =3D common_regs, -}; - #define MODE_1280_800 0 #define MODE_1280_720 1 #define MODE_640_400 2 @@ -317,7 +306,7 @@ static struct ov9282_reg_list common_regs_list =3D { #define DEFAULT_MODE MODE_1280_720 =20 /* Sensor mode registers */ -static const struct ov9282_reg mode_1280x800_regs[] =3D { +static const struct reg_sequence mode_1280x800_regs[] =3D { {0x3778, 0x00}, {0x3800, 0x00}, {0x3801, 0x00}, @@ -348,7 +337,7 @@ static const struct ov9282_reg mode_1280x800_regs[] =3D= { {0x4509, 0x00}, }; =20 -static const struct ov9282_reg mode_1280x720_regs[] =3D { +static const struct reg_sequence mode_1280x720_regs[] =3D { {0x3778, 0x00}, {0x3800, 0x00}, {0x3801, 0x00}, @@ -379,7 +368,7 @@ static const struct ov9282_reg mode_1280x720_regs[] =3D= { {0x4509, 0x80}, }; =20 -static const struct ov9282_reg mode_640x400_regs[] =3D { +static const struct reg_sequence mode_640x400_regs[] =3D { {0x3778, 0x10}, {0x3800, 0x00}, {0x3801, 0x00}, @@ -485,97 +474,6 @@ static inline struct ov9282 *to_ov9282(struct v4l2_sub= dev *subdev) return container_of(subdev, struct ov9282, sd); } =20 -/** - * ov9282_read_reg() - Read registers. - * @ov9282: pointer to ov9282 device - * @reg: register address - * @len: length of bytes to read. Max supported bytes is 4 - * @val: pointer to register value to be filled. - * - * Return: 0 if successful, error code otherwise. - */ -static int ov9282_read_reg(struct ov9282 *ov9282, u16 reg, u32 len, u32 *v= al) -{ - struct i2c_client *client =3D v4l2_get_subdevdata(&ov9282->sd); - struct i2c_msg msgs[2] =3D {0}; - u8 addr_buf[2] =3D {0}; - u8 data_buf[4] =3D {0}; - int ret; - - if (WARN_ON(len > 4)) - return -EINVAL; - - put_unaligned_be16(reg, addr_buf); - - /* Write register address */ - msgs[0].addr =3D client->addr; - msgs[0].flags =3D 0; - msgs[0].len =3D ARRAY_SIZE(addr_buf); - msgs[0].buf =3D addr_buf; - - /* Read data from register */ - msgs[1].addr =3D client->addr; - msgs[1].flags =3D I2C_M_RD; - msgs[1].len =3D len; - msgs[1].buf =3D &data_buf[4 - len]; - - ret =3D i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs)); - if (ret !=3D ARRAY_SIZE(msgs)) - return -EIO; - - *val =3D get_unaligned_be32(data_buf); - - return 0; -} - -/** - * ov9282_write_reg() - Write register - * @ov9282: pointer to ov9282 device - * @reg: register address - * @len: length of bytes. Max supported bytes is 4 - * @val: register value - * - * Return: 0 if successful, error code otherwise. - */ -static int ov9282_write_reg(struct ov9282 *ov9282, u16 reg, u32 len, u32 v= al) -{ - struct i2c_client *client =3D v4l2_get_subdevdata(&ov9282->sd); - u8 buf[6] =3D {0}; - - if (WARN_ON(len > 4)) - return -EINVAL; - - put_unaligned_be16(reg, buf); - put_unaligned_be32(val << (8 * (4 - len)), buf + 2); - if (i2c_master_send(client, buf, len + 2) !=3D len + 2) - return -EIO; - - return 0; -} - -/** - * ov9282_write_regs() - Write a list of registers - * @ov9282: pointer to ov9282 device - * @regs: list of registers to be written - * @len: length of registers array - * - * Return: 0 if successful, error code otherwise. - */ -static int ov9282_write_regs(struct ov9282 *ov9282, - const struct ov9282_reg *regs, u32 len) -{ - unsigned int i; - int ret; - - for (i =3D 0; i < len; i++) { - ret =3D ov9282_write_reg(ov9282, regs[i].address, 1, regs[i].val); - if (ret) - return ret; - } - - return 0; -} - /** * ov9282_update_controls() - Update control ranges based on streaming mode * @ov9282: pointer to ov9282 device @@ -639,15 +537,15 @@ static int ov9282_update_exp_gain(struct ov9282 *ov92= 82, u32 exposure, u32 gain) dev_dbg(ov9282->dev, "Set exp %u (~%u us), analog gain %u", exposure, exposure_us, gain); =20 - ret =3D ov9282_write_reg(ov9282, OV9282_REG_HOLD, 1, 1); + ret =3D cci_write(ov9282->regmap, OV9282_REG_HOLD, 0x01, NULL); if (ret) return ret; =20 - ret =3D ov9282_write_reg(ov9282, OV9282_REG_EXPOSURE, 3, exposure << 4); + ret =3D cci_write(ov9282->regmap, OV9282_REG_EXPOSURE, exposure << 4, NUL= L); if (ret) goto error_release_group_hold; =20 - ret =3D ov9282_write_reg(ov9282, OV9282_REG_AGAIN, 1, gain); + ret =3D cci_write(ov9282->regmap, OV9282_REG_AGAIN, gain, NULL); if (ret) goto error_release_group_hold; =20 @@ -656,60 +554,9 @@ static int ov9282_update_exp_gain(struct ov9282 *ov928= 2, u32 exposure, u32 gain) OV9282_STROBE_FRAME_SPAN_DEFAULT); =20 error_release_group_hold: - ov9282_write_reg(ov9282, OV9282_REG_HOLD, 1, 0); - - return ret; -} - -static int ov9282_set_ctrl_hflip(struct ov9282 *ov9282, int value) -{ - u32 current_val; - int ret =3D ov9282_read_reg(ov9282, OV9282_REG_TIMING_FORMAT_2, 1, - ¤t_val); - if (ret) - return ret; + int ret_hold =3D cci_write(ov9282->regmap, OV9282_REG_HOLD, 0, NULL); =20 - if (value) - current_val |=3D OV9282_FLIP_BIT; - else - current_val &=3D ~OV9282_FLIP_BIT; - - return ov9282_write_reg(ov9282, OV9282_REG_TIMING_FORMAT_2, 1, - current_val); -} - -static int ov9282_set_ctrl_vflip(struct ov9282 *ov9282, int value) -{ - u32 current_val; - int ret =3D ov9282_read_reg(ov9282, OV9282_REG_TIMING_FORMAT_1, 1, - ¤t_val); - if (ret) - return ret; - - if (value) - current_val |=3D OV9282_FLIP_BIT; - else - current_val &=3D ~OV9282_FLIP_BIT; - - return ov9282_write_reg(ov9282, OV9282_REG_TIMING_FORMAT_1, 1, - current_val); -} - -static int ov9282_set_ctrl_flash_strobe_oe(struct ov9282 *ov9282, bool ena= ble) -{ - u32 current_val; - int ret; - - ret =3D ov9282_read_reg(ov9282, OV9282_REG_OUTPUT_ENABLE6, 1, ¤t_va= l); - if (ret) - return ret; - - if (enable) - current_val |=3D OV9282_OUTPUT_ENABLE6_STROBE; - else - current_val &=3D ~OV9282_OUTPUT_ENABLE6_STROBE; - - return ov9282_write_reg(ov9282, OV9282_REG_OUTPUT_ENABLE6, 1, current_val= ); + return ret ? ret : ret_hold; } =20 static u32 ov9282_us_to_flash_duration(struct ov9282 *ov9282, u32 value) @@ -740,30 +587,6 @@ static u32 ov9282_flash_duration_to_us(struct ov9282 *= ov9282, u32 value) return DIV_ROUND_UP(value * frame_width, OV9282_STROBE_SPAN_FACTOR); } =20 -static int ov9282_set_ctrl_flash_duration(struct ov9282 *ov9282, u32 value) -{ - u32 val =3D ov9282_us_to_flash_duration(ov9282, value); - int ret; - - ret =3D ov9282_write_reg(ov9282, OV9282_REG_STROBE_FRAME_SPAN, 1, - (val >> 24) & 0xff); - if (ret) - return ret; - - ret =3D ov9282_write_reg(ov9282, OV9282_REG_STROBE_FRAME_SPAN + 1, 1, - (val >> 16) & 0xff); - if (ret) - return ret; - - ret =3D ov9282_write_reg(ov9282, OV9282_REG_STROBE_FRAME_SPAN + 2, 1, - (val >> 8) & 0xff); - if (ret) - return ret; - - return ov9282_write_reg(ov9282, OV9282_REG_STROBE_FRAME_SPAN + 3, 1, - val & 0xff); -} - /** * ov9282_set_ctrl() - Set subdevice control * @ctrl: pointer to v4l2_ctrl structure @@ -818,23 +641,27 @@ static int ov9282_set_ctrl(struct v4l2_ctrl *ctrl) break; case V4L2_CID_VBLANK: lpfr =3D ov9282->vblank + ov9282->cur_mode->height; - ret =3D ov9282_write_reg(ov9282, OV9282_REG_LPFR, 2, lpfr); + ret =3D cci_write(ov9282->regmap, OV9282_REG_LPFR, lpfr, NULL); break; case V4L2_CID_HFLIP: - ret =3D ov9282_set_ctrl_hflip(ov9282, ctrl->val); + ret =3D cci_update_bits(ov9282->regmap, OV9282_REG_TIMING_FORMAT_2, + OV9282_FLIP_BIT, ctrl->val ? OV9282_FLIP_BIT : 0, NULL); break; case V4L2_CID_VFLIP: - ret =3D ov9282_set_ctrl_vflip(ov9282, ctrl->val); + ret =3D cci_update_bits(ov9282->regmap, OV9282_REG_TIMING_FORMAT_1, + OV9282_FLIP_BIT, ctrl->val ? OV9282_FLIP_BIT : 0, NULL); break; case V4L2_CID_HBLANK: - ret =3D ov9282_write_reg(ov9282, OV9282_REG_TIMING_HTS, 2, - (ctrl->val + ov9282->cur_mode->width) >> 1); + ret =3D cci_write(ov9282->regmap, OV9282_REG_TIMING_HTS, + (ctrl->val + ov9282->cur_mode->width) >> 1, NULL); break; case V4L2_CID_FLASH_STROBE_OE: - ret =3D ov9282_set_ctrl_flash_strobe_oe(ov9282, ctrl->val); + ret =3D cci_update_bits(ov9282->regmap, OV9282_REG_OUTPUT_ENABLE6, + OV9282_OUTPUT_ENABLE6_STROBE, + ctrl->val ? OV9282_OUTPUT_ENABLE6_STROBE : 0, NULL); break; case V4L2_CID_FLASH_DURATION: - ret =3D ov9282_set_ctrl_flash_duration(ov9282, ctrl->val); + ret =3D cci_write(ov9282->regmap, OV9282_REG_STROBE_FRAME_SPAN, ctrl->va= l, NULL); break; default: dev_err(ov9282->dev, "Invalid control %d", ctrl->id); @@ -1114,7 +941,7 @@ static int ov9282_get_selection(struct v4l2_subdev *sd, */ static int ov9282_start_streaming(struct ov9282 *ov9282) { - const struct ov9282_reg bitdepth_regs[2][2] =3D { + const struct reg_sequence bitdepth_regs[2][2] =3D { { {OV9282_REG_PLL_CTRL_0D, OV9282_PLL_CTRL_0D_RAW10}, {OV9282_REG_ANA_CORE_2, OV9282_ANA_CORE2_RAW10}, @@ -1128,15 +955,16 @@ static int ov9282_start_streaming(struct ov9282 *ov9= 282) int ret; =20 /* Write common registers */ - ret =3D ov9282_write_regs(ov9282, common_regs_list.regs, - common_regs_list.num_of_regs); + ret =3D regmap_multi_reg_write(ov9282->regmap, common_regs, + ARRAY_SIZE(common_regs)); if (ret) { dev_err(ov9282->dev, "fail to write common registers"); return ret; } =20 bitdepth_index =3D ov9282->code =3D=3D MEDIA_BUS_FMT_Y10_1X10 ? 0 : 1; - ret =3D ov9282_write_regs(ov9282, bitdepth_regs[bitdepth_index], 2); + ret =3D regmap_multi_reg_write(ov9282->regmap, + bitdepth_regs[bitdepth_index], 2); if (ret) { dev_err(ov9282->dev, "fail to write bitdepth regs"); return ret; @@ -1144,7 +972,8 @@ static int ov9282_start_streaming(struct ov9282 *ov928= 2) =20 /* Write sensor mode registers */ reg_list =3D &ov9282->cur_mode->reg_list; - ret =3D ov9282_write_regs(ov9282, reg_list->regs, reg_list->num_of_regs); + ret =3D regmap_multi_reg_write(ov9282->regmap, reg_list->regs, + reg_list->num_of_regs); if (ret) { dev_err(ov9282->dev, "fail to write initial registers"); return ret; @@ -1158,8 +987,8 @@ static int ov9282_start_streaming(struct ov9282 *ov928= 2) } =20 /* Start streaming */ - ret =3D ov9282_write_reg(ov9282, OV9282_REG_MODE_SELECT, - 1, OV9282_MODE_STREAMING); + ret =3D cci_write(ov9282->regmap, OV9282_REG_MODE_SELECT, + OV9282_MODE_STREAMING, NULL); if (ret) { dev_err(ov9282->dev, "fail to start streaming"); return ret; @@ -1176,8 +1005,8 @@ static int ov9282_start_streaming(struct ov9282 *ov92= 82) */ static int ov9282_stop_streaming(struct ov9282 *ov9282) { - return ov9282_write_reg(ov9282, OV9282_REG_MODE_SELECT, - 1, OV9282_MODE_STANDBY); + return cci_write(ov9282->regmap, OV9282_REG_MODE_SELECT, + OV9282_MODE_STANDBY, NULL); } =20 /** @@ -1228,14 +1057,14 @@ static int ov9282_set_stream(struct v4l2_subdev *sd= , int enable) static int ov9282_detect(struct ov9282 *ov9282) { int ret; - u32 val; + u64 val; =20 - ret =3D ov9282_read_reg(ov9282, OV9282_REG_ID, 2, &val); + ret =3D cci_read(ov9282->regmap, OV9282_REG_ID, &val, NULL); if (ret) return ret; =20 if (val !=3D OV9282_ID) { - dev_err(ov9282->dev, "chip id mismatch: %x!=3D%x", + dev_err(ov9282->dev, "chip id mismatch: %x!=3D%llx", OV9282_ID, val); return -ENXIO; } @@ -1397,9 +1226,8 @@ static int ov9282_power_on(struct device *dev) =20 usleep_range(400, 600); =20 - ret =3D ov9282_write_reg(ov9282, OV9282_REG_MIPI_CTRL00, 1, - ov9282->noncontinuous_clock ? - OV9282_GATED_CLOCK : 0); + ret =3D cci_write(ov9282->regmap, OV9282_REG_MIPI_CTRL00, + ov9282->noncontinuous_clock ? OV9282_GATED_CLOCK : 0, NULL); if (ret) { dev_err(ov9282->dev, "fail to write MIPI_CTRL00"); goto error_clk; @@ -1576,6 +1404,11 @@ static int ov9282_probe(struct i2c_client *client) return ret; } =20 + ov9282->regmap =3D devm_cci_regmap_init_i2c(client, 16); + if (IS_ERR(ov9282->regmap)) + return dev_err_probe(ov9282->dev, PTR_ERR(ov9282->regmap), + "Failed to init CCI\n"); + mutex_init(&ov9282->mutex); =20 ret =3D ov9282_power_on(ov9282->dev); --=20 2.43.0 From nobody Thu Apr 16 08:29:58 2026 Received: from mx0b-0064b401.pphosted.com (mx0b-0064b401.pphosted.com [205.220.178.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7773924679C; Sun, 1 Mar 2026 10:49:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.178.238 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772362144; cv=fail; b=sDa9RhSdFBztjIqMQRWFoD2vs2XBUaeTbjta+f1UnXeDwjYWj5yOsakOF0IDjq425drL6+OZCIG8I70BPxkkelfO8AG8gNRizPO1XmfknUmYoGIIghhMYZbkJcYzfHAnWm3LaRHUX7LI3yOHQQoTf6h5SZUMxgz2Ls+W/lM8JjU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772362144; c=relaxed/simple; bh=AN3c4bBmQQE2Do7LHycCnS2jUJTKNII6t5ydRUQ5VRo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=TTZchbplJTctVf9tX0h6Ebu/kJ/jvvSFK9YaOP0VeJ+o3z/ul1HrgsL/izyiiMJQzhgZFgAcjcGjfFqiSloJGzQGGTvlv1YH4yOU6A42zvueAafkztg6uKVj4q607FQ3IHgvc+mS29XhMa6IBdW27pZL6NSXrXnoH67JjPTlgRk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=pass smtp.mailfrom=windriver.com; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b=YvQlqE63; arc=fail smtp.client-ip=205.220.178.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=windriver.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b="YvQlqE63" Received: from pps.filterd (m0250812.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 621ADg0J1397059; Sun, 1 Mar 2026 10:48:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to; s= PPS06212021; bh=x+UUiPRvqC0vWXto1fuHjzxdANOyOoaabzKmp6LqauY=; b= YvQlqE63M7EPm2zNBULGH7AxwrN5D/kaU/l4eW4kXKLN3uOPlaLoySfIziacok/u PbMaN8PQqH0OYlzx08OKeDPP468wlwSCU86HxoIVkSKlkri1+W/kAFXWuRnVBLMe rrdxaKdjyJHIddU9PUrgCST1rvII+5MVyAXlMdrE8XtXIKQj1X604GjvzcTS/RC8 VMNn0qOOG6omFp+TRkMVRUNqeQBr9L9XglSwD9uACJr83P7EaAEMvK2GIn7fFfSN DS0QkmxhgtGkCO0bZreLvRQttKp3NIY90kN8G7LtaMhMGwTb91MJQZWQ7wS/VE8V VTfAPxk/WWQMsigbB+QA2Q== Received: from cy3pr05cu001.outbound.protection.outlook.com (mail-westcentralusazon11013008.outbound.protection.outlook.com [40.93.201.8]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 4ckqb4hbm8-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sun, 01 Mar 2026 10:48:36 +0000 (GMT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zWzR6BLCtjjnH3/rkaeRH5yTmZZk9fnwa4J0s65bBc4SmmvuUsxStkk0F1MFNAztEf+ITCMcm2TTb9JwJk6HyDx7UoDCpXyBihwpO8LhxXHpcZ25bCJApemfLMTYAO/ag9x5kMjznNlMKMg4zlj24ZYhSntZrACDL89/zE4nhkwJwCPap1PGR16jYnL+Y4BrMtSj3pwAEt2Jrx4DqitFEB4z7ouUP4FbzyZKInmTLUutMqVx4zc8z68uaImcz/pR4wCir/12S6t7RFM9D8/WmZ+VIZwRaZnfOPGQgb3eqpe50tkovM4ZAwwsLiYsSz41XoG/dqISFksX6tynh6SlAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x+UUiPRvqC0vWXto1fuHjzxdANOyOoaabzKmp6LqauY=; b=QvSkJ+q8hz8KF5gWaYO/0gwlClNzTBgFWKa1QYloLzlG75pS0a1BcTJugh61T5KLifme9ABqHMWc+onRUfILdcrZV5VopX2J7OBDHxzw+zOFAMt3IJTbfWCa+MmheL3DvbNbvudzI0M5W6zlXADTQxL/shp/mEE/uPa7HBSw2CbVddo1FmQVrlQOJOxzcedho6RwkFOoEnHuW/sH+FRxLGMF7SBk2w5DpDaOTGdBoxWpnwWpuPviSVo9sXImcFTr9r3m1nMTws0HRnkTWQSro6LoOUifCYjPAJIp00ZcJrJ4IClNnRGAwe8ZNMk1R04l9QQXckPs9qWYvSVxNKNRVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from DS4PPFD667CEBB6.namprd11.prod.outlook.com (2603:10b6:f:fc02::53) by MW6PR11MB8311.namprd11.prod.outlook.com (2603:10b6:303:241::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.14; Sun, 1 Mar 2026 10:48:35 +0000 Received: from DS4PPFD667CEBB6.namprd11.prod.outlook.com ([fe80::5f46:caa4:60d4:f669]) by DS4PPFD667CEBB6.namprd11.prod.outlook.com ([fe80::5f46:caa4:60d4:f669%2]) with mapi id 15.20.9654.014; Sun, 1 Mar 2026 10:48:35 +0000 From: Xiaolei Wang To: sakari.ailus@linux.intel.com, tarang.raval@siliconsignals.io, laurent.pinchart@ideasonboard.com, dave.stevenson@raspberrypi.com, jacopo@jmondi.org, mchehab@kernel.org, prabhakar.mahadev-lad.rj@bp.renesas.com, hverkuil+cisco@kernel.org, johannes.goede@oss.qualcomm.com, hverkuil-cisco@xs4all.nl, jai.luthra@ideasonboard.com, Xiaolei.Wang@windriver.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] media: i2c: ov9282: Switch to using the sub-device state lock Date: Sun, 1 Mar 2026 18:48:08 +0800 Message-ID: <20260301104809.3505257-3-xiaolei.wang@windriver.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260301104809.3505257-1-xiaolei.wang@windriver.com> References: <20260301104809.3505257-1-xiaolei.wang@windriver.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SEWP216CA0119.KORP216.PROD.OUTLOOK.COM (2603:1096:101:2b9::9) To DS4PPFD667CEBB6.namprd11.prod.outlook.com (2603:10b6:f:fc02::53) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS4PPFD667CEBB6:EE_|MW6PR11MB8311:EE_ X-MS-Office365-Filtering-Correlation-Id: 412230df-aba8-4bb2-5c56-08de77801663 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|921020|38350700014; X-Microsoft-Antispam-Message-Info: 4PFNkjaR7+Bq5rBgcwat8UCwJCZGyJsDV821MvViWui/DKzUuDOoHfQBRTK+jDg8eOpNAXEFI401YTrA4Ww0bW4P9Qz9BWskyYF1U9ZujC17szfEtDbc/WfnY7oM8ngtcuKladhTJECqhMtNkqas8GJkhpZewNIeuwNwD7sAsidfj3JT6lKuriglB+0k9AUFE2Lyrd6KKD4M3wH/6IVC55mFg51RrjuFWZxOOGQACe3vYsOPXcTtr/jFoudQga2j9OUCRLaQsZccqrDSmfByGbDAjvmL10U5TZazdPHTbhoi2pZGY4iyf2FmXSTN+GQ/rAm3dxjIGr0wFZzRqNAsUhqk8nfYoXatzqIrt5NCYqHtsrozdtOKFj79LhSbjfv8L/jKRHtK40tPWpubLM7uxtHWDnziXR3P28DS/COvtTkfF19GECp1ymNWoxddX3lxu781nFNOUB62pgHnuZAdG/5u74tY/gW9DWzTG/Y8IEwdSDWNPSd7Qex7lW6fP7rWJFH3LYSMbWc0FVTs+/XwFlwKngE3L8hWFsF+8UXeIjKMw18Q5VtM5IQkYcrdm4maIx45Dt8EzpLiZ/xxaLGzKdc1gN4lfSim+hxymfH0hof/K+ijpVCkRRUDwshxVzWiJVtQnFkVbYhQfHcKWbwz/h3Xt7thhCq8bWgeq7Es1PsaeDHJyTdk2GuTTYMDJB3LQ7amb6tNAm7zVauEJ/zKaZ6bwGeKaEcSRHth2mcAOZ0jhn8Ak728evtSFAh8AaGg4ymR6otvg2gmEklUIQWYJiUtFJpcFHwLRiH64coX0dFHzVokK93Nd6P/7ZlbNBQ3 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS4PPFD667CEBB6.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gueNUtIwga6itLeq06E1PLImptYR6WLgoruQZeEL7QS82ZqRAzC9ncoY76/b?= =?us-ascii?Q?jtaEiDMbt57grO4ncLw9p2zdXWgSEsdN2PGMbOHRHhmTDyPqxlVCw5CERD6l?= =?us-ascii?Q?0swKfjAUbvTK0G5gQJbMupa0nywgOBPJM/y5Qc98E91MNCwC9RYxKLTeyhp5?= =?us-ascii?Q?glSYyNm5CaPlLk2R21/U0PZ7ea1SPSFAhonp6UXh78mt1Hs5YcD1yko1YNOg?= =?us-ascii?Q?t0bXVoW86dfcQxjlMVyd/MhBMEC6p8/G9ds+dkr8sxyDt8cjwDv1Pz7HofaD?= =?us-ascii?Q?/o9oHwPrGFiW7+KvGEg5DHrvrCaDLHLw6QiYZXIsg6tFSMZEeIinKSZk066m?= =?us-ascii?Q?lIfy9rBMqzvIz/NiFRz6GNc2boL4qcTVpBUfIPVii0VT1uO+4oiR8yZOM+tE?= =?us-ascii?Q?YLpjymDBdT7quPbu851uHFA5syPwrXKKqnjX8v7kT0OKugC0+352CyijnoMf?= =?us-ascii?Q?szqztqDR37eqpX/5MFpE8Pdt33bgRXOrNra4Y328Z7mhEgXyuwxnIzeIwr3V?= =?us-ascii?Q?OilMDS/jFxfcDHXxphpnrOhx2IwwFXD06jcCHsjF7Kus0yTQ7o9z6Dq1KbMD?= =?us-ascii?Q?XACSx+RzjU6qIQDZ29TOnxSB10F/+OUIyVdpHrdeMrCFxc5L8eRYg/iOaNCP?= =?us-ascii?Q?VoyoIM7rjtrAPo+7fUZqUGFXZxNkVrxsTyFPTVckVFBc/WBY20l9/vFeNmQs?= =?us-ascii?Q?Ow+Vj5GLiUDkJZnoodiqGZTmT2xQ+rOF+Y+U3BezEY58qSOx3XS1Jal7lsdL?= =?us-ascii?Q?C5zKD68ikrPOLUFEjbPBqrxbkReSVHoKevPzcRGc1RPirJ5ZP2kOafRyujsm?= =?us-ascii?Q?X1KQy/qqtNRiKOFESWeuhlJSEA6noqg2sgpPevMrOWsnzMOteWHaS0P84Svh?= =?us-ascii?Q?vf5mRUAxOuX1Mn6/Be55AYOplDHTe28C6Q7PQqNrTgkqNeXGr1UhAK22kJPO?= =?us-ascii?Q?Z2q72HLRpsB/ep7rUr5iar6YHFo7wrNK8K/YVepF5CDMZYa5wc+xU7A06LpY?= =?us-ascii?Q?VFlz/LPtWPMFBz769eTDbRDmKjzJ3EK3MCnk4Y3Mx5+NS/C6XSUYpVfmsZni?= =?us-ascii?Q?62CeE/GJJwkdUII4BGZ7eK9b18VUP6IfAMH86SqJPjxGk5JU2gZmE8UqgGpk?= =?us-ascii?Q?AUTdkZEEj3AcWsleRznV/29KHx+fXZgWFpSeL2MyfC04DUzBmIHQMHgZVcNW?= =?us-ascii?Q?DGYE4LCsBUD9hCJj/hhrKFW196M37oRsbOcuXNIiveMVfoRtVqGq9mcTAfV9?= =?us-ascii?Q?SWXvrsjVjW2+xQhbHth2ygNJYjNuezU0Gs4pLanSAWyiZQm7Ko08A3Cdxvm3?= =?us-ascii?Q?Sq5ahBd3Imyl2N2WEgBKMdBo7bP2OB/fb62hriTjL0X709mgrvzUe0iRhc0h?= =?us-ascii?Q?LOtJ7QtzjM1O9/ZUBP9HPvCavI5Odn/+QqZ8bG9NUAd1PX4re9GadVyFaqRI?= =?us-ascii?Q?zPa1ChfgcHK/PIiMfTp9edHWFSorVcnCUqtIrmehwjVBSWK8HLjb6PlU+tGu?= =?us-ascii?Q?ueoWacFk2l/Z+uXRUhoS5JtTUlV3Bq++AWFlHdYYzSHNcxrOraPVTNhHj2j+?= =?us-ascii?Q?Ih3yxHPiUZy7RSkvlRuR9tEum1p892xvQxpSV0Uddfpt/Ya+ym4rulr9t1iZ?= =?us-ascii?Q?9VHXRyiKgh50NFknbz6l2YoF8x2Arhv+keiAnhmyIQHr0f+6sVPnWih0MS5L?= =?us-ascii?Q?edOZQ8B/XBZaNQGhe7ANEhjq+ndhPGvvyKAUf9CVE4yt+pjxFVj4rPq+ZWCS?= =?us-ascii?Q?CvwyjXlTcQmj7N4kxTg+0AoGHq0ATRU=3D?= X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 412230df-aba8-4bb2-5c56-08de77801663 X-MS-Exchange-CrossTenant-AuthSource: DS4PPFD667CEBB6.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2026 10:48:35.0503 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zNgX8V3YpSCx2r0xwA7AvFAeBMWiat/GQNSFDN9+BxXpagOKd6jbUGXzneiV+TGuek0M1OQobo65+BbNBIPAqS9ezP76Ju1/Zcr47dzzZx4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR11MB8311 X-Authority-Analysis: v=2.4 cv=LqWfC3dc c=1 sm=1 tr=0 ts=69a41984 cx=c_pps a=2E9rO6gqkamS8B1JEYjvvA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=bi6dqmuHe4P4UrxVR6um:22 a=fTW__CHxibyLmBMfj2wP:22 a=t7CeM3EgAAAA:8 a=b-pzV9cxAM0HHkGdTPcA:9 a=FdTzh2GWekK77mhwV6Dw:22 X-Proofpoint-GUID: PRzFFJWkmpHVAvn1IutB-V7rnsujCikQ X-Proofpoint-ORIG-GUID: PRzFFJWkmpHVAvn1IutB-V7rnsujCikQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAxMDA5NyBTYWx0ZWRfX81Y2JAycD7CV a6Su7dJynfaRFq242N+4ek04NGuvR5xMfNkIktJ2pb3keLQSrISZDTDSb4/Q9TnD2kUbVaTD2O0 rciil2lfRdsC+y78hcMUdNgc32G4jxjDuh3mYoKJa9RlgoAde0w1ApNi7Owl7MUhMl2NrnI5lrg QIDAGIOFwZbnTdJ9NkAIBNC35KxU3nEQ5kWXWuxlg97vdxdAsMPR7o7bkCf1UxeEhetSo9H50qt E5H31DMbtoofuEZemL5qWQtgwjOJlw+3ZQgqM+6Ih8lVT/pFFH1JaXdnYVM5TDbbr64kn3Ao8DJ DxfFiry4JEc4EvskMSBOVMATVQQrzSDsWIJst5gsnafUg9ZZ/0OM2lgTf9OpbmQIXVzGEFl8sLc unfJUHjtCQHOwScE8ukpzR9RrFbVx8+bD/kOc5YxuYe9KiYDvVdyITHYz+3D6zkXIcO4uMkSXH+ 1ri9Bgd9MsPLfXzIgsA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-01_01,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 adultscore=0 clxscore=1015 priorityscore=1501 phishscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603010097 Content-Type: text/plain; charset="utf-8" Switch to using the sub-device state lock and properly call v4l2_subdev_init_finalize() / v4l2_subdev_cleanup() on probe() / remove(). Signed-off-by: Xiaolei Wang Reviewed-by: Tarang Raval --- drivers/media/i2c/ov9282.c | 50 +++++++++++++++----------------------- 1 file changed, 19 insertions(+), 31 deletions(-) diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c index 8bfaa3ae4be5..8acbd43838d5 100644 --- a/drivers/media/i2c/ov9282.c +++ b/drivers/media/i2c/ov9282.c @@ -221,7 +221,6 @@ struct ov9282 { bool noncontinuous_clock; const struct ov9282_mode *cur_mode; u32 code; - struct mutex mutex; }; =20 static const s64 link_freq[] =3D { @@ -795,8 +794,6 @@ static int ov9282_get_pad_format(struct v4l2_subdev *sd, { struct ov9282 *ov9282 =3D to_ov9282(sd); =20 - mutex_lock(&ov9282->mutex); - if (fmt->which =3D=3D V4L2_SUBDEV_FORMAT_TRY) { struct v4l2_mbus_framefmt *framefmt; =20 @@ -807,8 +804,6 @@ static int ov9282_get_pad_format(struct v4l2_subdev *sd, fmt); } =20 - mutex_unlock(&ov9282->mutex); - return 0; } =20 @@ -829,8 +824,6 @@ static int ov9282_set_pad_format(struct v4l2_subdev *sd, u32 code; int ret =3D 0; =20 - mutex_lock(&ov9282->mutex); - mode =3D v4l2_find_nearest_size(supported_modes, ARRAY_SIZE(supported_modes), width, height, @@ -856,8 +849,6 @@ static int ov9282_set_pad_format(struct v4l2_subdev *sd, } } =20 - mutex_unlock(&ov9282->mutex); - return ret; } =20 @@ -904,10 +895,8 @@ static int ov9282_get_selection(struct v4l2_subdev *sd, case V4L2_SEL_TGT_CROP: { struct ov9282 *ov9282 =3D to_ov9282(sd); =20 - mutex_lock(&ov9282->mutex); sel->r =3D *__ov9282_get_pad_crop(ov9282, sd_state, sel->pad, sel->which); - mutex_unlock(&ov9282->mutex); =20 return 0; } @@ -1019,9 +1008,10 @@ static int ov9282_stop_streaming(struct ov9282 *ov92= 82) static int ov9282_set_stream(struct v4l2_subdev *sd, int enable) { struct ov9282 *ov9282 =3D to_ov9282(sd); + struct v4l2_subdev_state *state; int ret; =20 - mutex_lock(&ov9282->mutex); + state =3D v4l2_subdev_lock_and_get_active_state(sd); =20 if (enable) { ret =3D pm_runtime_resume_and_get(ov9282->dev); @@ -1036,14 +1026,14 @@ static int ov9282_set_stream(struct v4l2_subdev *sd= , int enable) pm_runtime_put(ov9282->dev); } =20 - mutex_unlock(&ov9282->mutex); + v4l2_subdev_unlock_state(state); =20 return 0; =20 error_power_off: pm_runtime_put(ov9282->dev); error_unlock: - mutex_unlock(&ov9282->mutex); + v4l2_subdev_unlock_state(state); =20 return ret; } @@ -1285,9 +1275,6 @@ static int ov9282_init_controls(struct ov9282 *ov9282) if (ret) return ret; =20 - /* Serialize controls with sensor device */ - ctrl_hdlr->lock =3D &ov9282->mutex; - /* Initialize exposure and gain */ lpfr =3D mode->vblank + mode->height; ov9282->exp_ctrl =3D v4l2_ctrl_new_std(ctrl_hdlr, @@ -1409,13 +1396,10 @@ static int ov9282_probe(struct i2c_client *client) return dev_err_probe(ov9282->dev, PTR_ERR(ov9282->regmap), "Failed to init CCI\n"); =20 - mutex_init(&ov9282->mutex); - ret =3D ov9282_power_on(ov9282->dev); - if (ret) { - dev_err(ov9282->dev, "failed to power-on the sensor"); - goto error_mutex_destroy; - } + if (ret) + return dev_err_probe(ov9282->dev, ret, + "failed to power-on the sensor"); =20 /* Check module identity */ ret =3D ov9282_detect(ov9282); @@ -1448,10 +1432,10 @@ static int ov9282_probe(struct i2c_client *client) goto error_handler_free; } =20 - ret =3D v4l2_async_register_subdev_sensor(&ov9282->sd); + ov9282->sd.state_lock =3D ov9282->ctrl_handler.lock; + ret =3D v4l2_subdev_init_finalize(&ov9282->sd); if (ret < 0) { - dev_err(ov9282->dev, - "failed to register async subdev: %d", ret); + ret =3D dev_err_probe(ov9282->dev, ret, "failed to init subdev\n"); goto error_media_entity; } =20 @@ -1459,16 +1443,22 @@ static int ov9282_probe(struct i2c_client *client) pm_runtime_enable(ov9282->dev); pm_runtime_idle(ov9282->dev); =20 + ret =3D v4l2_async_register_subdev_sensor(&ov9282->sd); + if (ret < 0) + goto v4l2_subdev_cleanup; + return 0; =20 +v4l2_subdev_cleanup: + v4l2_subdev_cleanup(&ov9282->sd); + pm_runtime_disable(ov9282->dev); + pm_runtime_set_suspended(ov9282->dev); error_media_entity: media_entity_cleanup(&ov9282->sd.entity); error_handler_free: v4l2_ctrl_handler_free(ov9282->sd.ctrl_handler); error_power_off: ov9282_power_off(ov9282->dev); -error_mutex_destroy: - mutex_destroy(&ov9282->mutex); =20 return ret; } @@ -1482,9 +1472,9 @@ static int ov9282_probe(struct i2c_client *client) static void ov9282_remove(struct i2c_client *client) { struct v4l2_subdev *sd =3D i2c_get_clientdata(client); - struct ov9282 *ov9282 =3D to_ov9282(sd); =20 v4l2_async_unregister_subdev(sd); + v4l2_subdev_cleanup(sd); media_entity_cleanup(&sd->entity); v4l2_ctrl_handler_free(sd->ctrl_handler); =20 @@ -1492,8 +1482,6 @@ static void ov9282_remove(struct i2c_client *client) if (!pm_runtime_status_suspended(&client->dev)) ov9282_power_off(&client->dev); pm_runtime_set_suspended(&client->dev); - - mutex_destroy(&ov9282->mutex); } =20 static const struct dev_pm_ops ov9282_pm_ops =3D { --=20 2.43.0 From nobody Thu Apr 16 08:29:58 2026 Received: from mx0b-0064b401.pphosted.com (mx0b-0064b401.pphosted.com [205.220.178.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF25C283FE6; Sun, 1 Mar 2026 10:49:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.178.238 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772362145; cv=fail; b=cvf3VDnvLRR8jF9twe70Tolw+I3cuPOVa1klSBg4nVZgAJI5D1Mvhs+dh9HJHVvmpnLynajXEjHEbX+2+s6iJa8Yvd+ZSWKSet3kI8KVQDriLNBcbo0iU5dF+q2k06TGhUY0dkgi9bQt0NlEPGwZRBQp3ilR5jK0+jHbiH4YBuM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772362145; c=relaxed/simple; bh=G11c+8qHFwIjST53P9zKD6wbCZbw9HcWzjRmO1duqMw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=T47ZOqowEaiEYvDhvWc1ccjSmMM2PmuCueDSMGAUXMoG7UpvMkUxAv76Ws7ARbHAJpkgBntcBJiGbnqMsDOcXhrM2JK/PBRRkNVSizTSpJoBowUTU0aCro9vcqhPWQUn55UcAsXacRFANNbM18tojg4RtngzAMuQQ8ypWQ13cD0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=pass smtp.mailfrom=windriver.com; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b=N2BD/AaF; arc=fail smtp.client-ip=205.220.178.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=windriver.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b="N2BD/AaF" Received: from pps.filterd (m0250812.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 621ADg0K1397059; Sun, 1 Mar 2026 10:48:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to; s= PPS06212021; bh=e/Lag4euRqchwce7HA81lZGbJxdfFftmfWbUSN2oo60=; b= N2BD/AaFVnyCXuGwPe4hMczY6Y/ohzPKDqeHr9mXMQCuLaTXlCKPSRliw+8Kf6Bf S5kob+/qs9hV4+7SvX5alM6CMJ4wyRPYsm+JI7p7LrlZk+tMNxn6k9zXdtkhZePq kNLE1TjDvs0pR9FjNF1puJTaoFyLtDf/REqWtbWlBBsZKrUKVjS3L4Q0zDUs2XaI eGfgoKg1puoaZKlnHeTPcBcODX5AyZJYypE/13sxjJKYnBeLpjXdLh4VisiHxooZ n2TANQn79lO3e25BM6haXgso1TfolP9FhU+o/pg6gYoF8XWX97hrKCNmVxxPVoyE PsK2wjy+Fr59zL3HYxF07g== Received: from cy3pr05cu001.outbound.protection.outlook.com (mail-westcentralusazon11013050.outbound.protection.outlook.com [40.93.201.50]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 4ckqb4hbm9-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sun, 01 Mar 2026 10:48:41 +0000 (GMT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=T0gFrfixzkGqjAs5hlfh4vhnOpqfg7xM+obJbAyPgL+OO+I1RKixH4+ev+U5sALbi9O06RgKUv72F+/jHzTCjKalAmRTt8RxK/OVTq9CVMzI1UtgalDFLOzrwUSy/ez6VLIAzL9fPx8QjwG5QSMN0gcJL2uiiLwLS7xAbwcJolM9fM77YxmhnqtU20cbuLUGZz3E97qcfNKWWgSo0eJI0P6Hdi9BAzVzFELUpXHFsLNvmgHyWxyWu03QiB6L6CHoLZZFFquqKiw2cxSiBEn2/G6OH6htSLjJBSmKdwVQ9FOcfTuUeccQRhtn0Um8FoXWjNB/stQ57Wty6RqCIGf4kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e/Lag4euRqchwce7HA81lZGbJxdfFftmfWbUSN2oo60=; b=sXc071jyF8PUU76JrjkpN29wid/PtSApIb/vchGUnZmYSBYqUFNxGXb2/z+b4wnJtmIvmrlgaaZaAs2AZeI1NEU0pb8irH6xl04QhIy00hjCGGhQlVrkU2IdsRoaV2ijx048EZ00Ofyx6LTDr8G+3KQ1GZThm+Xd3GA/QFJmudJl9bfCFC+uVXbUDLDaWFEclAiDd6NtNdwuqD/zqVkrjkY5APB2HLPsZwGjWZTtvXM0dZNA2LmS/wVBXY9jV8kPPO2EDeEamfb4ZnrfvATZ2PbkLf/PZlq/Oz1UW39MYYkVF5lBzGkMqvCvuAxwQMCB7MFgvCDctpGOEpUwlxacfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from DS4PPFD667CEBB6.namprd11.prod.outlook.com (2603:10b6:f:fc02::53) by MW6PR11MB8311.namprd11.prod.outlook.com (2603:10b6:303:241::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.14; Sun, 1 Mar 2026 10:48:39 +0000 Received: from DS4PPFD667CEBB6.namprd11.prod.outlook.com ([fe80::5f46:caa4:60d4:f669]) by DS4PPFD667CEBB6.namprd11.prod.outlook.com ([fe80::5f46:caa4:60d4:f669%2]) with mapi id 15.20.9654.014; Sun, 1 Mar 2026 10:48:39 +0000 From: Xiaolei Wang To: sakari.ailus@linux.intel.com, tarang.raval@siliconsignals.io, laurent.pinchart@ideasonboard.com, dave.stevenson@raspberrypi.com, jacopo@jmondi.org, mchehab@kernel.org, prabhakar.mahadev-lad.rj@bp.renesas.com, hverkuil+cisco@kernel.org, johannes.goede@oss.qualcomm.com, hverkuil-cisco@xs4all.nl, jai.luthra@ideasonboard.com, Xiaolei.Wang@windriver.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] media: i2c: ov9282: switch to {enable,disable}_streams Date: Sun, 1 Mar 2026 18:48:09 +0800 Message-ID: <20260301104809.3505257-4-xiaolei.wang@windriver.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260301104809.3505257-1-xiaolei.wang@windriver.com> References: <20260301104809.3505257-1-xiaolei.wang@windriver.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SEWP216CA0119.KORP216.PROD.OUTLOOK.COM (2603:1096:101:2b9::9) To DS4PPFD667CEBB6.namprd11.prod.outlook.com (2603:10b6:f:fc02::53) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS4PPFD667CEBB6:EE_|MW6PR11MB8311:EE_ X-MS-Office365-Filtering-Correlation-Id: 32669bb2-a440-47d2-7852-08de778018fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|921020|38350700014; X-Microsoft-Antispam-Message-Info: EnWLTLlHmLHUCi4HBLmVbyWvG5lYz7yNqhr/oAAGLRE9Vn8e7pH61HehHqepMx1dUkbJuuxgMFtCLFj1kniWLuu9W995hw9ks7jueD0cSrlCzB8RIGsG+9Teh0uB/DeHNyKvYy4hFxHzQsseO5peCOY3RPsd/c0ywvUkP39jOGHgwRt6LQtZPKYQrqAuCN289I/GQNTKtMEOsmx4+3k/NlZC5s8lt6wa5vz7Iu7oE13iY+uAwTlz8B/evRzMuRplIs31XZiSqaIcL0ktQ+2T0xHVeNQuEZIST0JXdX3xN81nOWD6M8WqrlgzDPLxr4Vsfq3lsSovm08W5+C7I/muvdTFBTiP9gv9juM9RTRVDbwuWxkpfZn39/RuhqWYSw/4XR68yI6WObcHbyP+JAiuRX8OykDZw4kvu1bJ94fa73JWHHpagDmD0VLPFMq8R8oN+zoOV7hEXBe+Wgw3U0VickM7XWQWWuvbq1EGr6UfKeK+zA44eWgqQL9+Z06FtzxCA+p2Au5Ic+H4ur+L5QT/1W1HbISUTJTUZrysVepaTMAypLgZPFF6G4Ejmz1NToIxhOy7MWIu+Kh+OMEwDgc2Q6CzS2Td2RpJUEPeIEsEhK/0RZ4XmaGibSz52y0ghMmCRUbjXW+gNeXm56avgnlp8mVr9r6VllHaOfRsKlxSyW+348rqMFiURm7eyhLp8xAq3NCE47F7cEz7i4vnjYAmHAncgd4SVDGWbzSinPUd5TwYsSmE8fmsVr+/MuO7sCVPiI4CIT2J/8GyyhbtJPbH560G1ZEg3ImTyxg2df11gW/L2BlO+gLTkXHcAgdIH2hE X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS4PPFD667CEBB6.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fd9BocZlhP0ECIaPdy0Pkv3M8AUNkZS96JBsnkcSJy1K4Mh1YmgGZM3a8gJi?= =?us-ascii?Q?m/745WUdFy4sqY/u00laQ4pQYiwYTV5wxrsn2WkkRTLCIwtY419yxGQea9Ha?= =?us-ascii?Q?DyQ3CedyxE4BqGu6V9sF2ZdF5jdMECGKl1IRnWuQmmDFeG/LUtIPZ0EUhxri?= =?us-ascii?Q?esIZX1G2A7ioIWKXzUviDGxmcIAU/8abn3M+bK1u6tYR2MgiTEHAVWwnZEqz?= =?us-ascii?Q?nXZwYXLRqfV3/UB9lpWAyrT4Cb5CeieQ5C9L3/PZ3TSX4FM/TGjm8uR8QJu0?= =?us-ascii?Q?DaqieyEJJSpHCPTnoMG0RDdW0br44mHo36GTiJpWYPtAYqrvxTCKLXCasHyf?= =?us-ascii?Q?+SQYkVBn34snIGUBZdfGKJ6obZQA+lOIEvPx2VPFPHKFGP6yb1T0lZc6rESF?= =?us-ascii?Q?AQR1QNko8gi3E9939oBNvvOJlRWtZj8sBeHGS35hYSsDFeu5cRy+2b+6GPBh?= =?us-ascii?Q?I6EloVp0dIYQ2F38hZY25hEIuT/1SPFArRVoD8iCRYll7bj9Oz6d5IMi10d4?= =?us-ascii?Q?yEw14ZGfUOqk19Yg0lnUt79uNYuRL2hfV8oXgXxQZrAdkj8zWaWFJnhfp2IV?= =?us-ascii?Q?NjK5JmYG4SinyDWEs58CB2ZpbjgO/aW1BcaTegLZEEi5fhV1Z591anHUkSDn?= =?us-ascii?Q?TW9+flZAVvncHsV6gJEaBzoliE6+sBNwz0UTqGTn49sTkp6QQQwFAiFupGyg?= =?us-ascii?Q?iJ8CdzPLDmGJRJvUhAjYpeXk38kdchMIbhqCHxRoFdip2NyquRE8EVLrwKCx?= =?us-ascii?Q?72kXjYfQ9zNoTwYH5BRno1VyMF3LX6etkNCZwNXLyQS+pB6TWO+B56chKGEc?= =?us-ascii?Q?WL6iVJCJrokdkqzYFgAsyErvXofHsIoGAXkdCBd9UHRwPuwTVADfZFl5vpLl?= =?us-ascii?Q?bSDo8xu3fLBxArEpWLFJRjZq8QRIjELLbG/UmZumVXUM8Qwk09MBGcDy8Adt?= =?us-ascii?Q?9Ke9XCmeVmVZhrm4FdVIiANlEBDP9yT4cVqoU6d+5IUsLOjTdbIynl61UFeR?= =?us-ascii?Q?j1lU68glG8zudGMEbvMKo36D23cEztK3wr04DOtbIEpNF61hutUrUOf38Ggb?= =?us-ascii?Q?uFsQ6RGalz1N6Mr6kuTLuRgYD+jfJqaWGF3eJtwlyKo/G74zgu42buHBOIqy?= =?us-ascii?Q?ZMVjiuqr2kibJy6/DB94mtnMOLMmI719xJ+7vIgfsUlRHt+mYFCM8cUekkXv?= =?us-ascii?Q?e0iJSqNAfIsbQHdOZz14lX+ZfcQCj1dYLMtq4PAv9XodA5HNF458MHwNUggG?= =?us-ascii?Q?MSg2CrAU7l9V4t0eYXwDTJKY9mVDvoaxydKZCaZX+0Uxpdrlo5PgaOTvfO2B?= =?us-ascii?Q?atmaSvqXU1Px+bJFLtIDj/aFKaVMQBfiEKEyK6dlpyq5gJUmlhkxuHnu65Jf?= =?us-ascii?Q?ryVz+3jeGQWL1xYNeiZoU4W2IJaNo2tuXduSAw7SrF17GqM5xFK2ITiH6tU6?= =?us-ascii?Q?yPtLxuwdxjSua2x6uRTkeAj9GXLXPbdWhrtcaUoaWxuRBi0YeEZn6de0JKe2?= =?us-ascii?Q?xt576HM//5XS9GnlsdmtgbUa1u6XZYMT/ZBDNckg5+mFJCOy0c2ockURpKCK?= =?us-ascii?Q?GSpTYoE1OeYsUo0YD6XO1XcLuBVTTrpAbaj/1vFThXtImNp0IBw0Lv+ay5M2?= =?us-ascii?Q?ZS3SHovMCYU4MZsmoIVLX7GsBhNnr1It9Okv9IAG/SzHe1pXoFe2w98VVl6y?= =?us-ascii?Q?PUTHu0tgGDTBWCEpcjdtzxx7/D0CHiLhSp8/gl628VXAdVurbBytb2uuS0vu?= =?us-ascii?Q?hLNsD1I548VsSRzhtYrIEumQCi1VBVs=3D?= X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32669bb2-a440-47d2-7852-08de778018fc X-MS-Exchange-CrossTenant-AuthSource: DS4PPFD667CEBB6.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2026 10:48:39.4365 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0Z2pTUiB34CLv4Ik08xB6AkXVHps5ofJzxY3wyslvzpvuQ+Mi/vc2UqpK9dEBvZA6j2IQe2bBRoomJlY2jMG8IyYtWvsInzzW7Mhd8DtA8Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR11MB8311 X-Authority-Analysis: v=2.4 cv=LqWfC3dc c=1 sm=1 tr=0 ts=69a41989 cx=c_pps a=IN6nX5sQGDwae/9PVKyrlQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=bi6dqmuHe4P4UrxVR6um:22 a=fTW__CHxibyLmBMfj2wP:22 a=t7CeM3EgAAAA:8 a=-DGD1vg1X50fszjQOB8A:9 a=FdTzh2GWekK77mhwV6Dw:22 X-Proofpoint-GUID: n-LGJci243QmAOGCSLNJMX7Sc6KO9ZO5 X-Proofpoint-ORIG-GUID: n-LGJci243QmAOGCSLNJMX7Sc6KO9ZO5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAxMDA5NyBTYWx0ZWRfX/1/bDJDQUwRK OgXlsQTE0HVuq2vuHccOH+uY4y3EZdLR/+awt7bXBWpr8r7/Q43i4mrr3Lp8EPrHhjvn3SnHCYo NNnIInUfwnOLD+zqvfH2WrPQyXwjINmxRY1ZPqdaKJEdxjoGNQVmOTQcM7t71wCiBt3CuAnYc0o hzkYMcbYCfTPYMRIKkd7xWeGUO5j9/YpDg6ETScsFXIMFM/E6ADR8DdAwT9AjUT05T6MpsJ+dyP XYFJEIoi81aMDdnrvgz4WMHWzwZflrFbgVpb9NYrx1USXOJu4EG8bDSD15yxaWbl5Eq0+9boXdN AzTX+rW8QcVrL/BlY4CHJCtbvwE/w0cQFoGgbRRVM4RH2SUdsInLde6WWviL6q94TQHhkAjMQL6 pa0WO6TDkbYDZb5qbH0jl60V3agTXXTxy/pgm/0gdRDyu43mthQbduN5VZvFzqGX6ZaRm+2+ORL 8CKo6vlLF8qlMb79Rhw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-01_01,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 adultscore=0 clxscore=1015 priorityscore=1501 phishscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603010097 Content-Type: text/plain; charset="utf-8" Switch from s_stream to enable_streams and disable_streams callbacks. Signed-off-by: Xiaolei Wang Reviewed-by: Tarang Raval --- drivers/media/i2c/ov9282.c | 79 ++++++++++++-------------------------- 1 file changed, 25 insertions(+), 54 deletions(-) diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c index 8acbd43838d5..ffce3da04c00 100644 --- a/drivers/media/i2c/ov9282.c +++ b/drivers/media/i2c/ov9282.c @@ -922,13 +922,9 @@ static int ov9282_get_selection(struct v4l2_subdev *sd, return -EINVAL; } =20 -/** - * ov9282_start_streaming() - Start sensor stream - * @ov9282: pointer to ov9282 device - * - * Return: 0 if successful, error code otherwise. - */ -static int ov9282_start_streaming(struct ov9282 *ov9282) +static int ov9282_enable_streams(struct v4l2_subdev *sd, + struct v4l2_subdev_state *state, u32 pad, + u64 streams_mask) { const struct reg_sequence bitdepth_regs[2][2] =3D { { @@ -939,16 +935,21 @@ static int ov9282_start_streaming(struct ov9282 *ov92= 82) {OV9282_REG_ANA_CORE_2, OV9282_ANA_CORE2_RAW8}, } }; + struct ov9282 *ov9282 =3D to_ov9282(sd); const struct ov9282_reg_list *reg_list; int bitdepth_index; int ret; =20 + ret =3D pm_runtime_resume_and_get(ov9282->dev); + if (ret) + return ret; + /* Write common registers */ ret =3D regmap_multi_reg_write(ov9282->regmap, common_regs, ARRAY_SIZE(common_regs)); if (ret) { dev_err(ov9282->dev, "fail to write common registers"); - return ret; + goto err_pm_put; } =20 bitdepth_index =3D ov9282->code =3D=3D MEDIA_BUS_FMT_Y10_1X10 ? 0 : 1; @@ -956,7 +957,7 @@ static int ov9282_start_streaming(struct ov9282 *ov9282) bitdepth_regs[bitdepth_index], 2); if (ret) { dev_err(ov9282->dev, "fail to write bitdepth regs"); - return ret; + goto err_pm_put; } =20 /* Write sensor mode registers */ @@ -965,14 +966,14 @@ static int ov9282_start_streaming(struct ov9282 *ov92= 82) reg_list->num_of_regs); if (ret) { dev_err(ov9282->dev, "fail to write initial registers"); - return ret; + goto err_pm_put; } =20 /* Setup handler will write actual exposure and gain */ ret =3D __v4l2_ctrl_handler_setup(ov9282->sd.ctrl_handler); if (ret) { dev_err(ov9282->dev, "fail to setup handler"); - return ret; + goto err_pm_put; } =20 /* Start streaming */ @@ -980,60 +981,28 @@ static int ov9282_start_streaming(struct ov9282 *ov92= 82) OV9282_MODE_STREAMING, NULL); if (ret) { dev_err(ov9282->dev, "fail to start streaming"); - return ret; + goto err_pm_put; } =20 return 0; -} =20 -/** - * ov9282_stop_streaming() - Stop sensor stream - * @ov9282: pointer to ov9282 device - * - * Return: 0 if successful, error code otherwise. - */ -static int ov9282_stop_streaming(struct ov9282 *ov9282) -{ - return cci_write(ov9282->regmap, OV9282_REG_MODE_SELECT, - OV9282_MODE_STANDBY, NULL); +err_pm_put: + pm_runtime_put(ov9282->dev); + + return ret; } =20 -/** - * ov9282_set_stream() - Enable sensor streaming - * @sd: pointer to ov9282 subdevice - * @enable: set to enable sensor streaming - * - * Return: 0 if successful, error code otherwise. - */ -static int ov9282_set_stream(struct v4l2_subdev *sd, int enable) +static int ov9282_disable_streams(struct v4l2_subdev *sd, + struct v4l2_subdev_state *state, u32 pad, + u64 streams_mask) { struct ov9282 *ov9282 =3D to_ov9282(sd); - struct v4l2_subdev_state *state; int ret; =20 - state =3D v4l2_subdev_lock_and_get_active_state(sd); - - if (enable) { - ret =3D pm_runtime_resume_and_get(ov9282->dev); - if (ret) - goto error_unlock; - - ret =3D ov9282_start_streaming(ov9282); - if (ret) - goto error_power_off; - } else { - ov9282_stop_streaming(ov9282); - pm_runtime_put(ov9282->dev); - } - - v4l2_subdev_unlock_state(state); - - return 0; + ret =3D cci_write(ov9282->regmap, OV9282_REG_MODE_SELECT, + OV9282_MODE_STANDBY, NULL); =20 -error_power_off: pm_runtime_put(ov9282->dev); -error_unlock: - v4l2_subdev_unlock_state(state); =20 return ret; } @@ -1165,7 +1134,7 @@ static const struct v4l2_subdev_core_ops ov9282_core_= ops =3D { }; =20 static const struct v4l2_subdev_video_ops ov9282_video_ops =3D { - .s_stream =3D ov9282_set_stream, + .s_stream =3D v4l2_subdev_s_stream_helper, }; =20 static const struct v4l2_subdev_pad_ops ov9282_pad_ops =3D { @@ -1174,6 +1143,8 @@ static const struct v4l2_subdev_pad_ops ov9282_pad_op= s =3D { .get_fmt =3D ov9282_get_pad_format, .set_fmt =3D ov9282_set_pad_format, .get_selection =3D ov9282_get_selection, + .enable_streams =3D ov9282_enable_streams, + .disable_streams =3D ov9282_disable_streams, }; =20 static const struct v4l2_subdev_ops ov9282_subdev_ops =3D { --=20 2.43.0