From nobody Thu Apr 16 09:10:38 2026 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAF5D28852E for ; Sat, 28 Feb 2026 20:27:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772310434; cv=none; b=Dcep/OaEq0HxVU+8/3ZilMkRDZkncapWCQ98hJ8ZouGfTLEdv5jn9PNT+QgVoIVu1DoCxYO7hJCuc0ScQBFShVmgsRgfi0CUjwmEqCrafJ167dhxs8T/LrRwX5jV4mD1DMyvL9YOUGIFui3TueEhyRWFeFOIdADHXNE9qVcBorw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772310434; c=relaxed/simple; bh=aYp4smBf5B/m1My73xjNkVi3QPyMBWYzajkjVuSgSlw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=krlwWDHVARrzFnWAQfwVsznmr2i04d7fcvlWvIppXQnNdkFrJhcRaAxFjIRXZUqBVq0Jwg/OfBFSCw6VtH95ap671/SsVGQxQ1uiFtJEpBJK3k5XbCACXJ7gwxWoloPsxaMULD2R43EOpJd2ZRbGDUjFxBH3CGu09pWY4uiMZMg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mw3uX8lY; arc=none smtp.client-ip=209.85.214.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mw3uX8lY" Received: by mail-pl1-f195.google.com with SMTP id d9443c01a7336-2aae4d2d215so7840545ad.2 for ; Sat, 28 Feb 2026 12:27:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772310430; x=1772915230; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hbY6xLWGKXtaxrC528rj/sYRbGkuV5WfacpZcBywgMA=; b=mw3uX8lYU2wGBB5KBrbno5i8W9uynI96s2wOJzOu839+4mY8hamu7DyuVT69o5kAME ff2Qfs0n9Is3QshWAtwltimVcbsnKmIkohugnsWJDpIZAMVbGzga0ayBSYfWXSxQJCRV bH2rTSqqjvuaua6jmWXmYxGJhjnNxmA5TEB1mqql4RWyj+2s6qmnSdnELnI6Hj+/fCCn ZieqJg3JTJOPQMghKoQk4Pi0Ta/ETJPAcbBIWJvJtcD2x/wqbAkUcWEQtWSTkqIe41Da 1O9hTAtgFTJ7ROI5H5GidPOzkWzSIdIBfUH5E4MuYtqR8FAUc4pOp5jC7WxAPDD7jkZY 0OOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772310430; x=1772915230; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hbY6xLWGKXtaxrC528rj/sYRbGkuV5WfacpZcBywgMA=; b=wiBIpSx/EcAd1kscZkPDmenthRUt48waob5kzg6j0QhCNRy+94tyl+fXxue4IG8r1H RDs47kHbAFAI5JGH1zwr4oBaHp9EcaDYRX+hRItvpJsWX7HKl7nbNPDVPzkIy0zN7mU5 2+FUYcK/RJhCqg7qtJJFpWU9TY90Io7KD5G2vas2ZcK9QAiAf8UI5kDcuQ9wkRIFFXK/ 7prLSf9YRrX7CCOfRnVAJXQFdCCOBYM9OEPUAgLBp7FLeIpPW5HfTKULWx9t9Ib7flj6 FWpH95tU6IP171gNbz3CDqJa4IGIm9j6Dkk25xq14oBfRGo18LQgFD9hyzSseKMtPiD4 ZVCw== X-Forwarded-Encrypted: i=1; AJvYcCXXc4gcwBCWG7Yp92bnBkgDZFAzLNm411sJbFQYRG8KH4xScXjZcooa/yAYWG5+p21Qpi7ebXDrpgtUexs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+nNP9TVhdgi4aFa89fxqe0e2JccyWu5Owa+hMynRzCqIvtYlp O6bkMZxSbhIgK5rEAnuM8i3p9Iv8jEfPAb2oiif1eCgWIWnjuxDpQp39 X-Gm-Gg: ATEYQzyNNejaAHaCMPt4IcLAcJ6JY8M9AqCmTZ6K5rgMrKHTjJPiof2k83oHuIbWamw jnFqFW2rf7BmdiZjuezpilPzRNE13VWdyFqLSMHOtlnNJ5xa/mSvKAoysxsCHj97lQbXI58AQG6 0fd6jeujOL1nsQ1RCJj2i8+FYw25fVzIu1urKcfkJj0ZpK8H9MUj4IwHyfSijCzlCtZ2JQsOH47 OtVYxDTGpOrd1nqHRWSENGavQBjqQsVn6J0ujlsu3qHM4vqJLL7SOy5QFG9W8XckWQ7bndbsrSm 1dwz/lW/OBrh1VgP8+T3qd3WkMBJ9THwUd9BFSEatcOpi4uwgf94Mu9qNj4rG9hsCaa5B3Im4kp ykuof4+77skhlm28sFyJaVNchYQxhohhqxyPG8BkTUbVcuZyn6JcBj4LurJKyBrXehgiLbe58Xi sV7l+/LnDHC8eWe577hq/2Pn7lgw0astrEWP+SDVL3SsvHos7te+o18B/NgkobpPWSTzpeMseej km+X2sTV+NfBEM= X-Received: by 2002:a17:90b:3fc8:b0:354:9dcb:1935 with SMTP id 98e67ed59e1d1-35965cd26bbmr4906008a91.6.1772310429803; Sat, 28 Feb 2026 12:27:09 -0800 (PST) Received: from cute.. ([2405:201:31:d01f:37d3:368b:370c:c273]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359834ac606sm557872a91.6.2026.02.28.12.27.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Feb 2026 12:27:09 -0800 (PST) From: Soham Kute To: andy@kernel.org, gregkh@linuxfoundation.org Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Soham Kute Subject: [PATCH] staging: fbtft: replace -1 with proper error codes Date: Sun, 1 Mar 2026 01:57:01 +0530 Message-Id: <20260228202701.43337-1-officialsohamkute@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace return -1 with proper kernel error codes: - -ENODEV when SPI device is NULL - -EINVAL when display size or buffer is invalid - -EOPNOTSUPP for unimplemented functions Signed-off-by: Soham Kute --- drivers/staging/fbtft/fb_ra8875.c | 4 ++-- drivers/staging/fbtft/fbtft-bus.c | 4 ++-- drivers/staging/fbtft/fbtft-io.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/fbtft/fb_ra8875.c b/drivers/staging/fbtft/fb_r= a8875.c index 0ab1de6647d0..c2e5c6276415 100644 --- a/drivers/staging/fbtft/fb_ra8875.c +++ b/drivers/staging/fbtft/fb_ra8875.c @@ -29,7 +29,7 @@ static int write_spi(struct fbtft_par *par, void *buf, si= ze_t len) if (!par->spi) { dev_err(par->info->device, "%s: par->spi is unexpectedly NULL\n", __func__); - return -1; + return -ENODEV; } =20 spi_message_init(&m); @@ -144,7 +144,7 @@ static int init_display(struct fbtft_par *par) write_reg(par, 0x1F, 0x01); } else { dev_err(par->info->device, "display size is not supported!!"); - return -1; + return -EINVAL; } =20 /* PWM clock */ diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtf= t-bus.c index 30e436ff19e4..9a87bddd7d19 100644 --- a/drivers/staging/fbtft/fbtft-bus.c +++ b/drivers/staging/fbtft/fbtft-bus.c @@ -181,7 +181,7 @@ int fbtft_write_vmem16_bus9(struct fbtft_par *par, size= _t offset, size_t len) =20 if (!par->txbuf.buf) { dev_err(par->info->device, "%s: txbuf.buf is NULL\n", __func__); - return -1; + return -EINVAL; } =20 remain =3D len; @@ -217,7 +217,7 @@ EXPORT_SYMBOL(fbtft_write_vmem16_bus9); int fbtft_write_vmem8_bus8(struct fbtft_par *par, size_t offset, size_t le= n) { dev_err(par->info->device, "%s: function not implemented\n", __func__); - return -1; + return -EOPNOTSUPP; } EXPORT_SYMBOL(fbtft_write_vmem8_bus8); =20 diff --git a/drivers/staging/fbtft/fbtft-io.c b/drivers/staging/fbtft/fbtft= -io.c index de1904a443c2..2144f5257fa9 100644 --- a/drivers/staging/fbtft/fbtft-io.c +++ b/drivers/staging/fbtft/fbtft-io.c @@ -19,7 +19,7 @@ int fbtft_write_spi(struct fbtft_par *par, void *buf, siz= e_t len) if (!par->spi) { dev_err(par->info->device, "%s: par->spi is unexpectedly NULL\n", __func__); - return -1; + return -ENODEV; } =20 spi_message_init(&m); @@ -231,6 +231,6 @@ EXPORT_SYMBOL(fbtft_write_gpio16_wr); int fbtft_write_gpio16_wr_latched(struct fbtft_par *par, void *buf, size_t= len) { dev_err(par->info->device, "%s: function not implemented\n", __func__); - return -1; + return -EOPNOTSUPP; } EXPORT_SYMBOL(fbtft_write_gpio16_wr_latched); --=20 2.34.1