From nobody Thu Apr 16 09:02:38 2026 Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4AB9221DB1 for ; Sat, 28 Feb 2026 20:20:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.68 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772310021; cv=none; b=TNB7Wej1zBDCt1sflPuJANIjrWZEWLr4630ceBOTkO+x4h2tSNqm1quw8iIRZYgkLrZC8LOHwoNS3v8MUnZTCXRbpCuLUfHMSMU7rZ/er5Htc0J6Q553iNy3PLrU+e9Q9yiOcLNlaApGK4ac5zlXnHRka3RsFbx1yn5ONwvnXHU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772310021; c=relaxed/simple; bh=9DspbaeTdsFF+yDLB+2+iwzjjkL6dh10LFUGIq+AQJw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=UkC3zj6OE9oQgbPTfLIrMCYiJKQ5TWb4lYbCAMs7TBZyUv0wyEf+38w/4PVniDzZv+siu8fQxCn2IvxGLMmc+aVJ1XLXZGLoA5HmNBjeCVzlvg3wrnYYvKTyRA90UvxgQqP/Y/4Px4d0OThhGVEhDmoCrjHCW62yRLWb6CKQong= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z3BkAUAi; arc=none smtp.client-ip=209.85.216.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z3BkAUAi" Received: by mail-pj1-f68.google.com with SMTP id 98e67ed59e1d1-3598661fe57so6657a91.1 for ; Sat, 28 Feb 2026 12:20:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772310017; x=1772914817; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jkJv43NJSF2MCPVDTNMcORvT8LoE/dCFArhJg80QedY=; b=Z3BkAUAiw9eIij1Z2DdaXGdLF371Tq5B5/LRnja7Y053Cp2oiIjaVb2XbeGtBLl0KC qw+B2wydztX1MNS2cm4VwFWEVvNlR34E1E+fyH2tLpiSj8grxA/s3gjLpy0WlmwaYapx 7fkF4nm31DekxfuYb2fflWraUHdPGOStuyaNAHGJCFzxGOob5GahDl7/awnvQTwtgg5y OydcI2k6Tawj4WlFO1vzHBqvkIz6zD3jYytH12QWh0QlRyex5i2SINkc7dJDKWreu63i GTkQVBIxy5dGDSn2W7VQS6aBv3P4oOda56fCkH/AWYZQfSG0jn5nK2gBRa9jBR/iXWsD icnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772310017; x=1772914817; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jkJv43NJSF2MCPVDTNMcORvT8LoE/dCFArhJg80QedY=; b=osXhEE2scfmu8Fu2GpEC3O8e5GLQAHpfSOLxbmiC/Y4t8mVDCWldFc1OXa7dIfZl2X xkdYbvCCriFuke7HeMaavkZ8HPCGMWYPg92uz90pV8o01v45IUwaa+4qkbDhH7BPcjsV s7gv9R2aF0SXpXensK/BVz4RWkrjcUxphL3ZSbVOvmKT1D4FSOkZjCSw7ccP0lXGChzL hUFXCjL9EkbTOr+04KxL7uHjay7OCCC8OvHhS2iWy3tGKy1HLb+IutOJnK85H/E0c6Mg g31j1qp8duB8TGU7VCndY8GAQ9/wt2QWzN7V8BcXSiDpdQ49w4wmwtDO7C4qdbzMxZhH TGIg== X-Forwarded-Encrypted: i=1; AJvYcCVknWv1NmRmo9Nl3MXhrZRJkR9deA7e5nQExJzmKLpu5ybHVoXbqK7dZ4rCh//UTUE1jDfY2gngF7fxhss=@vger.kernel.org X-Gm-Message-State: AOJu0YwYmQrl72L97WdkT8chiuqzYKhHtKRBdWeW0/UqA8np+1KV408V pKReI9BhCLSiuomkGbZHSXUwPYixbD4I21dn1/3EI+S9DjmOaIRu9uOf X-Gm-Gg: ATEYQzw19x2IVAQ4oZLJkql5/4Hf0La7JMMQJEV3DDgELb+PltPwS9nJ8YO+xph6lbw jRhGezd3Lfrbe8BXCvLKJFnbRuU4Y7b9u0lnZnD+kHtmYINv6c33o1gLGghXK5kjIKsPcEHLt3k gETOd9k5zVbM7Qds0aDPfoK4qpB8tQmjdXL1X75mCA5yRzxTSJCQKy3LkPcY2Yxf17bIx7lHXHr wd7jgB4ilpadm3rHNxa1oTOjQCyGJH6p8u2p1QrlJhBsgTnRrKyAzSNIkNGeNIowDu+4SkFWoGI YJmdOQ3p2lDucNRYEcHoTTdPoDsZsv1D4RK2ooLGvN3hCKpT9G1OtTGA6OM0qmtpdPvNCIB0PSA WEsw8a/ndlvt8QQzyOCLFrf9Au9J+O9+nzpLv3A+N33M9KeeZALetSDe+U+TGgHWwBSEjE+vxHD 0/OU5VuuUt9yceVfCF9clbElQCOtiR/zTW94OqPbzcC0O9nFmptLnOyaCEubapQTjyUm6VNxhS5 U9j41HhJXhgfzw= X-Received: by 2002:a17:903:32c5:b0:2ad:f7a4:afaa with SMTP id d9443c01a7336-2ae2e3ede74mr59503405ad.2.1772310016999; Sat, 28 Feb 2026 12:20:16 -0800 (PST) Received: from cute.. ([2405:201:31:d01f:37d3:368b:370c:c273]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb5c1fa8sm94994545ad.26.2026.02.28.12.20.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Feb 2026 12:20:16 -0800 (PST) From: Soham Kute To: marvin24@gmx.de, gregkh@linuxfoundation.org Cc: ac100@lists.launchpad.net, linux-tegra@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Soham Kute Subject: [PATCH] staging: nvec: kbd: use -EINVAL instead of -1 Date: Sun, 1 Mar 2026 01:50:08 +0530 Message-Id: <20260228202008.40063-1-officialsohamkute@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return proper error code -EINVAL instead of -1 when the event type or code is not supported. Signed-off-by: Soham Kute --- drivers/staging/nvec/nvec_kbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/nvec/nvec_kbd.c b/drivers/staging/nvec/nvec_kb= d.c index d2b91318f151..5f742c8b32cc 100644 --- a/drivers/staging/nvec/nvec_kbd.c +++ b/drivers/staging/nvec/nvec_kbd.c @@ -92,10 +92,10 @@ static int nvec_kbd_event(struct input_dev *dev, unsign= ed int type, return 0; =20 if (type !=3D EV_LED) - return -1; + return -EINVAL; =20 if (code !=3D LED_CAPSL) - return -1; + return -EINVAL; =20 buf[2] =3D !!value; nvec_write_async(nvec, buf, sizeof(buf)); --=20 2.34.1