From nobody Thu Apr 16 08:56:45 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 748943FFAB2 for ; Sat, 28 Feb 2026 19:15:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772306130; cv=none; b=TM/FxTExytzFzrGT5JddpYHl94HNFzjhMJQBDIELJCexRq3XHXMdH+i+oEtVqsIez+3e+OvH/9P2scrLtsY+pLsrSosUmqZJl1rESBxWuTO31l0kq3PaJEMa6o7C6CXHhTgxxrS3/ffWEuVlz8muDMYUseP32pmvZNm+NK6cxrY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772306130; c=relaxed/simple; bh=l59zQD9YqPAndUJbVtbTFeoUp1y5ZaOdah34Q1NYPxw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t0y4I8nGdOZzzfTyKK8cVS8RaF6/TBoqk4QRHgAbjBjTgsBN+S2EKF4/GK580MSm64q+r+QGBA7NwJQUf3jXWN/q6xq/88uxpuh0BR3gl8QLusPhPtMzT54Q2I1a8eGdZn6RAeSIjhRpHab+5j/DiJ7oQPeKjz77kzC+4z2UuVY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z3RQEHp7; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z3RQEHp7" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-8272c559597so3159506b3a.1 for ; Sat, 28 Feb 2026 11:15:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772306126; x=1772910926; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VFJRHzNwns07yr8sD7csxbfUGSI0WFETyr/H6xdIo98=; b=Z3RQEHp7ZfVTRl//AXHq/VYr5jTxAMelVeUxMGYx9LBUEmTtHrismg3JfqMq5znwce j0agAiFbUSN0pPh3/QAMMQbCW8tPq6oILilEHyAB4CtIEOmL79n9IGNB9eeJieUcfX2L ZZQGayD8pOlNSQ34FNsoaGhdRW4VY5ACDFAnAtdk/WD3bEjtKhi395IRRNiQy8+Lo8KT X5lywX6uv9zbvWve1k4dvQ1VkmLcKhhrK9ALHqkDbthKCNigpRioZ2wcSZ9l+zl+ZlB2 wcsEg3n+cm9P/cWFcCZRcJXR8VZ8ZdNuxQh6iVFh5XHHBVrdJHNPuP8r+a5wsWf17I3z EcFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772306126; x=1772910926; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VFJRHzNwns07yr8sD7csxbfUGSI0WFETyr/H6xdIo98=; b=nxKgwK52Xo0MzYGvgHz7fIuQiyZzc1CWUiWpNwLokpdKkUze3stqwMdsJis8xv7wRP 9Ns/RXGvCnEUgqRegIU6z7GQiYiWb4hJzc8eglAYIrc5GBY5VUByiQFhLVRTlHEwaxbb TmvRUGXDQO8MIf13XBlGq7dWmtpv4Iiq0Ftn0ct560IRw7sMzw1deIVkkN0/W3MmOep7 EluyFZMGXzbcTGybQcxFi/fP/fLWN33szK/7znxlZkIVtEe26CO36DRc6cVuChM0UszS +px2wi1izu1/mKgNPt8OnaCizr+H02KelCg37fo7QUlO1T2WZPi0gc+Pn7imx/WcUL9Y ev/Q== X-Forwarded-Encrypted: i=1; AJvYcCXFW+7zaHVDHW5eQtIedL+DKdlxprW2uUOCGPPVxgBwrUUpjh7DFiJ1szouX7qJvoGkN0qm9507aPXpSOk=@vger.kernel.org X-Gm-Message-State: AOJu0YzkX9bPbsmc+fwIucmET1AxM70vqtbtnshlW5rS4nO1nWpp1kJU aKjrpCCecAQ0vxX8TWGgkPTgbDmdSCDXgtyxFEKYyo48x55IjHxaRaey X-Gm-Gg: ATEYQzzqxMD9SHx2DFg6GtFs3OO1nzFl9I8uA14cDjEiw0goqslWJTN06bJzjwzZkLe qXjUIrOzcJ3B8ZOgDOvWMiPvpI2tqLKSJKBG++NPvRxid1Lo4/1CQl2qQJg33YMSxKvyUcs7cBe pH0i1seWBY3JYweIvVBV734vlmoWAKk2wNZO8FjvSTlmVnA756NwypsBDdaO5tSz/6vBe3jDnfj xRdfx2t9FvMeUUj16XLPtFYR7KJlvoyzV9n3VGnS8KT0apNaPuTJE/ThYgJ+rVfMJTLhENgH8T6 IZcCVla6XJ6YLVfuYXqePINL7FZuFYqRYNxQf4co8YJvImdOUeRPncjQvCNbealjPnwh+YB0ypS Z0Er+305CHS+k/TYGevHt0gb+jt88hpiXpD1hkrC7OFCy9QXuhDVbGSjr7T+/ypgP1QO58dNRKy moB1QPSekN4jK/IDfUyHew6HLN X-Received: by 2002:a05:6a00:32c7:b0:824:936a:46bb with SMTP id d2e1a72fcca58-8274d972d17mr6912554b3a.20.1772306126567; Sat, 28 Feb 2026 11:15:26 -0800 (PST) Received: from arch ([2409:40c2:5057:a20e:20e0:a4e3:da85:ffd2]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82739d4c910sm8327918b3a.8.2026.02.28.11.15.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Feb 2026 11:15:26 -0800 (PST) From: Bhargav Joshi To: jikos@kernel.org, srinivas.pandruvada@linux.intel.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, rougueprince47@gmail.com, linux-input@vger.kernel.org Subject: [PATCH 1/2] iio: hid-sensor-gyro-3d: move iio_device_register() to end of probe() Date: Sun, 1 Mar 2026 00:43:59 +0530 Message-ID: <20260228191400.19244-2-rougueprince47@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260228191400.19244-1-rougueprince47@gmail.com> References: <20260228191400.19244-1-rougueprince47@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently, calling iio_device_register() before sensor_hub_register_callback() may create a race condition where the device is exposed to userspace before callbacks are wired. Move iio_device_register() to the end of the probe() function to prevent race condition. Consequently, update the error handling path in probe() and in remove() ensuring that iio_device_unregister() is called first to cut off userspace access before the hardware callbacks are removed. Signed-off-by: Bhargav Joshi --- drivers/iio/gyro/hid-sensor-gyro-3d.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c b/drivers/iio/gyro/hid-s= ensor-gyro-3d.c index c43990c518f7..8e3628cd8529 100644 --- a/drivers/iio/gyro/hid-sensor-gyro-3d.c +++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c @@ -333,12 +333,6 @@ static int hid_gyro_3d_probe(struct platform_device *p= dev) return ret; } =20 - ret =3D iio_device_register(indio_dev); - if (ret) { - dev_err(&pdev->dev, "device register failed\n"); - goto error_remove_trigger; - } - gyro_state->callbacks.send_event =3D gyro_3d_proc_event; gyro_state->callbacks.capture_sample =3D gyro_3d_capture_sample; gyro_state->callbacks.pdev =3D pdev; @@ -346,13 +340,19 @@ static int hid_gyro_3d_probe(struct platform_device *= pdev) &gyro_state->callbacks); if (ret < 0) { dev_err(&pdev->dev, "callback reg failed\n"); - goto error_iio_unreg; + goto error_remove_trigger; + } + + ret =3D iio_device_register(indio_dev); + if (ret) { + dev_err(&pdev->dev, "device register failed\n"); + goto error_remove_callback; } =20 return ret; =20 -error_iio_unreg: - iio_device_unregister(indio_dev); +error_remove_callback: + sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_GYRO_3D); error_remove_trigger: hid_sensor_remove_trigger(indio_dev, &gyro_state->common_attributes); return ret; @@ -365,8 +365,8 @@ static void hid_gyro_3d_remove(struct platform_device *= pdev) struct iio_dev *indio_dev =3D platform_get_drvdata(pdev); struct gyro_3d_state *gyro_state =3D iio_priv(indio_dev); =20 - sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_GYRO_3D); iio_device_unregister(indio_dev); + sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_GYRO_3D); hid_sensor_remove_trigger(indio_dev, &gyro_state->common_attributes); } =20 --=20 2.53.0 From nobody Thu Apr 16 08:56:45 2026 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F9AB3FFADE for ; Sat, 28 Feb 2026 19:15:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772306140; cv=none; b=ujHwqik75okJQsjqu5/rhnBOOI6LgMM6oDUTn40nv9EpjR1F/se+n3Vqzp2ovbeji/0DovEth643nvKVtPXfrdutWGBF5TGNZeZtxUPfMELxOXNyqCRVTIuH+HpVKf1oSQDQnzbLZoMn5XHiMYCv8rMxa0X+4uSs8q2g6SOGQpY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772306140; c=relaxed/simple; bh=RaHWcaTGquYjBjkFXqSWHYS4JWm8jPuCNNkiQhCR/zg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Rm5ZsOdoruTpnxxigLGjVHWGmDPA364NeWPhQzT8TMR3h96+f8rLlCFNuZOnF5llCdmWCZCTIphYgOnYpZxhgV/cKvorSZbm0mJheBP6fDD3dNo/Bf9MU5j/QS4gXAF1Lo9GIRLwuQi4G5S+0tsjh4YQo7fpHhKuGFTiSeivYpk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nNtBaXnn; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nNtBaXnn" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-827307b12dfso1721790b3a.1 for ; Sat, 28 Feb 2026 11:15:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772306137; x=1772910937; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TrjN8Am9nPkuoa8HBafNNHI41p4l7h9p4EeDz+6g2vw=; b=nNtBaXnn3Gw6ROSGPrVyXkeO3d0ULKG9kKU952f2VvQmADWAZSwMrM3sBNLs00R2bY 33Cl0Vngi57H8oGG8XDWE6F2XJcsyBgdXDhZ3Ad41aWCa9EzgK8bQNEJ7xc/2LnDcIfD wkE0ACDw3G4e1lyzjSg3MbAkbCgmYSConK4KJf0HMU8CdrkNe5NjKtl5+kkvBfMFxpBu au5iFQKIIaJqZzPHZXVPSgASOCdAnR9JQf+B4viQiCrKi35GVp2os2/bTaNmouTT6MyE WJE1myhYa+CH8Ap7hUWdLjUVqRLPZsEDUisS0aHSBNpdsZPObOncQYMwNO4oRuqKwXHe +gLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772306137; x=1772910937; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TrjN8Am9nPkuoa8HBafNNHI41p4l7h9p4EeDz+6g2vw=; b=cl1Dux3cce1T1kYD1ZL2EAzgybVLzMccwbdwHpm7YSftW/m1rO3/7D2AOMcJH+sOki HUhYHjl1ucSw03rTbnOic5/tCvTMjHFC32uj/CMKG5bagLE1UTSpQAgaOtyvXXKu2gCv hxbRZaAqMSIcdiDACDock/XJYMQYZNuM80u7ubomeaV2fTqZfVVQrS9mKqjzYxJc6q+f iPzaT7l4OiJk8uxaYehD4pbMNeYuKnIXFMiRWnAEpxqfkxALagtbKmEDlozEKGuMkGin ZC63y5bhwmFS/oVb0/bnvQ5RIMtXd7qofjr8Sja7TMeMw7N/J/GQqojPEK05Htk6G3GV yUDg== X-Forwarded-Encrypted: i=1; AJvYcCVBdsaZuWndjKuIlIwmUHTO5UOuFoRU38PhRr8wFjJ6jX+sR9dmMUQKpywohQ/hPu9hXl+C99+/E7I2R5A=@vger.kernel.org X-Gm-Message-State: AOJu0YzKLAYIqVrmqbg6ZYlXiN7O+3Ftx+SaQDOodVceaZOuy+MoNDs+ me42Jbb6WeDJ+CqCjoSxDjzOAjT8T2PTxKvGvZTXJNYVJjky6AB0pf2Y X-Gm-Gg: ATEYQzzJcGg/T1pM7QR/Au+0mHcZ2QlildOJpbvIsRIPr99t8g/UOqSeeHODx3eRv6B nev5VPGt95VFICSXJoK51tgsyywuVfFBL6EvXkzCvRmi9B62Hrzy11+6Sr+oY1j6U2Z+0LYyNAE jhsq3fZMPTR1Ez8u8OYHtfiJsN/e//dl/mF/NB2FqG3tDv69HW0HwSwA2j0E1d6ifZTwHOEsWww NvIhgp1NbniNZPZFlILjXlAk7zCGsSreZkOhP/uT/+U4rSwckW/YAKtvgjaQUT+WwuZMlvYMWzU d3Xf0msj4KUqIXfSRuWmhBHQwbimtlSR5lpfL2LgO9KkATOpAzB7bCV9u3NU8tr3x8BTAChV0GN f8zpD/+GibxEeMfzNy5PFg6lGGcGdAIc38+fKwnMz9u+FlqiHeoN0AZMzk10/oC5qY+Zjx9tTz7 a+xFAXbpnNUnG0Tuo5bsOpU7z7 X-Received: by 2002:a05:6a00:3685:b0:824:3d5b:3cd3 with SMTP id d2e1a72fcca58-8274d9dae20mr6737395b3a.0.1772306137308; Sat, 28 Feb 2026 11:15:37 -0800 (PST) Received: from arch ([2409:40c2:5057:a20e:20e0:a4e3:da85:ffd2]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82739d4c910sm8327918b3a.8.2026.02.28.11.15.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Feb 2026 11:15:36 -0800 (PST) From: Bhargav Joshi To: jikos@kernel.org, srinivas.pandruvada@linux.intel.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, rougueprince47@gmail.com, linux-input@vger.kernel.org Subject: [PATCH 2/2] iio: hid-sensor-gyro-3d: fix typo in array name Date: Sun, 1 Mar 2026 00:44:00 +0530 Message-ID: <20260228191400.19244-3-rougueprince47@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260228191400.19244-1-rougueprince47@gmail.com> References: <20260228191400.19244-1-rougueprince47@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The array 'gryo_3d_sensitivity_addresses' has a clear spelling mistake in its prefix. Rename it to 'gyro_3d_sensitivity_addresses' to correctly match the naming convention. Signed-off-by: Bhargav Joshi --- drivers/iio/gyro/hid-sensor-gyro-3d.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c b/drivers/iio/gyro/hid-s= ensor-gyro-3d.c index 8e3628cd8529..4f88fe478d84 100644 --- a/drivers/iio/gyro/hid-sensor-gyro-3d.c +++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c @@ -42,7 +42,7 @@ static const u32 gyro_3d_addresses[GYRO_3D_CHANNEL_MAX] = =3D { HID_USAGE_SENSOR_ANGL_VELOCITY_Z_AXIS }; =20 -static const u32 gryo_3d_sensitivity_addresses[] =3D { +static const u32 gyro_3d_sensitivity_addresses[] =3D { HID_USAGE_SENSOR_DATA_ANGL_VELOCITY, }; =20 @@ -297,8 +297,8 @@ static int hid_gyro_3d_probe(struct platform_device *pd= ev) ret =3D hid_sensor_parse_common_attributes(hsdev, HID_USAGE_SENSOR_GYRO_3D, &gyro_state->common_attributes, - gryo_3d_sensitivity_addresses, - ARRAY_SIZE(gryo_3d_sensitivity_addresses)); + gyro_3d_sensitivity_addresses, + ARRAY_SIZE(gyro_3d_sensitivity_addresses)); if (ret) { dev_err(&pdev->dev, "failed to setup common attributes\n"); return ret; --=20 2.53.0