From nobody Sat Apr 18 11:14:53 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE62F383C8B for ; Sat, 28 Feb 2026 18:08:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772302119; cv=none; b=I6pzozSU+rJ76IvGvon3fbDf4Px3f43rd3nwZGoIe54dZ65zzaARI+oOpWyQj6lAt9ZN3OMXdrQnvNHvvUrw2kFZP9JNjWXw81doFKKDEL9heyc+FQpX13r38uHcgItvEoLiZ8oFAny9eA/ETpMPkUoS0OMFnblo+j6BmVZpRAs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772302119; c=relaxed/simple; bh=EO7jsIkjy8zcpTckBUW3cT/KYocmnqn8xEzGqyuAgvQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kjT1bez38W95yKVYclafLfMBbh8XWgNNWh1AC6SIxVH31HfGXRHHVtlwx4yqfqgKQwpL6OUCmQ6jN0jkzjdQtNrbKTiNOR3bYYDb3QaVsz7LcXt+wGAZ0STnYM/FDerw+fzGkUjKK9dSMVJz3oQFbxQ67wgosUdaXjaVHXi0kgY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=igEuzZYs; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="igEuzZYs" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-82735a41985so1812907b3a.2 for ; Sat, 28 Feb 2026 10:08:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772302117; x=1772906917; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1b/B2f0Vk0y2rjHQ9oplWOwEPv2E78m9d0l1U5eNgvc=; b=igEuzZYs0FLulukX5TLCjH0ZFbTEc0NPSxnQ653Bq4me+wQxy/P/2utSkQNO4k4bfn XHDE185wIdFwTIyaJjd4xRBv5v8c6jutrodQAex8+pwtsq+L8qhj+EQSMUKlNrpED0Zm JUbYEOOJp410I2e1byDReMYeRr6mdV2wsKEl3bLh0AMKYVt1Hm0dX4/9Mgf76roBKZyj zP3RSa/raDoTv2lyfhHmR0j38wl2k6EvCcBL5xFOSyIm0OKXRdzNrPWTxb19RUNyyMz1 cz+vyFdhuX59a63ALhsaN2IYwLIa96zB2f2f0XLWqGliICVl/i4/hgksVqokID/aRiM6 /7JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772302117; x=1772906917; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1b/B2f0Vk0y2rjHQ9oplWOwEPv2E78m9d0l1U5eNgvc=; b=HLExTp+Zj0Xv1wNmJIrYkYISHzT035JjVTK9LQUYlyE9aOR7vZWTlfELASrZcEqZCf Bz0zWLLY7eEQe0xge7NudVWqEB4JRlKA+P4k04DrpQE6Sdt8DhhRdHfIWtGFajPgBIum 0HJeUCys0fodDS3YaRiBTjSGJVlWa9llB59XnBIRBjY+wVNZWcycHUQB58I2xgju7Fcp 3vvWEg68FHH1kx/4CG8XMnvA+/Yx33DTQx0RnLYSdWZSEZJGMcH/dLhI9mVieUSPQzK2 tTdZQIz0kZE0FJ2A6pqUqASPoXbDtLp9Em07PH3Q8IB06YOVzswbjP8WIIl5YXdTEruC pqXQ== X-Forwarded-Encrypted: i=1; AJvYcCU9XNfsI9RkeSgyBSwCFYrKcu5j0o4mRtRd0XksiXmN3g85uJZ1rXghQcy08C9EunuX6D318rrs6NaAX7k=@vger.kernel.org X-Gm-Message-State: AOJu0Yzu72lo/lYg/ROrH9tFLKFf5xxiroSfzKBr/z6EhZSOizifTm51 GhVNeIWOb7vrZ6EJ3NnUHlK7ihUQF0+AGxB9r4N9qO77ZhINQWbUdmNv X-Gm-Gg: ATEYQzzJpbYC73RznwtrVW/5k3r/Adkf+DqFaBTplJP/yHHJBV/a6NMmlD6WIPhj1U3 AjegACfwYdibeKRm4ANOG+hSLEnNJzGN57SD0rp12TjOJ8tlIV7seg522zdCFinUVNOFetzoHpI 9RPssxRIM9One/dqaZ089FuCFNrpf9lV7tjL44HhaGD6MK0CJlP2NGfldik2jatw3OFkmDDYYHy 3R+jFX66LKz9aJGym5EUT+oSo7Iyh6TO7IITw2R0lHmt0Q13XbmMVviTjyQrtI2ryFO0wGndBzI APHhz5LgxB7wXQcyLLNGkg3b1lvKMeV0vZK+X++auBIGYS4yBgfYrlfeTYzKkhBDh/byM/ENRkX pgsLaq10j0NMP+sHRAlXKdeEIb1ffblF8mo1Su5GD2C8c/QZuscx2l9vO+Q/cjyKxftCLjtJTM7 piOTicQYWl2tZ8WZwMVd74SqjPynArxHit8y4EHsQDFZs5Z8+59LwZcR52T3i492hz58RS X-Received: by 2002:a05:6a00:1a0b:b0:81d:a1b1:731b with SMTP id d2e1a72fcca58-8274d998763mr4706209b3a.19.1772302117279; Sat, 28 Feb 2026 10:08:37 -0800 (PST) Received: from sean-All-Series.. (1-160-203-78.dynamic-ip.hinet.net. [1.160.203.78]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82739ff1ca9sm8065154b3a.36.2026.02.28.10.08.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Feb 2026 10:08:37 -0800 (PST) From: Sean Chang To: Andrew Lunn , Chuck Lever , David Laight , nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev, trond.myklebust@hammerspace.com, anna@kernel.org Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v5 1/2] sunrpc: simplify dfprintk macros and fix nfsd build error Date: Sun, 1 Mar 2026 02:08:20 +0800 Message-Id: <20260228180821.811683-2-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260228180821.811683-1-seanwascoding@gmail.com> References: <20260228180821.811683-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When CONFIG_SUNRPC_DEBUG is disabled, the dfprintk() macros currently expand to empty do-while loops. This causes variables used solely within these calls to appear unused, triggering -Wunused-variable warnings. Following David Laight's suggestion, simplify the macro definitions by removing the unnecessary 'fmt' argument and using no_printk(__VA_ARGS__) directly. This ensures the compiler performs type checking and "sees" the variables, silencing the warnings without emitting any code. Additionally, fix a build error in fs/nfsd/nfsfh.c reported by syzbot. In nfsd_setuser_and_check_port(), the variable 'buf' is conditionally defined via RPC_IFDEBUG. Since no_printk() now performs type checking, it triggers an 'undeclared identifier' error when debug is disabled. Wrap the dprintk call in an #if block to synchronize its lifecycle with 'buf', following the pattern in svc_rdma_transport.c. Link: https://lore.kernel.org/all/69a2e269.050a0220.3a55be.003e.GAE@google.= com/ Suggested-by: Andrew Lunn Suggested-by: David Laight Signed-off-by: Sean Chang --- fs/nfsd/nfsfh.c | 2 ++ include/linux/sunrpc/debug.h | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c index ed85dd43da18..f7386fd483a6 100644 --- a/fs/nfsd/nfsfh.c +++ b/fs/nfsd/nfsfh.c @@ -106,8 +106,10 @@ static __be32 nfsd_setuser_and_check_port(struct svc_r= qst *rqstp, /* Check if the request originated from a secure port. */ if (rqstp && !nfsd_originating_port_ok(rqstp, cred, exp)) { RPC_IFDEBUG(char buf[RPC_MAX_ADDRBUFLEN]); +#if IS_ENABLED(CONFIG_SUNRPC_DEBUG) dprintk("nfsd: request from insecure port %s!\n", svc_print_addr(rqstp, buf, sizeof(buf))); +#endif return nfserr_perm; } =20 diff --git a/include/linux/sunrpc/debug.h b/include/linux/sunrpc/debug.h index eb4bd62df319..cb33c7e1f370 100644 --- a/include/linux/sunrpc/debug.h +++ b/include/linux/sunrpc/debug.h @@ -52,8 +52,8 @@ do { \ # define RPC_IFDEBUG(x) x #else # define ifdebug(fac) if (0) -# define dfprintk(fac, fmt, ...) do {} while (0) -# define dfprintk_rcu(fac, fmt, ...) do {} while (0) +# define dfprintk(fac, ...) no_printk(__VA_ARGS__) +# define dfprintk_rcu(fac, ...) no_printk(__VA_ARGS__) # define RPC_IFDEBUG(x) #endif =20 --=20 2.34.1 From nobody Sat Apr 18 11:14:53 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEAB038CFFE for ; Sat, 28 Feb 2026 18:08:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772302122; cv=none; b=t1dgsbRxvrkN1uwZ+PNyVQrcnJwPRwwqj5VcQOqj+VZUzuu7lIihDtmMC1J0JawL1wrYnNxGlOd/S6YR41DRdqDHij3CXmd6sToHbyCvfBvAHGJ5kxNOIGp0w5vtKNa9HzgFattKqxmqN8UUT63npj5A10NSHq8yb4gMygxuULs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772302122; c=relaxed/simple; bh=DsCvTnRonbBjO2JlO28mIxQ6YAbIlpWMICrRxDHCp3I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dcvDdCnDbTrGWVtYJif44ICNe3g54/HOADKHlgV7rd296H0039CsbSiGl/vSS+5VuhX902OFt8Dil5fZJJNqZVLjsHtRKeTHQqR3ovweeKqFIwqHyAWN/Pp7hwdKyNNdxQKxtMcKN+0JFuY2sBOYrkhad2RxyG9WsRbYOIAX6No= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=faYghuKc; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="faYghuKc" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-8274936d2c0so2785729b3a.3 for ; Sat, 28 Feb 2026 10:08:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772302121; x=1772906921; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rX9CCCw8zu4UXrbXJRhFhr2cp9sA+7MdybCVq3xcDCE=; b=faYghuKc7vXtr9QTHxALZNCNgHYhyRPzQWVmnW2aF0ZblwAjibf0agY2ZqdkqaOkIV 3VoDNDWdHg/40Pu7Avd0o+fGsCRQw8h6gDG4i4BU7V+ARI7l/1Vj1Y8CY38hYi4Tnp3e HLlQQwKWSieGVyLW16dGVdjWjkjR5rCkveP1JqKKIRf7kMnU1dYAAOTfHCYkswLmvOeC JAub9MbSmXl0laI7sGQ3xSv/Owzte4Z7gMTs7IL4ipG6wTQ4APw8AisYAGX+8FvC+AhI vBJi7VBwD3WBUTtEgWeVCAF/YU/wCAHEj1+Qh48wzq/FWlpaY4AjKZY462SFZWVzyHV5 dDwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772302121; x=1772906921; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rX9CCCw8zu4UXrbXJRhFhr2cp9sA+7MdybCVq3xcDCE=; b=jXfJ1ClETXm3PmmoXMfxt5H//XeeB16Uw37mFwUq85iBjpRScBwDbtZeBlmX7XSfEP 1RptgkmkPN0JOOXkZA3iUjuNApw0x/FkpzHXkOVxSEYY2mQPBJipCB7umIOFttiofQSp DYQmd0Mqb6zVB2b30LKHE2chG/+2stfa2+y/GfrZ1qVEJU6V3njshjnJKa26hnEEYIcb 3FHLotL+BEWkvnXVOw2yTrB4O4r2V/rIEm9n/ULHIE+Hiqz/C8+iQkg9eTWYVoJk2xqc gEwD4/YG4VYX608urttGsY738k6tUCl8df8OE4EOreIahmWzwj7BdESSWaDii+ueDOln yzHw== X-Forwarded-Encrypted: i=1; AJvYcCVWewwe7ye7qJRZRCVOALVlA2jVzGaRWlYbTDrPfEcFzlqSnlSZxLZcIl77X+tPfFa1qlRzwUEYSsUzZNU=@vger.kernel.org X-Gm-Message-State: AOJu0YxR62+bwBQ+gFN2h0CGdsSBEKlxJ6PvTRyoQa729eAlVkl2hkRY H9GNv7del8xWT8LFq/7xSkc+z+bM21x3whL/cdmsZaU1d6GD1HOWXBL8 X-Gm-Gg: ATEYQzx1DiHNxK1qvtGPrfwGT91PjmkiCSa0WUM6hYuBMQdUDA07+TwekPR8Ls/Uc8+ zw2W4e9e0+0HZxR+3VOWq+uqFGutZWLmSNYo1rEt9eED55kIdKFb7ZLTaF3+G7B12EZ4lYBKGlN EfKQivS6DSCnU6u0VE6aXNNN3AJLx6cC2Si4roVOwkHudAy8DmU+xUqHRfY0S3yMoIRybBaI/0J 7D0DufpcvAAcHYrCOFky9NqFJBECnN7Kk1gWzGucWrsBZzX/VmE7mLdo5TZCrMsTEPGru3QMakX KCEtBRISMOoPpNJo/6mWP7/RM9uMYb0SGZJFOdpVC3RdC3h/XdSrPjQHNRLGuoQGxLLoFD2d947 Ocrb9A5VwTceoxZhxopzXQQbCWQXG1pjVaqHe8nsaSfORRaVKT5XuAKh1d6UzJaDAJ8H/UBvDsq IzygND4oL6l6Z1yHpp4rB9QDPyP0JH+csGZFWNyF6ao4CiwyoaN26CMvewd/5hXmTbpbt7 X-Received: by 2002:a05:6a00:114f:b0:827:17b7:58cf with SMTP id d2e1a72fcca58-8274d93d1bfmr6875788b3a.23.1772302121139; Sat, 28 Feb 2026 10:08:41 -0800 (PST) Received: from sean-All-Series.. (1-160-203-78.dynamic-ip.hinet.net. [1.160.203.78]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82739ff1ca9sm8065154b3a.36.2026.02.28.10.08.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Feb 2026 10:08:40 -0800 (PST) From: Sean Chang To: Andrew Lunn , Chuck Lever , David Laight , nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev, trond.myklebust@hammerspace.com, anna@kernel.org Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v5 2/2] net: macb: use ethtool_sprintf to fill ethtool stats strings Date: Sun, 1 Mar 2026 02:08:21 +0800 Message-Id: <20260228180821.811683-3-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260228180821.811683-1-seanwascoding@gmail.com> References: <20260228180821.811683-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The RISC-V toolchain triggers a stringop-truncation warning when using snprintf() with a fixed ETH_GSTRING_LEN (32 bytes) buffer. Convert the driver to use the modern ethtool_sprintf() API from linux/ethtool.h. This removes the need for manual snprintf() and memcpy() calls, handles the 32-byte padding automatically, and simplifies the logic by removing manual pointer arithmetic. Suggested-by: Andrew Lunn Reviewed-by: Andrew Lunn Signed-off-by: Sean Chang Reviewed-by: Andy Shevchenko --- drivers/net/ethernet/cadence/macb_main.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/etherne= t/cadence/macb_main.c index 5bc35f651ebd..79ca19097b2d 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -3145,7 +3145,6 @@ static int gem_get_sset_count(struct net_device *dev,= int sset) =20 static void gem_get_ethtool_strings(struct net_device *dev, u32 sset, u8 *= p) { - char stat_string[ETH_GSTRING_LEN]; struct macb *bp =3D netdev_priv(dev); struct macb_queue *queue; unsigned int i; @@ -3158,10 +3157,8 @@ static void gem_get_ethtool_strings(struct net_devic= e *dev, u32 sset, u8 *p) ETH_GSTRING_LEN); =20 for (q =3D 0, queue =3D bp->queues; q < bp->num_queues; ++q, ++queue) { - for (i =3D 0; i < QUEUE_STATS_LEN; i++, p +=3D ETH_GSTRING_LEN) { - snprintf(stat_string, ETH_GSTRING_LEN, "q%d_%s", - q, queue_statistics[i].stat_string); - memcpy(p, stat_string, ETH_GSTRING_LEN); + for (i =3D 0; i < QUEUE_STATS_LEN; i++) { + ethtool_sprintf(&p, "q%u_%s", q, queue_statistics[i].stat_string); } } break; --=20 2.34.1