From nobody Sat Apr 18 09:32:10 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C6F047B43D for ; Sat, 28 Feb 2026 15:45:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772293535; cv=none; b=nKYzD70yO//ueNMgTx9JGIY7Lgfl5Kt2ksAwIgAoBqjSAZKOXA4t1CmC+DmriGOvrpLgcdBHNyALbGDZykxtic2Lhm5egubc9r/lxtTUb7+ErRDx829/GzHWbMB8bSvy+iqhHdpXbVMRnw87J2kWgdqUhpDZ7UCq8kMHoIcX1BI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772293535; c=relaxed/simple; bh=cQLQApxV+gyvPCk7Kb0ux6zyje+EMsitaz8UQXjtjv0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=PiUIFTMax31Vk72Brwr5GxfmXTa5xnarjqNeZIjUW1MFovGu8tMLd8feu5un9sa/a1TJ4aAjseuQipL75Rmb5mvGXrzHMwuZSsIYevAUQG1UOsSJqO3N/wiSDOIvy5T1ZW9hAqI0hp/yym7UkOYYPF/i9EZO6o3IF6NEnfwCk+M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LN19Nhev; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LN19Nhev" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-826c49b7628so1989328b3a.0 for ; Sat, 28 Feb 2026 07:45:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772293533; x=1772898333; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8y0A6UC5dgjVa/R/Ri9dwaEzI34u2KnV/kwuSGeb3lg=; b=LN19NhevlzJwqZwTkrCuXYXvTewuXUcHiT3dddtEEHwU5cr7oeUXbHJaICpzkmj/hw CmEy5LGrPDEJg75LJ/iXlV4PxBvs9DEbXAQHPRW++xyzkILqg81kL5wdozVoefO9WRH+ VRO9TIzPX/mtSLQgVzsttypIvVsFQayu0DsMnRNHWkHklXtJegyqYYo9C7B+RcFNLwql wAT/O1Mnq6lXYvAC3Ln5nsS3hboUQ8L1GDqRwTaArrA3RBtr384ERJw929AKdKEQCAGf MOvx77iRjTSZk+4yY8gQ5qfyxlV/hPCoCBzP9+YWIhPaEWiIhC4vWDtpDNXMiNvLVv8D 7EQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772293533; x=1772898333; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8y0A6UC5dgjVa/R/Ri9dwaEzI34u2KnV/kwuSGeb3lg=; b=Jb6GC54mqq/Q0QcjViTY2bSmaFi8S9/lnbNEBlpv2hvVkU269jNZyahuveee5hQ+Aa n6l0fQbxRMs2SB2RkEpnTd2F4dZAQ1l8vYHDMUEgp6kDW4+gHfDnJs0eBvjxblNTfFi7 lnJ60bZyblt+YAQzsS/rl9QIpkBt8N0+dlZdt8P6tWnA8H3cmNzTjtWyGdZ0Usc2XYFj CGeEgyTiY0edbT7Wnt6w3LbmgLkCxH7AxfESLuKauUlVEO+X7igRET7mpV5/UC+QPseI CQ+bFfJvoNExRbuTwNolC0d8f4C36OwVj/omLYABucLgedI1MpkljAgr6uXqr7mfGorq hDVQ== X-Forwarded-Encrypted: i=1; AJvYcCWC77aYRtrLqxTFlaNYHGwqTHIIZUVW30gD67fZTbPIPevtJ497Fk5Xb3R+xUckTBPauaUM7yx8IUYvky8=@vger.kernel.org X-Gm-Message-State: AOJu0YwEc2vzvcEeCY4ilaLrbpz9FiZGJ97mdE9vWGa3DaCo8AgEPd4K hkyfOqU556fQdUbp/w3qm4H6/q+D/IxQPpyUkpHH4/AdTchbvX921kXa X-Gm-Gg: ATEYQzyoxi5Jzrj4yc8E06LnhgVmfrCBNilzFHIvzr9qAvgpd8chTyP+usUusYGn/g0 YiUHd55Z6LVyVFYGkty6vk20b3Y1Wyfvo7FSD3+ergb6o0aXDM6Wh70FacxFHaMCpFdly2HhbnI jdk3HYf8gYQ83WdpelLH6Tb3c2jPLrabi+vbrX1LgTGYOoGa7de490NgplBliqxkb3Av0JGTAmv KgghW9yGHz7fGP5trEKFx3W8Hl+lsKI6R5j0zaerbrpBYHepAvODXMFs19pXz8+fX0GEHLmh1Aq 6peharVGcTIOQ3AIXtK6AwTVPQit4Q1awTYWSqX6ZTGANLq/X6m5o60698jYJn7NaW6D20n5COV pZQ8OrG4rgF5Nqj0/p6ajaWRf7LYuEZjYuPfhGlMJ1Ty55oZNu7rXQH7aqb5vRidXYw4Ll2N6I0 lUrH0ll3EXiJUGUlt7i+SKL39/ok6wlVaMrIAh64Nodg== X-Received: by 2002:a05:6a21:610e:b0:394:6109:a548 with SMTP id adf61e73a8af0-395c3a1cd63mr6137821637.3.1772293532669; Sat, 28 Feb 2026 07:45:32 -0800 (PST) Received: from debian.ari ([152.58.180.148]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70fa82dd09sm7807299a12.28.2026.02.28.07.45.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Feb 2026 07:45:32 -0800 (PST) From: Archit Anant To: jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Archit Anant Subject: [PATCH] iio: adc: ad799x: use devm_iio_device_register and devm buffer setup Date: Sat, 28 Feb 2026 21:15:15 +0530 Message-Id: <20260228154515.16639-1-architanant5@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert the driver to use the device-managed versions of iio_device_register() and iio_triggered_buffer_setup(). This simplifies the error handling in ad799x_probe() by removing the 'error_cleanup_ring' goto label. It also removes the need to manually call iio_device_unregister() and iio_triggered_buffer_cleanup() in ad799x_remove(). Signed-off-by: Archit Anant --- drivers/iio/adc/ad799x.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/iio/adc/ad799x.c b/drivers/iio/adc/ad799x.c index 108bb22162ef..42712372acdb 100644 --- a/drivers/iio/adc/ad799x.c +++ b/drivers/iio/adc/ad799x.c @@ -847,7 +847,7 @@ static int ad799x_probe(struct i2c_client *client) if (ret) goto error_disable_vref; =20 - ret =3D iio_triggered_buffer_setup(indio_dev, NULL, + ret =3D devm_iio_triggered_buffer_setup(&client->dev, indio_dev, NULL, &ad799x_trigger_handler, NULL); if (ret) goto error_disable_vref; @@ -862,19 +862,17 @@ static int ad799x_probe(struct i2c_client *client) client->name, indio_dev); if (ret) - goto error_cleanup_ring; + goto error_disable_vref; } =20 mutex_init(&st->lock); =20 - ret =3D iio_device_register(indio_dev); + ret =3D devm_iio_device_register(&client->dev, indio_dev); if (ret) - goto error_cleanup_ring; + goto error_disable_vref; =20 return 0; =20 -error_cleanup_ring: - iio_triggered_buffer_cleanup(indio_dev); error_disable_vref: if (st->vref) regulator_disable(st->vref); @@ -889,9 +887,6 @@ static void ad799x_remove(struct i2c_client *client) struct iio_dev *indio_dev =3D i2c_get_clientdata(client); struct ad799x_state *st =3D iio_priv(indio_dev); =20 - iio_device_unregister(indio_dev); - - iio_triggered_buffer_cleanup(indio_dev); if (st->vref) regulator_disable(st->vref); regulator_disable(st->reg); --=20 2.39.5