From nobody Sat Apr 18 11:14:20 2026 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D2FE28312F for ; Sat, 28 Feb 2026 15:22:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772292169; cv=none; b=ZkQl1BHWmLmspxNWyqFoWbfjpOhPAtZxmlwSQF/y7Y23QReJAK+2hehys4yop6+DJeA/2E14OIkIYkP1ihcaf4WdIu3TY3pdw/Or8IckFg9cYGzgjTtH1H9JBa2z4nmL2CtMQIwbA0KXrWE4ZOL26Pd/zDLOKahFK6ifeiUKIPw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772292169; c=relaxed/simple; bh=S6uDKROnJeeqIi0NYupNmyjs6pTJRDFiU0dtOZkVFus=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iihLzvAQNTN+M7jDKh5m38tjEMRjmUo/JCozf2GEEbRpLKZEHCDrYu9FDNLp1lmtDKjT2Pw+9jxb4JKmtGg+LrCqNNtLl6uLt0A7rMG4ugSO2Uzb/FthHVwjF/sufDaaNzyfKAuwiqtpJKYA3VudtTP3i7q2HulmX+ssMrNgT6U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eXZfU7fi; arc=none smtp.client-ip=209.85.128.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eXZfU7fi" Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-7982c3b7da9so30984077b3.1 for ; Sat, 28 Feb 2026 07:22:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772292167; x=1772896967; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8gJIyL9AfQkuFfPNEXdWTtLgAIKWa7r6TpMrqBv02Ok=; b=eXZfU7fiZdyEB5cPUCL2lek1qIrBMg3MoNoO3T7Wvkb0hiDUwSxZZw5nB/mdggLhdu WWmREOdEwOFezDWlTQ0tyyCx+190RahDv1FSqp6GloKFbWfrMHHF25RHpIUpx4aItRCI /hR6Vb4y2DujPIfmOrvHRrI4JamhHRk4E9LXrzhGKAlY/1WAycuyDiCHFl98IEFIeEFZ eACjPL2mJqj5Foj9MrodBEwARpGv/0yrbkyFRKQMbeeAiJyATiiTVrzV6/umuCI5FdEw WwOiJJPnJ/rIjEcY5RV0kyywb+FIoJzpYODHisvIH2b6x5f0R5OJrba/+Uim9vQuxhTG AnPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772292167; x=1772896967; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8gJIyL9AfQkuFfPNEXdWTtLgAIKWa7r6TpMrqBv02Ok=; b=vCiS8CcWQdqCW699ri+k5NfIC+NtqrcVDfgiZJ1QYJsMvZrJ2vNb2TUlxEL78AMfnc pMKBiTx+Vn5kwi09aZb/7wNTSrb9FpD7rjpPr1khhRzDzID3Bpyl31pUC6Vvim97t5+E alXiSClDd8Xbwz56L7S3SnNuNNHbrU7K30/c6uL47kfGQofTfa/44xL0V58dOrgFMYIK sKRIc0xrfOhhtL6P7DNumIsY1cpOWmzBtyDOtOVF9Gqy06AbsyST0IaYF+gH1dIbX6x3 c62f7dzMAkCcWtNe2TiTxNGN+2zzTKDN7h7LrVrH7gYyssfP4vQQAx9us+nun9APp5Jy xjnQ== X-Forwarded-Encrypted: i=1; AJvYcCW44m6/QvEbQ4bW3kn0eqPETSx3paom+494qNTcYLRsK42mraBO+JhBvcPcIHgj3I60BHSSeu0DkRJR/Wc=@vger.kernel.org X-Gm-Message-State: AOJu0YygX5onxBFGJkvgSJW5ILMDjuE9oJG1sIA/sSMElISkbM/xWwpF GP9CEPUQnp/58A/HS/D3Za3CrarUMXv+SrHwBsqm1f7e8E8/ytwVClNn X-Gm-Gg: ATEYQzw0yLKMBKFVM8oPpuj8HFWY+/zIsJ5+R1KEZLhMIs2IbYL9c2B/osAeOlQg1Oy tV1BJf8CkI9Sx2W4JNPK6u/g4cnlRvTEeqwjhKL6Ciq/Jw4PYhNPvKI3vL4znhDQoRtMYI1OVmD LlRxfpucnRtP0qCOrimbnM7A5gPZsrPrltA8u2Pcu4203+PO0fZ9h0y98t2HxUY3CrW6Ue115vw WLvvPOg/638AzqIVTMODhS6wX5VZppAjzwLy70WkenJ0y92A61rUHv1Bll269idjIAcF+7gG0sH /tScWVmbR0j8Wl67BriuGns4BAOwXxG8igzIjITCGbvC2WZwvVT3aCYKktRv1BwUqPYhenoz7eZ vZSkqswPchYEvqPs1XKVhLszd4W0FSXAHsoKadlXWdKnMLJoomv66Qt1yGXFqEtDU5K3O4NJW7U pJnCce8DknMknkMExg8hK+it5ccOjVi0twuN6bzflDLcHh7A7Srx1xTLsq/QjyABJhlAWQW4Cb6 qrIZMyxO9gDzjyKOB6+DX+B X-Received: by 2002:a05:690c:1b:b0:796:74cf:df0c with SMTP id 00721157ae682-798855082c6mr61686407b3.24.1772292167012; Sat, 28 Feb 2026 07:22:47 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876a92039sm32861897b3.8.2026.02.28.07.22.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Feb 2026 07:22:46 -0800 (PST) From: Ethan Tidmore To: anup@brainfault.org Cc: atish.patra@linux.dev, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, ajones@ventanamicro.com, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] RISC-V: KVM: Fix out-of-bounds by 1 Date: Sat, 28 Feb 2026 09:22:26 -0600 Message-ID: <20260228152226.2116895-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The array kvpmu->pmc is defined as: struct kvm_pmc pmc[RISCV_KVM_MAX_COUNTERS]; So, accessing it with index RISCV_KVM_MAX_COUNTERS would be out-of-bounds by 1. Change index check from > to >=3D. Detected by Smatch: arch/riscv/kvm/vcpu_pmu.c:528 kvm_riscv_vcpu_pmu_ctr_info() error: buffer overflow 'kvpmu->pmc' 64 <=3D 64 Fixes: 8f0153ecd3bf1 ("RISC-V: KVM: Add skeleton support for perf") Signed-off-by: Ethan Tidmore --- arch/riscv/kvm/vcpu_pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/kvm/vcpu_pmu.c b/arch/riscv/kvm/vcpu_pmu.c index 3a4d54aa96d8..51a12f90fb30 100644 --- a/arch/riscv/kvm/vcpu_pmu.c +++ b/arch/riscv/kvm/vcpu_pmu.c @@ -520,7 +520,7 @@ int kvm_riscv_vcpu_pmu_ctr_info(struct kvm_vcpu *vcpu, = unsigned long cidx, { struct kvm_pmu *kvpmu =3D vcpu_to_pmu(vcpu); =20 - if (cidx > RISCV_KVM_MAX_COUNTERS || cidx =3D=3D 1) { + if (cidx >=3D RISCV_KVM_MAX_COUNTERS || cidx =3D=3D 1) { retdata->err_val =3D SBI_ERR_INVALID_PARAM; return 0; } --=20 2.53.0