From nobody Mon Apr 13 00:22:46 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A850B43635E for ; Sat, 28 Feb 2026 11:28:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772278111; cv=none; b=adzP3wBJ0ZYOCVlgWegUIpjQrBmfRKDSSsgVB+4QZ0yB1XrCRaaI/y4H4BO0PYSupjG2IiQ0EA4wDtLzVDdebuhQBbfi7/FX6KM7gBycqTrMAGFhliNilM/SyFFmfy/MdBQneze2VYCVOU0CuORwRc2orwSIMXRO8+FU2ZA3dHQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772278111; c=relaxed/simple; bh=cgCwNJhJbVF3U9DvelnGBZ7XOgpzzj5IODNUu2N6LbA=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=AQInYuS9M5n/VnYWlwlez6Ks0H1+RQMClY6ZKTWuJpYTkqgqyGv5lGgsYRFkaaiXe9J8FXw28skQTEYJUhRfE85z/YeeoFF+u2o9AYAnWUr9Gxoj8U2kCICPOOpukkI++Nu96VhkokGQiW2IdYRUDtzOh2kftnJ1xsJAC8+rcN8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AgJrv4F0; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AgJrv4F0" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-483770e0b25so25458505e9.0 for ; Sat, 28 Feb 2026 03:28:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772278108; x=1772882908; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=lPMQsCRzdgUsnGe3LplGdHC9I0aaGaZ1j+ZQBXbed9c=; b=AgJrv4F0UnuXgr4mXxbBRByL6ApRz+ORHH+5JxbrDYgJiYpOiDGSQOudaY3fsRc9zj XILQlUBdL+zXVy4n3ygIwjz9JDLmuMWmcExZnBzpWtiGEsmjcFR16LiUIkmHN5UPikDX gM8rN+ai3j71hSz5FcnsxyjOJ4E61+PSYHdT9oJG5dowhgROkxZ2FIyz8GodXtopFKcp R7B5RX7FocFFFcwit7Cb42j2W6HhXByqKzxx6HQS/xGI22faYSuKIU/bMNuiL3AD+sMn Rhr7BxqLO96FmS5zhuWhhOINVaIzXn3pEjMa1tH79sFt6djhm4HKCxncXFyjEIxPFeO3 vmKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772278108; x=1772882908; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lPMQsCRzdgUsnGe3LplGdHC9I0aaGaZ1j+ZQBXbed9c=; b=sqREAHUgfysQcrhZtkEf1E1r+9EP99gm1u2WERZSLvll5fz/R9LbZGHAO0Z8vKJQth PI592euSQuJG00ThbIgeto5ACmHylmh7WwRHlreUzvbha4DV8edxZFQBdYcXXUGe55PN qaOIsaX5JgiS0jzIrhPDl9lr+9k/zEQDmxtZ+JGmxUrirosvc8WCl6vV5Y2nrjzS/E6H I/CGR1MO8bX5fVrIe9N0J4RPcRVpLEM8O6ZTot8Ufr1MVO5ydus1RLlq2PbpWZaN86Gq xEQRotDo69u/9VIUTRpni2Z2doK/ECK9YMUsONzKJD3OVmhgBEUp2+PJWmjzIQ9rNL31 6cdA== X-Forwarded-Encrypted: i=1; AJvYcCXa9CrB7NPP8D38uZD/A+L1onqjdwMcqynnuzdNSSQ9N7oZos1zAEgfpMMDdGioXpcv8sm5XpSooLC8TAk=@vger.kernel.org X-Gm-Message-State: AOJu0YwY/wF9KIVH3HrRKjQKs5YugZfKhk6/sJHynz4k8Md5D2c0eM8a xzQB6FWhhbE8WooqwJt0cc/l1qtW2pLdyQagu0fRNffQds/9Uwop9pDTvQ/SiEy9R2A= X-Gm-Gg: ATEYQzyAq6V1qJ2mh/g/htUBW+VyNJsD836Zsmdsf9gHGMhGDY1e79sIQW27YF6PDDv JLlnRnMYjIL2kLGwbYvEN11zZDCgrnFSJmVEsjgvkU5hFGsXSK9fi36i+Yw6A5l1+ZDvvJVK6YA ECamVol5ObuAoUeWwYa3aN1KTrm0tMzbjcs2JEucH5IhHE0TPXHGbMvfo/hvXSgbg3U1utRPcpJ eBhAFRLF7i2QnCaM9nXiRdg4rUZ45eMq7GRI+dqx+jskjJ7rf1JmZtoIfvI514afWi8PkiSosu1 Cs3qW/yojyMTAlOnEnBAGb35afNv5e7HcwBdOjULiGd4UKtpbatli86+dhmMB4QhsgQ6Z7PW2pB UMtJzLtf002guLidiOiXfWQCrf67yEnhQQM8Xe+4/N6UMkIqYla/Ssx2vvnQuvw/Ov0vX2yU+Uq hSKBNjpwJCMeMall18xE1EZUGOdUA= X-Received: by 2002:a05:600c:5308:b0:483:c490:8c0 with SMTP id 5b1f17b1804b1-483c9bdb6d6mr93362665e9.11.1772278107808; Sat, 28 Feb 2026 03:28:27 -0800 (PST) Received: from toolbox.. ([87.200.95.144]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd702e7bsm310980275e9.5.2026.02.28.03.28.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Feb 2026 03:28:27 -0800 (PST) From: Christian Hewitt To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , Cristian Ciocaltea , Detlev Casanova , Douglas Anderson , Andy Yan , Sugar Zhang , Luca Ceresoli , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] drm/bridge: dw-hdmi-qp: fix multi-channel audio output Date: Sat, 28 Feb 2026 11:28:22 +0000 Message-ID: <20260228112822.4056354-1-christianshewitt@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jonas Karlman Channel Allocation (PB4) and Level Shift Information (PB5) are configured with values from PB1 and PB2 due to the wrong offset being used. This results in missing audio channels or incorrect speaker placement when playing multi-channel audio. Use the correct offset to fix multi-channel audio output. Fixes: fd0141d1a8a2 ("drm/bridge: synopsys: Add audio support for dw-hdmi-q= p") Reported-by: Christian Hewitt Signed-off-by: Jonas Karlman Signed-off-by: Christian Hewitt Reviewed-by: Cristian Ciocaltea --- Changes in v2: - Add my SoB as requested in v1 [0] - Add Cristians review [0] https://patchwork.kernel.org/project/dri-devel/patch/20251206072718.203= 9874-1-christianshewitt@gmail.com/ drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm= /bridge/synopsys/dw-hdmi-qp.c index ab7fed6214e0..facfb7526928 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c @@ -848,7 +848,7 @@ static int dw_hdmi_qp_config_audio_infoframe(struct dw_= hdmi_qp *hdmi, =20 regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS0, &header_bytes, 1); regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS1, &buffer[3], 1); - regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS2, &buffer[4], 1); + regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS2, &buffer[7], 1); =20 /* Enable ACR, AUDI, AMD */ dw_hdmi_qp_mod(hdmi, --=20 2.43.0