From nobody Sat Apr 18 10:44:20 2026 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAA742741C0 for ; Sat, 28 Feb 2026 02:05:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772244361; cv=none; b=CXu+Hz5umO1VSHKydzmruclRGGKCSFaw/szE/anDdLriwclmESD+93u64gGkmVMyNahiSAHQoAz+hXlAS3pdnwgBCnEFP4531R3miGCp8RT/o+sJWA2uOr9HPrNGDvOcNx1goeG0tWR8rg5cMJayuY/Fo0j9vw0M3shKMLYKlsw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772244361; c=relaxed/simple; bh=3LvDRNYHC8JXb+ZOKSkWIpa1vNpa9gAMbwjQidcNlvs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qPJ0qM6uHD3X6w6fspcBBKrjIcZbZbjpxSjE1s7GNWCc/+nrU0jPp2DoWHWawHDObWauCQi7RSkMq37J5Q65QFzg8y0TF/1X6LrK2EasSnQFsw2gXDbklOU2GrLm4vYCdbJTDnWkRT2ceoE043G/jNW9xl16qy9nfQ57Euf9N+M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RvYd7uBA; arc=none smtp.client-ip=209.85.128.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RvYd7uBA" Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-79863ab8478so27507747b3.3 for ; Fri, 27 Feb 2026 18:05:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772244358; x=1772849158; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=30Ehmo1WiVUDTgRj0dd3CAg6+LsMd6/ZP+6jbf9kFuk=; b=RvYd7uBAkg1uuzhHeih0eQ2Cmv3LZBg+BoTgBT0xlrtkphXF0pqOBv18RuUH7oJ22A eT5qK7W3m6vuQ+xruWDMce5wWY1rjB+mk74MJtgAEtuP2g4aMMJnUOwOwdfT//d7C38q yj1xjU3nDZ+hWs7nd+soNTtHxS6GYkulvxJkud8+Z8tPRURrhatS5nndhYomVFs1avBn VXzV+df3LIkfAdUsCXuJjHKrmUUH4Iz5tnRGY1q2Nu3JEpxe8MvAGg2PPgWEaEYrKMgE WWT48YIibWeHxGBJaTq1uqfuekrkZkz6Ui4RNQCmvC29C+epytDuGJY0SXQJL+HTQ0zz 4aJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772244358; x=1772849158; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=30Ehmo1WiVUDTgRj0dd3CAg6+LsMd6/ZP+6jbf9kFuk=; b=NrerKyZECGdlSOtVloH9HuKCJbQ3rldY4npD2ey1m5yM3BSPEOUqejtfUGmsuxLj4p VV/aomyB83BmXedgfI91jsfEzUKQZMA4Nd220RI4W05dGTJSeW97NKj3sr83RpNLDZt6 FZaqVO1P52SFbXK/d4OcJGcHQBlF3DWuPDyPeGvzCZO2O+D0n57Vp32uiQTbtRRQbFF7 M69nvOqOPA6o4RL9qkrfH2FhSidLbyMJ3ftmiWMFNUGYILLcD7XTLDGcdPG101hYHIKi GH8dBSIhGVIaYw6uqe8RitTsAtvly0f/QsXIfNizoA9f6VlPapPkR6Z8XRRRAlLEk6jr LTvQ== X-Forwarded-Encrypted: i=1; AJvYcCW649WEQ/VGlsP2nE7XwtQbW6W5UsMYKH1EdWDhxXK0A7juyY1O/CElqhjqGalAbmbBAwV1nO66KtaBe0s=@vger.kernel.org X-Gm-Message-State: AOJu0YxUGADMikcs0yij/SsiCK50vwklOUtM4yI9ep4D01n7UfD03Mdb p9dkJKFHInScbK+mpFDZCGd3EdUwmA+tbRiwHxmhBn4TbSPkayPiqcmp X-Gm-Gg: ATEYQzx6wWhs6X7Ie4nw298F+3AHOjny4sE68Wf8qyLUaPeWbTVHN9eciYrtzu2jvfR aUMBwAlFYtTJxtQXhUj/QTJC/XVerAZTcVz4jyHDB6mLrtGkzeANxPu2gdiFL1r+xbLzjicwjTw qlcnk5y93RFRzXgero3EojZUVXU/VaxkaiCl93dfyW3MvLKd1PQF3aH4NBwoYae2x+kwNlbPyDG cJ8Bz/lWGdjXTWBYuJOPmgOUMWBGPqfZMW0Bvt11m9UyKBI3Fz1kgzG7upoEuTuWCaFerKtsjHq Xzrpju47pPkSMgXrFu6lTpJTyYqh1Nxlq0OambkjhT5YmGx+fxUyu5SGoiQRZye8ZBO2qT9w4bL toif5mG4PubPvnJYItcT2K5nOXKLYusJBau2CRVoR/JeMJA3nHc2XpI4PzI4St91jZiDZmeCPuT OAi6/OFBwNA3BVL8xH6C/p3mYd61hZ23oG/NhltOo7wLX/SIZuWPwlF/XDvl6ZQJ+r+9vn2S4zg CtM+1QPX5AytytX9H8r557s X-Received: by 2002:a05:690c:dd3:b0:794:22cf:6d27 with SMTP id 00721157ae682-7988546925fmr46505057b3.10.1772244357932; Fri, 27 Feb 2026 18:05:57 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876c8e568sm27564827b3.48.2026.02.27.18.05.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 18:05:57 -0800 (PST) From: Ethan Tidmore To: Andy Shevchenko , Patrick Rudolph , Linus Walleij Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] pinctrl: cy8c95x0: Use proper error code Date: Fri, 27 Feb 2026 20:05:38 -0600 Message-ID: <20260228020538.1103307-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function cy8c95x0_irq_pending() returns type bool not an error code. Use error code -EIO if cy8c95x0_irq_pending() fails. Detected by Smatch: drivers/pinctrl/pinctrl-cy8c95x0.c:1303 cy8c95x0_irq_setup() warn: passing positive error code '1' to 'dev_err_probe' Fixes: 014884732095b ("pinctrl: cy8c95x0: Unify messages with help of dev_e= rr_probe()") Signed-off-by: Ethan Tidmore --- drivers/pinctrl/pinctrl-cy8c95x0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-c= y8c95x0.c index 0d295ebc33d1..5796ce516788 100644 --- a/drivers/pinctrl/pinctrl-cy8c95x0.c +++ b/drivers/pinctrl/pinctrl-cy8c95x0.c @@ -1300,7 +1300,7 @@ static int cy8c95x0_irq_setup(struct cy8c95x0_pinctrl= *chip, int irq) /* Read IRQ status register to clear all pending interrupts */ ret =3D cy8c95x0_irq_pending(chip, pending_irqs); if (ret) - return dev_err_probe(dev, ret, "failed to clear irq status register\n"); + return dev_err_probe(dev, -EIO, "failed to clear irq status register\n"); =20 /* Mask all interrupts */ bitmap_fill(chip->irq_mask, MAX_LINE); --=20 2.53.0