From nobody Wed Apr 1 22:01:40 2026 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011029.outbound.protection.outlook.com [40.107.130.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A791E32D0DE; Sat, 28 Feb 2026 06:16:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772259410; cv=fail; b=FSHCXVidikuynYNRQg+kjfG5UKMBdrwNKoRw+44jSLeU6TPDS2bWVrwYmCPMAhAFw0jtXPvYFL4PMINztksIZaz10r4svtCwOTjj6y4o2coG14xrQUKFP42bhcZhR6Tx6DCuUQdmNcl0lGPv4oJCmgl9PHtw2oHixI9fPRixcBs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772259410; c=relaxed/simple; bh=U9V4p3O15qLERtuol4xbCMuW3rDCwD8rpz6Jy6qSn7Y=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=cteVkYS25sb16exTMcUpGMNe2TltQI6mhOTjeoJ5d7zHYqlZaIPZCC6l70ldKw9nVXKXZhOjQbI/doCuCITfRrhmEMXGC00LCsIECs1up8XHL62CeVPVrOpHc3kH6Hx2SL+nIQinvVXQS8uU2LD8EgklRqnudJAxZJDNI9JuORs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=C6LCVWTt; arc=fail smtp.client-ip=40.107.130.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="C6LCVWTt" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=R8iEN4Q+DiTGbdBm/XbiQDEEc68hKd7nBOD9M9FLeB80kwDtA6ArUWeE4YVzYi7s2GyLoFzVvVtXmvSxJHDekBY58StzZmK99gf6wc4XQZ++ZVkCHaAG0gG8X5var07XQukGig6GBBeBUT0ZaJ8Z0ngW9osuA1sL7AYWMj2JbqsewxDuu5lGrsNafRCZAZOvDAS+sEUgZ4EI4kk7PFhCAZ65x9z9j0GqJfMs7exqr6sdbrM3apoTDbJLeC3zYvlO+EDkYYoCqUv0T6eq65bgvjsFRuhswpU1JTu5q7UpuyqeTfnKA1gfGMC1cQd3vcLaMlhTDJlk5BmHY1wm1eZNlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=caNM3hdkZE/An3NztFcL0ghgQt/OaD1VdxgcinfnqO0=; b=qx6h33vr1atoFMthBYtg/QHdoL762IushMWO8m2GkIdIqnPQ995XEMdY8KLj+zRgPR8tCCbHskznOf+zlM23VCna7rrUQ0Ch6XI7wxRwu4C9fw4iastWt0pJncKsRbIGm4D29ye70FHIJPQBiswTIZQybVGRrpXJgB9ZPTbgH9EL7zFTwl5MMgF1wHq+cs7MKCoDOPe9KPPGJnKJIaU+bMEmd9TkNWsqIpB+1hbbhC6iTas0udP6/tKHSNSGiYqJEEQ/fzwkbJ0lXOpimRammBy6v/BDPnLSK/PQkJxZvHB4GWSsKEM3MEQTbIffPlW7PcgR5sNIWNDaclpQ9w5UWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=caNM3hdkZE/An3NztFcL0ghgQt/OaD1VdxgcinfnqO0=; b=C6LCVWTtm5eQUgWxJQEIOKY/7cNAlmyxBB08GcUl9p/v+j3VNqx/pq8gZCoZOl5rkvsrQJJO/OCYq/1aGHCzSNm4PRYlyttyYfuF6Qp/pGqD6/BGsSHLAwLPM3wJJe5xe2SQPehSSUEyhsn3IFxdCjACsb1VyOTnmttpDWh6Wv7c3NTbies74gfhwnJs57IcJRTOx/2OKy8WOu4ulHa30/ywDp13iVrLiQ+sgDuEqPbwNtefVduyq/g6Bi8yoxw4uecsIylTC58g8vTtZ6nUXsHgxejpJYKiKez95QMe3hHVwLVMIt7eZzaL/hQT/pB/Ymb7Wu4aC6WwfdvigzDSNg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) by VI1PR04MB9809.eurprd04.prod.outlook.com (2603:10a6:800:1dc::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.16; Sat, 28 Feb 2026 06:16:45 +0000 Received: from AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb]) by AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb%4]) with mapi id 15.20.9654.015; Sat, 28 Feb 2026 06:16:45 +0000 From: Guoniu Zhou Date: Sat, 28 Feb 2026 14:18:19 +0800 Subject: [PATCH v5 1/4] dt-bindings: media: ti,ds90ub953: Add new range for remote GPIO data Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260228-ds90ub953-v5-1-056cf07cc8f1@nxp.com> References: <20260228-ds90ub953-v5-0-056cf07cc8f1@nxp.com> In-Reply-To: <20260228-ds90ub953-v5-0-056cf07cc8f1@nxp.com> To: Tomi Valkeinen , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Vladimir Zapolskiy Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, Guoniu Zhou X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772259522; l=1841; i=guoniu.zhou@nxp.com; s=20250815; h=from:subject:message-id; bh=21a6bdBK7h3nUQCJihSk+ktGvnCQDfZ7n7hYzpkEEFU=; b=Vs7LLOKztEYYvzagol5PEj2NBgwlK3mCZBHatqSsHj9cvadPzRQDboCj38TU+LteAVXGoi/v2 gGagVL2aFBIDKsJpylgiiinL/+C6F7qP+5LL2golG357HiRb2mJdr6w X-Developer-Key: i=guoniu.zhou@nxp.com; a=ed25519; pk=MM+/XICg5S78/gs+f9wtGP6yIvkyjTdZwfaxXeu5rlo= X-ClientProxiedBy: SI2PR01CA0026.apcprd01.prod.exchangelabs.com (2603:1096:4:192::16) To AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB9080:EE_|VI1PR04MB9809:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ca04bf1-9a16-4bb7-ffa3-08de7690f2c5 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|7416014|1800799024|19092799006|366016|38350700014; X-Microsoft-Antispam-Message-Info: g0FxIlNKdjkprqJwHLRKz0+QFyAEgSqdjQaZGCP3PipAUyT8Z270LTGaEI8/tB0syXRhCjtGMQMWZeaqYnMaJlXLRXUlDIfYPoBTtqcLRnDnfKEBZpacDWfzfOpfqg6uyCV+VFt1lKCqClZCHeNPgzptKpxyWUJpyRKsWE+xxkEUb3HoOG94Fh64XSb3XIP4c19/4XTFdQxfIzYsXEmuBDf7M581N5OleauRte3nhWE9o9N3jhn+pLl82EnRmkrGwvy82nwJxEM/OWTJsnp7IOlxgkg4S8NbIazna9Ol/Lei3rI9FE/UzEL+J53/+/PXiy0uC3bXMPTrOHUJVXW/VB1AXu+4qfEzIlbZSo1iUsG26wM+Ch9EGUpULx/Lo3RXMrv6bb2rG9zXoqkB4xAIWy5dTWMCuixFrEvzXtwVb7tY3IEkTy6Yde2eIQQI5SFLoUQBrRIy6QZdzQFlBrrn2uI7BlMmVcWH063lcaERDNxWpvjb9yb58J8LFJ0PxJdrSQwpj41MI7u2BJXchMfcFJspiRCzh99J+b1FHn+AazlUdmDDMp4Y0g4RfRBkVK8astGtKxS5Lj2FtBH69Pj0l1KB0mwMUBYCeK7UEs2VCLX/dSaBX6GuLCVCpmubGBGw1clb8Bd3LOATrpIvhSCTRmWEVywhQatN5E9KyYEuNCgVu4DVFakbNvYwXBWbXtNaRy/q9RTkMhkf63uDyu7tlTAjd1NG5LPj2ZcycgWplPBJbo4l4UcctMC+EXxErpYqSqUdi2ebwWa/ov+Om1rd0FSE2jTlQtIWlOsjQ43v1p8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB9080.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(7416014)(1800799024)(19092799006)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDBtaFhZUU1qU1Jqelh0aHVneWNxcWN1QmxXaWRaNEFPWVJCdElhUHdYUFUy?= =?utf-8?B?YjE4L0F2WDc1ZGhkYlFRekpTb0p6RE0rbDYvS2ZiMDVZQWdLNlVGZXE4VlE2?= =?utf-8?B?djBOc3RqL2FibitSbWhxeWdOYmg3eTM0UHYzb3dONE9jWmRaQmpPTHNIKy9M?= =?utf-8?B?Mmp1WmVZUVJUUFRoOG5iNDJiMDNoQk1pUzZmR3NadkNIbW43Zlg1RVdSSWY1?= =?utf-8?B?STJsZGE0VmZpeUIwZkp5L3V6SGNLc0lyVTlFcWd6MkU0ZU9Fb0VReUF1U2RD?= =?utf-8?B?OXZST3gzYjJlQzJFQUZPTUtjWWN3c1RudVhqb1BNamRGOTQyVjNnOXBrRERX?= =?utf-8?B?OE8zQVZpVG9SYkluY3VDSE1pN1RIWGlLcFR5bDNlYnZreXZNcFJicjA3Mngy?= =?utf-8?B?aDhIeS9YRVY5M3h4UTdHVWlvQUJLVDAyRkF3ZVl5TFdxWDd3YmRIRGE5Zkpm?= =?utf-8?B?dVU4WFl5NFMxK1oyMzYyVDRZWDhtbjRhcXJ5SUp0RmJDVFF5M1F1ZW5MckpZ?= =?utf-8?B?RDhFeUVKN2pzQ0FFdkNzdVpKdXFlZlNlUmtsSTU0MUVCU2dkcE9nNVB0Vk1t?= =?utf-8?B?bVk2cnorZE9wZG5xS2FwK0E1LzRpWmxhaUFKaEtrZGsvU21FQWZJU2MvTzA0?= =?utf-8?B?SUxzcjBNc3BrRGYrMG1aVG00TndTWVJPczU5V3VaeFpKVWZUM2xXSnROeC81?= =?utf-8?B?UTZvdmtEV20zc0RHamsvbXpXR0NUTVFMTjZhcTZvaklINFFqQWpFMU85VWJE?= =?utf-8?B?bjBZUXpjWXVVZG5Za3hLbWFZanBCRGVpWTc5eXQ4TnZBRWt5SWF1N3lnblVS?= =?utf-8?B?ZEJPK3VRWml5OGY1bGFCL2srSjNhaEEwMlNqelJ1aEx0THNUcjB2cytoT0lX?= =?utf-8?B?MG9KZE5QRHRoTmhvYVZOOTBtQ3B6Wkw0Z0R0cHNxKzhRQ0hXQmxnSnp0QlI3?= =?utf-8?B?WFY4VE9zVEM0QXE3ejFOZ1paaGZESm5CSTFMWWhpWTk5blh1bUtIYlRmS3R6?= =?utf-8?B?cGo5TXp4dytRbitOTzlwbUhwN0s2YkZHRG43c2JEeGhPMzVUL09yQkdZOCt3?= =?utf-8?B?cjdmaUJFbGJIZ0kyTFM2bVRYWkVjVnA0anpwK0hnSllWQTRxK3NlKzhndHpK?= =?utf-8?B?cmdpaCsvNGRqdlNaSEhuUHNkY0o2dHRrN2JRanFpTzBZUG5ZakUrbTE3dHZJ?= =?utf-8?B?M2NSV3ZNdlp5cVlINWxyczFmNkptSFpMQ3VOTXJWQjRuUVJOaEJPOFczWkhH?= =?utf-8?B?MWd0ZzVJZXpoeVVsbjFnSGxhUlpjdUxxbExZL0VoKzVOc2tTcEJqMUFNTDhn?= =?utf-8?B?djVpbE5qeDdLN05ZTlpoLzFzaWlGdnVrTkFJMjNxRXVTcFVSYnZYaW1MZ3o0?= =?utf-8?B?M21naG5BY01pTXRTaXZLZVg0clVKYUlJaW9jSDQ5aDE1OFowcHpWdVZ4cmZU?= =?utf-8?B?c0ErSisxN1JxNTBFc2JHZ092a0N5VkJXUzNEazZrdzl5Szl3ZisySDlGbnAz?= =?utf-8?B?NENvYVRyUkh2cUN4YzhjN1M5TjRQSXkxRXJJNGFqSnBxaDRqN2xHK2FoVm4v?= =?utf-8?B?Y0xnWXBBZC9tRjYzUlV5dm1Ed0NmUG1YOVZsVEtaVHBZcEFOVzV3YlJuOG41?= =?utf-8?B?b1NtZVVnaTJYdjBXK0g5NFpEQS9lUUlyaXY2NHNyMjNzdmFnRzhSKzdPem9C?= =?utf-8?B?TEhaRVFnWUpJdDZzU09FbzRtZERhZHFNaDdKUURhK3k4RGxqQ21zSlRVbEdl?= =?utf-8?B?bldoVzdheEVabkRFTXJqNlFoWjRIS2JBSU00dVdHdXBOMDZMbGFGZ25odFM4?= =?utf-8?B?bnAvZ2I2anZianRNU25udko1YU5rNkF3ZStQVjM5Qzk2U3RpWk9UQUFaUGpm?= =?utf-8?B?Y2tVZldqVStiVkgxSDlUMVplZzZjN1QxNWIxaFVpWk9IK3ZtTDc2VHZONEMw?= =?utf-8?B?WE1LTXlpMlBFKzJUUFMyTzdHaG90eG9HSjE3MmRGU0lWL1lsOGlLZnFBbWVw?= =?utf-8?B?ZG9jRmx5V2x1WGJNTEF3Zlp5Ti9mU3pDYUVEQlRleVFra3NHdGFRcG9leXNM?= =?utf-8?B?dEVpT0JRZ1BSY3QxN0Jmdllpbk1PU3NzR2hDVFZFUENhQ3NEaHZHMlhkd0x2?= =?utf-8?B?YzE1cVlmaUdqaFRFMml2ZU5ZMjJIZzdjcnhKT3pGS2Q5bmdlaEJvOVJrM0FD?= =?utf-8?B?U2ExMlE0RlRJZ0hXaUMwSk83dXFsWVZ4eXZOSnpaUnlWd2FXZ1FvM1QvL2tt?= =?utf-8?B?L2IxR2dKWE5vUXlML1UwQU9va3pjUUNJbHp0cnBkWnZqSHFodmd3dnFidE5v?= =?utf-8?B?STJvRDV6dnh3cGJuODkwYndOa2Nlei9NSkZYWGM5Z3dSZVU0cjA3dz09?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ca04bf1-9a16-4bb7-ffa3-08de7690f2c5 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9080.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2026 06:16:45.5474 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D+nOMlpGUw4aneuUqN3vBKw7SFM3+ePyXnhunylx9Fr+VhagCfNVeSSwxByO3Vov+iumSQCbEsz2sWX7wiG4xg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9809 From: Guoniu Zhou The DS90UB953 supports four pins, GPIO0 through GPIO3. When enabled as an output, it can be programed to output local data or remote data coming from the remote compatible deserializer. Make a different GPIO range for remote ones. Signed-off-by: Guoniu Zhou Reviewed-by: Rob Herring (Arm) --- Changes in v5: - Improve the description for "#gpio-cells" as commented by Conor. Changes in v4: - Use folder block instead of literal block for #gpio-cell property descrip= tion. Changes in v3: - Make GPIO range from 0-3 to 0-7 to support GPIO data from remote compatible deserializer suggested by Rob instead of adding third cell for GPIO controller. Changes in v2: - Remove new property ti,gpio-data - Add third cell for GPIO controller to select GPIO output source. --- Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml = b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml index 2e129bf573b79e0ca8f25b4ec5fc6ea76c50abd7..143d546ecb482d2eb78a113b1a5= 7afcbff9cca01 100644 --- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml @@ -20,9 +20,13 @@ properties: =20 '#gpio-cells': const: 2 - description: + description: > First cell is the GPIO pin number, second cell is the flags. The GPI= O pin - number must be in range of [0, 3]. + number must be in range of [0, 3] when enabled as an input. + + If enabled as an output, the GPIO pin number must be in range of [0,= 7]. + [0, 3] are for local GPIO data and [4, 7] for GPIO data coming from + remote compatible deserializer. =20 gpio-controller: true =20 --=20 2.34.1 From nobody Wed Apr 1 22:01:40 2026 Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11013064.outbound.protection.outlook.com [52.101.83.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8F833321DE; Sat, 28 Feb 2026 06:16:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.83.64 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772259414; cv=fail; b=exvLIVxEyzDyRs0JQW368ovj80L0yXajb/AQvRfkmkWqhvd/pefUqGR4lhmcqzwWSnxvCsfxeZ80/oWqswCffpPiPiSnXIFSt0ADSsI0p2nGXnztK7W9toiwLPPBT3TJjOT+vuCfdGqKIWE0xSosqQEJhpAOvDM4FIiipWW+VHQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772259414; c=relaxed/simple; bh=1wuExgeASVTL+eCfTkPvna50NlxRchikkbKTZCj3mjo=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=ExU/caXrok14iO1FjkJvuz4+bnS7GO3Qdd5K1nds6iTpQq96FVWwhkQoupmFGKVs2tO468XEJ8XoxuRlEpmersy2i0GkhMxVl31PjZL2WWgCUIr7shu6It7DnZ3M50x0WmJsEJV/+hdt/jBWPxNP98bHFIsiqqlgUSz1O/cwFHs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=RXvlmLrQ; arc=fail smtp.client-ip=52.101.83.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="RXvlmLrQ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uUps8W8WC7/YdF5cm08oA5wA58nCyHDZBwL1MZdkyOd6T1DdCxEO59SbwUsvZKWwe236vyWOrTv9CZqiKBCWf/L+oBsaMvzbJAlYDQq013f0W6Nh13iB9dWzCkeoTLyongkYD1B1oStV4W2FlPqp1I9sBmWfbEfgE50LdIhD5SMx3IJeBykaD60ForQol646oLjPyjW5NCPFY2ApesHEwMdgzC+XMEzALXy7Pl+coWXy/DFffNYrQ2AaCBjFL2fBCIBfFjXZjiHTG6lnLtx3/q+ikfaQDGpap7JjKYoK60cVuKd01JBvvvX1hbi4Bqmfla4xg/9VnOZ+eVpHantwlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hIk76qODxn5DLV5chvk7lDsxZdlvYMvt3zSRXIHdjfU=; b=xEFzr43UEWd7WOoOMSGPCLJnbM+AXPA8wXOAg71GgqmoyT2zpAmVjQZXCXHtaT68thgi6oiNdd9pkWmaNzJXwSHtp9t4yqpNAH/xfceqZ/1ZwE3GFxv2ROsTiERhs3D4H2bSIxYe1waBibGggmSeXjV8FyV1roCxgfqIUpR6yCCGWoN13wjSgxR7UrLZNMqDo4Z5M3lmKDxhhj8Yn71I4mIRhVzW7nNb5khm02usQSE/fSuukm1OOW9fwKT7vyV8vgaXyNW5DN+CWh7KP6mUsxsBgP+33yoPLfGrekTjqid6mzNzMWxwJxpoOyeGQGYh0dKnG4PTsWn/KvMYXX6tYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hIk76qODxn5DLV5chvk7lDsxZdlvYMvt3zSRXIHdjfU=; b=RXvlmLrQykJ2M9osvXxJ/CSecoBCHC9porX8ChwcUEibsUex39/+akYwbM51IQc05lcDHh9ln9jMK7Eljb3uSjs1b/+CIgpLpLhvWhSjGieIe+yFMBvMKaQMnrBDn1sSYe9Wd7a90edAZkCS41VQdEsfJCprSXVyzvo40q3J1VKlbsP9b9LnGvHErxBzQQlN494Y07QGFjkL7zb6RhGCJJW/Uazb5Ks/De4CZy2Ak7PNdg81wuSC0Z4bVNB0KlGBzEQQAvMFnGDrXyItuTejIJuqD8JHTA/5rEUvAUuNcw7/eFKx9o23suX0UlNBjHQoKDtRBXhbnJmU/lzwh77auA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) by VI1PR04MB9809.eurprd04.prod.outlook.com (2603:10a6:800:1dc::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.16; Sat, 28 Feb 2026 06:16:49 +0000 Received: from AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb]) by AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb%4]) with mapi id 15.20.9654.015; Sat, 28 Feb 2026 06:16:49 +0000 From: Guoniu Zhou Date: Sat, 28 Feb 2026 14:18:20 +0800 Subject: [PATCH v5 2/4] media: i2c: ds90ub953: Add back channel GPIO support Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260228-ds90ub953-v5-2-056cf07cc8f1@nxp.com> References: <20260228-ds90ub953-v5-0-056cf07cc8f1@nxp.com> In-Reply-To: <20260228-ds90ub953-v5-0-056cf07cc8f1@nxp.com> To: Tomi Valkeinen , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Vladimir Zapolskiy Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, Guoniu Zhou X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772259522; l=4819; i=guoniu.zhou@nxp.com; s=20250815; h=from:subject:message-id; bh=5vNm/7YzwZfGUU0D4E8ViozkZCXptMzh+HgyUIdjD6M=; b=xDKGLU+0c06HUm7u0w2yJv/MUfoYKygh8wR4qEXZzSS6yfOXpnMUqIU+Y0Hs75YkoX7gWFo5n OaxUeFnPP0jBZhgvpvRTo7fV03gWZwoPA9GHpT75VVo2hqEP6MUfl+p X-Developer-Key: i=guoniu.zhou@nxp.com; a=ed25519; pk=MM+/XICg5S78/gs+f9wtGP6yIvkyjTdZwfaxXeu5rlo= X-ClientProxiedBy: SI2PR01CA0026.apcprd01.prod.exchangelabs.com (2603:1096:4:192::16) To AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB9080:EE_|VI1PR04MB9809:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e7a42cd-3b58-412c-9067-08de7690f513 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|7416014|1800799024|19092799006|366016|38350700014; X-Microsoft-Antispam-Message-Info: efgtHXaGkHTox5ljjb4HcDMGwjLPS+0Zvu+J2iADGWMjH4S8IBW+c44wgLw/ZtoMMGyxISrKuUd3bnKnRuA/PIGmUmvQLimAeZq24nPuut2q+d8fv1JZuGjNnGy++ripvH+qxepJFjyjA11PlaSlWUF49Pl7d2UcsZB0sQxwMu4PpIeqB9Aih72ho6ZpqGuEYmmYmL+xh59OMyZBJK0RDgPdNc1WbN6JLhDhrN14up4DQfMk29PzJguAiajslr4hj6jHtxKixPVJhR9hNoURXwOU3lnoLgPh8lfhyM6I0ZJdYgC1SJWMjSZI2wccwcW6nwqzuEaIOY1DWtIkPHamJ7WQhNTE0hm+nD6xqmdUNo3wTmpOuAXtAfgw1/XoT9CTK6lEvTb/Qc6pzoSyPCEvd/MwioUHNWjHXsKIgeLzVFU+FW+rSkfUm9XkA5oddj5ujnP0HFw96399i9AckLnkg5t6OaGkIouxb4pYX6zelR2No64DXhtwpnus0+buGyB9c3UsG6s8RoyC+AU2ePTDFBAI70d0UcJEjgOMpbTd328KZRFMZlsPHdoQTiuiPOdsWrsjIRSTfxEIMfEr7AUVYRU96EjC37aG9RsD200cP5GIYbVnlhYd6tXO221/Ziemh4lmVFFyebEWxGR5a3NVAI9DkmtS4cOde7HlHTbC4Eqkf7VCEFjqRCnirDDpbm+kvYApXZ2Oytf9PPrl3UnoXj0iu5rZEgGeuLCuulvUgRrqLkgK6K95P5O6qJXxxpTpoBCoPxPKdEPmwEf82bRxIteu+IriRcvnttR5m+2PJuk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB9080.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(7416014)(1800799024)(19092799006)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0xRRTBPKzhPanZjQkozSnZlMVlUTEI4M2xoeDJWUEhrUk9MK0MvcWhwSk5l?= =?utf-8?B?UE92Y1ppdUVQM2dRQ3lZcVZYM1NKa2huNFk1UnJBZjJMS3JYTFN2ZVFkNitR?= =?utf-8?B?OENTTFBsWWg5eGZiZi93MTkwdkZYSnJ5VUhPT3V6L3AydThoZXJFTldWVXdl?= =?utf-8?B?SVN0eXQ0dWJPVEkyaC80cXMwdXZ6UVBVLy9rU29rUEdrUGF2NTdJcFQ5dmNP?= =?utf-8?B?VlZpYTd3WXZFbDNCbUV3Ymx2Tmd3OUhlRy9kZ0lYZ0d2R3p3NW05UnVlWVZC?= =?utf-8?B?dDFNN3N0cldMYnFOTTVkRHRhb24wN3VHNEFGKzVMUHVyQnNTZVEvV3Jyc2lQ?= =?utf-8?B?emN3dWdBL2J5M1gxYTlCRUdOdDA5anV3N2NlRzF4ZkExblhENEZqeW5Sc2Ny?= =?utf-8?B?OUxnaUgvdGUzLytGTy9BVlk0V2x0MnpWZkpIYzk2NXViZVdFOXdhZUs0a29o?= =?utf-8?B?VE9KNVYxS2ZpNWZqTWJhcktrS1NSV3V6eWZKWmN1OHoySjgrS1RSeVRVSEQr?= =?utf-8?B?TlpUSWF5RGRCNXdKQW1LTFZpdDdnb3Jka1dsMktWUGxwMnRlZnd3YkM4emgr?= =?utf-8?B?ZGVMN3Z6K2hRSTBRRUYyUS9scUQ2TVRuYVJRTUllYXM5bFhFSEUyRGkxUDBx?= =?utf-8?B?VEN1cWtORjFLVTBFVzUxUTNpMEwrM2svbFNKQjhCT3RPUCtoaEUyZUlOMith?= =?utf-8?B?a1BRUDB6b01MdFlyUkl5RHhXQWhsRVZ5RHM1cWZkQ2xuaFFyL2xXVGR5d3NC?= =?utf-8?B?cUNBTnFDTmZ2Zmx4MjNHSW1lTUtFSlU3R0ZyajlPTnppNnNHTlZvamJOdlNJ?= =?utf-8?B?clVlWWQ2MTZCK3VuUW5QRTVPc3hERlpFSGVJZW5Oa2VIWTV5dG9hVnBPTU9Z?= =?utf-8?B?ZWsrUWk4TGNwUyt2WTh6ZzBDREpsblNHS2h6Wk90VzB0ekxrdWQrTW54cjE3?= =?utf-8?B?cURVOHg5bmNPWllvYlA2ckkxMUhkZVlLOEZ1OVhaYzJjcERsMnVvM2NEMGUy?= =?utf-8?B?UCtUN1N5TUpPb0pESFVmdEV3ck1iR3pyQzV0R2M1Mm9YRmZCNGdXbHZqbDZk?= =?utf-8?B?OW1zU2RqS3RQcVJEaXpmQjNKSEdWb3ZMWEY1WjVidCs0d0p5bDRFU3ZrNlAz?= =?utf-8?B?cC9wRk1QbkNHeVBOckpjcVp1YytCZXZZWWtLNUsxWHBwV0JGRFVuSTk4bUVM?= =?utf-8?B?TnNUaFVIUmxhM0lDL2tJUU9OanAwZkpIUUtzYWdPaTR0VHo0dEVPbFp4LzhO?= =?utf-8?B?a2FNMk03SFgzU25udFZHNC9yS2tLa3BDWUZDa0xaOXBoRndMZEEwQ2dUU1Fv?= =?utf-8?B?QzZtemM3R0JhRWJHNThUWFAyN0tPQnNTdkd0cGswWmxmdnZLdlhqeUlLQVJs?= =?utf-8?B?OStOZkhKbnRsaER4ZnNzeVJnV3ZZSkZRSmR4QjdsS1pVaEY4N3RTNGtJZG1W?= =?utf-8?B?MGhJN0YzRERPUVlVcGZ2U1JlZ3hSRVFRK014MU1VajE1RzB2c2U0WkhuenlK?= =?utf-8?B?SVBVT0d0QnJHa0FTRHJhbnZCaFFzanlxdWtlNkJzV3g5RXFGZ3hyYXFvcHp4?= =?utf-8?B?ajJiZzQ3QkhrOGExaWt2dDRLTnlVZmF2Wkd4ckpqUXppZFZHMGpMRXRnSjJs?= =?utf-8?B?S0JyVWdRaE1ma2xvVnNpYjZ3UkhQdm0zTjkvV2ZkdXVqa1RhdDErbWtZTVpB?= =?utf-8?B?VHFqRWtzaHRVTlAxcHlrVm9zc2JpT01yZnQ2UDBRYjZGZmhZRW9ZVTV5NThQ?= =?utf-8?B?ZmdjWnBVZWdOZkFFLzBTRmc5OFZ4Z1JXcGFBV0NyUzVSNWgxNk44c3RPNWRG?= =?utf-8?B?M1Y4dEdZS2VPQTZqU0JDUTVPM09WYWQwUlhDdHIrM0x1QkJjRVRUQWNsU1hZ?= =?utf-8?B?OGliL01MOE93dkNtT2RMdUNKSCtSTGhKQnFlRlNGL1U5OWdXdG11c3FTKzNE?= =?utf-8?B?TVNqbDFwdk5PVEJMMmN2V2tZVGcxbHVjVlBDajdvejBOMjFkTnB0YTFOSWJP?= =?utf-8?B?dGQrU2pCN09HWDYxcU9DNmV5TnpLdGovelhXT1UrVjhhb1p1b2pMOElVUUlw?= =?utf-8?B?aDBXc2FNakVFeFlpYkkrL1ZJNUVHOTlaRHpHTjB4bGNpRWd6Unk0V1UvT3VC?= =?utf-8?B?d1JyOGp2MVpveitRV21VekNQSk9TOWQ1MC81SEliQk1Cb0lLQjBqL05wallk?= =?utf-8?B?TzgzWHB5WDgvMWc0UHBhV2Jxa0tsdXNkWkdQWGZ6cTJRYTErSDZsa1ozNGJx?= =?utf-8?B?Sk51RUtDZmltcFBqMW95QzNmRXc5VzBPejdEc1I3cUVOclZGUDhyQjBJaWxV?= =?utf-8?B?YlVTQi9LbHJHcTd5MUJHNzdkQ0VXQ0NaUTArbTNldkJqTlUvKzdHQT09?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e7a42cd-3b58-412c-9067-08de7690f513 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9080.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2026 06:16:49.3731 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wHn798FyzKg5JYX901BwRYJ7BA8jgFkqT27fR9rIfpi+4OQcWGTddpda3bvo0nu6pqmJ0ypSC/IBgjbursn4uQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9809 From: Guoniu Zhou The ds90ub953 supports GPIO0 through GPIO3. When enabled as an output, each GPIO pin can be programed to output remote data coming from the compatible deserializer using the register LOCAL_GPIO_DATA[7:4] field. Make GPIO range from 0-3 to 0-7 to support this case. 0-3 for local GPIO and 4-7 for remote GPIO data. Signed-off-by: Guoniu Zhou --- Changes in v4: - Only log GPIO 0-3 stats since remote GPIO 4-7 reuse GPIO 0-3 pins. Changes in v3: - Update driver to expand GPIO range. Changes in v2: - Parse gpio third cell to select which GPIO pin the data from remote compatible deserializer. --- drivers/media/i2c/ds90ub953.c | 42 ++++++++++++++++++++++++++++++++++-----= --- 1 file changed, 34 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c index daefdb108fbf402453baeaccc61d1f3530521d74..14dd0aa4cc6ceba66a8c3545c7d= 7d19694007431 100644 --- a/drivers/media/i2c/ds90ub953.c +++ b/drivers/media/i2c/ds90ub953.c @@ -32,7 +32,9 @@ #define UB953_PAD_SINK 0 #define UB953_PAD_SOURCE 1 =20 -#define UB953_NUM_GPIOS 4 +#define UB953_NUM_LOCAL_GPIOS 4 +#define UB953_NUM_REMOTE_GPIOS 4 +#define UB953_NUM_GPIOS (UB953_NUM_LOCAL_GPIOS + UB953_NUM_REMOTE_GPIOS) =20 #define UB953_DEFAULT_CLKOUT_RATE 25000000UL =20 @@ -268,7 +270,7 @@ static int ub953_gpio_get_direction(struct gpio_chip *g= c, unsigned int offset) if (ret) return ret; =20 - if (v & UB953_REG_GPIO_INPUT_CTRL_INPUT_EN(offset)) + if (v & UB953_REG_GPIO_INPUT_CTRL_INPUT_EN((offset % UB953_NUM_LOCAL_GPIO= S))) return GPIO_LINE_DIRECTION_IN; else return GPIO_LINE_DIRECTION_OUT; @@ -277,6 +279,12 @@ static int ub953_gpio_get_direction(struct gpio_chip *= gc, unsigned int offset) static int ub953_gpio_direction_in(struct gpio_chip *gc, unsigned int offs= et) { struct ub953_data *priv =3D gpiochip_get_data(gc); + struct device *dev =3D &priv->client->dev; + + if (offset > UB953_NUM_LOCAL_GPIOS) { + dev_err(dev, "GPIO%u can't be programed as input\n", offset); + return -EINVAL; + } =20 return regmap_update_bits(priv->regmap, UB953_REG_GPIO_INPUT_CTRL, UB953_REG_GPIO_INPUT_CTRL_INPUT_EN(offset) | @@ -288,10 +296,14 @@ static int ub953_gpio_direction_out(struct gpio_chip = *gc, unsigned int offset, int value) { struct ub953_data *priv =3D gpiochip_get_data(gc); + unsigned int pin; int ret; =20 + pin =3D offset % UB953_NUM_LOCAL_GPIOS; + ret =3D regmap_update_bits(priv->regmap, UB953_REG_LOCAL_GPIO_DATA, - UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset), + UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(pin) | + UB953_REG_LOCAL_GPIO_DATA_GPIO_RMTEN(pin), value ? UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset) : 0); =20 @@ -299,9 +311,9 @@ static int ub953_gpio_direction_out(struct gpio_chip *g= c, unsigned int offset, return ret; =20 return regmap_update_bits(priv->regmap, UB953_REG_GPIO_INPUT_CTRL, - UB953_REG_GPIO_INPUT_CTRL_INPUT_EN(offset) | - UB953_REG_GPIO_INPUT_CTRL_OUT_EN(offset), - UB953_REG_GPIO_INPUT_CTRL_OUT_EN(offset)); + UB953_REG_GPIO_INPUT_CTRL_INPUT_EN(pin) | + UB953_REG_GPIO_INPUT_CTRL_OUT_EN(pin), + UB953_REG_GPIO_INPUT_CTRL_OUT_EN(pin)); } =20 static int ub953_gpio_get(struct gpio_chip *gc, unsigned int offset) @@ -314,12 +326,19 @@ static int ub953_gpio_get(struct gpio_chip *gc, unsig= ned int offset) if (ret) return ret; =20 - return !!(v & UB953_REG_GPIO_PIN_STS_GPIO_STS(offset)); + return !!(v & UB953_REG_GPIO_PIN_STS_GPIO_STS((offset % UB953_NUM_LOCAL_G= PIOS))); } =20 static int ub953_gpio_set(struct gpio_chip *gc, unsigned int offset, int v= alue) { struct ub953_data *priv =3D gpiochip_get_data(gc); + struct device *dev =3D &priv->client->dev; + + if (offset > UB953_NUM_LOCAL_GPIOS) { + dev_err(dev, "GPIO%u be programed to output remote data\n", + offset % UB953_NUM_LOCAL_GPIOS); + return -EINVAL; + } =20 return regmap_update_bits(priv->regmap, UB953_REG_LOCAL_GPIO_DATA, UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset), @@ -330,6 +349,9 @@ static int ub953_gpio_of_xlate(struct gpio_chip *gc, const struct of_phandle_args *gpiospec, u32 *flags) { + if (gpiospec->args[0] >=3D UB953_NUM_GPIOS) + return -EINVAL; + if (flags) *flags =3D gpiospec->args[1]; =20 @@ -632,7 +654,11 @@ static int ub953_log_status(struct v4l2_subdev *sd) if (ret) return ret; =20 - for (i =3D 0; i < UB953_NUM_GPIOS; i++) { + /* + * Only log GPIO 0-3 state since remote GPIO 4-7 pins reuse local + * GPIO 0-3 when enabled as an output. + */ + for (i =3D 0; i < UB953_NUM_LOCAL_GPIOS; i++) { dev_info(dev, "GPIO%u: remote: %u is_input: %u is_output: %u val: %u sts: %u\n", i, --=20 2.34.1 From nobody Wed Apr 1 22:01:40 2026 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012034.outbound.protection.outlook.com [52.101.66.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7E8F33F384; Sat, 28 Feb 2026 06:16:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.34 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772259418; cv=fail; b=mJetLAqXYvNa0Jv8AOyDlx1m22cUAIEkRLZrLaTeHxf1mhSo79lHY4KyXMdZUAViK5kFw0kb1voSTOjRVQ8JxrnlD2ZQsu+DStJT8XhCa9O9NOOKv/AQmfy51k3uocMDnhKEIX5Rm28/xamR+i2uXrR4ebvY5Z9eFU5VFYJtgg8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772259418; c=relaxed/simple; bh=7bglsEHhwjB8wbLTx2D3+qQOsFmYnvNW/m8z5Rjd/DA=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=rVvU0cxIxEC3FYol4WVlPUvBPqTmEAbAGOfaE1Bxyd5G2Es/Vg3k18tSk44uUpyRShXzZLj/ys8AAy9Mi3BrCPVsUKYApmbgl2xu/mrY/Cox6YyCohdw0JQstFIPF6TlJFu/PkA4hyhF7+YJAg6MNVDVdPPizxBFZFiGvyORF6I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=DrBk8DfI; arc=fail smtp.client-ip=52.101.66.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="DrBk8DfI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Gs8tGmszhzPG8d4MUooY6wH1PRf/j3PFUJ34hw5ZdNE1pRxl6QM+xHtc7ruCgbGL+F1D+IXEUyAE3ZuR3ZP29MunLIk8MuzuoA4xGhntvmr5isDnlX2nveFpd/m6GxmrwFwBaAGcAluMmInZQYCcqk4JeD3HKkKGZc81muNzv1P8MCJQezRfMgqqSKy0HIOJpjy+qDDNkkCqMAJoYiWGCgv+m1S+Yhf1qnOcnAAIfVHpEiGWa7scL+4XmotAEpKQxm5lvGg8tJBfF/bV9+x2vcG30wL6UKVjbUuGDXHIXVCR1onQ2O++OTLK3UlK26vNQo/NhFFUN3I/vZ0Pb4Lr/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WuvOezn5XQXVlaN0HZPzdbKPmh1F2t94Pv5numfDikA=; b=PPvwyXHSUkBdUOLG4EwiRqUSrrlNPiim++UAbkJKRNGmzVg8QLZN/aXujGIJ8izHmyJNNR9MLD/DXVrUhg06N+acF5otKbj1LsAz6hmzbC2CsYyj1FMgevtfBV13wWRG3GKGR+yVszAmDVGuKc6WCqVw0bDCZX7PB/nJeMO6B8/qjxNHQD1vtw2+fyVXa5+NAMeuPFfhLCKzuzmAsHePZEBqqU7ugthgJy3DxtP7kow1PW56FuESvKixTVzxQILiVULLBMKXD7J9TsbQ8FEF2LECFvc2QjBAmwOa9VxHJcX+QbtDH+3Ask3lAWfGtJzrs17nSJltF+NJFrJ/0wc36w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WuvOezn5XQXVlaN0HZPzdbKPmh1F2t94Pv5numfDikA=; b=DrBk8DfIexfuwHTSpTUjtxTAShFHVPRdXPhfAO+dtLfVqk2PZQay85M+bweEZH/9oAmHqORHX5EtgTb0Kt/NVI6fLINq6Zfo8edFjT9dZ3mldLNG84eQJmLkF+BbtMFBX54io9QTsGosoJ7uIpHjWPJN2AWxrB8SKyfQp7xuZlYF9qhrx+3DK4XEGClHLz28+8Db5oV6kWbFGDCw/OXKLEHX0Me9pBRCbrQMsiJB3XIdNCM6x/YCLuCOmRB8z8kwIjPzg0ONTTGVi0bIRqLSnOUY//ve7BCwQN9BjdPsnkXitditSxFRXOS7j17qLiPX6ob31Y64kgaoUCVwRHOzvQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) by VI1PR04MB9809.eurprd04.prod.outlook.com (2603:10a6:800:1dc::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.16; Sat, 28 Feb 2026 06:16:53 +0000 Received: from AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb]) by AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb%4]) with mapi id 15.20.9654.015; Sat, 28 Feb 2026 06:16:53 +0000 From: Guoniu Zhou Date: Sat, 28 Feb 2026 14:18:21 +0800 Subject: [PATCH v5 3/4] media: i2c: ds90ub953: use devm_mutex_init() to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260228-ds90ub953-v5-3-056cf07cc8f1@nxp.com> References: <20260228-ds90ub953-v5-0-056cf07cc8f1@nxp.com> In-Reply-To: <20260228-ds90ub953-v5-0-056cf07cc8f1@nxp.com> To: Tomi Valkeinen , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Vladimir Zapolskiy Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, Guoniu Zhou X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772259522; l=2687; i=guoniu.zhou@nxp.com; s=20250815; h=from:subject:message-id; bh=ZtASOTXPV96hESXIhSLHGU9VKdpJ9jjyRpoEenlG2nY=; b=eAbj0FUlx4VB/9m3xrDF5t1t88y/ADthJprMXyp4Wn0VpBkR77lI18vu8KDXEcrkM7oMtE4CD FBOPaMWeUvVCZ4rSG80JB9SuMbWMZ0/pmlOeUdNfbWRqvXIqXw+2FjW X-Developer-Key: i=guoniu.zhou@nxp.com; a=ed25519; pk=MM+/XICg5S78/gs+f9wtGP6yIvkyjTdZwfaxXeu5rlo= X-ClientProxiedBy: SI2PR01CA0026.apcprd01.prod.exchangelabs.com (2603:1096:4:192::16) To AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB9080:EE_|VI1PR04MB9809:EE_ X-MS-Office365-Filtering-Correlation-Id: b1b0593f-2282-495c-0257-08de7690f759 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|7416014|1800799024|19092799006|366016|38350700014; X-Microsoft-Antispam-Message-Info: zCufhM827g+d5XxTdD1MYOMZToA51DqJU6LHWKj0MrrsNm/4/zy3ImePmkZYPyHOdu2nxdsk9r9NZEdj1GxHnWpPQk8w3rgfk7i0qr1aZJQASnE5k72Y0Db1A+mmFL+aZB1wB6BDC7sarCBTWODqR6mh17GTi6I6ZcEH5ZhdHBeMGMOcSESlnbDrWQ+zcU/VTEKA3hvuRxa0fxTTvjal6xgJicVq9eMfxP3m0KuKlAXl6LfGCY9xFtpk/r6zi/IPrwJrpOwQEaoobMk3jzqOz0rdU0XpFgaaDkDCz1ZbUOkDVxt2yZe3dFcT2jlAMSUB6wVxeuGHCaxO+uUCUvd69mcFP5gk4OY1fJbAUPsn7UhMaL2KPF1grj9U9uDLsnapHYYmXc/lPW2ftMsG9nxR/bcaAVxg0Ty4pP4zsgpJ79+zVw1twI3YjGI15hDjMwUYRPc3iokNmPHwUvqKOnlgmMUabH+NizJoB7gyiUc9lZ80qIqhVvzl/pC76A1Oo7QEKJoaeLnBknvZURw8ct1TkezAPpY1AmrrWkUH8pktMGdPq31WLfp5HIZtspyDmtC9GboUgL0bDLWFEUb2q3eNmUJS/yjxqBttu2WzM1zfMem2Jtz/5CcSLFG8S4m8OJi6urpbiOQbcH4G4SiNL7ZYprgFvxX6OjegqflN5vIH8KAfGk3YyqOxqy2EWVwIitvu7VIlAOO/PEyormForlQT5K1Ebr71E02WXopKqmCMT/dsCaSPZXOwxL0dzjJ98choFar8j9JFYyh3dqPaAWPr2J0/SkqCIITUD3J4ejrm1ts= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB9080.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(7416014)(1800799024)(19092799006)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bTBYeW56cjdWSWNtM3k5ODMyKzNqcEFCejlUM2g5WndzUDNqZDc4Q1JFam53?= =?utf-8?B?MzlsVFJvNFN5cmlsSlV0OXowZ3lNSjl6d3ZrSERMWW50dUlabU81b3BySW1T?= =?utf-8?B?MDZNeHZiNEk1SFRqaEJGUmFqSjBtQ2N6TTZwWS83NVBwZTlLcE5oZHgxNWV5?= =?utf-8?B?VWtmd0cxaXQvNVVWZThqRGZ2Nnd4ZEMwamUxZEhSNm9mV1BCOC9IY3RaWTFm?= =?utf-8?B?eHJROHUxN1lDWGFVbVVqaDFrVi9kYXVMY3ptNlRxNHUzQlV0bEp3eTRERE55?= =?utf-8?B?RXlNalZZMmhPRFZiU2JFTllIMHBMN2hiaVdJR0NnZHZhT0pDRVJnR3BuRmFS?= =?utf-8?B?UXlGSzRvZE00SVk0aWdIMlFCcW14TThiU1dvN3dINVVaOGFYUU9LSjI3RGFU?= =?utf-8?B?em40bTljQ3NnMkpZQnFYR0lCWElyY0pKUHZScmszZVVsdjBkeDhwWTNyUVZq?= =?utf-8?B?ejNHRWZnckxZaTdJNjR3RUdIWmhiMWZSREZzVTBKblRJcktqOEIvZWg5SnJi?= =?utf-8?B?bXZTTVQ5RDczY1FJQ3pmT2d6VWdPUFR1VHdSN3JUTTJ1VEM5OCtadFdRam9C?= =?utf-8?B?d1VUMFVHRGFWVGtaUkgxYUpWU04yZlVRRlVTbTFTMmhBK0FVa29yTC9NV3ZY?= =?utf-8?B?bEZRRENzU2p1VjhRWVUvRjRjMTdMdW12UkVzZktpTlgyZnorQzcxRHhPZmJZ?= =?utf-8?B?d2tjVHFJc3JpaHRKVVArRTFncnlXdFI5WHl1VDdOVWRzOE16SHkrTDd3dHJP?= =?utf-8?B?YkEwZDQxc3BFM0ZmalkwZk5iZ3BadUtBM214eVptazZRVkNSNUhyUW9tSklw?= =?utf-8?B?VGtnK3dWVDd3MkRSYnVjeG9VMVUySlRqclMyZUFHT3JhaEROaUdGZkgrU2d5?= =?utf-8?B?Sk5QTXA0ZWlGNWJkTVpLR1ZaN0ZvdlU0UFc3dEtUNWovRTlmTDZJSEladFlI?= =?utf-8?B?RERHMTZZeitXV1JETlBWOThlV1pTcXVULzQ4ampkYkU4MlJtbzFVYjRmNHZk?= =?utf-8?B?NHdSQ3Z3d0dsU2pmNC85bFhRQk5OdmordTRxRUpUMG45MVhGamFQMmpwU3pX?= =?utf-8?B?SHBMa3czNlV3SzNidDJRTEpkSWRHSUlLL2pXNHp4UXdYNkM3bnNKU2x5UXpI?= =?utf-8?B?a1lwQnlPcVJjNWtac1ErYUwzMkl3WlBscCt5MUlBcUFyRjA3aWNCbHNlRXp4?= =?utf-8?B?MW8rdDZ6VTRNN1dBR1B3QnJYaGk1aW5vQkhYbEttczJNa0JiTVlWQXY3MUZT?= =?utf-8?B?ZktvdjI5bG5LM3NneE9oYTJNV0hUN1FySnRJellqcWUvWWVZSHRSUjdXczU5?= =?utf-8?B?dmc2alAzdGFCMFJ3NFR0Qi9uKzBTK2IvT2ZPNFhQZXhOZnVNTmFNZGNLV0tC?= =?utf-8?B?bEo4TGQwWjlva3ZacTgzSlRLakIzYyswVVFXNWV1VlI3blVWT3ZYYnY3UjR4?= =?utf-8?B?a2NJVUFOZ0lJaGd6OWRacmRBMHNvL2dreVNNQzZMV3FweGlYT0FNNkxYRVph?= =?utf-8?B?STNleXViQUw1Q0J0RkFQck11OFBMU1lUYWI4K3NvdkdrRG82WkxnbDlEaWx6?= =?utf-8?B?eXVuQTJOc2V4dVJkaGRERUN1YVBKbHM3RmxhZ3J1NVZ1REhEQXA2b2s3cC9H?= =?utf-8?B?MzZzRkhtN0R4cEMreHhReDFsZzR0VWh0YjJPQ052REN6VXhJZ2NWSTdiQU9B?= =?utf-8?B?ZGUxeS8zY0ZFUi9EOE9Sc3J3N1lBY0YzTURNOFYyd0lxdGIxNGd0L1NZTVJ2?= =?utf-8?B?eFVraCtnUmxtbVIzTStMMjUzZlduVTVwQURpTGxpK0tkdUxRakZGdk9hRDRS?= =?utf-8?B?VUxCZzlkVHZEbHNqRkEyOHFORGR2cnE0aS8wcTJpa29QNXk3ZURWV3hZT3NM?= =?utf-8?B?d2V3MDh4aC8rQUM5cFFYLzJubmVCTXNWQ2tvUGpubWpPNzBYeXl1YmFGTnB2?= =?utf-8?B?a25UbWVoTU92U2xMVU52YkpaY29ra29XVVFJZ0ZxR0c0dTZTNm9ZdzlOWk8r?= =?utf-8?B?SXRiMlhCU0pwbWtKN2Y2VjRqb1BKOEVnUHVaUWYyb1U1Q1MyQTM0aVN2QTBK?= =?utf-8?B?dFdMeFA2cUFKTlBZOUNGNktIcUMxQTgydDVncVdXOThOaGc2V2hKa0dROFlS?= =?utf-8?B?ZnBrd0VrenlQbHc5SWl3YzljMzdOa2tvazJKZzZSZTZ5VS84eUF2ZXF4eFpi?= =?utf-8?B?ZWxGY2Y3M2lFVEJEcTdsYkp0VndNalZIcXVsQ1BseE1TMko2TFdZa1lGY2dh?= =?utf-8?B?UWxTUXIvbXVyZ2dSKzBPZjZtb0MxVVdrMVc1SE0rUlFpWWpEVTk3MWQ5Y1Bx?= =?utf-8?B?bVVGeUQ3cnV4LzYzVCtoMTlZYmF6U2l0dHZBT016ZDZDY1BsNEs3Zz09?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1b0593f-2282-495c-0257-08de7690f759 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9080.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2026 06:16:53.1778 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HariNr+TrhrO0FdIqHs7syoWZ2m2trpyZ8U/S6lFU/gSbfdQ5t8y3A3Eb2TdreKgXPHMCYcmNw0uyuh3DkQ6bg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9809 From: Guoniu Zhou Use devm_mutex_init() to simplify the code. No functional change. Reviewed-by: Frank Li Signed-off-by: Guoniu Zhou Reviewed-by: Tomi Valkeinen --- Changes in v2: - Move PTR_ERR() in dev_err_probe(); --- drivers/media/i2c/ds90ub953.c | 33 +++++++++++++-------------------- 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c index 14dd0aa4cc6ceba66a8c3545c7d7d19694007431..a85c6a9b64070491db161ca1586= 179dba9c69cb0 100644 --- a/drivers/media/i2c/ds90ub953.c +++ b/drivers/media/i2c/ds90ub953.c @@ -1345,7 +1345,9 @@ static int ub953_probe(struct i2c_client *client) if (!priv->plat_data) return dev_err_probe(dev, -ENODEV, "Platform data missing\n"); =20 - mutex_init(&priv->reg_lock); + ret =3D devm_mutex_init(dev, &priv->reg_lock); + if (ret) + return ret; =20 /* * Initialize to invalid values so that the first reg writes will @@ -1354,32 +1356,26 @@ static int ub953_probe(struct i2c_client *client) priv->current_indirect_target =3D 0xff; =20 priv->regmap =3D devm_regmap_init_i2c(client, &ub953_regmap_config); - if (IS_ERR(priv->regmap)) { - ret =3D PTR_ERR(priv->regmap); - dev_err_probe(dev, ret, "Failed to init regmap\n"); - goto err_mutex_destroy; - } + if (IS_ERR(priv->regmap)) + return dev_err_probe(dev, PTR_ERR(priv->regmap), + "Failed to init regmap\n"); =20 priv->clkin =3D devm_clk_get_optional(dev, "clkin"); - if (IS_ERR(priv->clkin)) { - ret =3D PTR_ERR(priv->clkin); - dev_err_probe(dev, ret, "failed to parse 'clkin'\n"); - goto err_mutex_destroy; - } + if (IS_ERR(priv->clkin)) + return dev_err_probe(dev, PTR_ERR(priv->clkin), + "Failed to parse 'clkin'\n"); =20 ret =3D ub953_parse_dt(priv); if (ret) - goto err_mutex_destroy; + return ret; =20 ret =3D ub953_hw_init(priv); if (ret) - goto err_mutex_destroy; + return ret; =20 ret =3D ub953_gpiochip_probe(priv); - if (ret) { - dev_err_probe(dev, ret, "Failed to init gpiochip\n"); - goto err_mutex_destroy; - } + if (ret) + return dev_err_probe(dev, ret, "Failed to init gpiochip\n"); =20 ret =3D ub953_register_clkout(priv); if (ret) { @@ -1403,8 +1399,6 @@ static int ub953_probe(struct i2c_client *client) ub953_subdev_uninit(priv); err_gpiochip_remove: ub953_gpiochip_remove(priv); -err_mutex_destroy: - mutex_destroy(&priv->reg_lock); =20 return ret; } @@ -1419,7 +1413,6 @@ static void ub953_remove(struct i2c_client *client) ub953_subdev_uninit(priv); =20 ub953_gpiochip_remove(priv); - mutex_destroy(&priv->reg_lock); } =20 static const struct ub953_hw_data ds90ub953_hw =3D { --=20 2.34.1 From nobody Wed Apr 1 22:01:40 2026 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013029.outbound.protection.outlook.com [52.101.72.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E76F933DED6; Sat, 28 Feb 2026 06:17:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772259422; cv=fail; b=D6jk4hkyMyR38OxR+sEaspLwXJ/OWmMDlTIjWz4BYNyjF4MukL6gxctSQ6YNCJog5fQjnI3RVuzc4WqifsjAfnn2f2m44evSD/xOwTwHSp6+ZG3KjcEw0MW6S9ug12lL+TAw76nbsvFd9+49C6YAcnQVF3JhRWqI7/7kpm6Z4z4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772259422; c=relaxed/simple; bh=o3WEJQuvBSglI3gOb6xhO0qM6yjqfrXmqB0glmBDPWM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=XhVTeOzSNVKZkASavyWdZMVVm+Rp10LyRdDec8jaFGw/6XLW7jnMBaYQPnXTpUFeSsWu9IZyFwMJA+gx/UsIIPOcHDyDuoPvRC6Y+h36yMrLQEHi1f1D4eDiaExUlYjPpvJsdIng0A9MMiEZVxONEyvWNXxaa82HqPtjL9kEVMs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=KfElRT3g; arc=fail smtp.client-ip=52.101.72.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="KfElRT3g" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iIEb+cuQIVV1+nYEEohT4BWB1avniA0c7Mu0tkeEJSuqjjEvmZsWGEnZuXG+M4gf3jhoty6sZnlP1x3NQSnGy5uVYbU88YB5mdCNilYybBw9t9emi5ewakZGj7N6OO5qm5ms3VZtqjYX2QEflLG52eHQeNv46kIADdFpohMV0eGLfKb2L+ygl01UPieC9lFzmmG4+N7xV3WpffgqZRjy1aBvYeWYeEbt47v3b/ZoG+HoHyqN6uWZ/JdPnahBIqLhU69dvyusfQgQcsKBJWEs3eaKKWFzsLgXP1+TTQVXE9QqACRXVDuCmif0Vql4Nilvr4VU/WYa7/qC/jSPeqo4Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lgw5A27Fq/Xmmk6axnGp5p4AdQD2aNs3UIv4EPtH1BU=; b=V+PNbjc5MX2oIgmlaiqpl6JJVZR+JqxGn5lhTIkYj/oxpPP/PWa3aseD9hxJJ52Zsof43RKgkCX9o/ewc17iMOREQhOXvynqgEN7vY1Hh0id4BQtnafOW/5Z8I+zIES69ueiSzymFo5WCFAbgDR8NdR+ZNuTAJUdxJ0/jW6bHIQmG4G8F94pZGSKPpwtB4YmKWqvePQWwDOldiFtS7DEEZgUdnE/d2GgHVuh428N0MFYlaHeX1DPuIJccwPlg1DckY0AT5RX62XjrxYoCRamGEZDmhIo9dY7RDnVV0t3DuC9u+41uVNgjz4SXccY8EpxYmZcRJvUPOGWVXaGvWqC3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lgw5A27Fq/Xmmk6axnGp5p4AdQD2aNs3UIv4EPtH1BU=; b=KfElRT3glr3rvzvCjP0/PNfMwEdhzQITHJzbNHwQZl/6hvqKs67abBnDIwS82e0SvuIIk1D9J93eiPDXMX7pF5DRJZ1Bw1ocf1BsAHXO7mT/fdUOZ0rDgBO+DtR/zsoe0pKhXt4UGYvsdOdgDciBGwxKD5gB4Z34ue9cqvgRTNbR0VxKdaHWB3m5aib9mjKQGhD5VVcLVjZ3qjUwIXE2Meb3aW9/DDf0jReqL4fkFOAX75h6i06bPjfCJRyt6xW3SlM2saQXAeRouVT0M5BURRtAHRJk4Mjs0oDUOsV89TGOfSQvyJXQEvu3jH3w7lj8RC93CXvPr4lF29VxR1Eh+w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) by AM8PR04MB7460.eurprd04.prod.outlook.com (2603:10a6:20b:1c5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.16; Sat, 28 Feb 2026 06:16:57 +0000 Received: from AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb]) by AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb%4]) with mapi id 15.20.9654.015; Sat, 28 Feb 2026 06:16:57 +0000 From: Guoniu Zhou Date: Sat, 28 Feb 2026 14:18:22 +0800 Subject: [PATCH v5 4/4] media: i2c: ds90ub953: use guard() to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260228-ds90ub953-v5-4-056cf07cc8f1@nxp.com> References: <20260228-ds90ub953-v5-0-056cf07cc8f1@nxp.com> In-Reply-To: <20260228-ds90ub953-v5-0-056cf07cc8f1@nxp.com> To: Tomi Valkeinen , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Vladimir Zapolskiy Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, Guoniu Zhou X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772259522; l=3324; i=guoniu.zhou@nxp.com; s=20250815; h=from:subject:message-id; bh=r/v6tcNvULydFHfDTrfblx8lKA6B3paTS1RqF7h0x1o=; b=TJZUm9tYulnNw6ORW1jdwiVBRxwQhtOaZdtv53pzOVEF1vj5Aa5Aneh2uaQoB/W4MtN2bMQYc wOES8E2itzyDrgaKtEKzaLPphiKJstueIToduSded1YcvD+w3KRz3k8 X-Developer-Key: i=guoniu.zhou@nxp.com; a=ed25519; pk=MM+/XICg5S78/gs+f9wtGP6yIvkyjTdZwfaxXeu5rlo= X-ClientProxiedBy: SI2PR01CA0026.apcprd01.prod.exchangelabs.com (2603:1096:4:192::16) To AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB9080:EE_|AM8PR04MB7460:EE_ X-MS-Office365-Filtering-Correlation-Id: 91b169fa-e5e5-4f8d-a9c8-08de7690f99f X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|7416014|19092799006|38350700014; X-Microsoft-Antispam-Message-Info: J/4vSGVEi98Kfn1ZgDNSYBTgbrWzQ0Vhra0rTEoGffjF8S4hg79kcC/2XengNjwLyEvfRdR0tVS++br/vMa4Xjv3fRYiEtAWx3C0HQvzVMC6sHNPF3WItgMrm0qbnMpN7CP/0Vba1Jn+bdu+sLrUgd3YHpGfOpb5wuB/tf0HMsieXmGRc/DgApUC2v6eyJVFJzHpyU7T3pshjx/vHZHkGwDUQ01jR9WbcKGyNamIVn//g4XA5jvSKQCZW+CDl+tR/+XkhUX8KwQUpBazKuV7yfrb0Nr4n1oWH+XzR9wbuyAJzTYF0vod/Digv8YVUnpLBuBz7BiJHRgE62DzzwCsQU9Jkcw34iZSRAd7adVtoLJ5l2pEPiYIFWT6VI0lligUzdK/E676dxS2k57Nn65CQjcIuCQ3k8yIem0CW+eHSmIhsDkxqFHh++4vU/jnimLlB2QO4HGPrl6pvnBaWVmWxlBdGIoNPE6bPs3sD+ZbNIynK+eSeK6zUH5eTvMN48Lxz8SiCCN2CkXWhAEeW04H6RLsCdUJrz1IUv6pvu+CYfLFObOr25N0AXud51gxLx85Bk1gomejYBJWxZzhww3iCqkuT1w1ID4NjWrLvlLKnsqjn7LHMkUxlRLDQYeuZV+1OmAE8WEa5p63bJzqkrg/u/ucT2W+HO3pwtqn2t9CiPy6tdDNB75uoJwY9OfLHQJ0+Ji5L/yJkhuw6KJjv8BhSpwejws9vuOLadhPj2CCziuPWV0s4XHPy25ozKHC9w9urowge+9bA1aHdwjrLlWKoiNv/5pGgSlbXXJRnc3inMQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB9080.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(7416014)(19092799006)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFl5M1k3MlZjeXJXd1ExOTltL2YxZDhiaHQrdEJuck1NMElyS2krZDFZQmRI?= =?utf-8?B?UE4xd2x0cUowd3pqdUNkVGREVktoT3ZIMi9lSkZoMDRHc01QNUVHaTJHdEpa?= =?utf-8?B?aU1NOWMyYzNZVjRPUDErQW03Qmc1RWorb3E4dUoxN0xIMGVEYWxQVnMvaTdj?= =?utf-8?B?T2ZwaTBCTEdTSmpLYjExUDg2c1MwK0ZTMmMzWlNUYm5SUkw3VnpMcmxLaEdE?= =?utf-8?B?QWRTbDBENWNhZkE1Mm9FSVlPa3ozbWRENGw3Y2t3MHF5TmFLTXdvZzhWZXgz?= =?utf-8?B?SnNQRlpuWXBmSFFVUS9TdFN6cXpGQ1FFbFBmaFRwNFBxV3ExSzkraTZhUzI2?= =?utf-8?B?ZkU3MEluODFMNzB0YUg3bEVqZGh3WUhBNnZJejJNN0I3NjNpL2F0UDk1clA1?= =?utf-8?B?eWZsNFVmMmdVZWZBSk0yVFczUVAreDRYcEZ0elFzSkVhYXV6VnRZYXJBM2dn?= =?utf-8?B?RGJEaElDV1JXUnRBSkQwYmdVa0dhckNNcTZRRkVLaGlLVUpJN3MxU0pFNDZX?= =?utf-8?B?TjlWbU5FZ01rMGl0RGdBcVlyWXJOQ0xSYXpBTEJYS0VSK2VSZDlHWTc4UFVY?= =?utf-8?B?TVE5QjN1c2JEKzhNYlFZOW80cWhtWXlEOWV5SjV5emdTZm9GVHloVmg5ZVBB?= =?utf-8?B?Qy8zSDBHMXBoQ01zaHFYVE9sR2o5eVRDL0xpMmw1ck12SEVtWEFmV1hTQ3gr?= =?utf-8?B?TnNZSmdQS2ZYdjR1eUhBOENuakVwbGVpeXhiTFkwc2E5SXU4U2JWTFZUNGE1?= =?utf-8?B?WWVNb3A0MFI5RThOcVRTWE1BMmUxUVNxV0dJZXdrUVZvT0RRYVpFcVBRek0z?= =?utf-8?B?QjZOSU40b2hjcDJ3Wnh4WlZpTGlId3ZlMDdKUG45alh3WURnZGtWc09YUUhv?= =?utf-8?B?SzJZRGZyZzBBTXhrMEZLMG1wcGZWYVFzQkp3VE9xbHJEWnNEWDBablNKcGw5?= =?utf-8?B?akVYTGZISGJjY3RmaUtwMGhjZTBZQjFNbjhPV2pGL0NTZGpMcmRLWU9jMUli?= =?utf-8?B?S1RUMngzUG9UaTkxYmJhSlc2L2lrR0U3a2Ixd1k4NHNVclJDcjUvRE1mZFYy?= =?utf-8?B?bVpEV3BQWFdyMlpHcXNxQUpjM28zOEJiaWpuNitnNDhDTDNHcUs4SEl3KzFS?= =?utf-8?B?UGtsWE1LNFJzaHNibDBjRlFRTDQ4eEhKYVBJWUM3djA1Z0hiaC9ETXhNNlB2?= =?utf-8?B?a3lBK29HVkF1NndOajFKV0FVOFJSTW1uYnI4eHgzNlJOai9yNkJXYXBQemJw?= =?utf-8?B?bFRwS1ZlL2NBak02Z3FHQVpjY05IRDhwT1dLdE0raWhTZmg3QnQzMTRNOXEy?= =?utf-8?B?RnQ4OEcxbTJsaGhIbDFUR1ZIeXJ3a2syMmFuV3RBcG1qbFlVejAxOW9Pc3V5?= =?utf-8?B?RVZlRUd4ejFDK2dlMmRZbk9OTWIxMjdsZ0d1Kzc0a1ZPS3ExOFU0VHlURzky?= =?utf-8?B?OEVkSHNObmVVVEhGOXU3Y1F2UXc3LytaMmt3UGdGeUFKNWtjTkRtU0pBZE9H?= =?utf-8?B?TGpQNzNrR3ZuY0xzTDZVUFZ0UkxreitNeVNYWDlIcWxWV1lEbE80Y1hOUlM5?= =?utf-8?B?REtjUk0vL0V2SkJTR3Ywa2FvY0t5QVVSb0cxZ3ltKzRQajRUQ1Nrd2NYQzB0?= =?utf-8?B?a1BTc21IdkY2bUhDNzJxTW4xTzc4dmpvNGxNZGpaTUhaS2o2WHFobDRKWk9I?= =?utf-8?B?dE5oTUVBditKOEJRUlpxY3ZEZi9ONXozWmszKzBlTmVkdEp5cjIvdzFlK1Rv?= =?utf-8?B?UTJMM01kTUtLOWtUVTJOQkxUbFN4b1BkdmJqQzhNS2xxRkM1ZnROdmFpVnlC?= =?utf-8?B?YTlrSlRVSSthbWE1YzU0d2FDZ2Z3dTh3bGlkbzlqMTBnRkV2TXFnbkJCeUF0?= =?utf-8?B?NVp3MlNXNWZDZldBYXVNazVVUGNTMnZ5Ymh5TkJkeHJFR1lLWWUwSUNERFlZ?= =?utf-8?B?Rk5RNEw2UktOcGsxSURyVVN4c3lVZEZteFhpaUtKY3MwUTFGRTJDcUVUemZa?= =?utf-8?B?MU9ISGYxUlludHMzZVFXSGxGZElBc1A3cTNwazhrc3kzMmREQk1iQTdGbCtS?= =?utf-8?B?MzlSTmhjNVQ0MEJsNTBNdEFVN0dHYWc2WWxkQlpTWXBweFJMZGw0cDJZYUh6?= =?utf-8?B?UnNHTnBwN3ZsQUQ1aC9CeUt5R3hoREpObzNjVGNiNXlDT3YrNngzeWJLOTho?= =?utf-8?B?VGFqUFViV1VqUU5xbzh1N1JPb3ZjMWJjcEdaRm5xa3pDejQwR0o5VUVRdTlF?= =?utf-8?B?ODAwU3djcUNkQUR3dG9kYk81MDZBdkgrMkJtcGdjSThkMklNWXovem9XT3hO?= =?utf-8?B?WkVPRU1yOUt5eXpBN1NaVjFIZWxTTUVrbzlkMlVYeHcrdmhRcjhrdz09?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91b169fa-e5e5-4f8d-a9c8-08de7690f99f X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9080.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2026 06:16:56.9677 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 51SFvRgYN2yWxi3JUE8EAbEvrDpMa7tj+WJ2/lMDHUpOZzgs3F55vGdIr198f7NlNSKJL3c/LsGsro986UEYbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7460 From: Guoniu Zhou Use guard() to simplify mutex locking. No functional change. Reviewed-by: Frank Li Signed-off-by: Guoniu Zhou --- drivers/media/i2c/ds90ub953.c | 34 +++++++++++++--------------------- 1 file changed, 13 insertions(+), 21 deletions(-) diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c index a85c6a9b64070491db161ca1586179dba9c69cb0..3a459687aefce05ac025a517c8d= 4cc6d76cd7293 100644 --- a/drivers/media/i2c/ds90ub953.c +++ b/drivers/media/i2c/ds90ub953.c @@ -113,20 +113,18 @@ static int ub953_read(struct ub953_data *priv, u8 reg= , u8 *val, int *err) if (err && *err) return *err; =20 - mutex_lock(&priv->reg_lock); + guard(mutex)(&priv->reg_lock); =20 ret =3D regmap_read(priv->regmap, reg, &v); if (ret) { dev_err(&priv->client->dev, "Cannot read register 0x%02x: %d\n", reg, ret); - goto out_unlock; + goto err; } =20 *val =3D v; =20 -out_unlock: - mutex_unlock(&priv->reg_lock); - +err: if (ret && err) *err =3D ret; =20 @@ -140,15 +138,13 @@ static int ub953_write(struct ub953_data *priv, u8 re= g, u8 val, int *err) if (err && *err) return *err; =20 - mutex_lock(&priv->reg_lock); + guard(mutex)(&priv->reg_lock); =20 ret =3D regmap_write(priv->regmap, reg, val); if (ret) dev_err(&priv->client->dev, "Cannot write register 0x%02x: %d\n", reg, ret); =20 - mutex_unlock(&priv->reg_lock); - if (ret && err) *err =3D ret; =20 @@ -185,18 +181,18 @@ static int ub953_read_ind(struct ub953_data *priv, u8= block, u8 reg, u8 *val, if (err && *err) return *err; =20 - mutex_lock(&priv->reg_lock); + guard(mutex)(&priv->reg_lock); =20 ret =3D ub953_select_ind_reg_block(priv, block); if (ret) - goto out_unlock; + goto err; =20 ret =3D regmap_write(priv->regmap, UB953_REG_IND_ACC_ADDR, reg); if (ret) { dev_err(&priv->client->dev, "Write to IND_ACC_ADDR failed when reading %u:0x%02x: %d\n", block, reg, ret); - goto out_unlock; + goto err; } =20 ret =3D regmap_read(priv->regmap, UB953_REG_IND_ACC_DATA, &v); @@ -204,14 +200,12 @@ static int ub953_read_ind(struct ub953_data *priv, u8= block, u8 reg, u8 *val, dev_err(&priv->client->dev, "Write to IND_ACC_DATA failed when reading %u:0x%02x: %d\n", block, reg, ret); - goto out_unlock; + goto err; } =20 *val =3D v; =20 -out_unlock: - mutex_unlock(&priv->reg_lock); - +err: if (ret && err) *err =3D ret; =20 @@ -227,18 +221,18 @@ static int ub953_write_ind(struct ub953_data *priv, u= 8 block, u8 reg, u8 val, if (err && *err) return *err; =20 - mutex_lock(&priv->reg_lock); + guard(mutex)(&priv->reg_lock); =20 ret =3D ub953_select_ind_reg_block(priv, block); if (ret) - goto out_unlock; + goto err; =20 ret =3D regmap_write(priv->regmap, UB953_REG_IND_ACC_ADDR, reg); if (ret) { dev_err(&priv->client->dev, "Write to IND_ACC_ADDR failed when writing %u:0x%02x: %d\n", block, reg, ret); - goto out_unlock; + goto err; } =20 ret =3D regmap_write(priv->regmap, UB953_REG_IND_ACC_DATA, val); @@ -248,9 +242,7 @@ static int ub953_write_ind(struct ub953_data *priv, u8 = block, u8 reg, u8 val, block, reg, ret); } =20 -out_unlock: - mutex_unlock(&priv->reg_lock); - +err: if (ret && err) *err =3D ret; =20 --=20 2.34.1