From nobody Sat Apr 18 11:08:29 2026 Received: from mail-yx1-f53.google.com (mail-yx1-f53.google.com [74.125.224.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AF7F37FF72 for ; Fri, 27 Feb 2026 21:56:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772229409; cv=none; b=NFPphb2A79n2DIPekgexkCLsI+GQAHWhwAWgGxWAkiYj8yzimV6iPKksJU8A2dbGYsspxbi0aWSlwHQg5eg+WZupUO28YsbcTOhLUgZvl8lun9kUr4wzEkkDLNZSVtDX6eqCXKI+CrYdv37QNlPKvLNsBT6uPBfAZ1yGO9lm4gA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772229409; c=relaxed/simple; bh=GQDN1R2s9mM921F8hqC+JQetSAhVPiZawRGbiievuNw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d2w9daDDWnstHetadwYoB2yUXQ9qFyqIH7RN6wUSf2DeGx3ukwO5vLesilqfOBWCq4Nw7ZBPrCk1xIhmpIPnHXn+1df+wXgkMrGc+pljduiLzG4CzYAtDFZvzvN5ht3r59jF54Da6GU7YnOWGdMLdwqtbaLYxn/b7uYpgdXFrxM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a8kxxp+3; arc=none smtp.client-ip=74.125.224.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a8kxxp+3" Received: by mail-yx1-f53.google.com with SMTP id 956f58d0204a3-64c9ebd1369so2319230d50.1 for ; Fri, 27 Feb 2026 13:56:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772229407; x=1772834207; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=b/E4mXwswRGJTxuG0f6Dlg/ntBjWKWPl5F6qxEETdII=; b=a8kxxp+3mQs36q2WcTPuyJZvM5LR83EWWI77/h6QUcf4L/vOlG2edVn9tcPigWqp/y JoK3WNZPifxgqzeizEA83VD4V5HW72zjtCMBK3FYiBE1JVfKMGxHREBTGbEnp8p7TGCP ufh2HhZQ9q7X8y/pOuND+n1G1hiLs6EvXLABNSdLZ8firoagLpaXows2nq21n60Q/dGz WyWIS9WnCVUlRp+TkmnhyXrvuK/falfnGkWyzdsXHf0S9B1+6PFDbigROcagHF9rLv2d QP4bm7i1fx1tfXmAgisAyvEashz+VSFAvjLKnWoYrm4KJ9qmJJWF4kBbVOA3DduuuHxA CT7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772229407; x=1772834207; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=b/E4mXwswRGJTxuG0f6Dlg/ntBjWKWPl5F6qxEETdII=; b=BtyBy9YdNl6wmfjELdW0eYpImnLF3DQrF5pfLVDIpe9sMQpVZAKdQcOEDQ/OehVARN btOJ3TOjx8iVMaEoH0FOA8fg564/N5B6+yWbBC9/xiXE3UBnSVuPb9vWFf9jjAVNR/14 XJVHAIu5vhLLMNKcP9C/v8T6PkllCQNK22sLv9AmcwjOd9lx0eoz+D11NncVx+83a6SB Q/D53KbsnMRpOXJDmiKlN/JqS4ZNSpaVGXElkbX7F59jGPCKMNtHpyv+hIxgOc+leudV m/AdBKGMGVNZBDRDuKrwMu7DVzpPG9+2giV7QxHbUpiED+QhJVMgL7ReCngNyu8RnzvX zveQ== X-Forwarded-Encrypted: i=1; AJvYcCU0FGKw/9RGos5/AaEwDgn3jMJuBdtPUciE5eNfM9oFhHiG1kYttRSD1M2PbBRtjrEfqhZ/rDkk7E2uq0Q=@vger.kernel.org X-Gm-Message-State: AOJu0YznuWiTEx89zrWSiMhYrf4Y7LUzzb6S3EaljOzzSFedXlGCru2x hXzaJFo2+91rdOfLh/LiQyrd8FH3qgwtuCf8BiFb4YUM0nTkFSzZJlHu X-Gm-Gg: ATEYQzy+EZ0gC2zw+z2KQi6cN48tWScZi3hTfeNgy3qWz0bpxqRYIWdMaWou3QBNF+h EIoyroDR74n55HfIGIa6Prm0MzvKRYmegsLkFTWqtMq7BFUgkgIezB/Vqfzu77udviK/VbE/lzH ePNzWH3PywCO1qBk6NyWrOyk59RO8nWXHY+5UhoWSXCFz90Tt3WtqbSsCvNLV2sRJqqkMMDNnSI zaN4OSuvLOoXP59mfnsP/pBjN2NXt2TWPmi6C5elwM6ybtECuToXwsv7iIHwWhghBgNZ4PfMCo9 LwZCXayFsLgqU3DhjkqN/SNHuvnb/w6/75q/g332mYsmxO+/m3kXjXijjux98HUEqPghE+X2peZ phpGqKHR8PzOpwGdV1qO8V7N1yjecjE8pl7gBrmh5cEPmtCXq51LH385fIF6BZy7JjP8rTwkycc n9pQd4Fo2xEB6S/XAUkHqYHDgPIK0U/9oiNgi0gSx+jHZmv34ZXrhI8iezRuOkUPzPNP8zdyugI IG8xLKDSlNhFOI+Qr75qY0q X-Received: by 2002:a53:e02f:0:b0:64a:d74f:2580 with SMTP id 956f58d0204a3-64cc2082d28mr2750707d50.1.1772229407133; Fri, 27 Feb 2026 13:56:47 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64cb75a1157sm2948509d50.6.2026.02.27.13.56.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 13:56:46 -0800 (PST) From: Ethan Tidmore To: Linus Walleij Cc: Joshua Henderson , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 1/2] pinctrl: pinctrl-pic32: Fix resource leak Date: Fri, 27 Feb 2026 15:56:23 -0600 Message-ID: <20260227215624.1094832-2-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260227215624.1094832-1-ethantidmore06@gmail.com> References: <20260227215624.1094832-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix three possible resource leaks by using the devres version of clk_prepare_enable(). Also, update error message accordingly. Detected by Smatch: drivers/pinctrl/pinctrl-pic32.c:2211 pic32_pinctrl_probe() warn: 'pctl->clk' from clk_prepare_enable() not released on lines: 2208. drivers/pinctrl/pinctrl-pic32.c:2274 pic32_gpio_probe() warn: 'bank->clk' from clk_prepare_enable() not released on lines: 2264,2272. Fixes: 2ba384e6c3810 ("pinctrl: pinctrl-pic32: Add PIC32 pin control driver= ") Signed-off-by: Ethan Tidmore --- v2: - Use devres instead of manual cleanup. drivers/pinctrl/pinctrl-pic32.c | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/pinctrl/pinctrl-pic32.c b/drivers/pinctrl/pinctrl-pic3= 2.c index eb438c9d9667..d185fe48dc0d 100644 --- a/drivers/pinctrl/pinctrl-pic32.c +++ b/drivers/pinctrl/pinctrl-pic32.c @@ -2174,16 +2174,10 @@ static int pic32_pinctrl_probe(struct platform_devi= ce *pdev) if (IS_ERR(pctl->reg_base)) return PTR_ERR(pctl->reg_base); =20 - pctl->clk =3D devm_clk_get(&pdev->dev, NULL); + pctl->clk =3D devm_clk_get_enabled(&pdev->dev, NULL); if (IS_ERR(pctl->clk)) { ret =3D PTR_ERR(pctl->clk); - dev_err(&pdev->dev, "clk get failed\n"); - return ret; - } - - ret =3D clk_prepare_enable(pctl->clk); - if (ret) { - dev_err(&pdev->dev, "clk enable failed\n"); + dev_err(&pdev->dev, "Failed to get and enable clock\n"); return ret; } =20 @@ -2239,16 +2233,10 @@ static int pic32_gpio_probe(struct platform_device = *pdev) if (irq < 0) return irq; =20 - bank->clk =3D devm_clk_get(&pdev->dev, NULL); + bank->clk =3D devm_clk_get_enabled(&pdev->dev, NULL); if (IS_ERR(bank->clk)) { ret =3D PTR_ERR(bank->clk); - dev_err(&pdev->dev, "clk get failed\n"); - return ret; - } - - ret =3D clk_prepare_enable(bank->clk); - if (ret) { - dev_err(&pdev->dev, "clk enable failed\n"); + dev_err(&pdev->dev, "Failed to get and enable clock\n"); return ret; } =20 --=20 2.53.0 From nobody Sat Apr 18 11:08:29 2026 Received: from mail-yx1-f46.google.com (mail-yx1-f46.google.com [74.125.224.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF288472791 for ; Fri, 27 Feb 2026 21:56:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772229409; cv=none; b=RKe3LY5oWFwtC1lL4mjoOL+0BdHBvP3tGrcc2wBZh2RSE5mJeCstzkrrEqOeMS6mTTgHSo7476yNUCgtlRl3zEYqFHo06o20cZq57Zh9FtRLI6pPd9s9lxesx1DhufO69csmGI1IJz/kY3yNvOS61x2hWTSanU9p5a/oZkIWvb4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772229409; c=relaxed/simple; bh=jAdRiOc6eHNnrcaLppBpsAksw3gqq4WhjHpdzYZdmkE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H5njbypsVPvqF2mpp4pXf0nYHZD3rOaV+NlwVw1/8mbQkkPxqfwJQSUftK3BmEizygfRBcwn3dJpZzDJzcOLJh1pF9vIKfvsn6aokpYVh3euznYhrrxC1W7u3NaPfhT431xO7C0xPmdmHZ8kcYkQ9u10kH+oUDPjEUMi8DTZcgM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BYcDo7Ze; arc=none smtp.client-ip=74.125.224.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BYcDo7Ze" Received: by mail-yx1-f46.google.com with SMTP id 956f58d0204a3-64ca09f2056so1849840d50.2 for ; Fri, 27 Feb 2026 13:56:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772229408; x=1772834208; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ICpWNGc9t/1ds7tN5GBFPqCGmQCh607eDV5V6BgRP2o=; b=BYcDo7ZeAq7JxJW+8g8uGxJM7/n8fYRKAeQJFoZp1l8mazQtQ+/GzvXgAezRrq5cgw ljgVSq4ucBgmAVK85e5iKTqhE3igQhosI3+Ce5AoxdDutHW/sHacka5SyNFhsn33v5QD zq/7pokGBV0EEQ1pDUKmRGRt48Z25jXJvkUxslUusnAmXVApGfxqYKS1UPg304lQphrF P7i+f/VG2HOj0hDPo3Ns801a3+KvYJDxBWHhrB1Cz+4v1FtoXzNcwp9gb/2ekv55hHr5 2gnVJV8Y71r+5m+G/2VbofkRg0PRep+3vTRIuaxyb6PUymX7XHOnYfAc3sv6HzZ8nyGJ 1QJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772229408; x=1772834208; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ICpWNGc9t/1ds7tN5GBFPqCGmQCh607eDV5V6BgRP2o=; b=fPOnaeuEQJCIr60DQ+HTFoFFgNb2aI2HwFkiiGqTDtJByrSSemcXwlOypymmGCvrnE 3+mSJ7v3rfokGDT72JYeGZigGzQU7bvIhJBcm2o+Wtq5YYbUeAS3nZif/Orpbvm9cEWq QNLOQCzZHOUsagaHLp6rQYK1kYZSHws8uiQHKEe7xKAvgUeoR+cErj89Xrf0166/SNoj eN44ycUtAVszlnwwtX+Hd0hgW4NE7EZHfsmOjdlBWmfq7JnOK+YbiwpDpajZ2Oz0yQix OboEYracChlI/cOJG3cPUhlsrIn21KTx8iAzcSFzM7l1Y3su1zqe0xPySIMuSIKD1m13 0gfA== X-Forwarded-Encrypted: i=1; AJvYcCUlOc+VsJXl/Af7G0TJ7h2Ko1vTFC+L+w7eqcl+Aye8PnLJtoyAOjp+dx2ixNQS4we1IIKr33V/mr+XDyw=@vger.kernel.org X-Gm-Message-State: AOJu0YwoojGc+6emdYOhMGP2z60ikYWzITJBPkP/FV2xCMipM54Sp7YZ 1rGn6utCXPvcN2obTUTan4juCmATBjOK9k1Vjw4WE+87wOz79L/8a9Eb X-Gm-Gg: ATEYQzw0QPhNoDHxD0O8MsaEwn28ImTZK8wk3/P9nu12+IbUNV+QmSvb9yBMZEVV3Qd ULLG8QqlkaNf8HTufdObEFo0rZBojNdoMTljGHAHGHYSDQkzwg7HjHZC4hnj6OWpNU9yb4W6pBD P5UgOnobxUTlPssyH7knXlBbOS1D6zxPVVCi2DQ7mx89q69/wHppenmXCuNpLd2efp965W7mbni 9parhixeIWJNMEo5bvuKEJkK57yFwzm2zBiBR9G1z7kzoYIV/Ai8L9n1p6VI3dru2RAzORvYzMn r+mIJqTnX5QXu8QnoYnmD4idXDacXn6Ai6ie5DWCZ9BocYRufB30vdQJSVu+IPANNP6AUAZOfaN jWztDlw2IqPHMWw5JNxK+DF55DLKnS7VWRkDDQsb+zf4W9gFLc2s/H34f5unoBpcSR8DkxR32kG GavoQI4sGUiYo8qkDO5ehDoUbhN/4spBkQnwZR8JEJ+XNya4WmJNiv4fcy+9wPy+vjC1HO6Vkdt KjjTJG4lOhMDTgN/vesu2Wc X-Received: by 2002:a53:c943:0:b0:64a:e222:d3fa with SMTP id 956f58d0204a3-64cc22107a1mr3305068d50.58.1772229407863; Fri, 27 Feb 2026 13:56:47 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64cb75a1157sm2948509d50.6.2026.02.27.13.56.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 13:56:47 -0800 (PST) From: Ethan Tidmore To: Linus Walleij Cc: Joshua Henderson , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2 2/2] pinctrl: pinctrl-pic32: Use devres version of gpiochip_add_data() Date: Fri, 27 Feb 2026 15:56:24 -0600 Message-ID: <20260227215624.1094832-3-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260227215624.1094832-1-ethantidmore06@gmail.com> References: <20260227215624.1094832-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert gpiochip_add_data() to devm_gpiochip_add_data() to use devres style cleanup across entire driver. Suggested-by: Linus Walleij Signed-off-by: Ethan Tidmore --- v2: - Made this a series, added this patch. drivers/pinctrl/pinctrl-pic32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-pic32.c b/drivers/pinctrl/pinctrl-pic3= 2.c index d185fe48dc0d..07a24e17d35b 100644 --- a/drivers/pinctrl/pinctrl-pic32.c +++ b/drivers/pinctrl/pinctrl-pic32.c @@ -2253,7 +2253,7 @@ static int pic32_gpio_probe(struct platform_device *p= dev) girq->default_type =3D IRQ_TYPE_NONE; girq->handler =3D handle_level_irq; girq->parents[0] =3D irq; - ret =3D gpiochip_add_data(&bank->gpio_chip, bank); + ret =3D devm_gpiochip_add_data(&pdev->dev, &bank->gpio_chip, bank); if (ret < 0) { dev_err(&pdev->dev, "Failed to add GPIO chip %u: %d\n", id, ret); --=20 2.53.0