From nobody Thu Apr 16 12:25:04 2026 Received: from mail-yx1-f45.google.com (mail-yx1-f45.google.com [74.125.224.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3B3143DA53 for ; Fri, 27 Feb 2026 20:55:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772225707; cv=none; b=R2sZgOgWDLHFDQDf2khLg2NI6oSx3fBIfJQ8heOtf3HZ4kEXWglGcsAcdEPbirPkp16KvcvAGUHIvWXyiOgynO5vYewdO2Y1noBJ4tJUPpFCcLBTwgdRwC6RVfTfloBkeM2b8DoZdycnb0LwR1mQNxbrOjFDwWJGJAo7155a/T4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772225707; c=relaxed/simple; bh=2L9AH1fbv3hD2pN30kfeymBpxCP0X38ypHeoTWHMfQY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XbUlnOPWwZJGKLt1ZbQWbspsZ9NsZMcDnN+fLlYR5wda0e6BHo7i7oSceEtEnj6kCRq1OkVDUqZvds/7aZz3P9jtjbmrRl84Zt2ic3h8jyu75N7YxWBjFXVws+JdU5qx0+VRlZaKADAKbWR9hRAqxQ6+TKQENYcZRDrAH8YU30w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e/QrJ1u2; arc=none smtp.client-ip=74.125.224.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e/QrJ1u2" Received: by mail-yx1-f45.google.com with SMTP id 956f58d0204a3-64c9a6d68e5so1891647d50.3 for ; Fri, 27 Feb 2026 12:55:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772225705; x=1772830505; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qpJvwZ8KcD1PIhsz01U1baureuVfvggAoVTmPDUtPPA=; b=e/QrJ1u2W/MhQJjfmEUsG6iz1LOsT9moSI/H9mmLsyVM8NM6aHYJbJx3N9uBA2CWBl 4VgJTzw9DkK6hh0VJBOFxCl+dT6SfFxAFzCOkh9zNbSCUcey7yaJDxQwssqok6lj9Zt7 AAslvvJcrFdeUyxPjhejE5/hU2Td7Aq7A3SWBOqGnLbcC0BSRJkn9cuus5HuF9qHRY6P UKb8RjrhqI4etZLVMpm6zfbScslSdTzmzP1tw1LMLEcfNj+Cvv5mSRkF+kpSUls00CY9 f8dEhEb/5+ign4WoesE1NyR4bZOAliTTCNQ5PlSD7jeK3+Eaolm92A5A/RCyWBpnlIG3 0EmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772225705; x=1772830505; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qpJvwZ8KcD1PIhsz01U1baureuVfvggAoVTmPDUtPPA=; b=xAVACn93VGRN9zY1zXLdD1TMGVoC9FkFk513rN6lAyAz0AUtLy6drB7ZHsIi/8+Fd+ hExQtf92vR++MZhfQcpwPrly1XRM0+XnVyOetRCQJGCmglTBW2A6oF6fIPMUMRCI4PYw iQsteGpZaCus2n/1IVOZvYaFQXsVC/6gMsFm8rGrQDuF7KDSlgOAVQB48HTe9qSzscY5 Nh6psPG2yElh9WaOnQnFXF1Pl3gJL6UpxSdLyI4O+j4wy1Vps9pnXyXhA5iZqnsVA2uw NgsicVnhk8S8spWJnSRh4v9l/fSp/P+KvKOaRT2nfdIyUjR/ENOBNzRMOu/wOgNI3j6c XToA== X-Forwarded-Encrypted: i=1; AJvYcCWQrSpKnn0BO6OadzeRteV/NRaljI2P82InzoInJW3Co9zmM8rbRf6wlMLvfe1xw8+hUJfGoa0k8PJqjAo=@vger.kernel.org X-Gm-Message-State: AOJu0YytUEl91km8k35sKTbUviCWLqljwtbClzlhxWzFcZB3f/uPNmn8 bm0qyg9bjjHOwy9zc2izdlfORhDgGCdEvYBcPUtO++6Ln4zJvRiEfllU X-Gm-Gg: ATEYQzzy4qtT1AaUfoJ2JUMI3V39Tm2P9m7ojHr3nR/h/E2dXEp+KjyXpGx8LY3gSaW fSL0wtipDXOpSIYuBhVP0WWYOQ0aY3f3s7Wd5zhpa3dHmq5TR8fufff9SHE8lS24Zzli98i2hdk tfAiinHEwLutSBaaCfk9COHcPQZfFi85FXZj/6JvJpyR3R7n31sLLjjM1LQ9cOjmm87yn6gm9Cz pN24Co/L5aXo/RFYE+oZBlOkDJ5mOppGpDFusUiyvzFDhrapR3ok3HZHu4zhju6LJ/G0dCl6kWZ 0YVtsaXd3FYGPha6t2EVoH/krfO3yc+oxAaKJ4slVFrEeN/WvWEjwJT7hR5cF2laITaiEGueq/l 77xjTDsEE1Qq2+333b5BOkpICwRvNL6xbytESPrx+zpFL0fMwp8qiHsmfM6WDwy51r1ASZWcRIb AiDkaz/7WjvQhUF/Y7ug4uwwfmpvdknsovtAjbZmsqYLVX3KNYz22r5DtavAQGIZIo/1o+Zetyg zD13LP+77aOQOOQM3QTfdHE X-Received: by 2002:a05:690e:150d:b0:64a:ec39:dd64 with SMTP id 956f58d0204a3-64cc22dda60mr3473637d50.43.1772225704974; Fri, 27 Feb 2026 12:55:04 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64cb7571e00sm2805811d50.3.2026.02.27.12.55.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 12:55:04 -0800 (PST) From: Ethan Tidmore To: "Derek J . Clark" , Mark Pearson , Jiri Kosina Cc: Benjamin Tissoires , Mario Limonciello , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 1/3] HID: hid-lenovo-go-s: Fix signedness bug Date: Fri, 27 Feb 2026 14:54:42 -0600 Message-ID: <20260227205444.1083103-2-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260227205444.1083103-1-ethantidmore06@gmail.com> References: <20260227205444.1083103-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function get_endpoint_address() returns type u8 but in its error path returns -ENODEV. Also, every variable that is assigned from this function is type int. Change return type to int from u8. Detected by Smatch: drivers/hid/hid-lenovo-go-s.c:391 get_endpoint_address() warn: signedness bug returning '(-19)' Fixes: 4325fdab5dbbf ("HID: hid-lenovo-go-s: Add Lenovo Legion Go S Series = HID Driver") Signed-off-by: Ethan Tidmore Reviewed-by: Derek J. Clark --- drivers/hid/hid-lenovo-go-s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-lenovo-go-s.c b/drivers/hid/hid-lenovo-go-s.c index cacc5bd5ed2b..0ef98ba68d86 100644 --- a/drivers/hid/hid-lenovo-go-s.c +++ b/drivers/hid/hid-lenovo-go-s.c @@ -377,7 +377,7 @@ static int hid_gos_set_event_return(struct command_repo= rt *cmd_rep) return 0; } =20 -static u8 get_endpoint_address(struct hid_device *hdev) +static int get_endpoint_address(struct hid_device *hdev) { struct usb_interface *intf =3D to_usb_interface(hdev->dev.parent); struct usb_host_endpoint *ep; --=20 2.53.0 From nobody Thu Apr 16 12:25:04 2026 Received: from mail-yx1-f50.google.com (mail-yx1-f50.google.com [74.125.224.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7D3F4779BA for ; Fri, 27 Feb 2026 20:55:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772225708; cv=none; b=udHlARtdCwqmyrk1vfFnhnlbaRgNQAlnssYju/f7Qhwxy6umJ9SabP4QWOaAFiGRsRxicAs0ZYRBQmLFy7ig19ClRGMY1baHmB3HWUPOODQpec9N6tJ7eqn7cxcvzDwEwsVIPBEyNyM6w3l4K4Y5UikMCi6IJ6iZAqyf6RtHpr4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772225708; c=relaxed/simple; bh=9NIt0LDmVzP8O4boMraBtvrv5bDGxJ2VZ6TZ9AQn3+c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=se+CZKhNM6ATkkbwGwg8rcK5s4reiM9g01FzXxGO5bze0piN2KjR0JSSTiOn06NQKa+kqpLh8RRpOunR5soTqpFlFmrQX0Nhw9T79QB+On1yMR5NbSHiox4jMnDiGiSXiZNuouX2P721KYqoC2Ld/qb5+VZi4QWtZaSp0InLjtM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YzW3jGAJ; arc=none smtp.client-ip=74.125.224.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YzW3jGAJ" Received: by mail-yx1-f50.google.com with SMTP id 956f58d0204a3-64ca4dfdd88so2348385d50.0 for ; Fri, 27 Feb 2026 12:55:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772225706; x=1772830506; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CZ1hJ+pNn6Hb2WoHwRCbFIjmlbpk468+7oSIaJffrks=; b=YzW3jGAJz5eus3ptBKiMVASuQOgFwaeM9jFF8aWePmzkzJmZX4L7cv0OPEC1c8PfKP /Ihpd1ZM8X54SadIAhEaKes8g6EZZHeSgXqu+ZnQPo4dBJ6ruSewsMiO93CsfGnAh8mu nQBfN4hsW2EBIgATHBX3ZfsCMl2gTdHbtwWCfdyad5su3VukpySu4mRESLMAEMyg/nwt MbboF74rINnmV2NWpRX4nDDqwh1/WAFt+9S/5HuA0AsJ77IRA+yRJEdhkXZKf+wbzItm 977WvXacEoQ3lASF8keONPp4Rwygf3bbt6Ukp2Q+/wFwp58H4qlqG7QqxvyOIgz9pqZT 0fsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772225706; x=1772830506; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CZ1hJ+pNn6Hb2WoHwRCbFIjmlbpk468+7oSIaJffrks=; b=WfN5eRwjDV1aVglmJlPL3qqvx3pmKnlzT/5Lg8D1f/7v/UKns+bk3RpUYUECQbJnmp eROGxDPlC9FqMYhrxBCEspN0H/uddtUCWShiFWczQ7r7ORCmEyKxL6PMPCrey9wFYZzp huSZvyIsno0MVG1DLcF7iVAqWiMPCU5IPt/3rTDnZ3ZPcZkYnsxN00VFxN34CYpe6gZh 01oVjpZmiuQ0pQAvT3MnsWNIqNM66CmrBfdNVUln1bZ/F/UwaQHiO002fXqMY/1W4siG ByRKFobaYMAPsLGGWKW0kuHK7TSIv6qxnki6VoQtvIDQXoc2SJeTGm0o61WQlpF/+TUx A7Vg== X-Forwarded-Encrypted: i=1; AJvYcCVX7drzmwpHbSOg1yJkfa32pvbinah/pFu0W1Ol9Mp+gLhSKTVsOVQMghsDUlLMDdeu1GcaJqIGv8it9wA=@vger.kernel.org X-Gm-Message-State: AOJu0YzCa61tmImkPRihGbgCBWZ910yMpiKAssMy/mYgKg+ObmEID2Kj sy4DUFTGnwrnVMROuzXsBvJYVdWYC3brKUk9vW+dJjMNfotyJFlW3dmX X-Gm-Gg: ATEYQzwGzFsgtSMSuingF9mvUuxV4A2kVX3ml0nSYa6dwl5kWMO7VChZLPI8KuOGdCf 1/le5KEuVkKAvj+j4ydKIDHLwxBJRIICPKjLYWAJ2RKj14tU7deTcV4Es2Dk30xJKJv9ha4EeDz WWX8thUdksuZklzmIcBG7MvgmGT/Xko1kUlOyGQh6jMyn+l6IlTDr7iw3/E6k6QdmPxzNNZY28I bDzZ2MXtObhid5nzQIT11Tu31c79tz/1gW2PmpCihAhq37jrzZRD1HsavrOP6ngFQrswDVdMGOx tHxcnsEdAp7RW1bdr3t0Fidp1DPSF4libJCVnA5Izs2C8vpzHwwF5KYqX+I58DEMDwctEmlzG/w bBx+N5z5U8iYekdXAG8aQHBRdFMV58fYl3DN+8yN/ARWkOfWA35X/kuv77DFL6CKCFnatmM40c/ /Xhlc+BvJTYOqIJFo1sNzCl68u6f2RCHOX0OyA56jGymfsBC5u0gM4f4+z3UpaQ/i1lZuRqr5Tm UF2bGIW91RIDnm5UqZLgEne X-Received: by 2002:a53:ee68:0:b0:64c:98f2:272f with SMTP id 956f58d0204a3-64cc23701bdmr3319500d50.74.1772225705759; Fri, 27 Feb 2026 12:55:05 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64cb7571e00sm2805811d50.3.2026.02.27.12.55.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 12:55:05 -0800 (PST) From: Ethan Tidmore To: "Derek J . Clark" , Mark Pearson , Jiri Kosina Cc: Benjamin Tissoires , Mario Limonciello , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 2/3] HID: hid-lenovo-go-s: Remove impossible condition Date: Fri, 27 Feb 2026 14:54:43 -0600 Message-ID: <20260227205444.1083103-3-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260227205444.1083103-1-ethantidmore06@gmail.com> References: <20260227205444.1083103-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The variable val is of type u8, so it can only be 0-255. Remove this condition. Detected by Smatch: drivers/hid/hid-lenovo-go-s.c:508 gamepad_property_store() warn: impossible condition '(val > 255) =3D> (0-255 > 255)' Signed-off-by: Ethan Tidmore Reviewed-by: Derek J. Clark --- drivers/hid/hid-lenovo-go-s.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/hid/hid-lenovo-go-s.c b/drivers/hid/hid-lenovo-go-s.c index 0ef98ba68d86..a24737170f83 100644 --- a/drivers/hid/hid-lenovo-go-s.c +++ b/drivers/hid/hid-lenovo-go-s.c @@ -504,9 +504,6 @@ static ssize_t gamepad_property_store(struct device *de= v, ret =3D kstrtou8(buf, 10, &val); if (ret) return ret; - - if (val < 0 || val > 255) - return -EINVAL; break; case FEATURE_IMU_ENABLE: ret =3D sysfs_match_string(feature_enabled_text, buf); --=20 2.53.0 From nobody Thu Apr 16 12:25:04 2026 Received: from mail-yx1-f41.google.com (mail-yx1-f41.google.com [74.125.224.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAE98450902 for ; Fri, 27 Feb 2026 20:55:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772225709; cv=none; b=tfm5+6ZZWhi4XrfnJPhC0OjST5tzFjpIpA9mbdvNknKmo6zOmE1yI+xS+Us3VpJvVQABeJR+bdZ7V1boIpqc3p8bfOTQk2Eks3GoXKL1ZD52gdOPLGgvCFe4KjdQUleWBSH1Dkv/3F1jVtYKS3AZGGgHvNYxNmT1LxbcCix02k0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772225709; c=relaxed/simple; bh=Pi+esKYrGjsWzhvVHo5NYiRkb7XCnD/2Gqdfov9W/UA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YEol3xPiTBsvb5jaYLG6dHx8tc30vOlHCRHN4w6YHzWYBWf02By/psS95xXkkx0TlwKB5VL5NBxnVT79whc+81i0WYGjBpIUVy8nFw1yOBsF6mAzKP1Dw3PC2OVx2fLUylF4LDLKViJMZgnQ4ZQb4AFQApctEm9G7/iBfvm3nUA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lAk6jBdX; arc=none smtp.client-ip=74.125.224.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lAk6jBdX" Received: by mail-yx1-f41.google.com with SMTP id 956f58d0204a3-64c9ebd1369so2276354d50.1 for ; Fri, 27 Feb 2026 12:55:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772225707; x=1772830507; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OYk748M1s+aXNXFsEvtd3WtBPcm8lSLvdvOHU9p2Wqw=; b=lAk6jBdXoleV6+me9SFuEWo/fgM05iOzwV3oSsPXo5z1RH3hO+uCrltqMhusTYURds 4GgZIWWl61tI/yVQS2sT38NJ57ooY7OLTIqTXYfJrMe0W+Nie6LQotYE9HkvQoY9mNYk cIkSrpuIXWR3VXklyhtYHez8whsXE9sE2F/e1HiStZtLSYWrRIAeHRjwuTa6QYeiNAxh mcB5wDXGq4+J1AqW1I0WWfFoiArxNNZWR/vkAlW2IrRTiKt2ox+CPdYIb1lP2lb3TArG EIlmSLJELaMRncb+jpTckRf3VScJxUgPmOqqHIAv4Alu4B5PLGbyqbJhOEViOrzWy3U6 0NHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772225707; x=1772830507; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OYk748M1s+aXNXFsEvtd3WtBPcm8lSLvdvOHU9p2Wqw=; b=E0tNozLL7M3+qwIO2Xon4k3mRg2wC/AqnyPYjFyMGWy4c/QOiVHBfB/FTvnUZEtd5E HGD2SMxqFq2lsOsAahOcIFmw8kpaHf34XYQ0nbdfT6t5tvNcYQArQZxWFsfDoMSTGb7s huu2TW6SVQMPXSHAWTWLGn5aJHpqKKwuixx3ojXd0ABazF7+Ji4T5lHTTqlcCMkDJo3W RDA2IhuUsv3CDjfAo3Q1UDD09UBRw/fyvj9fBK7Z/SUKNkzM1QNPfWvdx2mENE+V39/F d7jSyppreyHF/Q/ouFncti48CxawYEgXgOUDWsgpTgUgZZiXNTyy+dSuF2Wmp5nteR3A yX0Q== X-Forwarded-Encrypted: i=1; AJvYcCV2V0YSAgVqB9sjgiSsyicr6LO+hRHlpbBCwKA2qna28hkXhVdg5BC2re6VG9aUdV+zrFGQ71T1DYiamK4=@vger.kernel.org X-Gm-Message-State: AOJu0YxliQN0XTsFZfNzptDxDFMwx3eJTL/GV/JVNkyzXDVdBFF00ZRa 1Y7X5y9XX5D2nE+ORRIk7hBVCaUy0oxpIOZrGfrQNBSo8bucv3URRYaTZpWbzkZ1FCs= X-Gm-Gg: ATEYQzwDK50rUqq17ek8TV+fcAtk4cUDdwhTw4XdqCf6Q7iotVXEaDH6DyudEKB1qe6 L07fql3Zl46mH7Q05ykgKO/U4rBOZZowbRutLzzby+Qk2UWiFf8XWEnA9b1KBshxaW8Aj9NzlPh Jdekjqu0YCDOJG9VHq2AEH7JJNSVbobEgtR+VXxxYMuPJpp07Y3AdWA66qFpkm40ryrs6vIH7WS N7S0a6p+VKRSUSlBLoAcntYTSdelSlnSNWHiIoTEmsfQrSHe3c1vZTl8O7YUK9wc8V6Gb8oq9Et lYAQzg2Z5z3l3BpYwa7WKDv9YjowIy0pH8xK1eONpPrEHEcr8E6kAz318PH9/3WwqOq1jhz/DZo qgiuP9+FUP8+kmx/l6uJsazSbQWoF5T6T9n0FEsRsq2AEetR2/CzYw7OviEjBeHSCSIPyXyAvmA GMoYxpbRpepTcLRAXm3RlDJazXo2Hk3djuOw1zWSPjugfOMrMgL9+RXfGDuuq6PTrxio1CktWd4 n1Oy31Dlr5VYTZURMx7K654 X-Received: by 2002:a05:690e:150d:b0:64a:ec39:dd64 with SMTP id 956f58d0204a3-64cc22dda60mr3473706d50.43.1772225706826; Fri, 27 Feb 2026 12:55:06 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64cb7571e00sm2805811d50.3.2026.02.27.12.55.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 12:55:06 -0800 (PST) From: Ethan Tidmore To: "Derek J . Clark" , Mark Pearson , Jiri Kosina Cc: Benjamin Tissoires , Mario Limonciello , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 3/3] HID: hid-lenovo-go-s: Fix positive promotion bug Date: Fri, 27 Feb 2026 14:54:44 -0600 Message-ID: <20260227205444.1083103-4-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260227205444.1083103-1-ethantidmore06@gmail.com> References: <20260227205444.1083103-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function mcu_property_out() returns type int and returns negative error codes. The variable count is assigned from it and checked with (count < 0) but this check would always be false because count can never be less than zero as it is size_t. Change count to ssize_t. Detected by Smatch: drivers/hid/hid-lenovo-go-s.c:583 gamepad_property_show() warn: unsigned 'count' is never less than zero. drivers/hid/hid-lenovo-go-s.c:583 gamepad_property_show() warn: error code type promoted to positive: 'count' Fixes: 14651777fd675 ("HID: hid-lenovo-go-s: Add Feature Status Attributes") Signed-off-by: Ethan Tidmore Reviewed-by: Derek J. Clark --- drivers/hid/hid-lenovo-go-s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-lenovo-go-s.c b/drivers/hid/hid-lenovo-go-s.c index a24737170f83..4596c18037a9 100644 --- a/drivers/hid/hid-lenovo-go-s.c +++ b/drivers/hid/hid-lenovo-go-s.c @@ -573,7 +573,7 @@ static ssize_t gamepad_property_show(struct device *dev, struct device_attribute *attr, char *buf, enum feature_status_index index) { - size_t count =3D 0; + ssize_t count =3D 0; u8 i; =20 count =3D mcu_property_out(drvdata.hdev, GET_GAMEPAD_CFG, index, 0, 0); --=20 2.53.0