From nobody Tue Apr 7 18:45:27 2026 Received: from mail-pf1-f227.google.com (mail-pf1-f227.google.com [209.85.210.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FAC14508F4 for ; Fri, 27 Feb 2026 20:24:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772223844; cv=none; b=c1AO+uYrzuZKlqtpQ4wuvfqoZMotiCF2DcQRDE9ucmm+MU7ygzY5+ASc5egfg9MnqwCfJ+qyyvS7Lqf+jqM/fu+j5VgULYPgrlEylZtYDGryGwa6br7b7LfwiazBJI+hRNl0y5GYQNEtDd5YNMDyjBLV1siHTXH4FVsmY/DsNqU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772223844; c=relaxed/simple; bh=pBiR297b8PXFueLy2tPMN9uZJGaoOz/0vV31TY2gEY8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sPxH/+sXRt1ed8oyiOtdCTxwkz+zbfhlRv+jcwkscCoJOvCh5W+ZbFpxLqPPb85My7A3S12m7rgiSqi+GwGBjGYh/sjQkBG41IUldnJn3eSHgyMms0YyTz4ulJASF2K1TaI6xPwgK3JOjbSX/T3TfbfIFXzAnY0HA/G8PDB98aU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=Iea0VyNE; arc=none smtp.client-ip=209.85.210.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="Iea0VyNE" Received: by mail-pf1-f227.google.com with SMTP id d2e1a72fcca58-824ba13c49eso122624b3a.3 for ; Fri, 27 Feb 2026 12:24:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1772223843; x=1772828643; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=chF3cAD1j09EpR3bM9lUaumkQDJZpAeYYRmoTp9QLII=; b=Iea0VyNEBt5PczWVYi4LbPzxq19ycIp8AgfL66mtEsjm9ipslmP4kqP5T61zu/J+V9 LXGMTHx0AzkssSO96DDO+aKsav02ZlwpX0cuW/2GnyV3D+9DqzJENbfsvQgqr7deY31q YY71WKC5HyXlt6s0MrMBbmWGu4Dye+suoViElYnLsmhQLDvGl+B0z2gkwVtiNqEIG4Tv uZJz4GSR/nGGLDjA9BDAdXR9GvRLGZRpWXcZCMwichpcJkNuOXAhI0hdyTPJZDVbUJfr iMbsVlGiIoVcDbiHZ0k7sMVTUQwbsdIlEtIPaHnAiDAYECTbIeHzyON9iL8a1J6Tg2vC VBHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772223843; x=1772828643; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=chF3cAD1j09EpR3bM9lUaumkQDJZpAeYYRmoTp9QLII=; b=Z74Vwmd4Mym5YjbGCKLOGk5MYypmaOjobtX9aBk7Qt4lrFxH0ae++m0GVTczMT7nFl FAqX9Na1kW/qRwf4/hiXMCa/A4kWn/znqoRKVlTvTxw7NsbFjpMQwOpRZxA58fIaPxOm fM2lNGChBEcKup2faJkEE0stS7AKc4mfaUkOjg9MPuZCq4XZ+VKWrZhN/JIQHLSwYz81 bJSaAO6sNljiNOgkulbpyS8zLEWh+eha040zEHS6xkIuy57XV3pOI9yCAyT1trbEWUl0 wDSvcXlL1a46LQJHEA/tdNfng6qHVXJEpoMO1nRMngxJoEAwOpn/V8E1l4fXCODgw/f9 INMA== X-Forwarded-Encrypted: i=1; AJvYcCUuI09BM9bw8uy9PHTIvpef0OxQ5bOZLpyMoow4xbkhmqpqtxE7m3eStJ7Kd+FMqLVwV5rx+DD3omqh1Ng=@vger.kernel.org X-Gm-Message-State: AOJu0YxGvlHlqb+84WmJv4oDbLgTq4FMnd8h9JuRMZ3REKjtyJM8SN3p mGvOft+mYiziuEdiveI1VA5iZ+6ljGxgV5xJ40Oho3S2osjGIl/M4VlpMlh9qwZvpzJnhsTnO+7 HhfWPO9a0w/RRu/DpHjqWcWuLrTDsHSJ07FG6 X-Gm-Gg: ATEYQzzdqD4+IuLnEYUgWCozuaSw0JUmw8+vAjGJMsyOgyjioMJiTP0D0JDBM0Hy6E8 PIjiRon0qaOVZU4kxkcLk4H6/UN/xuFOCEIiOG5SXYo2+dw51CY8jrD/xxj9MNTMUi4jXx5MQdL zq4POv7NYF5RVXnPmJRLAblkj2xKjOTHhelNqAykNqf224X/13hEI6lLyAeX7WLgZz2JT9LX3aH c3itP17wIgzegjt1v0fh2sh4aaaxhbVhJwydz0ZjUlss1g23uJFW6wqdnhx1uz37pD+QCJ3L1Me ROYnRm3U17bJwGxhaaTx+XGQlj73/45FJgdXrtCFnbCnxGLntLRc+NHrtKlR2gZ9/fb8NjWFF34 4kRKMmFBcnrQoGUjldU4jZ4kAjskbXMXxVWRyLleUNhxaYHqLM3PVGg== X-Received: by 2002:a05:6a21:6d88:b0:38b:e7ca:9517 with SMTP id adf61e73a8af0-395c3b422bamr3131161637.7.1772223842730; Fri, 27 Feb 2026 12:24:02 -0800 (PST) Received: from c7-smtp-2023.dev.purestorage.com ([208.88.159.129]) by smtp-relay.gmail.com with ESMTPS id d2e1a72fcca58-82739d70643sm670497b3a.3.2026.02.27.12.24.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 12:24:02 -0800 (PST) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.112.29.101]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id 5A9693422C9; Fri, 27 Feb 2026 13:24:01 -0700 (MST) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id 543BBE420D8; Fri, 27 Feb 2026 13:24:01 -0700 (MST) From: Caleb Sander Mateos To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Caleb Sander Mateos Subject: [PATCH v5 7/8] nvmet: use NVME_NS_FEAT_OPTPERF_SHIFT Date: Fri, 27 Feb 2026 13:23:52 -0700 Message-ID: <20260227202354.1012322-8-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260227202354.1012322-1-csander@purestorage.com> References: <20260227202354.1012322-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the NVME_NS_FEAT_OPTPERF_SHIFT constant in nvmet_bdev_set_limits() to set the OPTPERF bits of the nvme_id_ns NSFEAT field instead of the magic number 4. Signed-off-by: Caleb Sander Mateos Reviewed-by: Christoph Hellwig --- drivers/nvme/target/io-cmd-bdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd= -bdev.c index 8d246b8ca604..d94f885a56d9 100644 --- a/drivers/nvme/target/io-cmd-bdev.c +++ b/drivers/nvme/target/io-cmd-bdev.c @@ -28,15 +28,15 @@ void nvmet_bdev_set_limits(struct block_device *bdev, s= truct nvme_id_ns *id) id->nawun =3D lpp0b; id->nawupf =3D lpp0b; id->nacwu =3D lpp0b; =20 /* - * Bit 4 indicates that the fields NPWG, NPWA, NPDG, NPDA, and + * OPTPERF =3D 01b indicates that the fields NPWG, NPWA, NPDG, NPDA, and * NOWS are defined for this namespace and should be used by * the host for I/O optimization. */ - id->nsfeat |=3D 1 << 4; + id->nsfeat |=3D 0x1 << NVME_NS_FEAT_OPTPERF_SHIFT; /* NPWG =3D Namespace Preferred Write Granularity. 0's based */ id->npwg =3D to0based(bdev_io_min(bdev) / bdev_logical_block_size(bdev)); /* NPWA =3D Namespace Preferred Write Alignment. 0's based */ id->npwa =3D id->npwg; /* NPDG =3D Namespace Preferred Deallocate Granularity. 0's based */ --=20 2.45.2