From nobody Tue Apr 7 18:45:33 2026 Received: from mail-pl1-f225.google.com (mail-pl1-f225.google.com [209.85.214.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E90C344D695 for ; Fri, 27 Feb 2026 20:24:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.225 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772223844; cv=none; b=Ff31YnZmmD5mO89fAtbTdSHzqFEL3wYMw787EbItmYCjTXhOgYQBQNN+7QTp91R6c27DAPwwbl1hBXfhZcEXOopX1cXMRzN0deFpbHnBRdiJA0qaaBB+z1xSAw2B4PAi46yOhheQWmMdfxWqWYBxcBpwof8soOmGHQewIrXCD34= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772223844; c=relaxed/simple; bh=rEgUCflMnbP+oeHSg611GJ51AOMqm3sC9AviUd3En14=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gOe/6ZjGgGrC8EPslSdREYIVwrPLUIGEI9IK6CUMzQ1FSUdSO36sQBPdLMfhgRCKOImLd6IvXkleKQTLYZZ8huRX5LZ2wyMkCFKkG5CWwqKW9ETLmFwY/gUfKjv6GKdjY/7XgBB8SPTi6ElpAwosxlr84rp9VdBbzDQp5sOa2oU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=ANgIqAN6; arc=none smtp.client-ip=209.85.214.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="ANgIqAN6" Received: by mail-pl1-f225.google.com with SMTP id d9443c01a7336-2ae3a007bd1so20775ad.2 for ; Fri, 27 Feb 2026 12:24:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1772223842; x=1772828642; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lG8nfg+ASIKQ9CbyoNXjrLj+myT10j8TFxZs8gb+75o=; b=ANgIqAN6wlGFvpSZlpia95mQqlcsb6eDAZNoBVos6YzGuqMgtG2jHEst0+Ddwmwao2 hxZ9hE1VLmleGnjkNY4oF/pBTrLl9SPrYbLqx27RqZiYnMGJ2sZbvWqT2JMcn8S9Jbcq ty0UqB7gXaG0YenH7m2/27PmOJ6qdi3Ke6e4iUztZBzhFvRtZgMIiIzlvyZPQI4qa1Ir k/3iDxcAKXMeTHFmaisNFP609PWBez5Z2UYcfCTrkCrEKJhV2NAMpLct0O6xLUK+x3Jr H7QElx72ziPWjvBmGIQ92B2p+ZnzelE5B9H6BKYm6FGq2d+GPXbeGiSmEJTqs7qapJsZ mFig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772223842; x=1772828642; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lG8nfg+ASIKQ9CbyoNXjrLj+myT10j8TFxZs8gb+75o=; b=JO9AaMeNpxwg67vTRbb8Eb7+mwpKE5E+Zje2iBMYoZlupU6LJSH0RiIsuqxN3dKFz1 lgotWp07Kb3sV9fO8bXw6WLUwE/9iEfruN3wYoWtj6z3JxuVvO0TPuRrBENg5XY/4Cd5 T+D3rJ/s3IGsOR9XYls2ABK4oX6UuTAX/H9N/MmX5uORyRICQkxFS7uT1ydIEhwIvKQr JLU4o1kcn3VkGOHJu0DW0RxlxFh9kooxhN+sCcjT7HfVEwM0MoMfw65l7Lru1pjzqjbg p5dPoH8fu7JMjNqiMb0Xj5FQ8Y2BOhrdaxdvAah5hJ/DLdcLVrxnn8rjpbV62Ct/QPw8 69/w== X-Forwarded-Encrypted: i=1; AJvYcCWRiYul6XxnBjr0q78njafyRBIvb87ywnSB3wm7IuOQryic6St7GOq447qIb2eaHWfcrGrX5DVZS7MMxdE=@vger.kernel.org X-Gm-Message-State: AOJu0YxqK5IQPcKI5UUwPDm0EXmTsnG65iJutArsBSdLZxzqhylvKpmf uXUsUM/UBfTB6RocqLQy8E28OedYM+ughLZg4A5GDGz9fbKBgsPpngVfBSkc9z1JBK0qdKzg50Z CmJpLs/Elw21qca5l4TZO+BSMciNQ87tz3SnhW7eelyY9Dk9Grsdi X-Gm-Gg: ATEYQzwQdkvx35ETk8Ib7btfQ4cM1NWVCIF1Av7XaPiQmz+I+5IDValkDjQ23CvWsrJ 86vEAbmglgDEFRG40jxlOcD3WVp9FtK8blsOTTnIn09wW7XN0HPob5eot01HPb8KFtS+hlk8+tz dRj77CHQE/XC6FELvXN2iRqUH/FgJljWk4wg5W8jvB12bwu8cfBuL5EgjZPxk1qbQ/3EdqUnjue iA826vhd73RL74ITFoX4VgCpqZnm5qzGibqfruZMuGtyfKapN5dExwMyOMujXRkxpEguy7PCP/n dcNHZOuhKjUwqShqzpHdXdi5j4ruuVx4PM5kIJmFreW+1TnKdmnOLKbtIH18Auo7BgeKAKNlcVY AD8kRYd1m27qIHiykr3BLh3pGVFurJh/JAbDCZ6g= X-Received: by 2002:a17:903:1c2:b0:2aa:df82:ed85 with SMTP id d9443c01a7336-2ae2e3e3cbdmr29408695ad.1.1772223842360; Fri, 27 Feb 2026 12:24:02 -0800 (PST) Received: from c7-smtp-2023.dev.purestorage.com ([2620:125:9017:12:36:3:5:0]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2adfb5fbd8esm7393695ad.47.2026.02.27.12.24.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 12:24:02 -0800 (PST) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.112.29.101]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id 0D1E3342295; Fri, 27 Feb 2026 13:24:01 -0700 (MST) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id 05ED6E420D8; Fri, 27 Feb 2026 13:24:01 -0700 (MST) From: Caleb Sander Mateos To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Caleb Sander Mateos Subject: [PATCH v5 5/8] nvme: add from0based() helper Date: Fri, 27 Feb 2026 13:23:50 -0700 Message-ID: <20260227202354.1012322-6-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260227202354.1012322-1-csander@purestorage.com> References: <20260227202354.1012322-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The NVMe specifications are big fans of "0's based"/"0-based" fields for encoding values that must be positive. The encoded value is 1 less than the value it represents. nvmet already provides a helper to0based() for encoding 0's based values, so add a corresponding helper to decode these fields on the host side. Suggested-by: Christoph Hellwig Signed-off-by: Caleb Sander Mateos --- drivers/nvme/host/nvme.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h index 9971045dbc05..ccd5e05dac98 100644 --- a/drivers/nvme/host/nvme.h +++ b/drivers/nvme/host/nvme.h @@ -760,10 +760,16 @@ static inline sector_t nvme_lba_to_sect(struct nvme_n= s_head *head, u64 lba) static inline u32 nvme_bytes_to_numd(size_t len) { return (len >> 2) - 1; } =20 +/* Decode a 2-byte "0's based"/"0-based" field */ +static inline u32 from0based(__le16 value) +{ + return (u32)le16_to_cpu(value) + 1; +} + static inline bool nvme_is_ana_error(u16 status) { switch (status & NVME_SCT_SC_MASK) { case NVME_SC_ANA_TRANSITION: case NVME_SC_ANA_INACCESSIBLE: --=20 2.45.2