From nobody Tue Apr 7 18:45:27 2026 Received: from mail-pl1-f228.google.com (mail-pl1-f228.google.com [209.85.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB3DB41C2ED for ; Fri, 27 Feb 2026 20:24:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.228 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772223844; cv=none; b=ERY70FI9csnqiO2GwqBzhbitSnKHgRI3jQYBZNWkoJ6YCLy2K2De/eECoLgqatL8e4LJxHAMhaKlTaPzdCVCIc/ULGD0g9UA7VgYbEF+nzgCrbueJGMcIbhuF2co5e7c8UABH+RPkp9kA7epSf/4RsI73oj3dcqdiARbP3JRZ6A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772223844; c=relaxed/simple; bh=EVgNL5Ff+LgS27uDkBNGv73Qt0PWL7UobTeI9pnCh4g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OBTossrOwjUrqhBd82Fmap1VRt48vs0giwmF8qf+jCmxmP5GpEpqdt6E/a3puwdNQeiAlgJdZwi9JDt5z9+xjpIbIf6k3EdVmeHJdi9HCSy7zauuOFCY7E+li/0TuIj2/f5/D5reU+/UlMdo/DFc4IXaW32d41x5oZE/eNPzNX0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=OWxgYPon; arc=none smtp.client-ip=209.85.214.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="OWxgYPon" Received: by mail-pl1-f228.google.com with SMTP id d9443c01a7336-2a3e79fe2b8so3119975ad.1 for ; Fri, 27 Feb 2026 12:24:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1772223842; x=1772828642; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4pe4RREd+BTPRgbiC807YGAMUFduYLhwjMogn+PjJEc=; b=OWxgYPonLZ3LU2F/3JVakxflZRrlepaLXW+IMCAzNC6bfMFXL18IxqtBzjsgn8ptxk ncm7mX4tOqqAWZG0kKJkmXcfPuxy3DbvxNqGwm453RYqrMRSufdZN0x6kdM/ALs5r8Ws TrgBdc+JkvVwvRqLMFdLjXFpZ4RuXEjsaCZMJ6+MV4xy3Wq0AryUrjIlRROvb07OS3cs QmaV0DH+n6da0yS4jNjZp5aV3uS7k+xnVEmo1rUJYX+jqN2e+nE+BbDUpC7H0BzRrlOK v9au+18M0l7bCianfyao6rA4LmGWzKSjGLjzFqKQAuHl01s1B0h7clxJFZm2beCoXAbk npQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772223842; x=1772828642; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4pe4RREd+BTPRgbiC807YGAMUFduYLhwjMogn+PjJEc=; b=NzBaSI1xc+szVQeUVXD60Qw2LiMhBMsyWqUvvU/lYoleuUIaf81xkb0Jr9311GpHTQ w54nlFq/5+JTEOPZvmFhas60IG2oDa80gN7R8zfS8gVhHL8IQOf9RTwVzlwbx/aXSX4p r/d16zpAdOYyaQmZbujrcQJpWUsQmg1RZ1ZG2aNCtRmQIZtZBCgFxhTKbPeALyAaVw6R aoElOPqzViwMr0S69XupjqpbRoEn4hEiVhRMOweiilcts0pewpOTH6HY22Gey52UWNtM Wpg6S/jQ7fsTzAoMs5HvmGbNrHNrNhdw1uzpkb4LPnlLFYCVlH0v1S+yG2PUd52CwOWn b+zA== X-Forwarded-Encrypted: i=1; AJvYcCVlSNNpLBt8cXE610DOKtC4Fja+p996iqHmhQAtt9uKz22Dqe0vyYBZApv/uCQSe1zrs2ZYHygEDgEZrsY=@vger.kernel.org X-Gm-Message-State: AOJu0YzIK2c2u72DdvyhQgfHyFXwhi5b7gAfGypIfSEeJiAxxkUq5KAa ZA5vF4GjnJHssO4Wihz9d1z9x6rpFOaJVAfsvh9O/OcID/HlGnZKjwh0GQlOrgnyp9GkjtFCnZE RwmjhNC6w17+mL1oqNbsd3h/Y+caADSEG0joXPo1yCpjQqcqe2wFQ X-Gm-Gg: ATEYQzwBBVFveUXFeaCIp/QyCUWwDNqVn50Wlii2uEC59qRCDxixd+XCEfd+pSy/T2N iNdWU4Od/qUosL9dLYCp2KY5+qR95AIPbeogMJcq2O9pe2exwxBN7/X6fzWdCGqCw2kN1O8+gO/ 1a0Ieg6lY4iKZrAaEY597FHwo3RPpnlDnUNszXI7uHEUoidPEF+QrC/qwRblaqI7ZXRc01IQiMX xsz5JfFIirvHEIxnR4vaVSVdix1TirRt6R3XUBJcXbkuTjabINWyLDFSEXLHGPPtwWMiI9Qwh+U dZXafTejQF39U+aJFIJEowl0dN+QNQTCrGy0isPWm0Hxpd6BBdtySscHLnK5tvsUHiAJtXI4sZF NBjlraqC3lt513BECkcP7C+nhHJJV3ZBirFgO2SQ= X-Received: by 2002:a17:902:f650:b0:2ad:e300:df0f with SMTP id d9443c01a7336-2ae2e4770b7mr31860275ad.4.1772223842043; Fri, 27 Feb 2026 12:24:02 -0800 (PST) Received: from c7-smtp-2023.dev.purestorage.com ([2620:125:9017:12:36:3:5:0]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2adfb267621sm7698445ad.20.2026.02.27.12.24.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 12:24:02 -0800 (PST) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.112.29.101]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id D8870342243; Fri, 27 Feb 2026 13:24:00 -0700 (MST) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id D3EB5E420D8; Fri, 27 Feb 2026 13:24:00 -0700 (MST) From: Caleb Sander Mateos To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Caleb Sander Mateos Subject: [PATCH v5 4/8] nvme: always issue I/O Command Set specific Identify Namespace Date: Fri, 27 Feb 2026 13:23:49 -0700 Message-ID: <20260227202354.1012322-5-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260227202354.1012322-1-csander@purestorage.com> References: <20260227202354.1012322-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently, the I/O Command Set specific Identify Namespace structure is only fetched for controllers that support extended LBA formats. This is because struct nvme_id_ns_nvm is only used by nvme_configure_pi_elbas(), which is only called when the ELBAS bit is set in the CTRATT field of the Identify Controller structure. However, the I/O Command Set specific Identify Namespace structure will soon be used in nvme_update_disk_info(), so always try to obtain it in nvme_update_ns_info_block(). This Identify structure is first defined in NVMe spec version 2.0, but controllers reporting older versions could still implement it. Signed-off-by: Caleb Sander Mateos Reviewed-by: Christoph Hellwig --- drivers/nvme/host/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index bff6f26d7bcf..c3b24fcb2274 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -2352,11 +2352,11 @@ static int nvme_update_ns_info_block(struct nvme_ns= *ns, ret =3D -ENXIO; goto out; } lbaf =3D nvme_lbaf_index(id->flbas); =20 - if (ns->ctrl->ctratt & NVME_CTRL_ATTR_ELBAS) { + if (nvme_id_cns_ok(ns->ctrl, NVME_ID_CNS_CS_NS)) { ret =3D nvme_identify_ns_nvm(ns->ctrl, info->nsid, &nvm); if (ret < 0) goto out; } =20 --=20 2.45.2