From nobody Thu Apr 16 12:27:01 2026 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0E9A44D02D for ; Fri, 27 Feb 2026 20:07:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772222860; cv=none; b=C9yTb0PsmLbpqo7/ZjuZvYXdtiPkXL1cdp+4mnGJTPHEoPuptTMVn0KXZsG1eLDsL0iB/HP3dsI8MVtdR/QLoJkV8cmdId3ysQKx9lp36cmFFyT8xPjX7lrkIZSnZQdRGmFg39QkfS4XGlLwzHmsNUq2jYz4ANmfFhUKEUJP/I8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772222860; c=relaxed/simple; bh=HDor/PBZ2JeNLNdh+Uqn6EAndE6TwQGCM87QxWeBZ/8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=kfMsGqM3+lSorS4Ym+YZVhAtplmsTEF3QWj6UPl4DDNeEXdUm0l3Gm7+Y/J9A+VjxOuzwhQb3fDMx38paJvw2EI1CvmlYEAR3fQriD9bYZ9TB18IOhFrj3E5Oi4gL91yGxwBbIOUm6pm9n1ccppRo66kQd3n0HIWMkggAJMD8AM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mjWF2wsd; arc=none smtp.client-ip=209.85.128.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mjWF2wsd" Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-4833115090dso24447485e9.3 for ; Fri, 27 Feb 2026 12:07:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772222857; x=1772827657; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qv/8o16ZJyxqWqCxAnZXzWbbfeTw2X9izfBMExBRzt4=; b=mjWF2wsdFW7hip5nVYztF86BzPl8cl9eDEgVN2HuoEY95UFDPZNFWUfFoycdac95LG Z5LhOpUKM8Bg191FeIGJGArszMDv7XBYAdCd63w49frfUeFauSUXD24aeppdcF8IyY0y g3X1AvhPYarMKLRSWXpaRKzemSJMmoC1ntivkN710Z86HHID/3dAkSxNdvl0t3V66cBi /kT5MlZ5tK27bTSrMWlTWSZxTYn8Qi6LOW400aIrx4OfzqVVXQAwAdPv3I0MduU9eupc miQQn7zdQ49lYcg73g7byvSHBW0Ej0oaZ3E+BUpR63nWuP0IkXjCM7rmqlcSiGYfWho0 jXYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772222857; x=1772827657; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qv/8o16ZJyxqWqCxAnZXzWbbfeTw2X9izfBMExBRzt4=; b=N7p1V7dTUfkXnDZrHlMxcPpxBRSlYKL+ylYfDeFdmPq/gjUjczuI5owmkKa42lAHZG 2LyPvn89EbG84KpbEgYj5Ig6RrCRYjSsrhvPYHSjg1EZZU9HD5/3wA6WoqHX0O6yId2k 5X41LerwtJoOaSzeUJNfJ+1Z71evj2VViy3xC4pzuu8AWAopnR36ffKedG4A+K1OqHQC j1/KI6r0HPmVceOrjEhyDntwEGjoMg9+rvB+Dk3vuwAF2EV+ltAsWtXDSmqWrp0DAGeB EM4eMf7G63QFMwFgrcFr7dJYLvon0GBmbp/GfTC1v61xf6Hwo3DRCHCJFnIZm9uKASj6 x9FA== X-Forwarded-Encrypted: i=1; AJvYcCXW8S4y/FQEMZKvYRAC90f5YUcM9F60iVD62xCKDip72sHThJYLtq9czunaztALLa5XU/iH5pEpoyjOK7Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwofHoeGlYtwEON8OCa3A2JzXOOwuK7eyXnxt4og439f5NQ7FI9 7yMz20NNZrAU4Pc45KqUJdhT5JPo48+TemtIvx98PhniwGkoB1I5GEFnOBPakIxJgeM= X-Gm-Gg: ATEYQzyu12dfVWMV/bo/7Eeb2seb0AUuglaaxSUADz8ygI+Z2JvigKQYqqGb/AYuA0l BcNXfbKS1iczjXhxjqymCW1EYWJqIn1VyrFoIuZH9dy2ZtyLOdyDIbF7JpWcQ5hNFR1RrWQAuWC ZEtMS05P9+3QQnRxu21WxiNPZS5wMXwEw8Ny7NwO1pO34KlVRjkcyGTj47Pthl2EpKPA+1juxaC Cvn72FlyLSXlRMpME5JeyUaLPa4MfqX8875sSf2HlTViXsuJj/Bxi8i6Z5FkFkMzMaAAq/G7vpV WLzkzB01UHbQu8EbNwnBzV5tZ148Esw+69gItNrG1M5FCj3pd1QhvoTIjZRneA1wfmD+Q77IyO+ J2f3gWuF3fr6SET2ASdc/OqS7vj5OTijz5d2pt+gsu2zqY1iKBBs2jVRHranFhIjWQUb+ugq7G4 E5o29zv/9j2TROFdv3NFuVdewENS7GRFT7FfUO X-Received: by 2002:a05:600c:3b9f:b0:465:a51d:d4 with SMTP id 5b1f17b1804b1-483c9ba7e4dmr62806435e9.6.1772222857080; Fri, 27 Feb 2026 12:07:37 -0800 (PST) Received: from BERA.localdomain ([31.223.72.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483c3addb3asm133845525e9.0.2026.02.27.12.07.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 12:07:36 -0800 (PST) From: =?UTF-8?q?Bera=20Y=C3=BCzl=C3=BC?= To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, Yeking@Red54.com, hansg@kernel.org, andriy.shevchenko@linux.intel.com, ethantidmore06@gmail.com, weibu@redadmin.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, =?UTF-8?q?Bera=20Y=C3=BCzl=C3=BC?= Subject: [PATCH] staging: rtl8723bs: change custom comparing function to memcmp() Date: Fri, 27 Feb 2026 23:06:37 +0300 Message-ID: <20260227200637.47130-1-b9788213@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable eqNByte() function is a redundant reimplementation of memcmp(). Remove eqNByte() and switch its usages to memcmp(). No functional change. Signed-off-by: Bera Y=C3=BCzl=C3=BC Reviewed-by: Andy Shevchenko --- drivers/staging/rtl8723bs/hal/hal_com.c | 12 ------------ .../staging/rtl8723bs/hal/hal_com_phycfg.c | 19 ++++++++++--------- drivers/staging/rtl8723bs/include/hal_com.h | 2 -- 3 files changed, 10 insertions(+), 23 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index 31b3e880ae6a..a7720f821823 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -750,18 +750,6 @@ void SetHalODMVar( } =20 =20 -bool eqNByte(u8 *str1, u8 *str2, u32 num) -{ - if (num =3D=3D 0) - return false; - while (num > 0) { - num--; - if (str1[num] !=3D str2[num]) - return false; - } - return true; -} - bool GetU1ByteIntegerFromStringInDecimal(char *Str, u8 *pInt) { u16 i =3D 0; diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/stagi= ng/rtl8723bs/hal/hal_com_phycfg.c index dc2da49e6738..b5ba3eba597b 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c @@ -8,6 +8,7 @@ #include #include #include +#include =20 u8 PHY_GetTxPowerByRateBase(struct adapter *Adapter, u8 RfPath, enum rate_section RateSection) @@ -819,27 +820,27 @@ void PHY_SetTxPowerLimit( =20 powerLimit =3D powerLimit > MAX_POWER_INDEX ? MAX_POWER_INDEX : powerLimi= t; =20 - if (eqNByte(Regulation, (u8 *)("FCC"), 3)) + if (memcmp(Regulation, "FCC", 3) =3D=3D 0) regulation =3D 0; - else if (eqNByte(Regulation, (u8 *)("MKK"), 3)) + else if (memcmp(Regulation, "MKK", 3) =3D=3D 0) regulation =3D 1; - else if (eqNByte(Regulation, (u8 *)("ETSI"), 4)) + else if (memcmp(Regulation, "ETSI", 4) =3D=3D 0) regulation =3D 2; - else if (eqNByte(Regulation, (u8 *)("WW13"), 4)) + else if (memcmp(Regulation, "WW13", 4) =3D=3D 0) regulation =3D 3; =20 - if (eqNByte(RateSection, (u8 *)("CCK"), 3) && eqNByte(RfPath, (u8 *)("1T"= ), 2)) + if (memcmp(RateSection, "CCK", 3) =3D=3D 0 && memcmp(RfPath, "1T", 2) =3D= =3D 0) rateSection =3D 0; - else if (eqNByte(RateSection, (u8 *)("OFDM"), 4) && eqNByte(RfPath, (u8 *= )("1T"), 2)) + else if (memcmp(RateSection, "OFDM", 4) =3D=3D 0 && memcmp(RfPath, "1T", = 2) =3D=3D 0) rateSection =3D 1; - else if (eqNByte(RateSection, (u8 *)("HT"), 2) && eqNByte(RfPath, (u8 *)(= "1T"), 2)) + else if (memcmp(RateSection, "HT", 2) =3D=3D 0 && memcmp(RfPath, "1T", 2)= =3D=3D 0) rateSection =3D 2; else return; =20 - if (eqNByte(Bandwidth, (u8 *)("20M"), 3)) + if (memcmp(Bandwidth, "20M", 3) =3D=3D 0) bandwidth =3D 0; - else if (eqNByte(Bandwidth, (u8 *)("40M"), 3)) + else if (memcmp(Bandwidth, "40M", 3) =3D=3D 0) bandwidth =3D 1; =20 channelIndex =3D phy_GetChannelIndexOfTxPowerLimit(channel); diff --git a/drivers/staging/rtl8723bs/include/hal_com.h b/drivers/staging/= rtl8723bs/include/hal_com.h index 74d6c892c401..483f0390addc 100644 --- a/drivers/staging/rtl8723bs/include/hal_com.h +++ b/drivers/staging/rtl8723bs/include/hal_com.h @@ -141,8 +141,6 @@ void rtw_hal_check_rxfifo_full(struct adapter *adapter); u8 GetHalDefVar(struct adapter *adapter, enum hal_def_variable variable, void *value); =20 -bool eqNByte(u8 *str1, u8 *str2, u32 num); - bool GetU1ByteIntegerFromStringInDecimal(char *str, u8 *in); =20 #define HWSET_MAX_SIZE 512 --=20 2.43.0