From nobody Thu Apr 16 12:27:29 2026 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBD343E9F95 for ; Fri, 27 Feb 2026 19:44:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772221499; cv=none; b=Eet5WXfi/zrztfWlj+Ps1NxnATG5W54rnSbuCDTV+jGf7xcI8kxh0E2zv95BOuSP+nT+SJdd7ZfbMsGZcdZio2WjpMUE4jSpXgAzDby1qoYcj1xlji6XTvvk+3fzqYA77LLR6tQz1qOCbxqoqFBXSwuCNz9MSqmhZ7TTvBXyK08= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772221499; c=relaxed/simple; bh=sGukunZf/yiMmIshCxlQIMKg/jvcuH6/Gbp7DaGc8JE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=n21PEG7sXtsPq9xdfghWfnMQSm0FJJ3TGVmEl257F6aN/OalKI23sApaXNHQHFdz/UNvMCBJYV0Aixy87FwnhVl7oDbhxWCTyd8oUbFmzoyndnACo7JBaR2mTIzEm9mcxAyh2Q1YqS3B9m3ygUGRzwCFfLU9Qv8/dVE71r3jjos= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=INvDwP7d; arc=none smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="INvDwP7d" Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-7985d11da10so26152277b3.3 for ; Fri, 27 Feb 2026 11:44:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772221497; x=1772826297; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qfiXw09aKYFd8mOuaxrb+P18U9WKXR/TPhCnApMgZ/s=; b=INvDwP7dBVCk8AhZp/EVu8xwH4jKFR8oxHhhOF8M2cPfK2AwP7mwzIfPXEDWbQ2Fy2 TNM/RU+OAa4XwgwQIxfVV76pe0VDCmnTdJgGJcZOYCdD+L4G4Cc5FpttmAD40sGW1PqL 7puX6OtiLURYV1S5otWmgbLQHMC15k1Ly59LNYddsQ/vb2A+7OcTJZb93l4YQ92kauVM CF5V+VpH2kjS4Ieg10NT2xV0kQvwzC5ip8684T5dRlSf3WdKUzUomaqYvl2D0A+5oVM8 klnNY1KBjnE92ciDQA5EjxCL3w9O/jNo3atJ+cE6foZaEVs9ya7ipb00SLSud1jAACfI JhRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772221497; x=1772826297; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qfiXw09aKYFd8mOuaxrb+P18U9WKXR/TPhCnApMgZ/s=; b=M9dArcW4tl2ZmaozgE8NaC5uAM+ks+yoZ3F7XRF1LZWjZvqHfmOfU2fbo0IkmT/b9O 4Z+li8yYgCfhnVU6noDWx1if16pQwI830oY6yru8TKezbNvwuzxV32lRdASs779Zurtj EaFlX+I0dWno87A13/NxzNxFoOCuqf2f5DxLswIZjgWdoOjkEmIJzotxWuFVc54n9EvS 0fc1+5cvOGiCAPECpBs8zfGLzO6a9gKkcBDWYygo/laC1ildCuG28IRWVJEyzRQO/5bB UTZYPmRhI3BqZjfvfQSKTIQLscXCGqPPKbP984e9TQW2HIxXcCTLv+qZLUQnJvTIYSI5 88FA== X-Forwarded-Encrypted: i=1; AJvYcCVT8v2ojTrzhvo3KLDKIeSF+lvrQir42ZOrH7xgmTi+EYdf6uIsKxTF0xIXyL/WJfDWI6uuAtGHAhrJpYo=@vger.kernel.org X-Gm-Message-State: AOJu0Yzaxlt3D7FgKYm/fROz0AXmWjZgXfS4JSXf6AEYunChze8fwD/S lkhjzjkT6F5Np9XpIbPz10qVrNUZ2x16oK6BbXUD8RmQNJqnM26SN5ctvk7wj0IrmI8= X-Gm-Gg: ATEYQzxUAre9rBcEkKP7+Rrw4/DEYvl/e4wHRWLEzebFtgwvN0hzSNqg/Z8OUAJnNkb gVXIoaCoq7kjQdVkEz2CrCd7z0Xwpb1AbifweYTm9CgDTEGgBV4e22Fbz6pKbizgfmczy7sT6y+ aXgVuu8H6emMj1hOmNrrMEyVnhBXGIVDVIrxxsPHkd/yVDOW57/0yixmbq1ZMHSNY2vmM9DGJhf fzcecO1OrHwaZ2YjhByg0rxEu5B5st4NuWAx6n2ovLtE/fX/NHB6Tu6vwHkz4ZbOFySbr8zfXn3 Ns6xinyE/P5Fm2+9O+CEpAT1hehUb1bzeJc8J+P2gLWv5/QepQcTs3k14h//8zvqybfnSk/eHGy QnpH0lbWJKxUijagVyvwCZQ8UFahFIMrc6eZZxhTwoXocBDs2Lju6dNMUcPOCANpSxkjDIW/QeI LljF8FywcOVYpMiKsb6ZFyC4DB X-Received: by 2002:a05:690c:dc7:b0:796:6da9:bf97 with SMTP id 00721157ae682-798855bd4a2mr43885187b3.43.1772221496705; Fri, 27 Feb 2026 11:44:56 -0800 (PST) Received: from ubuntu ([76.38.17.53]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876bf9449sm24829997b3.28.2026.02.27.11.44.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 11:44:56 -0800 (PST) From: AnishMulay To: rostedt@goodmis.org, mhiramat@kernel.org Cc: mathieu.desnoyers@efficios.com, linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, AnishMulay Subject: [PATCH] tracefs: Simplify get_dname() with kmemdup_nul() Date: Fri, 27 Feb 2026 14:44:53 -0500 Message-ID: <20260227194453.213095-1-anishm7030@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In fs/tracefs/inode.c, get_dname() allocates a buffer with kmalloc() to hold a dentry name, followed by a memcpy() and manual null-termination. Replace this open-coded pattern with the standard kmemdup_nul() helper. Additionally, remove the now single-use local variables `dname` and `len`. This simplifies the function to a single line, reducing visual clutter and making the memory-safety intent immediately obvious without changing any functional behavior. Testing: Booted a custom kernel natively in virtme-ng (ARM64). Triggered tracefs inode and dentry allocation by creating and removing a custom directory under a temporary tracefs mount. Verified that the instance is created successfully and that no memory errors or warnings are emitted in dmesg. Signed-off-by: AnishMulay --- fs/tracefs/inode.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c index d9d8932a7b9c9..86ba8dc25aaef 100644 --- a/fs/tracefs/inode.c +++ b/fs/tracefs/inode.c @@ -96,17 +96,7 @@ static struct tracefs_dir_ops { =20 static char *get_dname(struct dentry *dentry) { - const char *dname; - char *name; - int len =3D dentry->d_name.len; - - dname =3D dentry->d_name.name; - name =3D kmalloc(len + 1, GFP_KERNEL); - if (!name) - return NULL; - memcpy(name, dname, len); - name[len] =3D 0; - return name; + return kmemdup_nul(dentry->d_name.name, dentry->d_name.len, GFP_KERNEL); } =20 static struct dentry *tracefs_syscall_mkdir(struct mnt_idmap *idmap, --=20 2.51.0