From nobody Thu Apr 16 12:31:04 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 493663A1A5B for ; Fri, 27 Feb 2026 18:50:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772218234; cv=none; b=E1vWM6+f/xPAWO14lq64weU4akc4wrs60s2GPni71wxPi9fFVcory8jAwL5QNfN5K0/SOW4AmR+HUbHPB9dUKELOirkawvimqVl0FpddKtzmQaEE6ouhJ1cVE5mkA8+S8o86cgNbKEXNgYc9/dq6vLl5AmouHOCzQ7ELMtSuHh4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772218234; c=relaxed/simple; bh=l5F3e0YPzrTIIwQbcsoOk+4QMaUJcF5q/SEmSsYPKNs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o9a1Pdeji4zxZH2DR9ERK4QRZUFHfRpW3hKLKVf5Gya5uf/B8GRZOr9GHpMxf8hOQvIWwis6E6W3Q1HKWbw7YphqjCr3R97W6DQfand0ULu3YoTvvUT2kTzFxZQXGslCYpmhF+iY06+mOD9KSADhJIyKYJ/W1reHHP8XAM9uJAg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RpA8m9TN; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RpA8m9TN" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-35621ce8a9cso1129570a91.1 for ; Fri, 27 Feb 2026 10:50:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772218233; x=1772823033; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2zSA6ggEX7RI5uK0hoklNltffsPuuX0XWMQrcz7Ii24=; b=RpA8m9TNF5sem+IKIe8Dd/EpdkZ/bSGoq9sYbPUPx1VXidTHlfmdANUekquEktL5sL pGDX1avB8YfOqAZQL1P0GjqccDI182Gic6lnkDyTlDwLs1S3xKKMa64p8dc/7UtiJMeG IGUEziI8pCAy3cgP2k4zFdIqOFXhz2fPKyxVuf5Sn++r9VgiP8VdQMAsWEMm1eq9/v4u 7VIkYwPckC4HYkXFSENnsCkfh2mB7dkQZ1ILA4WIp1v89Owu1HdsHGtbsTRoyftnHmK9 KL8RYxsCToYSWKkna7e0FkNHjk/vyh1aLbAAi0ZiZCaIwZDHCE/XwwHEeCqP3+NxLGiv dEfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772218233; x=1772823033; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2zSA6ggEX7RI5uK0hoklNltffsPuuX0XWMQrcz7Ii24=; b=Pda6NYOL/8iefBomMIIlTBLFOCMiPihMTNtpojy2mt2JGk/wEDNCAifK31XJrppUPe K2+96aL8gvBg46E8LbAgZqpRKMl7xuEzZ+1WPXWNOCrbqHugw0GA4L/mWDZaK3pS0GVU JfLbkRLG1NQwVfhu8IKww5zxKDSe99FOPEuQDOgNNJSDsjDpRZAnWomjB1S3gSoEcdFA kRdwdZtBMku7cPypS1nh+O9VDNx61tXergVMCuJHTFbVyBZFk3a9+/rl//icjtCNom2G /s5iDvYrH3OMaGa95Bi9wIJb5zWyNIls/uaN33Od9qybFj/Z3NaW652VCQXwsSCTV+Hz eBuw== X-Forwarded-Encrypted: i=1; AJvYcCVf2isxZejUPKi7nMdeR+2onwNaNpXS65XrmB33AwWsC2basBBIN1l6M4ogGZ7hsl9v8dGtkAIRhAYItqU=@vger.kernel.org X-Gm-Message-State: AOJu0YwKgagt127uiBdI9k4GlHTCsBr6Uc88iNA7WWj/tlZ7kJPLTe9M 9u3FozJX9bJcHGjGbfvsPsxhdUR7gzOx1C0eb6E1G4SPe6YGRQZiHdOM X-Gm-Gg: ATEYQzxcti0EfOEpE6ns8z4TP8VWeV+a1LuVnV4lcqPhfFX9IfdZk9amalm+WfY9LJH bii4d6C2LVdJ1n1V8LAtzqzuPHFO/KoNKqm7Sn+nYWcgYywm5zgrFaDn94Fs6/fEbZx7Wpbpfuc Oxsk6FjaEZ7d/s0YcESEjbeq6iELgn2t4kzSLj9MIDUAshM7skXIzFSCPI30DL9IqMD04r1n14g Rzz2oHCXccxR1i+iJUW0rN0ZDfMjVVTw8hk3CT+lHTDF7zYRX39KHPKgqJ1Omak1cKlfmfUBgbl ENEpjdUWdO01JL+kQbmjvnRQd8T048RxPFuLV5Ye8+7tXxiRbA3nMGPgVtmlShgPuidsoTJ73Lb +fYXb22WO7I21+fXo/a+x0pHE/l4oqwxVMs/AmnB545FtMt+BEJkoMY29F9BBjmSnSmrv4vrGoQ mn6VXEQSG9QcbqCDBuER2WmkplvD5wFTzO1ABiBDp398PrA6E8zvWGDBnA9seF3gg9Kz/0UkI= X-Received: by 2002:a17:90b:5590:b0:356:1edc:b71 with SMTP id 98e67ed59e1d1-35965c228a8mr2943696a91.1.1772218232652; Fri, 27 Feb 2026 10:50:32 -0800 (PST) Received: from HRD-WDG8GDY3.roa.hexagonmetrology.com ([49.43.203.209]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35912f5f29fsm5559002a91.1.2026.02.27.10.50.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 10:50:32 -0800 (PST) From: Venkata Swamy Kassa X-Google-Original-From: Venkata Swamy Kassa To: heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook , Nathan Chancellor Subject: [PATCH 1/2] kcsan: test: Adjust "expect" allocation type for kmalloc_obj Date: Fri, 27 Feb 2026 18:50:20 +0000 Message-ID: <20260227185021.767948-2-venkata.swamy.kassa@hexagon.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260227185021.767948-1-venkata.swamy.kassa@hexagon.com> References: <20260227185021.767948-1-venkata.swamy.kassa@hexagon.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kees Cook The call to kmalloc_obj(observed.lines) returns "char (*)[3][512]", a pointer to the whole 2D array. But "expect" wants to be "char (*)[512]", the decayed pointer type, as if it were observed.lines itself (though without the "3" bounds). This produces the following build error: ../kernel/kcsan/kcsan_test.c: In function '__report_matches': ../kernel/kcsan/kcsan_test.c:171:16: error: assignment to 'char (*)[512]' f= rom incompatible pointer type 'char (*)[3][512]' [-Wincompatible-pointer-types] 171 | expect =3D kmalloc_obj(observed.lines); | ^ Instead of changing the "expect" type to "char (*)[3][512]" and requiring a dereference at each use (e.g. "(expect*)[0]"), just explicitly cast the return to the desired type. Note that I'm intentionally not switching back to byte-based "kmalloc" here because I cannot find a way for the Coccinelle script (which will be used going forward to catch future conversions) to exclude this case. Tested with: $ ./tools/testing/kunit/kunit.py run \ --kconfig_add CONFIG_DEBUG_KERNEL=3Dy \ --kconfig_add CONFIG_KCSAN=3Dy \ --kconfig_add CONFIG_KCSAN_KUNIT_TEST=3Dy \ --arch=3Dx86_64 --qemu_args '-smp 2' kcsan Reported-by: Nathan Chancellor Fixes: 69050f8d6d07 ("treewide: Replace kmalloc with kmalloc_obj for non-sc= alar types") Signed-off-by: Kees Cook --- kernel/kcsan/kcsan_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/kcsan/kcsan_test.c b/kernel/kcsan/kcsan_test.c index 79e655ea4ca1..ae758150ccb9 100644 --- a/kernel/kcsan/kcsan_test.c +++ b/kernel/kcsan/kcsan_test.c @@ -168,7 +168,7 @@ static bool __report_matches(const struct expect_report= *r) if (!report_available()) return false; =20 - expect =3D kmalloc_obj(observed.lines); + expect =3D (typeof(expect))kmalloc_obj(observed.lines); if (WARN_ON(!expect)) return false; =20 --=20 2.43.0 From nobody Thu Apr 16 12:31:04 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CECEA3A1CF9 for ; Fri, 27 Feb 2026 18:50:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772218244; cv=none; b=bOdOQD53Pvnpkmncza3FDJZVfVIUU+mVS8sbOGPL+JHPyECSITp1O8Eo2Ku3eN+uyUoEliQX6RtE1KrAZSYi5BjVV33b/rULPMComRii5g2TDvFlUavoplN9A0k12lNGO5RB+fivTHmav7hmkMjA5dChzVW15miKQXxsBOotKRg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772218244; c=relaxed/simple; bh=A6RjsAimFVE2c0vEDaZfMfkwb5jOhElTdG8K5Z3+k/c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JCgdYq9h4ogcfowSpvInkEx8bf8eyZtrlfbmsY56Cp1k60LFwUDQlub5Sr6K3Ko2jFMd62C/5OpC1DyqPhqv7l+JUR7kS5ZJoO/Shl4QPQMG9qQrC77UZkkHKTrqB1rSpUiE/JLz9oPEhHKUGYYm+gKeLa/KoSTomejiBY/q96U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LD2wxj4J; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LD2wxj4J" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2adc1d9ec56so16716535ad.0 for ; Fri, 27 Feb 2026 10:50:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772218241; x=1772823041; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U5hgdG67NhsA8/s80Xhr0nDKSwgAo+rNFXpqsrrmAaM=; b=LD2wxj4JMRiCgAxylrxEQZ2B7F7ioVZfzln6pfvSZbc1MYJLBqHDI/jP2YHOJlqB0f XFxhUi8uwr6p4QsoxxWKrnrl5SjpCaoTh9CTGcjKv78oGuP7iT19V7M21pbu2TUUti2n gNUzJLZEad77aNsiIGjuBfE+k7Id5wnAw/hSavqPi8wgP1IPZVWp1Aqm8xh7Okz8bIBg MVbuqbsspZvcTnyARbGdabkK7prHskan8kyJUeBEla5q3B1exlE+Me5D2f75C3JEWeT+ iO+eoz7RCnJq4fLzWcLR2Uejyjh7asVXoZlDsmxT0DnjwbUw3eQNUsLy04bqOhU+8KVh Ze5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772218241; x=1772823041; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=U5hgdG67NhsA8/s80Xhr0nDKSwgAo+rNFXpqsrrmAaM=; b=TwlPux9Eu25YkSXGnbvyUZho0sWDIjt4Bnajgxq27YRbOVsO7jKy/+f/uWXzljN8Y9 q4BwlYGHuEd5jg3Fvub1fn6v/k7U2NS7ZxFSqXC5rjmmmeX+8KDJez44Ay+rQiaUPUuH Xt4Kb+y1U2ad3+gh0TlTeXht3LhKBI/CsUHec+5VULt7NesuY7gTNt0ixQCJqFCvTezn /DlkPdT4ikCR/vdHfzZmuKVgNNX2dGaZJ732arGHrDRw253JKWGW7/8VPDMZqo/ZIUgM O6+CC9LLc5ShSyRggS1o3BWPAK0UY0QFA8EnNrwrTde6Tsr83EqevktiTC7aL88L6y37 JLlw== X-Forwarded-Encrypted: i=1; AJvYcCX+zxZz1pn5eLLTB101aiFtBrrLsQlwOAcDHd+C24vPnYeCAoxNbnKWck1WtEQh/CXs2cBggKU99MVS3Ik=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6vgWniw32VhMEs5XlOM7g916o0h3SsUnN0Tee9O/9lAD1CTiG lc7VL8kbOSE/y/geNGNrU1U6YmcaNl63sdXijtq7j875y7GbiqcKwUpmHRJtvgDa X-Gm-Gg: ATEYQzxypqFk30WWN0mXGNb0NjWTBajQ4NW9m+qiaFZ9judv/eCrSNr7t5XMqvLAId0 mRzFT3yTe2k1Di6TbJORagLV3sq66T+U1HbCh3g/tLGi+kJSM3cMx89XRGHKYjm31XVpvxrTht+ u7gHBrPlpWj0/+O503uZI7vovZoY8u+LNOBQo7zl0A1/JWL6zoMTv1ds492J0vlBBPeg6r3Y2N6 djp4vN5gfIbgty0BnQKW1fMtjcl3Prw/I9ElqiTtw3Bb2oJfCaxZVvJEBivuNij3xNx4LYFXAgz DSe1pKgmyCyqhwOGHb/M9CQQSvP/z1jtocXPceZZT04DjjpkMmP8OgXIo9Ym4wWo6v9616Bunrb 1I/YL1L2eAK8xpWXEbSYZ0fj58MTsiqOWxUPct5u7zVlCIM0/qNpNIrJ78/4ctwXhSX1cHS+1DC fWyivcmgCNuPdzFbW5PKa6q3sulb/0DoSKU+Tx13f7uWfMM6nH/PtNd8Jg6hwCat5nnb89bPM= X-Received: by 2002:a17:903:2ac3:b0:2a9:4bd9:bba1 with SMTP id d9443c01a7336-2ae2e4e2052mr28017095ad.52.1772218241125; Fri, 27 Feb 2026 10:50:41 -0800 (PST) Received: from HRD-WDG8GDY3.roa.hexagonmetrology.com ([49.43.203.209]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35912f5f29fsm5559002a91.1.2026.02.27.10.50.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 10:50:40 -0800 (PST) From: Venkata Swamy Kassa X-Google-Original-From: Venkata Swamy Kassa To: heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Venkata Swamy Kassa Subject: [PATCH 2/2] usb-typec-hd3ss3220-Add-sysfs-attribute-for-USB-role Date: Fri, 27 Feb 2026 18:50:21 +0000 Message-ID: <20260227185021.767948-3-venkata.swamy.kassa@hexagon.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260227185021.767948-1-venkata.swamy.kassa@hexagon.com> References: <20260227185021.767948-1-venkata.swamy.kassa@hexagon.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Venkata Swamy Kassa --- drivers/usb/typec/hd3ss3220.c | 207 +++++++++++++++++++++------------- 1 file changed, 128 insertions(+), 79 deletions(-) diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c index 3e39b800e6b5..9c8e1e9dadc2 100644 --- a/drivers/usb/typec/hd3ss3220.c +++ b/drivers/usb/typec/hd3ss3220.c @@ -5,66 +5,86 @@ * Copyright (C) 2019 Renesas Electronics Corp. */ =20 -#include #include +#include #include -#include -#include #include -#include -#include -#include -#include -#include #include -#include +#include +#include +#include +#include +#include +#include +#include =20 -#define HD3SS3220_REG_CN_STAT 0x08 -#define HD3SS3220_REG_CN_STAT_CTRL 0x09 -#define HD3SS3220_REG_GEN_CTRL 0x0A -#define HD3SS3220_REG_DEV_REV 0xA0 +#define HD3SS3220_REG_CN_STAT 0x08 +#define HD3SS3220_REG_CN_STAT_CTRL 0x09 +#define HD3SS3220_REG_GEN_CTRL 0x0A +#define HD3SS3220_REG_DEV_REV 0xA0 =20 /* Register HD3SS3220_REG_CN_STAT */ -#define HD3SS3220_REG_CN_STAT_CURRENT_MODE_MASK (BIT(7) | BIT(6)) -#define HD3SS3220_REG_CN_STAT_CURRENT_MODE_DEFAULT 0x00 -#define HD3SS3220_REG_CN_STAT_CURRENT_MODE_MID BIT(6) -#define HD3SS3220_REG_CN_STAT_CURRENT_MODE_HIGH BIT(7) +#define HD3SS3220_REG_CN_STAT_CURRENT_MODE_MASK (BIT(7) | BIT(6)) +#define HD3SS3220_REG_CN_STAT_CURRENT_MODE_DEFAULT 0x00 +#define HD3SS3220_REG_CN_STAT_CURRENT_MODE_MID BIT(6) +#define HD3SS3220_REG_CN_STAT_CURRENT_MODE_HIGH BIT(7) =20 /* Register HD3SS3220_REG_CN_STAT_CTRL*/ -#define HD3SS3220_REG_CN_STAT_CTRL_ATTACHED_STATE_MASK (BIT(7) | BIT(6)) -#define HD3SS3220_REG_CN_STAT_CTRL_AS_DFP BIT(6) -#define HD3SS3220_REG_CN_STAT_CTRL_AS_UFP BIT(7) -#define HD3SS3220_REG_CN_STAT_CTRL_TO_ACCESSORY (BIT(7) | BIT(6)) -#define HD3SS3220_REG_CN_STAT_CTRL_INT_STATUS BIT(4) +#define HD3SS3220_REG_CN_STAT_CTRL_ATTACHED_STATE_MASK (BIT(7) | BIT(6)) +#define HD3SS3220_REG_CN_STAT_CTRL_AS_DFP BIT(6) +#define HD3SS3220_REG_CN_STAT_CTRL_AS_UFP BIT(7) +#define HD3SS3220_REG_CN_STAT_CTRL_TO_ACCESSORY (BIT(7) | BIT(6)) +#define HD3SS3220_REG_CN_STAT_CTRL_INT_STATUS BIT(4) =20 /* Register HD3SS3220_REG_GEN_CTRL*/ -#define HD3SS3220_REG_GEN_CTRL_DISABLE_TERM BIT(0) -#define HD3SS3220_REG_GEN_CTRL_SRC_PREF_MASK (BIT(2) | BIT(1)) -#define HD3SS3220_REG_GEN_CTRL_SRC_PREF_DRP_DEFAULT 0x00 -#define HD3SS3220_REG_GEN_CTRL_SRC_PREF_DRP_TRY_SNK BIT(1) -#define HD3SS3220_REG_GEN_CTRL_SRC_PREF_DRP_TRY_SRC (BIT(2) | BIT(1)) -#define HD3SS3220_REG_GEN_CTRL_MODE_SELECT_MASK (BIT(5) | BIT(4)) -#define HD3SS3220_REG_GEN_CTRL_MODE_SELECT_DEFAULT 0x00 -#define HD3SS3220_REG_GEN_CTRL_MODE_SELECT_DFP BIT(5) -#define HD3SS3220_REG_GEN_CTRL_MODE_SELECT_UFP BIT(4) -#define HD3SS3220_REG_GEN_CTRL_MODE_SELECT_DRP (BIT(5) | BIT(4)) +#define HD3SS3220_REG_GEN_CTRL_DISABLE_TERM BIT(0) +#define HD3SS3220_REG_GEN_CTRL_SRC_PREF_MASK (BIT(2) | BIT(1)) +#define HD3SS3220_REG_GEN_CTRL_SRC_PREF_DRP_DEFAULT 0x00 +#define HD3SS3220_REG_GEN_CTRL_SRC_PREF_DRP_TRY_SNK BIT(1) +#define HD3SS3220_REG_GEN_CTRL_SRC_PREF_DRP_TRY_SRC (BIT(2) | BIT(1)) +#define HD3SS3220_REG_GEN_CTRL_MODE_SELECT_MASK (BIT(5) | BIT(4)) +#define HD3SS3220_REG_GEN_CTRL_MODE_SELECT_DEFAULT 0x00 +#define HD3SS3220_REG_GEN_CTRL_MODE_SELECT_DFP BIT(5) +#define HD3SS3220_REG_GEN_CTRL_MODE_SELECT_UFP BIT(4) +#define HD3SS3220_REG_GEN_CTRL_MODE_SELECT_DRP (BIT(5) | BIT(4)) =20 struct hd3ss3220 { struct device *dev; struct regmap *regmap; - struct usb_role_switch *role_sw; + struct usb_role_switch *role_sw; struct typec_port *port; struct delayed_work output_poll_work; enum usb_role role_state; bool poll; - struct gpio_desc *id_gpiod; int id_irq; - struct regulator *vbus; }; =20 -static int hd3ss3220_set_power_opmode(struct hd3ss3220 *hd3ss3220, int pow= er_opmode) +/* + * Sysfs attribute to show current USB role (device/host/none) + */ +static ssize_t usb_role_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct hd3ss3220 *hd3ss3220 =3D dev_get_drvdata(dev); + const char *role_str =3D usb_role_string(hd3ss3220->role_state); + + return sysfs_emit(buf, "%s\n", role_str); +} +static DEVICE_ATTR_RO(usb_role); + +static struct attribute *hd3ss3220_attrs[] =3D { + &dev_attr_usb_role.attr, + NULL +}; + +static const struct attribute_group hd3ss3220_attr_group =3D { + .attrs =3D hd3ss3220_attrs, +}; + +static int hd3ss3220_set_power_opmode(struct hd3ss3220 *hd3ss3220, + int power_opmode) { int current_mode; =20 @@ -78,9 +98,11 @@ static int hd3ss3220_set_power_opmode(struct hd3ss3220 *= hd3ss3220, int power_opm case TYPEC_PWR_MODE_3_0A: current_mode =3D HD3SS3220_REG_CN_STAT_CURRENT_MODE_HIGH; break; - case TYPEC_PWR_MODE_PD: /* Power delivery not supported */ + case TYPEC_PWR_MODE_PD: + /* Power delivery not supported */ default: - dev_err(hd3ss3220->dev, "bad power operation mode: %d\n", power_opmode); + dev_err(hd3ss3220->dev, "bad power operation mode: %d\n", + power_opmode); return -EINVAL; } =20 @@ -108,12 +130,15 @@ static int hd3ss3220_set_port_type(struct hd3ss3220 *= hd3ss3220, int type) return -EINVAL; } =20 - /* Disable termination before changing MODE_SELECT as required by datashe= et */ + /* Disable termination before changing MODE_SELECT as required by + * datasheet + */ err =3D regmap_update_bits(hd3ss3220->regmap, HD3SS3220_REG_GEN_CTRL, HD3SS3220_REG_GEN_CTRL_DISABLE_TERM, HD3SS3220_REG_GEN_CTRL_DISABLE_TERM); if (err < 0) { - dev_err(hd3ss3220->dev, "Failed to disable port for mode change: %d\n", = err); + dev_err(hd3ss3220->dev, + "Failed to disable port for mode change: %d\n", err); return err; } =20 @@ -130,12 +155,15 @@ static int hd3ss3220_set_port_type(struct hd3ss3220 *= hd3ss3220, int type) err =3D regmap_update_bits(hd3ss3220->regmap, HD3SS3220_REG_GEN_CTRL, HD3SS3220_REG_GEN_CTRL_DISABLE_TERM, 0); if (err < 0) - dev_err(hd3ss3220->dev, "Failed to re-enable port after mode change: %d\= n", err); + dev_err(hd3ss3220->dev, + "Failed to re-enable port after mode change: %d\n", + err); =20 return err; } =20 -static int hd3ss3220_set_source_pref(struct hd3ss3220 *hd3ss3220, int pref= er_role) +static int hd3ss3220_set_source_pref(struct hd3ss3220 *hd3ss3220, + int prefer_role) { int src_pref; =20 @@ -150,7 +178,8 @@ static int hd3ss3220_set_source_pref(struct hd3ss3220 *= hd3ss3220, int prefer_rol src_pref =3D HD3SS3220_REG_GEN_CTRL_SRC_PREF_DRP_TRY_SRC; break; default: - dev_err(hd3ss3220->dev, "bad role preference: %d\n", prefer_role); + dev_err(hd3ss3220->dev, "bad role preference: %d\n", + prefer_role); return -EINVAL; } =20 @@ -192,7 +221,8 @@ static int hd3ss3220_try_role(struct typec_port *port, = int role) return hd3ss3220_set_source_pref(hd3ss3220, role); } =20 -static int hd3ss3220_port_type_set(struct typec_port *port, enum typec_por= t_type type) +static int hd3ss3220_port_type_set(struct typec_port *port, + enum typec_port_type type) { struct hd3ss3220 *hd3ss3220 =3D typec_get_drvdata(port); =20 @@ -217,8 +247,8 @@ static void hd3ss3220_regulator_control(struct hd3ss322= 0 *hd3ss3220, bool on) ret =3D regulator_disable(hd3ss3220->vbus); =20 if (ret) - dev_err(hd3ss3220->dev, - "vbus regulator %s failed: %d\n", on ? "disable" : "enable", ret); + dev_err(hd3ss3220->dev, "vbus regulator %s failed: %d\n", + on ? "disable" : "enable", ret); } =20 static void hd3ss3220_set_role(struct hd3ss3220 *hd3ss3220) @@ -239,9 +269,14 @@ static void hd3ss3220_set_role(struct hd3ss3220 *hd3ss= 3220) } =20 if (hd3ss3220->vbus && !hd3ss3220->id_gpiod) - hd3ss3220_regulator_control(hd3ss3220, role_state =3D=3D USB_ROLE_HOST); + hd3ss3220_regulator_control(hd3ss3220, + role_state =3D=3D USB_ROLE_HOST); =20 hd3ss3220->role_state =3D role_state; + + /* Notify userspace of usb_role change */ + sysfs_notify(&hd3ss3220->dev->kobj, NULL, "usb_role"); + kobject_uevent(&hd3ss3220->dev->kobj, KOBJ_CHANGE); } =20 static void output_poll_execute(struct work_struct *work) @@ -263,9 +298,10 @@ static irqreturn_t hd3ss3220_irq(struct hd3ss3220 *hd3= ss3220) int err; =20 hd3ss3220_set_role(hd3ss3220); + err =3D regmap_write_bits(hd3ss3220->regmap, HD3SS3220_REG_CN_STAT_CTRL, - HD3SS3220_REG_CN_STAT_CTRL_INT_STATUS, - HD3SS3220_REG_CN_STAT_CTRL_INT_STATUS); + HD3SS3220_REG_CN_STAT_CTRL_INT_STATUS, + HD3SS3220_REG_CN_STAT_CTRL_INT_STATUS); if (err < 0) return IRQ_NONE; =20 @@ -283,17 +319,17 @@ static irqreturn_t hd3ss3220_irq_handler(int irq, voi= d *data) static int hd3ss3220_configure_power_opmode(struct hd3ss3220 *hd3ss3220, struct fwnode_handle *connector) { - /* - * Supported power operation mode can be configured through device tree - */ + /* Supported power operation mode can be configured through device tree */ const char *cap_str; int ret, power_opmode; =20 - ret =3D fwnode_property_read_string(connector, "typec-power-opmode", &cap= _str); + ret =3D fwnode_property_read_string(connector, "typec-power-opmode", + &cap_str); if (ret) return 0; =20 power_opmode =3D typec_find_pwr_opmode(cap_str); + return hd3ss3220_set_power_opmode(hd3ss3220, power_opmode); } =20 @@ -301,9 +337,7 @@ static int hd3ss3220_configure_port_type(struct hd3ss32= 20 *hd3ss3220, struct fwnode_handle *connector, struct typec_capability *cap) { - /* - * Port type can be configured through device tree - */ + /* Port type can be configured through device tree */ const char *cap_str; int ret; =20 @@ -316,6 +350,7 @@ static int hd3ss3220_configure_port_type(struct hd3ss32= 20 *hd3ss3220, return ret; =20 cap->type =3D ret; + return hd3ss3220_set_port_type(hd3ss3220, cap->type); } =20 @@ -323,13 +358,12 @@ static int hd3ss3220_configure_source_pref(struct hd3= ss3220 *hd3ss3220, struct fwnode_handle *connector, struct typec_capability *cap) { - /* - * Preferred role can be configured through device tree - */ + /* Preferred role can be configured through device tree */ const char *cap_str; int ret; =20 - ret =3D fwnode_property_read_string(connector, "try-power-role", &cap_str= ); + ret =3D fwnode_property_read_string(connector, "try-power-role", + &cap_str); if (ret) return 0; =20 @@ -338,6 +372,7 @@ static int hd3ss3220_configure_source_pref(struct hd3ss= 3220 *hd3ss3220, return ret; =20 cap->prefer_role =3D ret; + return hd3ss3220_set_source_pref(hd3ss3220, cap->prefer_role); } =20 @@ -373,8 +408,8 @@ static int hd3ss3220_probe(struct i2c_client *client) return -ENOMEM; =20 i2c_set_clientdata(client, hd3ss3220); - hd3ss3220->dev =3D &client->dev; + hd3ss3220->regmap =3D devm_regmap_init_i2c(client, &config); if (IS_ERR(hd3ss3220->regmap)) return PTR_ERR(hd3ss3220->regmap); @@ -384,13 +419,16 @@ static int hd3ss3220_probe(struct i2c_client *client) if (connector) { hd3ss3220->role_sw =3D fwnode_usb_role_switch_get(connector); } else { - ep =3D fwnode_graph_get_next_endpoint(dev_fwnode(hd3ss3220->dev), NULL); + ep =3D fwnode_graph_get_next_endpoint(dev_fwnode(hd3ss3220->dev), + NULL); if (!ep) return -ENODEV; + connector =3D fwnode_graph_get_remote_port_parent(ep); fwnode_handle_put(ep); if (!connector) return -ENODEV; + hd3ss3220->role_sw =3D usb_role_switch_get(hd3ss3220->dev); } =20 @@ -400,8 +438,7 @@ static int hd3ss3220_probe(struct i2c_client *client) } =20 vbus =3D devm_of_regulator_get_optional(hd3ss3220->dev, - to_of_node(connector), - "vbus"); + to_of_node(connector), "vbus"); if (IS_ERR(vbus) && vbus !=3D ERR_PTR(-ENODEV)) { ret =3D PTR_ERR(vbus); dev_err(hd3ss3220->dev, "failed to get vbus: %d", ret); @@ -412,8 +449,7 @@ static int hd3ss3220_probe(struct i2c_client *client) =20 if (hd3ss3220->vbus) { hd3ss3220->id_gpiod =3D devm_gpiod_get_optional(hd3ss3220->dev, - "id", - GPIOD_IN); + "id", GPIOD_IN); if (IS_ERR(hd3ss3220->id_gpiod)) { ret =3D PTR_ERR(hd3ss3220->id_gpiod); goto err_put_fwnode; @@ -424,8 +460,7 @@ static int hd3ss3220_probe(struct i2c_client *client) hd3ss3220->id_irq =3D gpiod_to_irq(hd3ss3220->id_gpiod); if (hd3ss3220->id_irq < 0) { ret =3D hd3ss3220->id_irq; - dev_err(hd3ss3220->dev, - "failed to get ID gpio: %d\n", + dev_err(hd3ss3220->dev, "failed to get ID gpio: %d\n", hd3ss3220->id_irq); goto err_put_fwnode; } @@ -434,10 +469,13 @@ static int hd3ss3220_probe(struct i2c_client *client) hd3ss3220->id_irq, NULL, hd3ss3220_id_isr, IRQF_TRIGGER_RISING | - IRQF_TRIGGER_FALLING | IRQF_ONESHOT, - dev_name(hd3ss3220->dev), hd3ss3220); + IRQF_TRIGGER_FALLING | + IRQF_ONESHOT, + dev_name(hd3ss3220->dev), + hd3ss3220); if (ret < 0) { - dev_err(hd3ss3220->dev, "failed to get ID irq: %d\n", ret); + dev_err(hd3ss3220->dev, "failed to get ID irq: %d\n", + ret); goto err_put_fwnode; } } @@ -467,28 +505,37 @@ static int hd3ss3220_probe(struct i2c_client *client) if (ret < 0) goto err_unreg_port; =20 + ret =3D devm_device_add_group(&client->dev, &hd3ss3220_attr_group); + if (ret) { + dev_err(&client->dev, + "Failed to create sysfs attributes: %d\n", ret); + goto err_unreg_port; + } + hd3ss3220_set_role(hd3ss3220); + ret =3D regmap_read(hd3ss3220->regmap, HD3SS3220_REG_CN_STAT_CTRL, &data); if (ret < 0) goto err_unreg_port; =20 if (data & HD3SS3220_REG_CN_STAT_CTRL_INT_STATUS) { - ret =3D regmap_write(hd3ss3220->regmap, - HD3SS3220_REG_CN_STAT_CTRL, - data | HD3SS3220_REG_CN_STAT_CTRL_INT_STATUS); + ret =3D regmap_write(hd3ss3220->regmap, HD3SS3220_REG_CN_STAT_CTRL, + data | HD3SS3220_REG_CN_STAT_CTRL_INT_STATUS); if (ret < 0) goto err_unreg_port; } =20 if (client->irq > 0) { ret =3D devm_request_threaded_irq(&client->dev, client->irq, NULL, - hd3ss3220_irq_handler, - IRQF_TRIGGER_FALLING | IRQF_ONESHOT, - "hd3ss3220", &client->dev); + hd3ss3220_irq_handler, + IRQF_TRIGGER_FALLING | + IRQF_ONESHOT, + "hd3ss3220", &client->dev); if (ret) goto err_unreg_port; } else { - INIT_DELAYED_WORK(&hd3ss3220->output_poll_work, output_poll_execute); + INIT_DELAYED_WORK(&hd3ss3220->output_poll_work, + output_poll_execute); hd3ss3220->poll =3D true; } =20 @@ -504,6 +551,7 @@ static int hd3ss3220_probe(struct i2c_client *client) dev_info(&client->dev, "probed revision=3D0x%x\n", ret); =20 return 0; + err_unreg_port: typec_unregister_port(hd3ss3220->port); err_put_role: @@ -526,7 +574,7 @@ static void hd3ss3220_remove(struct i2c_client *client) } =20 static const struct of_device_id dev_ids[] =3D { - { .compatible =3D "ti,hd3ss3220"}, + { .compatible =3D "ti,hd3ss3220" }, {} }; MODULE_DEVICE_TABLE(of, dev_ids); @@ -545,3 +593,4 @@ module_i2c_driver(hd3ss3220_driver); MODULE_AUTHOR("Biju Das "); MODULE_DESCRIPTION("TI HD3SS3220 DRP Port Controller Driver"); MODULE_LICENSE("GPL"); + --=20 2.43.0