From nobody Tue Apr 7 17:12:32 2026 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED5B935CB64 for ; Fri, 27 Feb 2026 17:27:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772213277; cv=none; b=MF6YKZcRWDsOn/jCXUkbW6p4kSWuarRNdpdDauof7rOUcl9T6H7qkGPKLdEEkvpQ7VbQYGkv3k6S+9RrCxCd6upAXmuolnG2ZyB+gHvGr0Oj7OLmBtTqJAzWo6+vIXr7L6paPIt3cEP4hZ06Zp4HYVvoAKWU6pFVYPN3hjhGLXs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772213277; c=relaxed/simple; bh=Uyy0P/50J+zguA2nR0Xrs5bpcIHcz3crpVb1TTNfoYs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=s01KHe1V1Y2Pg45PZBqIyzEIpI0IrjJa9ir4/0JOyr40WYDzR55VYVaE5W4G2NekbUjDuNSLmXKQ+Q2GDg6QipXeH78FtpFoLL7tpS+kozdfQPKCvj/Ll8FCFsKzMoGiCmV7Qp3X0X7NmL4kuFS9aqP/+mRNWUX0GOhBSOhBsrw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XVvrXa4i; arc=none smtp.client-ip=209.85.219.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XVvrXa4i" Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-896f9397ecdso28227556d6.3 for ; Fri, 27 Feb 2026 09:27:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772213275; x=1772818075; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=M1m4SRnWdoprPhg5W/7JgXd6LZPxjHGiXySFsGJDyKE=; b=XVvrXa4i6u74RYLjyJL8GIPP+AQQdeqAneNVs5pgU2ak2yN/jsNOGZHL3aan0vpTXY Od8iy5vCz3QjPevFhieLUkSYkiHD6H9MGWlSg261N8KgPqTbmWoKMsZq6Inh3txscd8B jkB7lQhuzXMxtskmSKAKT4jG09gK1jXrWlvJXHX9sWe8xYuLN7Gb602a2UuXH3FSH25l LX3kn5b9MFzReutDBdhx1wA9ELlH0eTCzzLaY+qKFtxkiJy1Xz+eimLdua6bHmkoL0DK kOb5Eaz2CNvzohIQRKx92AGhvOVdgMiNIDA8H2L+EGt2gQ4sb/iD9qBeYE7xHSySokZj bhkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772213275; x=1772818075; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M1m4SRnWdoprPhg5W/7JgXd6LZPxjHGiXySFsGJDyKE=; b=irl+6rQ7luS1BS32ZaJvgVE8mDnflOKgQ4TV/f7Gj29jNMh4GIz+fiWXbPJbEgQ4Kz 9BJY8Cw08A7R6hnJYYDd2Hml5/cnh4c6UULQ+RCK6pwRB/tNREKP1Hy9rRsw4kMY76vF QYcmeNJSP16v/zzRaSB1/qlD+uW/zuZSJxMSP3MpCUGXs9YcFiSK76LxCddwMgLDV58c sun5TQmecd1NglHQWNzRwESwACRNJB0uADbaX89JbVas7/bHB0TKMBfiHENW+CX1dtjg Zdn3gj0ozjCY4QbCTTs3s1fh+Ep5RPtxbDXLCsJPeLQAZo2RuoC1gg1liRZoggYswuz+ gTWw== X-Forwarded-Encrypted: i=1; AJvYcCXwaucgbZgjj6P8EUfvkxtQotlAPNljdSSkU8KSAhhU1S5thOf7h3YTihj01glsP7DHKiyRsdlBnQRiWuM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2KsPVHf2qwuIHY+hkLSBq5epmRX8lC+uylnQPdIXWCrTQw1VO l3mSuPbBCq2Zati4R1fyXTl8Rb8MtNKm9s2Lem/9EKOgWmwnYvjwf8xq X-Gm-Gg: ATEYQzyR9InNIhbja27nu3wott6Omp2FqH4cLZm40rbSPJHxLFV/0bESMpL8oxDxd/G /XYZIPS4Zp+D9wYhDez+ZJR20jnEHOe68jF9Isi0eUsV1QH+4bn+hENJnj3FxhEgHVHwNYF6ucs cKxYBxmXktOeXx8dcSoCNGtGXkH618Q7mpMibMk8hROpBd7lzkI+opidCc/+KNVYicyxR1BgjI6 m9i6zAVdoSosidIOLT+EOfgKyTlsgIasT2L89Sp6F4vvFHThZAt2NJX8nFCePfhM/RFVTX3rxb1 REb8jP17VjcQYvn/h6Xj30gpLZlX8naGfQgyo5OqeWTW+xhazQfbM11ebn9o9WHZbuABQi++vU/ 7dmr508G6d4t2cdcFSPpD2HCSMeJchyiI9YBsi2QAvuUobEXYt/8MirNibMrzz6vFMGyHxgoovq nkXOeL5BbopH1hL+kQGvNuEiSW5nqf03/LZkSg2CWOHjiL8QOfwdpu7zAvEOaB X-Received: by 2002:a05:6214:2584:b0:895:498e:e9dd with SMTP id 6a1803df08f44-899d1d72523mr55707746d6.2.1772213274772; Fri, 27 Feb 2026 09:27:54 -0800 (PST) Received: from NIKUNJ.resource.campus.njit.edu ([128.235.159.79]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-899c7377d7dsm45254076d6.26.2026.02.27.09.27.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 09:27:54 -0800 (PST) From: Nikunj Kantaria To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nikunj Kantaria Subject: [PATCH] staging: rtl8723bs: remove RTL8188E references Date: Fri, 27 Feb 2026 12:27:34 -0500 Message-ID: <20260227172734.2266911-1-niktechgig@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove all references to RTL8188E chip from the driver code. This includes renaming variables, deleting unused macros and struct members, and updating comments to reflect that this driver is specifically for RTL8723BS. This addresses the TODO item to remove leftover code for other chips. Signed-off-by: techy-Nik Signed-off-by: Nikunj Kantaria --- drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 16 ++++++++-------- drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.h | 2 +- drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c | 2 +- drivers/staging/rtl8723bs/hal/odm.h | 3 --- drivers/staging/rtl8723bs/include/hal_com_reg.h | 4 ++-- drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 4 +++- 6 files changed, 15 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/stagi= ng/rtl8723bs/hal/HalPhyRf_8723B.c index 9df3274c1..f2e19e044 100644 --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c @@ -23,14 +23,14 @@ =20 /*---------------------------Define Local Constant------------------------= ---*/ =20 -/* In the case that we fail to read TxPowerTrack.txt, we use the table for - * 88E as the default table. +/* In the case that we fail to read TxPowerTrack.txt, we use the default + * delta swing table. */ -static u8 DeltaSwingTableIdx_2GA_N_8188E[] =3D { +static u8 DeltaSwingTableIdx_2GA_N_8723B[] =3D { 0, 0, 0, 2, 2, 3, 3, 4, 4, 4, 4, 5, 5, 6, 6, 7, 7, 7, 7, 8, 8, 9, 9, 10, 10, 10, 11, 11, 11, 11 }; -static u8 DeltaSwingTableIdx_2GA_P_8188E[] =3D { +static u8 DeltaSwingTableIdx_2GA_P_8723B[] =3D { 0, 0, 0, 0, 1, 1, 2, 2, 3, 3, 4, 4, 4, 4, 4, 4, 4, 4, 5, 5, 7, 7, 8, 8, 8, 9, 9, 9, 9, 9 }; @@ -326,10 +326,10 @@ static void GetDeltaSwingTable_8723B( *TemperatureDOWN_B =3D pRFCalibrateInfo->DeltaSwingTableIdx_2GB_N; } } else { - *TemperatureUP_A =3D (u8 *)DeltaSwingTableIdx_2GA_P_8188E; - *TemperatureDOWN_A =3D (u8 *)DeltaSwingTableIdx_2GA_N_8188E; - *TemperatureUP_B =3D (u8 *)DeltaSwingTableIdx_2GA_P_8188E; - *TemperatureDOWN_B =3D (u8 *)DeltaSwingTableIdx_2GA_N_8188E; + *TemperatureUP_A =3D (u8 *)DeltaSwingTableIdx_2GA_P_8723B; + *TemperatureDOWN_A =3D (u8 *)DeltaSwingTableIdx_2GA_N_8723B; + *TemperatureUP_B =3D (u8 *)DeltaSwingTableIdx_2GA_P_8723B; + *TemperatureDOWN_B =3D (u8 *)DeltaSwingTableIdx_2GA_N_8723B; } } =20 diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.h b/drivers/stagi= ng/rtl8723bs/hal/HalPhyRf_8723B.h index c83442917..a21764adb 100644 --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.h +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.h @@ -65,4 +65,4 @@ void _PHY_MACSettingCalibration_8723B( struct adapter *padapter, u32 *MACReg, u32 *MACBackup ); =20 -#endif /* #ifndef __HAL_PHY_RF_8188E_H__ */ +#endif /* #ifndef __HAL_PHY_RF_8723B_H__ */ diff --git a/drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c b/drivers/staging= /rtl8723bs/hal/HalPwrSeqCmd.c index 86404b5e6..7f57ae017 100644 --- a/drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c +++ b/drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c @@ -26,7 +26,7 @@ Major Change History: =20 /* */ /* Description: */ -/* This routine deal with the Power Configuration CMDs parsing for RTL872= 3/RTL8188E Series IC. */ +/* This routine deals with the Power Configuration CMDs parsing for RTL87= 23 Series IC. */ /* */ /* Assumption: */ /* We should follow specific format which was released from HW SD. */ diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723b= s/hal/odm.h index 1c929d88e..c4fce230c 100644 --- a/drivers/staging/rtl8723bs/hal/odm.h +++ b/drivers/staging/rtl8723bs/hal/odm.h @@ -203,7 +203,6 @@ struct odm_rate_adaptive { /* Declare for common info */ /* */ #define MAX_PATH_NUM_92CS 2 -#define MAX_PATH_NUM_8188E 1 #define MAX_PATH_NUM_8192E 2 #define MAX_PATH_NUM_8723B 1 #define MAX_PATH_NUM_8812A 2 @@ -538,8 +537,6 @@ struct odm_rf_cal_t { /* ODM_RF_Calibration_Structure */ u8 DeltaSwingTableIdx_2GA_N[DELTA_SWINGIDX_SIZE]; u8 DeltaSwingTableIdx_2GB_P[DELTA_SWINGIDX_SIZE]; u8 DeltaSwingTableIdx_2GB_N[DELTA_SWINGIDX_SIZE]; - u8 DeltaSwingTableIdx_2GA_P_8188E[DELTA_SWINGIDX_SIZE]; - u8 DeltaSwingTableIdx_2GA_N_8188E[DELTA_SWINGIDX_SIZE]; =20 /* */ =20 diff --git a/drivers/staging/rtl8723bs/include/hal_com_reg.h b/drivers/stag= ing/rtl8723bs/include/hal_com_reg.h index cf5c15dc2..a1cfe2f7d 100644 --- a/drivers/staging/rtl8723bs/include/hal_com_reg.h +++ b/drivers/staging/rtl8723bs/include/hal_com_reg.h @@ -202,7 +202,7 @@ #define WCAMI REG_CAMWRITE /* Software write CAM input content */ =20 /* */ -/* 8723/8188E Host System Interrupt Status Register (offset 0x5C, 3= 2 byte) */ +/* 8723 Host System Interrupt Status Register (offset 0x5C, 32 byte= ) */ /* */ #define HSISR_GPIO12_0_INT BIT0 #define HSISR_SPS_OCP_INT BIT5 @@ -539,7 +539,7 @@ =20 #define SDIO_HIMR_DISABLED 0 =20 -/* RTL8723/RTL8188E SDIO Host Interrupt Mask Register */ +/* RTL8723 SDIO Host Interrupt Mask Register */ #define SDIO_HIMR_RX_REQUEST_MSK BIT0 #define SDIO_HIMR_AVAL_MSK BIT1 =20 diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/sta= ging/rtl8723bs/include/rtw_mlme_ext.h index afa5631a4..a8ebcb314 100644 --- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h +++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h @@ -10,7 +10,9 @@ =20 /* Commented by Albert 20101105 */ /* Increase the SURVEY_TO value from 100 to 150 (100ms to 150ms) */ -/* The Realtek 8188CE SoftAP will spend around 100ms to send the probe re= sponse after receiving the probe request. */ +/* The Realtek SoftAP will spend around 100ms to send the probe response + * after receiving the probe request. + */ /* So, this driver tried to extend the dwell time for each scanning chann= el. */ /* This will increase the chance to receive the probe response from SoftA= P. */ =20 --=20 2.43.0